-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux:SystemTimeSupport: make compatible with time64 (64-bit time_t) #19985
Merged
andy31415
merged 2 commits into
project-chip:master
from
plan44:PR/systemtimesupport-adapt-for-time64
Jun 27, 2022
Merged
linux:SystemTimeSupport: make compatible with time64 (64-bit time_t) #19985
andy31415
merged 2 commits into
project-chip:master
from
plan44:PR/systemtimesupport-adapt-for-time64
Jun 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… time_t, as in musl)
tcarmelveilleux
approved these changes
Jun 26, 2022
PR #19985: Size comparison from 46b15d6 to 92c7559 Increases (5 builds for cc13x2_26x2, cyw30739, esp32, linux, nrfconnect)
Decreases (1 build for cc13x2_26x2)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov and
LuDuda
June 26, 2022 20:32
pullapprove
bot
requested review from
msandstedt,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
June 26, 2022 20:32
msandstedt
approved these changes
Jun 27, 2022
Damian-Nordic
approved these changes
Jun 27, 2022
bzbarsky-apple
approved these changes
Jun 27, 2022
@plan44 Please fix the restyled failure? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some environments (e.g. musl >=1.2.0, as used in OpenWrt) have switched to time64 - using a 64bit type for time_t to prevent year 2037 problems due to 32bit epoch time overflow.
This PR fixes a formatstring error that appears when time_t is 64bit. It does so in a way that keeps compatibility with 32bit time_t while now also compiling and working correctly for 64bit.
Testing: