-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Added versioning to the factory data #19885
Merged
woody-apple
merged 2 commits into
project-chip:master
from
ArekBalysNordic:factory_data_add_versioning
Jun 23, 2022
Merged
[nrfconnect] Added versioning to the factory data #19885
woody-apple
merged 2 commits into
project-chip:master
from
ArekBalysNordic:factory_data_add_versioning
Jun 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added versioning to the factory data to check the compatibility of a factory data set stored in the Flash memory with the current implementation of a factory data provider. - Provided some fixes to python scripts and Kconfig definitions.
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple and
kghost
June 23, 2022 12:07
pullapprove
bot
requested review from
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt,
mspang,
rgoliver,
sagar-apple,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
June 23, 2022 12:07
PR #19885: Size comparison from a870bb5 to befa506 Increases (4 builds for cc13x2_26x2, nrfconnect)
Decreases (4 builds for cc13x2_26x2, nrfconnect)
Full report (33 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jun 23, 2022
Fast tracking platform changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the nRF Connect Factory Data parameter set does not contain a
version
field that can be used to verify if a Factory Data Provider version is compatible with the Python scripts version.Change overview
FactoryDataProvider.cpp
file.Testing
Tested manually on nRF52 DK and nRF53 DK