Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrfconnect] Added versioning to the factory data #19885

Merged

Conversation

ArekBalysNordic
Copy link
Contributor

Problem

Currently, the nRF Connect Factory Data parameter set does not contain a version field that can be used to verify if a Factory Data Provider version is compatible with the Python scripts version.

Change overview

  • Added versioning to the factory data to check the compatibility of a factory data set stored in the Flash memory with the current implementation of a factory data provider.
  • Added a version field to the Python script and the JSON Schema file.
  • Added version checking in the FactoryDataProvider.cpp file.
  • Provided some fixes to python scripts and Kconfig definitions.

Testing

Tested manually on nRF52 DK and nRF53 DK

- Added versioning to the factory data to check the compatibility
of a factory data set stored in the Flash memory with
the current implementation of a factory data provider.
- Provided some fixes to python scripts and Kconfig definitions.
@github-actions
Copy link

github-actions bot commented Jun 23, 2022

PR #19885: Size comparison from a870bb5 to befa506

Increases (4 builds for cc13x2_26x2, nrfconnect)
platform target config section a870bb5 befa506 change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 649343 649351 8 0.0
.text 558400 558408 8 0.0
shell LP_CC2652R7 (read/write) 157284 157292 8 0.0
nrfconnect pump-app nrf52840dk_nrf52840 text 744768 744772 4 0.0
pump-controller-app nrf52840dk_nrf52840 text 736148 736152 4 0.0
Decreases (4 builds for cc13x2_26x2, nrfconnect)
platform target config section a870bb5 befa506 change % change
cc13x2_26x2 shell LP_CC2652R7 (read only) 690290 690282 -8 -0.0
.text 580112 580104 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1203187 1203171 -16 -0.0
text 824232 824228 -4 -0.0
lighting-app nrf5340dk_nrf5340_cpuapp (read/write) 1066010 1065994 -16 -0.0
text 727784 727780 -4 -0.0
lock-app nrf52840dk_nrf52840 text 761456 761452 -4 -0.0
Full report (33 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a870bb5 befa506 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660451 660451 0 0.0
(read/write) 191620 191620 0 0.0
.bss 74964 74964 0 0.0
.data 3356 3356 0 0.0
.rodata 87011 87011 0 0.0
.text 573128 573128 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649343 649351 8 0.0
(read/write) 158524 158524 0 0.0
.bss 74252 74252 0 0.0
.data 3356 3356 0 0.0
.rodata 90623 90623 0 0.0
.text 558400 558408 8 0.0
lock-ftd LP_CC2652R7 (read only) 692099 692099 0 0.0
(read/write) 150084 150084 0 0.0
.bss 71964 71964 0 0.0
.data 3280 3280 0 0.0
.rodata 99467 99467 0 0.0
.text 592148 592148 0 0.0
lock-mtd LP_CC2652R7 (read only) 641515 641515 0 0.0
(read/write) 145096 145096 0 0.0
.bss 67700 67700 0 0.0
.data 3280 3280 0 0.0
.rodata 99355 99355 0 0.0
.text 541668 541668 0 0.0
pump-app LP_CC2652R7 (read only) 673343 673343 0 0.0
(read/write) 169736 169736 0 0.0
.bss 72092 72092 0 0.0
.data 3280 3280 0 0.0
.rodata 87783 87783 0 0.0
.text 585076 585076 0 0.0
pump-controller-app LP_CC2652R7 (read only) 659223 659223 0 0.0
(read/write) 183968 183968 0 0.0
.bss 72204 72204 0 0.0
.data 3276 3276 0 0.0
.rodata 83623 83623 0 0.0
.text 575120 575120 0 0.0
shell LP_CC2652R7 (read only) 690290 690282 -8 -0.0
(read/write) 157284 157292 8 0.0
.bss 77268 77268 0 0.0
.data 3360 3360 0 0.0
.rodata 109866 109866 0 0.0
.text 580112 580104 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 592538 592538 0 0.0
.app_xip_area 462652 462652 0 0.0
.bss 72848 72848 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589922 589922 0 0.0
.app_xip_area 459860 459860 0 0.0
.bss 73024 73024 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 595054 595054 0 0.0
.app_xip_area 466040 466040 0 0.0
.bss 72032 72032 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1014148 1014148 0 0.0
(read/write) 1485666 1485666 0 0.0
.dram0.bss 71424 71424 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 214176 214176 0 0.0
.flash.text 1014148 1014148 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068475 1068475 0 0.0
(read/write) 487752 487752 0 0.0
.dram0.bss 76936 76936 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244676 244676 0 0.0
.flash.text 1063091 1063091 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 662204 662204 0 0.0
.bss 70396 70396 0 0.0
.data 1992 1992 0 0.0
.text 584016 584016 0 0.0
lock k32w061+release (read/write) 724200 724200 0 0.0
.bss 70844 70844 0 0.0
.data 2000 2000 0 0.0
.text 645556 645556 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9902644 9902644 0 0.0
(read/write) 675265 675265 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614184 614184 0 0.0
.dynamic 528 528 0 0.0
.got 13472 13472 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 471492 471492 0 0.0
.text 7892292 7892292 0 0.0
thermostat-no-ble arm64 (read only) 2579044 2579044 0 0.0
(read/write) 180673 180673 0 0.0
.bss 87905 87905 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 82952 82952 0 0.0
.dynamic 528 528 0 0.0
.got 5088 5088 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164724 164724 0 0.0
.text 2175104 2175104 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439536 2439536 0 0.0
.bss 214692 214692 0 0.0
.data 5864 5864 0 0.0
.text 1402180 1402180 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1203187 1203171 -16 -0.0
bss 143646 143646 0 0.0
rodata 156388 156388 0 0.0
text 824232 824228 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1150535 1150535 0 0.0
bss 142882 142882 0 0.0
rodata 132720 132720 0 0.0
text 796024 796024 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1162319 1162319 0 0.0
bss 145225 145225 0 0.0
rodata 123176 123176 0 0.0
text 815064 815064 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 1132519 1132519 0 0.0
bss 145670 145670 0 0.0
rodata 114720 114720 0 0.0
text 792792 792792 0 0.0
nrf52840dongle_nrf52840 (read/write) 1069283 1069283 0 0.0
bss 152456 152456 0 0.0
rodata 92236 92236 0 0.0
text 743464 743464 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1066010 1065994 -16 -0.0
bss 141596 141596 0 0.0
rodata 115584 115584 0 0.0
text 727784 727780 -4 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 1115431 1115431 0 0.0
bss 135174 135174 0 0.0
rodata 139928 139928 0 0.0
text 761456 761452 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1019294 1019294 0 0.0
bss 131577 131577 0 0.0
rodata 132396 132396 0 0.0
text 674240 674240 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1075287 1075287 0 0.0
bss 135120 135120 0 0.0
rodata 116560 116560 0 0.0
text 744768 744772 4 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1063315 1063315 0 0.0
bss 134915 134915 0 0.0
rodata 113340 113340 0 0.0
text 736148 736152 4 0.0
p6 all-clusters-app default (read/write) 2555952 2555952 0 0.0
.bss 149872 149872 0 0.0
.data 2776 2776 0 0.0
.text 1514216 1514216 0 0.0
all-clusters-minimal-app default (read/write) 2501800 2501800 0 0.0
.bss 149152 149152 0 0.0
.data 2776 2776 0 0.0
.text 1460064 1460064 0 0.0
light-app default (read/write) 2432552 2432552 0 0.0
.bss 141232 141232 0 0.0
.data 2592 2592 0 0.0
.text 1390816 1390816 0 0.0
lock-app default (read/write) 2453280 2453280 0 0.0
.bss 141056 141056 0 0.0
.data 2600 2600 0 0.0
.text 1411544 1411544 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 793000 793000 0 0.0
bss 71924 71924 0 0.0
noinit 40416 40416 0 0.0
text 561084 561084 0 0.0
lighting-app tlsr9518adk80d (read/write) 812704 812704 0 0.0
bss 72172 72172 0 0.0
noinit 40416 40416 0 0.0
text 577544 577544 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking platform changes

@woody-apple woody-apple merged commit ae941da into project-chip:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants