Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issues with running the iOS TvCasting app on physical iPhones #19868

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

sharadb-amazon
Copy link
Contributor

@sharadb-amazon sharadb-amazon commented Jun 23, 2022

Problem

The TvCasting app for iOS was crashing on real iPhones

Change overview

  1. Reconfigured KVS file/path for this ios port of the casting app
  2. Allow listed matter service types under NSBonjourServices in Info.plist to allow Matter service discovery
  3. Fixed bad access errs in making calls to callback handlers in CastingServerBridge.mm
  4. Initialized Device attestation config for this example.

Testing

Tested that the TvCasting app runs on a physical iPhone against a tv-app running on Raspi, from commissioner discovery, to sending the UDC request, to getting commissioned and finally sending the content launch request.

@github-actions
Copy link

github-actions bot commented Jun 23, 2022

PR #19868: Size comparison from 0a995b0 to 33caea7

Increases (5 builds for cc13x2_26x2, cyw30739, telink)
platform target config section 0a995b0 33caea7 change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 649339 649347 8 0.0
.text 558400 558408 8 0.0
pump-controller-app LP_CC2652R7 (read/write) 183508 183516 8 0.0
shell LP_CC2652R7 (read/write) 156824 156832 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 591730 591738 8 0.0
.app_xip_area 462628 462636 8 0.0
telink lighting-app tlsr9518adk80d text 577532 577536 4 0.0
Decreases (3 builds for cc13x2_26x2, telink)
platform target config section 0a995b0 33caea7 change % change
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read only) 659219 659211 -8 -0.0
.text 575120 575112 -8 -0.0
shell LP_CC2652R7 (read only) 690286 690278 -8 -0.0
.text 580112 580104 -8 -0.0
telink light-switch-app tlsr9518adk80d text 561076 561074 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0a995b0 33caea7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660447 660447 0 0.0
(read/write) 191160 191160 0 0.0
.bss 74500 74500 0 0.0
.data 3356 3356 0 0.0
.rodata 87007 87007 0 0.0
.text 573128 573128 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649339 649347 8 0.0
(read/write) 158060 158060 0 0.0
.bss 73788 73788 0 0.0
.data 3356 3356 0 0.0
.rodata 90619 90619 0 0.0
.text 558400 558408 8 0.0
lock-ftd LP_CC2652R7 (read only) 692095 692095 0 0.0
(read/write) 149624 149624 0 0.0
.bss 71500 71500 0 0.0
.data 3280 3280 0 0.0
.rodata 99463 99463 0 0.0
.text 592148 592148 0 0.0
lock-mtd LP_CC2652R7 (read only) 641511 641511 0 0.0
(read/write) 144632 144632 0 0.0
.bss 67236 67236 0 0.0
.data 3280 3280 0 0.0
.rodata 99351 99351 0 0.0
.text 541668 541668 0 0.0
pump-app LP_CC2652R7 (read only) 673327 673327 0 0.0
(read/write) 169288 169288 0 0.0
.bss 71628 71628 0 0.0
.data 3280 3280 0 0.0
.rodata 87775 87775 0 0.0
.text 585068 585068 0 0.0
pump-controller-app LP_CC2652R7 (read only) 659219 659211 -8 -0.0
(read/write) 183508 183516 8 0.0
.bss 71740 71740 0 0.0
.data 3276 3276 0 0.0
.rodata 83619 83619 0 0.0
.text 575120 575112 -8 -0.0
shell LP_CC2652R7 (read only) 690286 690278 -8 -0.0
(read/write) 156824 156832 8 0.0
.bss 76804 76804 0 0.0
.data 3360 3360 0 0.0
.rodata 109862 109862 0 0.0
.text 580112 580104 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 591730 591738 8 0.0
.app_xip_area 462628 462636 8 0.0
.bss 72064 72064 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589122 589122 0 0.0
.app_xip_area 459844 459844 0 0.0
.bss 72240 72240 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 594258 594258 0 0.0
.app_xip_area 466028 466028 0 0.0
.bss 71248 71248 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1071000 1071000 0 0.0
.bss 132932 132932 0 0.0
.data 2048 2048 0 0.0
.text 936000 936000 0 0.0
BRD4161A+rpc (read/write) 1125060 1125060 0 0.0
.bss 149620 149620 0 0.0
.data 2260 2260 0 0.0
.text 973160 973160 0 0.0
BRD4161A+rs911x (read/write) 935672 935672 0 0.0
.bss 139304 139304 0 0.0
.data 2048 2048 0 0.0
.text 794300 794300 0 0.0
lock-app BRD4161A+wf200 (read/write) 1111348 1111348 0 0.0
.bss 139720 139720 0 0.0
.data 2056 2056 0 0.0
.text 969552 969552 0 0.0
window-app BRD4161A (read/write) 1056252 1056252 0 0.0
.bss 133004 133004 0 0.0
.data 2076 2076 0 0.0
.text 921152 921152 0 0.0
esp32 all-clusters-app c3devkit (read only) 1014134 1014134 0 0.0
(read/write) 1484882 1484882 0 0.0
.dram0.bss 70640 70640 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 214176 214176 0 0.0
.flash.text 1014134 1014134 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068475 1068475 0 0.0
(read/write) 486960 486960 0 0.0
.dram0.bss 76152 76152 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244668 244668 0 0.0
.flash.text 1063091 1063091 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 661556 661556 0 0.0
.bss 69756 69756 0 0.0
.data 1992 1992 0 0.0
.text 584008 584008 0 0.0
lock k32w061+release (read/write) 723540 723540 0 0.0
.bss 70204 70204 0 0.0
.data 2000 2000 0 0.0
.text 645536 645536 0 0.0
linux all-clusters-app debug (read only) 2939145 2939145 0 0.0
(read/write) 177136 177136 0 0.0
.bss 84192 84192 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84696 84696 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 261661 261661 0 0.0
.text 2500994 2500994 0 0.0
all-clusters-minimal-app debug (read only) 2792921 2792921 0 0.0
(read/write) 169040 169040 0 0.0
.bss 83520 83520 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77336 77336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 263261 263261 0 0.0
.text 2355346 2355346 0 0.0
bridge-app debug+rpc (read only) 2296905 2296905 0 0.0
(read/write) 147936 147936 0 0.0
.bss 71616 71616 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 66760 66760 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 196448 196448 0 0.0
.text 1939202 1939202 0 0.0
chip-tool debug (read only) 10170925 10170925 0 0.0
(read/write) 610600 610600 0 0.0
.bss 24416 24416 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 578792 578792 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 508181 508181 0 0.0
.text 8254757 8254757 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9907540 9907540 0 0.0
(read/write) 675265 675265 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614184 614184 0 0.0
.dynamic 528 528 0 0.0
.got 13472 13472 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 471092 471092 0 0.0
.text 7897588 7897588 0 0.0
lighting-app debug+rpc (read only) 2533673 2533673 0 0.0
(read/write) 151928 151928 0 0.0
.bss 72064 72064 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71912 71912 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 212200 212200 0 0.0
.text 2151634 2151634 0 0.0
lock-app debug (read only) 2466977 2466977 0 0.0
(read/write) 146672 146672 0 0.0
.bss 70496 70496 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68632 68632 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 225928 225928 0 0.0
.text 2076610 2076610 0 0.0
ota-provider-app debug (read only) 2304817 2304817 0 0.0
(read/write) 140776 140776 0 0.0
.bss 70176 70176 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62872 62872 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 202104 202104 0 0.0
.text 1940418 1940418 0 0.0
ota-requestor-app debug (read only) 2421921 2421921 0 0.0
(read/write) 147648 147648 0 0.0
.bss 72544 72544 0 0.0
.data 2200 2200 0 0.0
.data.rel.ro 67048 67048 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 205984 205984 0 0.0
.text 2045266 2045266 0 0.0
shell debug (read only) 2612633 2612633 0 0.0
(read/write) 196120 196120 0 0.0
.bss 111304 111304 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 77832 77832 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 231698 231698 0 0.0
.text 2221154 2221154 0 0.0
thermostat-no-ble arm64 (read only) 2579044 2579044 0 0.0
(read/write) 180673 180673 0 0.0
.bss 87905 87905 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 82952 82952 0 0.0
.dynamic 528 528 0 0.0
.got 5088 5088 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164724 164724 0 0.0
.text 2175104 2175104 0 0.0
tv-app debug (read only) 3079665 3079665 0 0.0
(read/write) 277864 277864 0 0.0
.bss 187720 187720 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 79048 79048 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 247808 247808 0 0.0
.text 2644946 2644946 0 0.0
tv-casting-app debug (read only) 5542289 5542289 0 0.0
(read/write) 184144 184144 0 0.0
.bss 72872 72872 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 102592 102592 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 341737 341737 0 0.0
.text 4924274 4924274 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439536 2439536 0 0.0
.bss 212180 212180 0 0.0
.data 5864 5864 0 0.0
.text 1402180 1402180 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1202383 1202383 0 0.0
bss 142862 142862 0 0.0
rodata 156368 156368 0 0.0
text 824228 824228 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1149731 1149731 0 0.0
bss 142098 142098 0 0.0
rodata 132700 132700 0 0.0
text 796020 796020 0 0.0
p6 all-clusters-app default (read/write) 2555936 2555936 0 0.0
.bss 147360 147360 0 0.0
.data 2776 2776 0 0.0
.text 1514200 1514200 0 0.0
all-clusters-minimal-app default (read/write) 2501800 2501800 0 0.0
.bss 146640 146640 0 0.0
.data 2776 2776 0 0.0
.text 1460064 1460064 0 0.0
light-app default (read/write) 2432536 2432536 0 0.0
.bss 138720 138720 0 0.0
.data 2592 2592 0 0.0
.text 1390800 1390800 0 0.0
lock-app default (read/write) 2453256 2453256 0 0.0
.bss 138544 138544 0 0.0
.data 2600 2600 0 0.0
.text 1411520 1411520 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 792204 792204 0 0.0
bss 71140 71140 0 0.0
noinit 40416 40416 0 0.0
text 561076 561074 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 811908 811908 0 0.0
bss 71388 71388 0 0.0
noinit 40416 40416 0 0.0
text 577532 577536 4 0.0

Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking platform changes

@woody-apple woody-apple merged commit 29451fb into project-chip:master Jun 23, 2022
@sharadb-amazon sharadb-amazon deleted the ios-20220622 branch June 23, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants