Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EFR32] Fix OpenThread and Matter shell operation on EFRMG24 boards #19858

Merged
merged 46 commits into from
Jun 22, 2022
Merged

[EFR32] Fix OpenThread and Matter shell operation on EFRMG24 boards #19858

merged 46 commits into from
Jun 22, 2022

Conversation

selissia
Copy link
Contributor

Problem

OpenThread and Matter shells do not work on EFRMG24 boards

Change overview

Use correct platform calls for EUSART initialization and IRQ handling.

Testing

Tested various commands in the OpenThread and Matter shells on BRD4186A (MG24) and BRD4161A (MG12).

kowsisoundhar12 and others added 30 commits March 8, 2022 22:28
@kowsisoundhar12
Test added march 8 (project-chip#15957)
35fad7d 
* Added new manual scripts

* Added Auto generated File
@carol-apple
[OTA] Fix OTARequestorDriverImpl inclusion (project-chip#15981)
d5f4b0b
@bzbarsky-apple
Regen to fix CI failures (project-chip#15990)
9bee828
@Damian-Nordic @restyled-commits
[ota] Store Default OTA Providers in flash (project-chip#15970)
b942392 
* [ota] Store Default OTA Providers in flash

Store Default OTA Providers in flash each time the attribute
is modified and load it back on the application startup.

* Restyled by clang-format

* Fix build and reduce flash usage

Co-authored-by: Restyled.io <[email protected]>
@selissia
Merge branch 'master' of github.com:project-chip/connectedhomeip
c219807
@selissia
Merge branch 'project-chip:master' into master
fa279bc
@selissia
Merge branch 'project-chip:master' into master
9e18f9b
@selissia
Merge branch 'project-chip:master' into master
b6ca5ca
@selissia
Merge branch 'project-chip:master' into master
135dc25
@selissia
Merge branch 'project-chip:master' into master
0446c67
@selissia
Merge branch 'project-chip:master' into master
e69e63c
@selissia
Merge branch 'project-chip:master' into master
a40f6df
@selissia
Merge branch 'project-chip:master' into master
e5925ba
@selissia
Merge branch 'project-chip:master' into master
0435362
@selissia
Merge branch 'project-chip:master' into master
40b3412
@selissia
Merge branch 'project-chip:master' into master
d197cb5
@selissia
Merge branch 'project-chip:master' into master
e9b685d
@selissia
Merge branch 'project-chip:master' into master
ef11df2
@selissia
Merge branch 'project-chip:master' into master
b088f83
@selissia
Merge branch 'project-chip:master' into master
8530810
@selissia
Merge branch 'project-chip:master' into master
87a9581
@selissia
Merge branch 'project-chip:master' into master
d9b496d
@selissia
Merge branch 'project-chip:master' into master
2d283df
@selissia
Merge branch 'project-chip:master' into master
2639213
@selissia
Merge branch 'project-chip:master' into master
995a07e
@selissia
Merge branch 'project-chip:master' into master
139f480
@selissia
Merge branch 'project-chip:master' into master
f0beac0
@selissia
Merge branch 'project-chip:master' into master
70059e4
@selissia
Merge branch 'project-chip:master' into master
4faa576
@selissia
Merge branch 'project-chip:master' into master
e22e2fc
@restyled-io restyled-io bot mentioned this pull request Jun 22, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jun 22, 2022 •
edited
Loading

PR #19858: Size comparison from f36569f to 459ce36

Increases (3 builds for cc13x2_26x2, telink)
platform target config section f36569f 459ce36 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 691991 691999 8 0.0
.text 592156 592164 8 0.0
pump-app LP_CC2652R7 (read only) 673223 673231 8 0.0
.text 585076 585084 8 0.0
telink light-switch-app tlsr9518adk80d text 561062 561064 2 0.0
Decreases (4 builds for cc13x2_26x2, cyw30739, esp32)
platform target config section f36569f 459ce36 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 149728 149720 -8 -0.0
pump-app LP_CC2652R7 (read/write) 169392 169384 -8 -0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 589114 589106 -8 -0.0
.app_xip_area 459836 459828 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1014138 1014136 -2 -0.0
.flash.text 1014138 1014136 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section f36569f 459ce36 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660439 660439 0 0.0
(read/write) 191168 191168 0 0.0
.bss 74500 74500 0 0.0
.data 3356 3356 0 0.0
.rodata 86975 86975 0 0.0
.text 573152 573152 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649251 649251 0 0.0
(read/write) 158060 158060 0 0.0
.bss 73788 73788 0 0.0
.data 3356 3356 0 0.0
.rodata 90507 90507 0 0.0
.text 558424 558424 0 0.0
lock-ftd LP_CC2652R7 (read only) 691991 691999 8 0.0
(read/write) 149728 149720 -8 -0.0
.bss 71500 71500 0 0.0
.data 3280 3280 0 0.0
.rodata 99351 99351 0 0.0
.text 592156 592164 8 0.0
lock-mtd LP_CC2652R7 (read only) 641415 641415 0 0.0
(read/write) 144632 144632 0 0.0
.bss 67236 67236 0 0.0
.data 3280 3280 0 0.0
.rodata 99239 99239 0 0.0
.text 541684 541684 0 0.0
pump-app LP_CC2652R7 (read only) 673223 673231 8 0.0
(read/write) 169392 169384 -8 -0.0
.bss 71628 71628 0 0.0
.data 3280 3280 0 0.0
.rodata 87663 87663 0 0.0
.text 585076 585084 8 0.0
pump-controller-app LP_CC2652R7 (read only) 659123 659123 0 0.0
(read/write) 183604 183604 0 0.0
.bss 71740 71740 0 0.0
.data 3276 3276 0 0.0
.rodata 83507 83507 0 0.0
.text 575136 575136 0 0.0
shell LP_CC2652R7 (read only) 690198 690198 0 0.0
(read/write) 156912 156912 0 0.0
.bss 76804 76804 0 0.0
.data 3360 3360 0 0.0
.rodata 109758 109758 0 0.0
.text 580128 580128 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 591730 591730 0 0.0
.app_xip_area 462628 462628 0 0.0
.bss 72064 72064 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589114 589106 -8 -0.0
.app_xip_area 459836 459828 -8 -0.0
.bss 72240 72240 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 594250 594250 0 0.0
.app_xip_area 466020 466020 0 0.0
.bss 71248 71248 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 926072 926072 0 0.0
(read/write) 133664 133664 0 0.0
.bss 131584 131584 0 0.0
.data 2080 2080 0 0.0
.text 926064 926064 0 0.0
BRD4161A+rpc (read only) 963216 963216 0 0.0
(read/write) 150552 150552 0 0.0
.bss 148264 148264 0 0.0
.data 2284 2284 0 0.0
.text 963208 963208 0 0.0
BRD4161A+rs911x (read only) 802580 802580 0 0.0
(read/write) 140316 140316 0 0.0
.bss 138228 138228 0 0.0
.data 2088 2088 0 0.0
.text 802572 802572 0 0.0
lock-app BRD4161A+wf200 (read only) 968288 968288 0 0.0
(read/write) 140692 140692 0 0.0
.bss 138604 138604 0 0.0
.data 2088 2088 0 0.0
.text 968280 968280 0 0.0
window-app BRD4161A (read only) 911240 911240 0 0.0
(read/write) 133768 133768 0 0.0
.bss 131656 131656 0 0.0
.data 2108 2108 0 0.0
.text 911232 911232 0 0.0
esp32 all-clusters-app c3devkit (read only) 1014138 1014136 -2 -0.0
(read/write) 1484770 1484770 0 0.0
.dram0.bss 70640 70640 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 214064 214064 0 0.0
.flash.text 1014138 1014136 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068463 1068463 0 0.0
(read/write) 486856 486856 0 0.0
.dram0.bss 76152 76152 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244564 244564 0 0.0
.flash.text 1063079 1063079 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 661524 661524 0 0.0
.bss 69756 69756 0 0.0
.data 1992 1992 0 0.0
.text 583976 583976 0 0.0
lock k32w061+release (read/write) 723452 723452 0 0.0
.bss 70204 70204 0 0.0
.data 2000 2000 0 0.0
.text 645448 645448 0 0.0
linux all-clusters-app debug (read only) 2938705 2938705 0 0.0
(read/write) 177072 177072 0 0.0
.bss 84192 84192 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84632 84632 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 261597 261597 0 0.0
.text 2500738 2500738 0 0.0
all-clusters-minimal-app debug (read only) 2792513 2792513 0 0.0
(read/write) 168976 168976 0 0.0
.bss 83520 83520 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77272 77272 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 263229 263229 0 0.0
.text 2355090 2355090 0 0.0
bridge-app debug+rpc (read only) 2295097 2295097 0 0.0
(read/write) 147872 147872 0 0.0
.bss 71616 71616 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 66696 66696 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 196384 196384 0 0.0
.text 1937602 1937602 0 0.0
chip-tool debug (read only) 10191229 10191229 0 0.0
(read/write) 611464 611464 0 0.0
.bss 24416 24416 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 579680 579680 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 511317 511317 0 0.0
.text 8269813 8269813 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9925532 9925532 0 0.0
(read/write) 676161 676161 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 615080 615080 0 0.0
.dynamic 528 528 0 0.0
.got 13472 13472 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473932 473932 0 0.0
.text 7910628 7910628 0 0.0
lighting-app debug+rpc (read only) 2533233 2533233 0 0.0
(read/write) 151896 151896 0 0.0
.bss 72064 72064 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71864 71864 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 212136 212136 0 0.0
.text 2151378 2151378 0 0.0
lock-app debug (read only) 2466537 2466537 0 0.0
(read/write) 146608 146608 0 0.0
.bss 70496 70496 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68568 68568 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 225864 225864 0 0.0
.text 2076354 2076354 0 0.0
ota-provider-app debug (read only) 2304377 2304377 0 0.0
(read/write) 140712 140712 0 0.0
.bss 70176 70176 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62808 62808 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 202040 202040 0 0.0
.text 1940162 1940162 0 0.0
ota-requestor-app debug (read only) 2421481 2421481 0 0.0
(read/write) 147584 147584 0 0.0
.bss 72544 72544 0 0.0
.data 2200 2200 0 0.0
.data.rel.ro 67000 67000 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 205920 205920 0 0.0
.text 2045010 2045010 0 0.0
shell debug (read only) 2612193 2612193 0 0.0
(read/write) 196056 196056 0 0.0
.bss 111304 111304 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 77776 77776 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 231634 231634 0 0.0
.text 2220898 2220898 0 0.0
thermostat-no-ble arm64 (read only) 2578428 2578428 0 0.0
(read/write) 180609 180609 0 0.0
.bss 87905 87905 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 82896 82896 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164540 164540 0 0.0
.text 2174816 2174816 0 0.0
tv-app debug (read only) 3076425 3076425 0 0.0
(read/write) 277800 277800 0 0.0
.bss 187720 187720 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 78984 78984 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 247712 247712 0 0.0
.text 2641922 2641922 0 0.0
tv-casting-app debug (read only) 5541849 5541849 0 0.0
(read/write) 184080 184080 0 0.0
.bss 72872 72872 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 102544 102544 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 341673 341673 0 0.0
.text 4924018 4924018 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439432 2439432 0 0.0
.bss 212180 212180 0 0.0
.data 5864 5864 0 0.0
.text 1402076 1402076 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1201883 1201883 0 0.0
bss 142862 142862 0 0.0
rodata 156108 156108 0 0.0
text 823988 823988 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1149639 1149639 0 0.0
bss 142098 142098 0 0.0
rodata 132592 132592 0 0.0
text 796036 796036 0 0.0
p6 all-clusters-app default (read/write) 2555776 2555776 0 0.0
.bss 147360 147360 0 0.0
.data 2776 2776 0 0.0
.text 1514040 1514040 0 0.0
all-clusters-minimal-app default (read/write) 2501640 2501640 0 0.0
.bss 146640 146640 0 0.0
.data 2776 2776 0 0.0
.text 1459904 1459904 0 0.0
light-app default (read/write) 2432384 2432384 0 0.0
.bss 138720 138720 0 0.0
.data 2592 2592 0 0.0
.text 1390648 1390648 0 0.0
lock-app default (read/write) 2453096 2453096 0 0.0
.bss 138544 138544 0 0.0
.data 2600 2600 0 0.0
.text 1411360 1411360 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 792080 792080 0 0.0
bss 71140 71140 0 0.0
noinit 40416 40416 0 0.0
text 561062 561064 2 0.0
lighting-app tlsr9518adk80d (read/write) 811792 811792 0 0.0
bss 71388 71388 0 0.0
noinit 40416 40416 0 0.0
text 577524 577524 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking platform changes.

@andy31415 andy31415 merged commit 6231ccc into project-chip:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 left review comments

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples fast track review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@selissia @woody-apple @andy31415 @bzbarsky-apple @jmartinez-silabs @kowsisoundhar12 @carol-apple @Damian-Nordic @restyled-commits