-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Re-subscription event notification support #19833
Merged
woody-apple
merged 1 commit into
project-chip:master
from
mrjerryjohns:python/add-resub-callback
Jun 22, 2022
Merged
[Python] Re-subscription event notification support #19833
woody-apple
merged 1 commit into
project-chip:master
from
mrjerryjohns:python/add-resub-callback
Jun 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
registering for resubscription notifications.
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel and
lazarkov
June 22, 2022 01:26
pullapprove
bot
requested review from
kghost,
kpschoedel,
lazarkov,
LuDuda,
msandstedt,
mspang,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
June 22, 2022 01:26
PR #19833: Size comparison from c8149b1 to c971761 Increases (2 builds for cc13x2_26x2, nrfconnect)
Decreases (5 builds for cc13x2_26x2, cyw30739, telink)
Full report (36 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
agners
approved these changes
Jun 22, 2022
bzbarsky-apple
approved these changes
Jun 22, 2022
tehampson
approved these changes
Jun 22, 2022
yunhanw-google
approved these changes
Jun 22, 2022
woody-apple
approved these changes
Jun 22, 2022
Merging, given CI timeouts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Python test code that is being written up for CASE eviction testing needs to be able to tell if a subscription that has re-sub enabled on it has error'ed out in any way, resulting in re-subscription being triggered.
Solution
Add the ability to register a custom callback.
Testing
Defined a custom callback, and passed it in through
SetResubscriptionAttemptedCallback
, and ensured it got triggered.