Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Re-subscription event notification support #19833

Merged

Conversation

mrjerryjohns
Copy link
Contributor

Problem

Python test code that is being written up for CASE eviction testing needs to be able to tell if a subscription that has re-sub enabled on it has error'ed out in any way, resulting in re-subscription being triggered.

Solution

Add the ability to register a custom callback.

Testing

Defined a custom callback, and passed it in through SetResubscriptionAttemptedCallback, and ensured it got triggered.

registering for resubscription notifications.
@github-actions
Copy link

github-actions bot commented Jun 22, 2022

PR #19833: Size comparison from c8149b1 to c971761

Increases (2 builds for cc13x2_26x2, nrfconnect)
platform target config section c8149b1 c971761 change % change
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read/write) 183724 183732 8 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 795676 795680 4 0.0
Decreases (5 builds for cc13x2_26x2, cyw30739, telink)
platform target config section c8149b1 c971761 change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 649267 649259 -8 -0.0
.text 558192 558184 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 659003 658995 -8 -0.0
.text 574792 574784 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 591402 591394 -8 -0.0
.app_xip_area 462300 462292 -8 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 594210 594202 -8 -0.0
.app_xip_area 465980 465972 -8 -0.0
telink lighting-app tlsr9518adk80d text 577270 577268 -2 -0.0
Full report (36 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c8149b1 c971761 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660439 660439 0 0.0
(read/write) 191168 191168 0 0.0
.bss 74500 74500 0 0.0
.data 3356 3356 0 0.0
.rodata 87223 87223 0 0.0
.text 572904 572904 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649267 649259 -8 -0.0
(read/write) 158060 158060 0 0.0
.bss 73788 73788 0 0.0
.data 3356 3356 0 0.0
.rodata 90755 90755 0 0.0
.text 558192 558184 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 691863 691863 0 0.0
(read/write) 149856 149856 0 0.0
.bss 71500 71500 0 0.0
.data 3280 3280 0 0.0
.rodata 99535 99535 0 0.0
.text 591844 591844 0 0.0
lock-mtd LP_CC2652R7 (read only) 641263 641263 0 0.0
(read/write) 144632 144632 0 0.0
.bss 67236 67236 0 0.0
.data 3280 3280 0 0.0
.rodata 99415 99415 0 0.0
.text 541356 541356 0 0.0
pump-app LP_CC2652R7 (read only) 673119 673119 0 0.0
(read/write) 169496 169496 0 0.0
.bss 71628 71628 0 0.0
.data 3280 3280 0 0.0
.rodata 87887 87887 0 0.0
.text 584748 584748 0 0.0
pump-controller-app LP_CC2652R7 (read only) 659003 658995 -8 -0.0
(read/write) 183724 183732 8 0.0
.bss 71740 71740 0 0.0
.data 3276 3276 0 0.0
.rodata 83731 83731 0 0.0
.text 574792 574784 -8 -0.0
shell LP_CC2652R7 (read only) 690190 690190 0 0.0
(read/write) 156920 156920 0 0.0
.bss 76804 76804 0 0.0
.data 3360 3360 0 0.0
.rodata 110006 110006 0 0.0
.text 579872 579872 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 591402 591394 -8 -0.0
.app_xip_area 462300 462292 -8 -0.0
.bss 72064 72064 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 588786 588786 0 0.0
.app_xip_area 459508 459508 0 0.0
.bss 72240 72240 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 594210 594202 -8 -0.0
.app_xip_area 465980 465972 -8 -0.0
.bss 71248 71248 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1014114 1014114 0 0.0
(read/write) 1484770 1484770 0 0.0
.dram0.bss 70640 70640 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 214064 214064 0 0.0
.flash.text 1014114 1014114 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068463 1068463 0 0.0
(read/write) 486856 486856 0 0.0
.dram0.bss 76152 76152 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244564 244564 0 0.0
.flash.text 1063079 1063079 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660972 660972 0 0.0
.bss 69756 69756 0 0.0
.data 1992 1992 0 0.0
.text 583424 583424 0 0.0
lock k32w061+release (read/write) 723508 723508 0 0.0
.bss 70204 70204 0 0.0
.data 2000 2000 0 0.0
.text 645504 645504 0 0.0
linux all-clusters-app debug (read only) 2938089 2938089 0 0.0
(read/write) 177040 177040 0 0.0
.bss 84160 84160 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84632 84632 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 261341 261341 0 0.0
.text 2500402 2500402 0 0.0
all-clusters-minimal-app debug (read only) 2791897 2791897 0 0.0
(read/write) 168944 168944 0 0.0
.bss 83488 83488 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77272 77272 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 262973 262973 0 0.0
.text 2354754 2354754 0 0.0
bridge-app debug+rpc (read only) 2294545 2294545 0 0.0
(read/write) 147840 147840 0 0.0
.bss 71584 71584 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 66696 66696 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 196192 196192 0 0.0
.text 1937266 1937266 0 0.0
chip-tool debug (read only) 10190781 10190781 0 0.0
(read/write) 611464 611464 0 0.0
.bss 24416 24416 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 579680 579680 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 511317 511317 0 0.0
.text 8269365 8269365 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9925132 9925132 0 0.0
(read/write) 676161 676161 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 615080 615080 0 0.0
.dynamic 528 528 0 0.0
.got 13472 13472 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473916 473916 0 0.0
.text 7910244 7910244 0 0.0
lighting-app debug+rpc (read only) 2527241 2527241 0 0.0
(read/write) 151896 151896 0 0.0
.bss 72064 72064 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71864 71864 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 211944 211944 0 0.0
.text 2145602 2145602 0 0.0
lock-app debug (read only) 2465921 2465921 0 0.0
(read/write) 146576 146576 0 0.0
.bss 70464 70464 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68568 68568 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 225608 225608 0 0.0
.text 2076018 2076018 0 0.0
ota-provider-app debug (read only) 2303873 2303873 0 0.0
(read/write) 140680 140680 0 0.0
.bss 70144 70144 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62808 62808 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 201848 201848 0 0.0
.text 1939874 1939874 0 0.0
ota-requestor-app debug (read only) 2419697 2419697 0 0.0
(read/write) 147392 147392 0 0.0
.bss 72448 72448 0 0.0
.data 2200 2200 0 0.0
.data.rel.ro 66904 66904 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 205536 205536 0 0.0
.text 2043778 2043778 0 0.0
shell debug (read only) 2611969 2611969 0 0.0
(read/write) 196056 196056 0 0.0
.bss 111304 111304 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 77776 77776 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 231570 231570 0 0.0
.text 2220738 2220738 0 0.0
thermostat-no-ble arm64 (read only) 2577892 2577892 0 0.0
(read/write) 180577 180577 0 0.0
.bss 87889 87889 0 0.0
.data 1688 1688 0 0.0
.data.rel.ro 82896 82896 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164356 164356 0 0.0
.text 2174480 2174480 0 0.0
tv-app debug (read only) 3075873 3075873 0 0.0
(read/write) 277768 277768 0 0.0
.bss 187688 187688 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 78984 78984 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 247520 247520 0 0.0
.text 2641586 2641586 0 0.0
tv-casting-app debug (read only) 5541297 5541297 0 0.0
(read/write) 184080 184080 0 0.0
.bss 72872 72872 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 102544 102544 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 341481 341481 0 0.0
.text 4923682 4923682 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439432 2439432 0 0.0
.bss 212180 212180 0 0.0
.data 5864 5864 0 0.0
.text 1402076 1402076 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1201415 1201415 0 0.0
bss 142846 142846 0 0.0
rodata 156296 156296 0 0.0
text 823460 823460 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1149519 1149519 0 0.0
bss 142098 142098 0 0.0
rodata 132824 132824 0 0.0
text 795676 795680 4 0.0
p6 all-clusters-app default (read/write) 2555728 2555728 0 0.0
.bss 147360 147360 0 0.0
.data 2776 2776 0 0.0
.text 1513992 1513992 0 0.0
all-clusters-minimal-app default (read/write) 2501592 2501592 0 0.0
.bss 146640 146640 0 0.0
.data 2776 2776 0 0.0
.text 1459856 1459856 0 0.0
light-app default (read/write) 2432336 2432336 0 0.0
.bss 138720 138720 0 0.0
.data 2592 2592 0 0.0
.text 1390600 1390600 0 0.0
lock-app default (read/write) 2453048 2453048 0 0.0
.bss 138544 138544 0 0.0
.data 2600 2600 0 0.0
.text 1411312 1411312 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 792120 792120 0 0.0
bss 71140 71140 0 0.0
noinit 40416 40416 0 0.0
text 560810 560810 0 0.0
lighting-app tlsr9518adk80d (read/write) 811824 811824 0 0.0
bss 71388 71388 0 0.0
noinit 40416 40416 0 0.0
text 577270 577268 -2 -0.0

@woody-apple
Copy link
Contributor

Merging, given CI timeouts.

@woody-apple woody-apple merged commit 36476bc into project-chip:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants