-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to return software_version_string with <branch>:<commit_id> on linux platform #19710
Conversation
PR #19710: Size comparison from 26d6c54 to 937ee69 Increases (5 builds for cc13x2_26x2, esp32, telink)
Decreases (2 builds for cc13x2_26x2)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
fast track build changes for test tools. Does not affect SDK functionality. |
branch = shell.run_cmd( | ||
"git branch | awk -v FS=' ' '/\*/{print $NF}' | sed 's|[()]||g'", return_cmd_output=True).replace("\n", "") | ||
commit_id = shell.run_cmd("git rev-parse HEAD", return_cmd_output=True).replace("\n", "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tag + #commits + hash from git describe --tags
is easier and probably more useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for suggestion, I'll consider that in the future!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is too confusing, now changing branches will affect the resulting binary.
This type of stamping should be opt-in, not opt-out, since it's also seriously detrimental to performance and artifact caching since even a documentation change will result in a different binary.
…it_id> on linux platform (project-chip#19710)" (project-chip#19786) This reverts commit 8da6fc8.
…it_id> on linux platform (project-chip#19710)" (project-chip#19786) This reverts commit 8da6fc8.
…it_id> on linux platform (project-chip#19710)" (project-chip#19786) This reverts commit 8da6fc8.
…19979) * Pigweed: Update to 67bc89cdda8c (#19560) * Fix esp32 wifi and add RPC support on linux (#19260) * Chef - Extended Pigweed RPC support (#17781) * Build flash_script package for ESP32 Change-Id: I4e0375c9b9837b3b9f8a3d2570635536e7e34e42 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1419520 Reviewed-by: Doug Ferraz <[email protected]> * new: Wifi and Descriptor clusters on ESP32 Change-Id: I37b61425a55d8210c2286becce47917fddf54a3f Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1418359 Reviewed-by: Rob Oliver <[email protected]> Reviewed-by: Kevin Cheung <[email protected]> Reviewed-by: Jerry Lee <[email protected]> * new: added stub file. Included callbacks for successful operation of lock/unlock commands Change-Id: I9f4d601feb3b043d3c6689775bcaf40a8c5564d2 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1420959 Reviewed-by: Michael Spang <[email protected]> Reviewed-by: Jerry Lee <[email protected]> * Enable PW RPC server on chef-built virtual device app Change-Id: I878955e9df26e893c136650654019a8fa14e2a8b Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1417979 Reviewed-by: Doug Ferraz <[email protected]> * cosmetic change Change-Id: Ia2063a395a8d3f16965356d4a76b0d9df0834e57 * changes to linux pigweed dependencies. Still has issues building Pigweed Change-Id: I2be4e81f6c2e14112e31a0803813ef56d012b206 * Fix nrfconnect compilation errors (#17713) * Fix nrfconnect compilation errors * Chef: fix arguments for clean build * Build flash_script package for ESP32 Change-Id: I4e0375c9b9837b3b9f8a3d2570635536e7e34e42 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1419520 Reviewed-by: Doug Ferraz <[email protected]> * new: Wifi and Descriptor clusters on ESP32 Change-Id: I37b61425a55d8210c2286becce47917fddf54a3f Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1418359 Reviewed-by: Rob Oliver <[email protected]> Reviewed-by: Kevin Cheung <[email protected]> Reviewed-by: Jerry Lee <[email protected]> * new: added stub file. Included callbacks for successful operation of lock/unlock commands Change-Id: I9f4d601feb3b043d3c6689775bcaf40a8c5564d2 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1420959 Reviewed-by: Michael Spang <[email protected]> Reviewed-by: Jerry Lee <[email protected]> * Enable PW RPC server on chef-built virtual device app Change-Id: I878955e9df26e893c136650654019a8fa14e2a8b Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1417979 Reviewed-by: Doug Ferraz <[email protected]> * cosmetic change Change-Id: Ia2063a395a8d3f16965356d4a76b0d9df0834e57 * changes to linux pigweed dependencies. Still has issues building Pigweed Change-Id: I2be4e81f6c2e14112e31a0803813ef56d012b206 * Restyled by gn * Restyled by autopep8 * Restyled by gn Co-authored-by: Sebastian Mauer <[email protected]> Co-authored-by: MT Tsai <[email protected]> Co-authored-by: vinitg1 <[email protected]> Co-authored-by: Restyled.io <[email protected]> Change-Id: I827aa39ea41b8084d6fdca202e5a87e0f29cb4f3 * fix: added initialization to platform wifi network commissioning instance (#17983) Change-Id: I03b6b523d4c4557ab6cc432216e48b6d6b2b6964 * Chef - Revert changes on lighting-app that separate wifi and thread Co-authored-by: Douglas Rocha Ferraz <[email protected]> Co-authored-by: Sebastian Mauer <[email protected]> Co-authored-by: MT Tsai <[email protected]> Co-authored-by: vinitg1 <[email protected]> Co-authored-by: Restyled.io <[email protected]> * Support to return software_version_string with <branch>:<commit_id> on linux platform (#19710) * Chef - Add 13 sample apps (#19663) * Chef - Remove redundant hash_string in sample_app_util rename func * Chef - Add debugg output on exception to stateful_shell * Chef - Add choices for device arg * Chef - Add 13 sample apps * Revert "Support to return software_version_string with <branch>:<commit_id> on linux platform (#19710)" (#19786) This reverts commit 8da6fc8. * Truncate the branch info of the software version string while the total length greater equal to 64 bytes. (#19788) Make the filling of software version string with <branch>:<commit_id> as an option. The new option for it is '-a' or '--automated_test_stamp'. * Make Chef CI use existing zzz_generated and complete Chef CD for existing platforms (#19478) * Squashed commit of the following: commit b5d5920 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 18:17:34 2022 +0000 [no ci] comment commit 7c5fb08 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 18:15:37 2022 +0000 [no ci] Make border nice commit d67a7bc Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 18:09:29 2022 +0000 [no ci] restyle commit 5783829 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 17:48:39 2022 +0000 Add error handling to build all commit 083b072 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 17:15:33 2022 +0000 [no ci] update build image version commit 48805a8 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 08:20:49 2022 +0000 [no ci] minor commit 3cae95c Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 08:15:22 2022 +0000 [no ci] Minor commit df929b2 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 07:37:49 2022 +0000 Minor commit 759ddb0 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 07:28:36 2022 +0000 Minor commit d9ca2a6 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 07:22:03 2022 +0000 Style commit dbb9b30 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 06:50:11 2022 +0000 Style commit 3daff46 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 02:58:43 2022 +0000 nrf bundle commit 7d38eb4 Author: Austin Bozowski <[email protected]> Date: Wed Jun 8 16:34:57 2022 +0000 Linux bundle commit fd5689e Author: Austin Bozowski <[email protected]> Date: Wed Jun 8 09:08:42 2022 +0000 Make esp32 generic commit 1af3a2e Author: Austin Bozowski <[email protected]> Date: Tue Jun 7 08:35:52 2022 +0000 Missed comment commit 5f7c41c Author: Austin Bozowski <[email protected]> Date: Tue Jun 7 08:32:07 2022 +0000 Example bundle function * Bundle .matter, metadata & ensure .matter commit * Add partial check for .matter regen * Restyle and spelling * Address comments * Remove reflection * Generate zzz, .MATTERMD5 should go away in future * Temp del workflows * Remove chef exclusion from regen * Make regen all put chef exs in individual dirs * Remove validate zzz * Remove unused code from chef, change use_zzz * Skip util test files in gen all * Commit chef in root zzz * Delete chef zzz * Clean chef .matter files * Add post build for chef * Change .matter bundle rc to oot zzz * Generated files * Restore workflows * Change open to with * Restyle * Chef - Fix broken esp32 RPC build caused by #18621 (#19876) * Chef - Fix broken esp32 RPC build caused by #18621 * Chef - Fix esp32 RPC build issue caused by pigweed update * Make Scenes name support dependent on FeatureMap attribute (#18667) * Make Scenes name support dependent on FeatureMap attribute * Fix CI * Rebuild Zap generated files * Fix CI for ipv6only/esp32 example build * Fix errors regarding ownership of repo. (Taken from #18302) * Bump chef.yaml platform containers to 0.5.75 Co-authored-by: rgoliver <[email protected]> Co-authored-by: Douglas Rocha Ferraz <[email protected]> Co-authored-by: Sebastian Mauer <[email protected]> Co-authored-by: MT Tsai <[email protected]> Co-authored-by: vinitg1 <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: MtTsai <[email protected]> Co-authored-by: Michael Spang <[email protected]> Co-authored-by: Austin Bozowski <[email protected]> Co-authored-by: Jean-Francois Penven <[email protected]>
…roject-chip#19979) * Pigweed: Update to 67bc89cdda8c (project-chip#19560) * Fix esp32 wifi and add RPC support on linux (project-chip#19260) * Chef - Extended Pigweed RPC support (project-chip#17781) * Build flash_script package for ESP32 Change-Id: I4e0375c9b9837b3b9f8a3d2570635536e7e34e42 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1419520 Reviewed-by: Doug Ferraz <[email protected]> * new: Wifi and Descriptor clusters on ESP32 Change-Id: I37b61425a55d8210c2286becce47917fddf54a3f Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1418359 Reviewed-by: Rob Oliver <[email protected]> Reviewed-by: Kevin Cheung <[email protected]> Reviewed-by: Jerry Lee <[email protected]> * new: added stub file. Included callbacks for successful operation of lock/unlock commands Change-Id: I9f4d601feb3b043d3c6689775bcaf40a8c5564d2 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1420959 Reviewed-by: Michael Spang <[email protected]> Reviewed-by: Jerry Lee <[email protected]> * Enable PW RPC server on chef-built virtual device app Change-Id: I878955e9df26e893c136650654019a8fa14e2a8b Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1417979 Reviewed-by: Doug Ferraz <[email protected]> * cosmetic change Change-Id: Ia2063a395a8d3f16965356d4a76b0d9df0834e57 * changes to linux pigweed dependencies. Still has issues building Pigweed Change-Id: I2be4e81f6c2e14112e31a0803813ef56d012b206 * Fix nrfconnect compilation errors (project-chip#17713) * Fix nrfconnect compilation errors * Chef: fix arguments for clean build * Build flash_script package for ESP32 Change-Id: I4e0375c9b9837b3b9f8a3d2570635536e7e34e42 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1419520 Reviewed-by: Doug Ferraz <[email protected]> * new: Wifi and Descriptor clusters on ESP32 Change-Id: I37b61425a55d8210c2286becce47917fddf54a3f Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1418359 Reviewed-by: Rob Oliver <[email protected]> Reviewed-by: Kevin Cheung <[email protected]> Reviewed-by: Jerry Lee <[email protected]> * new: added stub file. Included callbacks for successful operation of lock/unlock commands Change-Id: I9f4d601feb3b043d3c6689775bcaf40a8c5564d2 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1420959 Reviewed-by: Michael Spang <[email protected]> Reviewed-by: Jerry Lee <[email protected]> * Enable PW RPC server on chef-built virtual device app Change-Id: I878955e9df26e893c136650654019a8fa14e2a8b Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1417979 Reviewed-by: Doug Ferraz <[email protected]> * cosmetic change Change-Id: Ia2063a395a8d3f16965356d4a76b0d9df0834e57 * changes to linux pigweed dependencies. Still has issues building Pigweed Change-Id: I2be4e81f6c2e14112e31a0803813ef56d012b206 * Restyled by gn * Restyled by autopep8 * Restyled by gn Co-authored-by: Sebastian Mauer <[email protected]> Co-authored-by: MT Tsai <[email protected]> Co-authored-by: vinitg1 <[email protected]> Co-authored-by: Restyled.io <[email protected]> Change-Id: I827aa39ea41b8084d6fdca202e5a87e0f29cb4f3 * fix: added initialization to platform wifi network commissioning instance (project-chip#17983) Change-Id: I03b6b523d4c4557ab6cc432216e48b6d6b2b6964 * Chef - Revert changes on lighting-app that separate wifi and thread Co-authored-by: Douglas Rocha Ferraz <[email protected]> Co-authored-by: Sebastian Mauer <[email protected]> Co-authored-by: MT Tsai <[email protected]> Co-authored-by: vinitg1 <[email protected]> Co-authored-by: Restyled.io <[email protected]> * Support to return software_version_string with <branch>:<commit_id> on linux platform (project-chip#19710) * Chef - Add 13 sample apps (project-chip#19663) * Chef - Remove redundant hash_string in sample_app_util rename func * Chef - Add debugg output on exception to stateful_shell * Chef - Add choices for device arg * Chef - Add 13 sample apps * Revert "Support to return software_version_string with <branch>:<commit_id> on linux platform (project-chip#19710)" (project-chip#19786) This reverts commit 8da6fc8. * Truncate the branch info of the software version string while the total length greater equal to 64 bytes. (project-chip#19788) Make the filling of software version string with <branch>:<commit_id> as an option. The new option for it is '-a' or '--automated_test_stamp'. * Make Chef CI use existing zzz_generated and complete Chef CD for existing platforms (project-chip#19478) * Squashed commit of the following: commit b5d5920 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 18:17:34 2022 +0000 [no ci] comment commit 7c5fb08 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 18:15:37 2022 +0000 [no ci] Make border nice commit d67a7bc Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 18:09:29 2022 +0000 [no ci] restyle commit 5783829 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 17:48:39 2022 +0000 Add error handling to build all commit 083b072 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 17:15:33 2022 +0000 [no ci] update build image version commit 48805a8 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 08:20:49 2022 +0000 [no ci] minor commit 3cae95c Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 08:15:22 2022 +0000 [no ci] Minor commit df929b2 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 07:37:49 2022 +0000 Minor commit 759ddb0 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 07:28:36 2022 +0000 Minor commit d9ca2a6 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 07:22:03 2022 +0000 Style commit dbb9b30 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 06:50:11 2022 +0000 Style commit 3daff46 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 02:58:43 2022 +0000 nrf bundle commit 7d38eb4 Author: Austin Bozowski <[email protected]> Date: Wed Jun 8 16:34:57 2022 +0000 Linux bundle commit fd5689e Author: Austin Bozowski <[email protected]> Date: Wed Jun 8 09:08:42 2022 +0000 Make esp32 generic commit 1af3a2e Author: Austin Bozowski <[email protected]> Date: Tue Jun 7 08:35:52 2022 +0000 Missed comment commit 5f7c41c Author: Austin Bozowski <[email protected]> Date: Tue Jun 7 08:32:07 2022 +0000 Example bundle function * Bundle .matter, metadata & ensure .matter commit * Add partial check for .matter regen * Restyle and spelling * Address comments * Remove reflection * Generate zzz, .MATTERMD5 should go away in future * Temp del workflows * Remove chef exclusion from regen * Make regen all put chef exs in individual dirs * Remove validate zzz * Remove unused code from chef, change use_zzz * Skip util test files in gen all * Commit chef in root zzz * Delete chef zzz * Clean chef .matter files * Add post build for chef * Change .matter bundle rc to oot zzz * Generated files * Restore workflows * Change open to with * Restyle * Chef - Fix broken esp32 RPC build caused by project-chip#18621 (project-chip#19876) * Chef - Fix broken esp32 RPC build caused by project-chip#18621 * Chef - Fix esp32 RPC build issue caused by pigweed update * Make Scenes name support dependent on FeatureMap attribute (project-chip#18667) * Make Scenes name support dependent on FeatureMap attribute * Fix CI * Rebuild Zap generated files * Fix CI for ipv6only/esp32 example build * Fix errors regarding ownership of repo. (Taken from project-chip#18302) * Bump chef.yaml platform containers to 0.5.75 Co-authored-by: rgoliver <[email protected]> Co-authored-by: Douglas Rocha Ferraz <[email protected]> Co-authored-by: Sebastian Mauer <[email protected]> Co-authored-by: MT Tsai <[email protected]> Co-authored-by: vinitg1 <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: MtTsai <[email protected]> Co-authored-by: Michael Spang <[email protected]> Co-authored-by: Austin Bozowski <[email protected]> Co-authored-by: Jean-Francois Penven <[email protected]>
Problem
The value of software version string is need for some test automation.
Change overview
Put the software version string with format :<commit_id> in the CHIP_DEVICE_CONFIG_DEVICE_SOFTWARE_VERSION_STRING by chef.py for linux sample app of chef build
Testing
Testing on linux sample app of chef build, the build command is as below.
And use rpc console to getDeviceInfo to check the value of software version string.