Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handling of CloseSession messages. #19645

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Add handling of CloseSession messages. #19645

merged 1 commit into from
Jun 16, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

To handle a CloseSession status message, we need something with access
to SecureChannel::StatusReport. That means it can't live in
src/transport or src/messaging, so can't be handled by the session
manager or exchange manager automatically.

So unfortunate as it is, add yet another thing that needs to be
initialized and initialize it once we have an initialized exchange
manager.

Fixes #16839

Problem

CloseSession not implemented.

Change overview

Implement it.

Testing

Used the chip-tool command from #19641 in interactive mode and made sure that both PASE and CASE sessions get closed.

@bzbarsky-apple
Add handling of CloseSession messages.
865bbda 
To handle a CloseSession status message, we need something with access
to SecureChannel::StatusReport.  That means it can't live in
src/transport or src/messaging, so can't be handled by the session
manager or exchange manager automatically.

So unfortunate as it is, add yet another thing that needs to be
initialized and initialize it once we have an initialized exchange
manager.

Fixes project-chip#16839
@github-actions
Copy link

github-actions bot commented Jun 15, 2022 •
edited
Loading

PR #19645: Size comparison from be878d3 to 865bbda

Increases above 0.2%:

platform target config section be878d3 865bbda change % change
linux bridge-app debug+rpc .rodata 193504 193952 448 0.2
lock-app debug .rodata 223176 223624 448 0.2
ota-provider-app debug .data.rel.ro 62520 62648 128 0.2
.rodata 199320 199800 480 0.2
ota-requestor-app debug .rodata 203040 203488 448 0.2
Increases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section be878d3 865bbda change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 657803 658075 272 0.0
.bss 73708 73716 8 0.0
.rodata 86883 86947 64 0.1
.text 570608 570816 208 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 646303 646647 344 0.1
(read/write) 157260 157268 8 0.0
.bss 72988 72996 8 0.0
.rodata 90159 90279 120 0.1
.text 555824 556048 224 0.0
lock-ftd LP_CC2652R7 (read only) 688639 688959 320 0.0
.bss 70700 70708 8 0.0
.rodata 98911 99031 120 0.1
.text 589244 589444 200 0.0
lock-mtd LP_CC2652R7 (read only) 638047 638375 328 0.1
(read/write) 143832 143840 8 0.0
.bss 66436 66444 8 0.0
.rodata 98791 98911 120 0.1
.text 538764 538972 208 0.0
pump-app LP_CC2652R7 (read only) 669863 670199 336 0.1
.bss 70820 70828 8 0.0
.rodata 87007 87127 120 0.1
.text 582372 582588 216 0.0
pump-controller-app LP_CC2652R7 (read only) 660619 660947 328 0.0
.bss 70948 70956 8 0.0
.rodata 84931 85051 120 0.1
.text 575204 575412 208 0.0
shell LP_CC2652R7 (read only) 687138 687482 344 0.1
.bss 76004 76012 8 0.0
.rodata 109410 109530 120 0.1
.text 577416 577640 224 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 611170 611474 304 0.0
.app_xip_area 467860 468156 296 0.1
.bss 86232 86240 8 0.0
lock cyw930739m2evb_01 (read/write) 608254 608558 304 0.0
.app_xip_area 464800 465096 296 0.1
.bss 86408 86416 8 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614266 614578 312 0.1
.app_xip_area 471876 472180 304 0.1
.bss 85400 85408 8 0.0
efr32 lighting-app BRD4161A (read only) 920708 921420 712 0.1
(read/write) 132396 132404 8 0.0
.bss 130280 130288 8 0.0
.text 920700 921412 712 0.1
BRD4161A+rpc (read only) 956364 957092 728 0.1
(read/write) 149272 149280 8 0.0
.bss 146952 146960 8 0.0
.text 956356 957084 728 0.1
BRD4161A+rs911x (read only) 795824 796440 616 0.1
(read/write) 128676 128684 8 0.0
.bss 126548 126556 8 0.0
.text 795816 796432 616 0.1
lock-app BRD4161A+wf200 (read only) 963720 964080 360 0.0
(read/write) 129012 129020 8 0.0
.bss 126924 126932 8 0.0
.text 963712 964072 360 0.0
window-app BRD4161A (read only) 905596 906308 712 0.1
(read/write) 132460 132468 8 0.0
.bss 130352 130360 8 0.0
.text 905588 906300 712 0.1
esp32 all-clusters-app c3devkit (read only) 1010754 1011010 256 0.0
(read/write) 1482626 1482770 144 0.0
.dram0.bss 69344 69352 8 0.0
.dram0.data 14656 14664 8 0.1
.flash.rodata 213200 213312 112 0.1
.flash.text 1010754 1011010 256 0.0
m5stack (read only) 1065035 1065351 316 0.0
(read/write) 484744 484872 128 0.0
.dram0.bss 74864 74872 8 0.0
.flash.rodata 243708 243828 120 0.0
.flash.text 1059651 1059967 316 0.0
k32w light k32w061+release (read/write) 657368 657664 296 0.0
.bss 68708 68716 8 0.0
.text 580832 581120 288 0.0
lock k32w061+release (read/write) 719008 719376 368 0.1
.bss 69140 69148 8 0.0
.text 642068 642428 360 0.1
linux all-clusters-app debug (read only) 2920241 2922121 1880 0.1
(read/write) 188328 188456 128 0.1
.bss 95680 95712 32 0.0
.data.rel.ro 84344 84456 112 0.1
.rodata 258749 259197 448 0.2
.text 2485794 2486962 1168 0.0
all-clusters-minimal-app debug (read only) 2774121 2776017 1896 0.1
(read/write) 180136 180296 160 0.1
.bss 94976 95008 32 0.0
.data.rel.ro 76984 77096 112 0.1
.rodata 260221 260701 480 0.2
.text 2340450 2341602 1152 0.0
bridge-app debug+rpc (read only) 2254377 2256257 1880 0.1
(read/write) 158008 158168 160 0.1
.bss 81952 81984 32 0.0
.data.rel.ro 66408 66536 128 0.2
.rodata 193504 193952 448 0.2
.text 1900482 1901650 1168 0.1
chip-tool debug (read only) 9941429 9943533 2104 0.0
(read/write) 581632 581728 96 0.0
.data.rel.ro 549896 550016 120 0.0
.rodata 502229 502645 416 0.1
.text 8098965 8100389 1424 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9690572 9692308 1736 0.0
(read/write) 646001 646129 128 0.0
.data.rel.ro 585264 585384 120 0.0
.got 13152 13160 8 0.1
.rodata 466396 466580 184 0.0
.text 7754036 7755300 1264 0.0
lighting-app debug+rpc (read only) 2509929 2511761 1832 0.1
(read/write) 163120 163248 128 0.1
.data.rel.ro 71560 71688 128 0.2
.rodata 209416 209832 416 0.2
.text 2131506 2132658 1152 0.1
lock-app debug (read only) 2448361 2450225 1864 0.1
(read/write) 157680 157840 160 0.1
.bss 81920 81952 32 0.0
.data.rel.ro 68248 68376 128 0.2
.rodata 223176 223624 448 0.2
.text 2061650 2062802 1152 0.1
ota-provider-app debug (read only) 2286313 2288225 1912 0.1
(read/write) 151816 151976 160 0.1
.bss 81600 81632 32 0.0
.data.rel.ro 62520 62648 128 0.2
.rodata 199320 199800 480 0.2
.text 1925586 1926754 1168 0.1
ota-requestor-app debug (read only) 2402073 2403937 1864 0.1
(read/write) 158592 158720 128 0.1
.bss 83904 83936 32 0.0
.data.rel.ro 66632 66744 112 0.2
.rodata 203040 203488 448 0.2
.text 2029394 2030546 1152 0.1
shell debug (read only) 2593785 2595649 1864 0.1
(read/write) 218992 219152 160 0.1
.bss 134440 134472 32 0.0
.data.rel.ro 77512 77632 120 0.2
.rodata 229074 229522 448 0.2
.text 2205698 2206850 1152 0.1
thermostat-no-ble arm64 (read only) 2561996 2563588 1592 0.1
(read/write) 191729 191873 144 0.1
.bss 99393 99409 16 0.0
.data.rel.ro 82560 82680 120 0.1
.got 5064 5072 8 0.2
.rodata 163004 163188 184 0.1
.text 2160704 2161824 1120 0.1
tv-app debug (read only) 3058337 3060585 2248 0.1
(read/write) 289120 289248 128 0.0
.bss 199176 199208 32 0.0
.data.rel.ro 78688 78808 120 0.2
.rodata 245024 245440 416 0.2
.text 2627122 2628690 1568 0.1
tv-casting-app debug (read only) 5540761 5542641 1880 0.0
(read/write) 199664 199792 128 0.1
.data.rel.ro 102856 102976 120 0.1
.rodata 340521 340969 448 0.1
.text 4924514 4925682 1168 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2435720 2436096 376 0.0
.bss 208148 208156 8 0.0
.text 1398364 1398740 376 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1196803 1197147 344 0.0
bss 141554 141562 8 0.0
rodata 155420 155540 120 0.1
text 820972 821204 232 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144851 1145319 468 0.0
bss 140794 140802 8 0.0
rodata 131948 132064 116 0.1
text 793288 793524 236 0.0
p6 all-clusters-app default (read/write) 2550112 2550840 728 0.0
.bss 143344 143352 8 0.0
.text 1508376 1509104 728 0.0
all-clusters-minimal-app default (read/write) 2496056 2496800 744 0.0
.bss 142608 142616 8 0.0
.text 1454320 1455064 744 0.1
light-app default (read/write) 2426936 2427680 744 0.0
.bss 134688 134696 8 0.0
.text 1385200 1385944 744 0.1
lock-app default (read/write) 2447352 2448080 728 0.0
.bss 134512 134520 8 0.0
.text 1405616 1406344 728 0.1
telink light-switch-app tlsr9518adk80d (read/write) 786916 787296 380 0.0
bss 69836 69844 8 0.0
text 557810 558064 254 0.0
lighting-app tlsr9518adk80d (read/write) 806904 807284 380 0.0
bss 70088 70096 8 0.0
text 574506 574758 252 0.0
Decreases (5 builds for cc13x2_26x2)
platform target config section be878d3 865bbda change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 193012 192748 -264 -0.1
lock-ftd LP_CC2652R7 (read/write) 152280 151968 -312 -0.2
pump-app LP_CC2652R7 (read/write) 171944 171616 -328 -0.2
pump-controller-app LP_CC2652R7 (read/write) 181316 180996 -320 -0.2
shell LP_CC2652R7 (read/write) 159172 158836 -336 -0.2
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section be878d3 865bbda change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 657803 658075 272 0.0
(read/write) 193012 192748 -264 -0.1
.bss 73708 73716 8 0.0
.data 3380 3380 0 0.0
.rodata 86883 86947 64 0.1
.text 570608 570816 208 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 646303 646647 344 0.1
(read/write) 157260 157268 8 0.0
.bss 72988 72996 8 0.0
.data 3356 3356 0 0.0
.rodata 90159 90279 120 0.1
.text 555824 556048 224 0.0
lock-ftd LP_CC2652R7 (read only) 688639 688959 320 0.0
(read/write) 152280 151968 -312 -0.2
.bss 70700 70708 8 0.0
.data 3280 3280 0 0.0
.rodata 98911 99031 120 0.1
.text 589244 589444 200 0.0
lock-mtd LP_CC2652R7 (read only) 638047 638375 328 0.1
(read/write) 143832 143840 8 0.0
.bss 66436 66444 8 0.0
.data 3280 3280 0 0.0
.rodata 98791 98911 120 0.1
.text 538764 538972 208 0.0
pump-app LP_CC2652R7 (read only) 669863 670199 336 0.1
(read/write) 171944 171616 -328 -0.2
.bss 70820 70828 8 0.0
.data 3316 3316 0 0.0
.rodata 87007 87127 120 0.1
.text 582372 582588 216 0.0
pump-controller-app LP_CC2652R7 (read only) 660619 660947 328 0.0
(read/write) 181316 180996 -320 -0.2
.bss 70948 70956 8 0.0
.data 3276 3276 0 0.0
.rodata 84931 85051 120 0.1
.text 575204 575412 208 0.0
shell LP_CC2652R7 (read only) 687138 687482 344 0.1
(read/write) 159172 158836 -336 -0.2
.bss 76004 76012 8 0.0
.data 3384 3384 0 0.0
.rodata 109410 109530 120 0.1
.text 577416 577640 224 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 611170 611474 304 0.0
.app_xip_area 467860 468156 296 0.1
.bss 86232 86240 8 0.0
.data 764 764 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 608254 608558 304 0.0
.app_xip_area 464800 465096 296 0.1
.bss 86408 86416 8 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614266 614578 312 0.1
.app_xip_area 471876 472180 304 0.1
.bss 85400 85408 8 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920708 921420 712 0.1
(read/write) 132396 132404 8 0.0
.bss 130280 130288 8 0.0
.data 2116 2116 0 0.0
.text 920700 921412 712 0.1
BRD4161A+rpc (read only) 956364 957092 728 0.1
(read/write) 149272 149280 8 0.0
.bss 146952 146960 8 0.0
.data 2320 2320 0 0.0
.text 956356 957084 728 0.1
BRD4161A+rs911x (read only) 795824 796440 616 0.1
(read/write) 128676 128684 8 0.0
.bss 126548 126556 8 0.0
.data 2124 2124 0 0.0
.text 795816 796432 616 0.1
lock-app BRD4161A+wf200 (read only) 963720 964080 360 0.0
(read/write) 129012 129020 8 0.0
.bss 126924 126932 8 0.0
.data 2088 2088 0 0.0
.text 963712 964072 360 0.0
window-app BRD4161A (read only) 905596 906308 712 0.1
(read/write) 132460 132468 8 0.0
.bss 130352 130360 8 0.0
.data 2108 2108 0 0.0
.text 905588 906300 712 0.1
esp32 all-clusters-app c3devkit (read only) 1010754 1011010 256 0.0
(read/write) 1482626 1482770 144 0.0
.dram0.bss 69344 69352 8 0.0
.dram0.data 14656 14664 8 0.1
.flash.rodata 213200 213312 112 0.1
.flash.text 1010754 1011010 256 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1065035 1065351 316 0.0
(read/write) 484744 484872 128 0.0
.dram0.bss 74864 74872 8 0.0
.dram0.data 34176 34176 0 0.0
.flash.rodata 243708 243828 120 0.0
.flash.text 1059651 1059967 316 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657368 657664 296 0.0
.bss 68708 68716 8 0.0
.data 2028 2028 0 0.0
.text 580832 581120 288 0.0
lock k32w061+release (read/write) 719008 719376 368 0.1
.bss 69140 69148 8 0.0
.data 2000 2000 0 0.0
.text 642068 642428 360 0.1
linux all-clusters-app debug (read only) 2920241 2922121 1880 0.1
(read/write) 188328 188456 128 0.1
.bss 95680 95712 32 0.0
.data 2112 2112 0 0.0
.data.rel.ro 84344 84456 112 0.1
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 258749 259197 448 0.2
.text 2485794 2486962 1168 0.0
all-clusters-minimal-app debug (read only) 2774121 2776017 1896 0.1
(read/write) 180136 180296 160 0.1
.bss 94976 95008 32 0.0
.data 2048 2048 0 0.0
.data.rel.ro 76984 77096 112 0.1
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 260221 260701 480 0.2
.text 2340450 2341602 1152 0.0
bridge-app debug+rpc (read only) 2254377 2256257 1880 0.1
(read/write) 158008 158168 160 0.1
.bss 81952 81984 32 0.0
.data 3888 3888 0 0.0
.data.rel.ro 66408 66536 128 0.2
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 193504 193952 448 0.2
.text 1900482 1901650 1168 0.1
chip-tool debug (read only) 9941429 9943533 2104 0.0
(read/write) 581632 581728 96 0.0
.bss 24352 24352 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 549896 550016 120 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 502229 502645 416 0.1
.text 8098965 8100389 1424 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9690572 9692308 1736 0.0
(read/write) 646001 646129 128 0.0
.bss 42625 42625 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 585264 585384 120 0.0
.dynamic 528 528 0 0.0
.got 13152 13160 8 0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 466396 466580 184 0.0
.text 7754036 7755300 1264 0.0
lighting-app debug+rpc (read only) 2509929 2511761 1832 0.1
(read/write) 163120 163248 128 0.1
.bss 83552 83552 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 71560 71688 128 0.2
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 209416 209832 416 0.2
.text 2131506 2132658 1152 0.1
lock-app debug (read only) 2448361 2450225 1864 0.1
(read/write) 157680 157840 160 0.1
.bss 81920 81952 32 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68248 68376 128 0.2
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 223176 223624 448 0.2
.text 2061650 2062802 1152 0.1
ota-provider-app debug (read only) 2286313 2288225 1912 0.1
(read/write) 151816 151976 160 0.1
.bss 81600 81632 32 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62520 62648 128 0.2
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 199320 199800 480 0.2
.text 1925586 1926754 1168 0.1
ota-requestor-app debug (read only) 2402073 2403937 1864 0.1
(read/write) 158592 158720 128 0.1
.bss 83904 83936 32 0.0
.data 2200 2200 0 0.0
.data.rel.ro 66632 66744 112 0.2
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 203040 203488 448 0.2
.text 2029394 2030546 1152 0.1
shell debug (read only) 2593785 2595649 1864 0.1
(read/write) 218992 219152 160 0.1
.bss 134440 134472 32 0.0
.data 1296 1296 0 0.0
.data.rel.ro 77512 77632 120 0.2
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 229074 229522 448 0.2
.text 2205698 2206850 1152 0.1
thermostat-no-ble arm64 (read only) 2561996 2563588 1592 0.1
(read/write) 191729 191873 144 0.1
.bss 99393 99409 16 0.0
.data 1688 1688 0 0.0
.data.rel.ro 82560 82680 120 0.1
.dynamic 528 528 0 0.0
.got 5064 5072 8 0.2
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 163004 163188 184 0.1
.text 2160704 2161824 1120 0.1
tv-app debug (read only) 3058337 3060585 2248 0.1
(read/write) 289120 289248 128 0.0
.bss 199176 199208 32 0.0
.data 4816 4816 0 0.0
.data.rel.ro 78688 78808 120 0.2
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 245024 245440 416 0.2
.text 2627122 2628690 1568 0.1
tv-casting-app debug (read only) 5540761 5542641 1880 0.0
(read/write) 199664 199792 128 0.1
.bss 88040 88040 0 0.0
.data 2544 2544 0 0.0
.data.rel.ro 102856 102976 120 0.1
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 340521 340969 448 0.1
.text 4924514 4925682 1168 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2435720 2436096 376 0.0
.bss 208148 208156 8 0.0
.data 5864 5864 0 0.0
.text 1398364 1398740 376 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1196803 1197147 344 0.0
bss 141554 141562 8 0.0
rodata 155420 155540 120 0.1
text 820972 821204 232 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144851 1145319 468 0.0
bss 140794 140802 8 0.0
rodata 131948 132064 116 0.1
text 793288 793524 236 0.0
p6 all-clusters-app default (read/write) 2550112 2550840 728 0.0
.bss 143344 143352 8 0.0
.data 2800 2800 0 0.0
.text 1508376 1509104 728 0.0
all-clusters-minimal-app default (read/write) 2496056 2496800 744 0.0
.bss 142608 142616 8 0.0
.data 2776 2776 0 0.0
.text 1454320 1455064 744 0.1
light-app default (read/write) 2426936 2427680 744 0.0
.bss 134688 134696 8 0.0
.data 2624 2624 0 0.0
.text 1385200 1385944 744 0.1
lock-app default (read/write) 2447352 2448080 728 0.0
.bss 134512 134520 8 0.0
.data 2600 2600 0 0.0
.text 1405616 1406344 728 0.1
telink light-switch-app tlsr9518adk80d (read/write) 786916 787296 380 0.0
bss 69836 69844 8 0.0
noinit 40416 40416 0 0.0
text 557810 558064 254 0.0
lighting-app tlsr9518adk80d (read/write) 806904 807284 380 0.0
bss 70088 70096 8 0.0
noinit 40416 40416 0 0.0
text 574506 574758 252 0.0

@woody-apple woody-apple merged commit 83a0863 into project-chip:master Jun 16, 2022
@bzbarsky-apple bzbarsky-apple deleted the process-close-session branch June 16, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to implement handling of CloseSession status messages
3 participants
@bzbarsky-apple @mrjerryjohns @woody-apple