-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set chip_progress_logging = false for all-clusters for cc13x2 builds … #19469
Merged
andy31415
merged 1 commit into
project-chip:master
from
andy31415:disable_progress_logging_on_cc_all_clusters
Jun 10, 2022
Merged
Set chip_progress_logging = false for all-clusters for cc13x2 builds … #19469
andy31415
merged 1 commit into
project-chip:master
from
andy31415:disable_progress_logging_on_cc_all_clusters
Jun 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as it does not fit in flash
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
rgoliver
June 10, 2022 15:34
pullapprove
bot
requested review from
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
msandstedt,
rgoliver,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
June 10, 2022 15:34
pullapprove
bot
added
review - pending
and removed
hotfix
urgent fix needed, can bypass review
labels
Jun 10, 2022
PR #19469: Size comparison from 66d6d1a to a6ead86 Increases (2 builds for esp32, telink)
Decreases (1 build for nrfconnect)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…as it does not fit in flash
Problem
Compile error: out of flash on all clusters app:
https://github.com/project-chip/connectedhomeip/runs/6833066586?check_suite_focus=true
Change overview
Disable progress logging for all clusters app to save some flash space.
Testing
Local compile test.