-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: nrf_connect: rework OT RCP dongle guide #19374
Merged
andy31415
merged 2 commits into
project-chip:master
from
greg-fer:doc_nrf_connect_ot_rcp_nrf_dongle_update
Jun 9, 2022
Merged
doc: nrf_connect: rework OT RCP dongle guide #19374
andy31415
merged 2 commits into
project-chip:master
from
greg-fer:doc_nrf_connect_ot_rcp_nrf_dongle_update
Jun 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edited the nRF Connect OpenThread RCP dongle guide. Made minor style edits to OT border router page. Signed-off-by: Grzegorz Ferenc <[email protected]>
boring-cyborg
bot
added
the
documentation
Improvements or additions to documentation
label
Jun 9, 2022
PR #19374: Size comparison from 47a51ce to 3f6cf24 Increases (2 builds for cc13x2_26x2, telink)
Decreases (2 builds for cc13x2_26x2, esp32)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov and
LuDuda
June 9, 2022 12:18
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
rgoliver,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
June 9, 2022 12:18
Damian-Nordic
approved these changes
Jun 9, 2022
PR #19374: Size comparison from 47a51ce to a8884d9 Increases (1 build for cc13x2_26x2)
Decreases (5 builds for cc13x2_26x2, cyw30739, esp32, nrfconnect)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jun 9, 2022
woody-apple
approved these changes
Jun 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking documentation
LuDuda
approved these changes
Jun 9, 2022
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Jun 10, 2022
* doc: nrf_connect: rework OT RCP dongle guide Edited the nRF Connect OpenThread RCP dongle guide. Made minor style edits to OT border router page. Signed-off-by: Grzegorz Ferenc <[email protected]> * Restyled by prettier-markdown Co-authored-by: Restyled.io <[email protected]>
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Jun 15, 2022
* doc: nrf_connect: rework OT RCP dongle guide Edited the nRF Connect OpenThread RCP dongle guide. Made minor style edits to OT border router page. Signed-off-by: Grzegorz Ferenc <[email protected]> * Restyled by prettier-markdown Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited the nRF Connect OpenThread RCP dongle guide.
Made minor style edits to OT border router page.
Signed-off-by: Grzegorz Ferenc [email protected]
Problem
Fix outdated information about setting up RCP on nRF52840 Dongle.
Change overview
Removed bare-metal RCP instructions for more recent NCS-based RCP instructions.
Edited the Setup OpenThread Border Router on Raspberry Pi for style to make links more clear
and remove non-technical emotionally-marked forms with exclamation marks and too much formatting.
Testing
Doc changes only.