-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore expired identities for Darwin codesigning. #19330
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:codesign-ignore-expired
Jun 8, 2022
Merged
Ignore expired identities for Darwin codesigning. #19330
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:codesign-ignore-expired
Jun 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
June 8, 2022 18:30
pullapprove
bot
requested review from
mspang,
rgoliver,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
wbschiller,
woody-apple and
xylophone21
June 8, 2022 18:30
tcarmelveilleux
approved these changes
Jun 8, 2022
vivien-apple
reviewed
Jun 8, 2022
vivien-apple
approved these changes
Jun 8, 2022
jmartinez-silabs
approved these changes
Jun 8, 2022
PR #19330: Size comparison from 3a5d086 to ca46aa7 Increases (1 build for esp32)
Decreases (2 builds for nrfconnect, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19327
Problem
We try to use expired identities, then codesigning fails
Change overview
Skip over expired identities.
Testing
Checked that if I use other strings that appear in my identities instead of CSSMERR_TP_CERT_EXPIRED the right things are skipped.