Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove internal synchronization for event management #19285

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Remove internal synchronization for event management #19285

merged 1 commit into from
Jun 8, 2022

Conversation

yunhanw-google
Copy link
Contributor

Problem

#18065

Change overview

Remove internal synchronization for event management

Testing

compilation.

@boring-cyborg boring-cyborg bot added the app label Jun 7, 2022
@yunhanw-google yunhanw-google force-pushed the feature/remove_event_management_lock branch from c07b680 to 88229ba Compare June 7, 2022 18:37
@github-actions
Copy link

github-actions bot commented Jun 7, 2022 •
edited
Loading

PR #19285: Size comparison from e57476d to 88229ba

Increases above 0.2%:

platform target config section e57476d 88229ba change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 159592 159992 400 0.3
lock-ftd LP_CC2652R7 (read/write) 157136 157544 408 0.3
Increases (7 builds for cc13x2_26x2, cyw30739)
platform target config section e57476d 88229ba change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 159592 159992 400 0.3
lock-ftd LP_CC2652R7 (read/write) 157136 157544 408 0.3
pump-app LP_CC2652R7 (read/write) 176900 177324 424 0.2
pump-controller-app LP_CC2652R7 (read/write) 185860 186268 408 0.2
shell LP_CC2652R7 (read/write) 162808 163200 392 0.2
cyw30739 lock cyw930739m2evb_01 (read/write) 601254 601262 8 0.0
.app_xip_area 460048 460056 8 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599462 599470 8 0.0
.app_xip_area 459380 459388 8 0.0
Decreases (34 builds for cc13x2_26x2, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section e57476d 88229ba change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692263 691863 -400 -0.1
.rodata 112719 112695 -24 -0.0
.text 579232 578856 -376 -0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 642887 642487 -400 -0.1
.rodata 89759 89735 -24 -0.0
.text 552808 552432 -376 -0.1
lock-ftd LP_CC2652R7 (read only) 685783 685375 -408 -0.1
.rodata 98583 98559 -24 -0.0
.text 586716 586332 -384 -0.1
lock-mtd LP_CC2652R7 (read only) 635199 634783 -416 -0.1
.rodata 98471 98447 -24 -0.0
.text 536236 535844 -392 -0.1
pump-app LP_CC2652R7 (read only) 666923 666499 -424 -0.1
.rodata 86819 86787 -32 -0.0
.text 579620 579228 -392 -0.1
pump-controller-app LP_CC2652R7 (read only) 658075 657667 -408 -0.1
.rodata 84867 84843 -24 -0.0
.text 572724 572340 -384 -0.1
shell LP_CC2652R7 (read only) 684542 684150 -392 -0.1
.rodata 109318 109294 -24 -0.0
.text 574912 574544 -368 -0.1
efr32 lighting-app BRD4161A (read only) 919272 919032 -240 -0.0
.text 919264 919024 -240 -0.0
BRD4161A+rpc (read only) 953500 953260 -240 -0.0
.text 953492 953252 -240 -0.0
BRD4161A+rs911x (read only) 794548 794196 -352 -0.0
.text 794540 794188 -352 -0.0
lock-app BRD4161A+wf200 (read only) 960964 960676 -288 -0.0
.text 960956 960668 -288 -0.0
window-app BRD4161A (read only) 904320 904080 -240 -0.0
.text 904312 904072 -240 -0.0
k32w light k32w061+release (read/write) 655736 655544 -192 -0.0
.text 577864 577672 -192 -0.0
lock k32w061+release (read/write) 717284 717060 -224 -0.0
.text 639000 638776 -224 -0.0
linux all-clusters-app debug (read only) 2894321 2893297 -1024 -0.0
.rodata 255485 255357 -128 -0.1
.text 2463794 2462898 -896 -0.0
all-clusters-minimal-app debug (read only) 2770025 2769017 -1008 -0.0
.rodata 257277 257149 -128 -0.0
.text 2338882 2338002 -880 -0.0
bridge-app debug+rpc (read only) 2212353 2211345 -1008 -0.0
.rodata 188192 188064 -128 -0.1
.text 1864178 1863298 -880 -0.0
chip-tool debug (read only) 9739045 9738757 -288 -0.0
.rodata 505565 505533 -32 -0.0
.text 7831269 7831013 -256 -0.0
lighting-app debug+rpc (read only) 2498513 2497505 -1008 -0.0
.rodata 205928 205800 -128 -0.1
.text 2123650 2122770 -880 -0.0
lock-app debug (read only) 2444409 2443385 -1024 -0.0
.rodata 219944 219816 -128 -0.1
.text 2060514 2059618 -896 -0.0
ota-provider-app debug (read only) 2208465 2207441 -1024 -0.0
.rodata 192408 192280 -128 -0.1
.text 1855890 1854994 -896 -0.0
ota-requestor-app debug (read only) 2269273 2268265 -1008 -0.0
.rodata 195744 195616 -128 -0.1
.text 1909506 1908626 -880 -0.0
shell debug (read only) 2598777 2597769 -1008 -0.0
.rodata 228178 228050 -128 -0.1
.text 2210914 2210034 -880 -0.0
tv-app debug (read only) 3044489 3043481 -1008 -0.0
.rodata 240992 240864 -128 -0.1
.text 2617362 2616482 -880 -0.0
tv-casting-app debug (read only) 5348353 5347345 -1008 -0.0
.rodata 340832 340704 -128 -0.0
.text 4655970 4655090 -880 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2432080 2431776 -304 -0.0
.text 1394724 1394420 -304 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1194419 1194211 -208 -0.0
rodata 155260 155228 -32 -0.0
text 818856 818692 -164 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1142131 1141923 -208 -0.0
rodata 131756 131724 -32 -0.0
text 790908 790740 -168 -0.0
p6 all-clusters-app default (read/write) 2548904 2548520 -384 -0.0
.text 1507168 1506784 -384 -0.0
all-clusters-minimal-app default (read/write) 2493760 2493392 -368 -0.0
.text 1452024 1451656 -368 -0.0
light-app default (read/write) 2425664 2425296 -368 -0.0
.text 1383928 1383560 -368 -0.0
lock-app default (read/write) 2445968 2445616 -352 -0.0
.text 1404232 1403880 -352 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 784172 783900 -272 -0.0
text 554392 554152 -240 -0.0
lighting-app tlsr9518adk80d (read/write) 804216 803952 -264 -0.0
text 571134 570898 -236 -0.0
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section e57476d 88229ba change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692263 691863 -400 -0.1
(read/write) 159592 159992 400 0.3
.bss 74748 74748 0 0.0
.data 3408 3408 0 0.0
.rodata 112719 112695 -24 -0.0
.text 579232 578856 -376 -0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 642887 642487 -400 -0.1
(read/write) 158228 158228 0 0.0
.bss 73964 73964 0 0.0
.data 3348 3348 0 0.0
.rodata 89759 89735 -24 -0.0
.text 552808 552432 -376 -0.1
lock-ftd LP_CC2652R7 (read only) 685783 685375 -408 -0.1
(read/write) 157136 157544 408 0.3
.bss 72700 72700 0 0.0
.data 3272 3272 0 0.0
.rodata 98583 98559 -24 -0.0
.text 586716 586332 -384 -0.1
lock-mtd LP_CC2652R7 (read only) 635199 634783 -416 -0.1
(read/write) 145824 145824 0 0.0
.bss 68436 68436 0 0.0
.data 3272 3272 0 0.0
.rodata 98471 98447 -24 -0.0
.text 536236 535844 -392 -0.1
pump-app LP_CC2652R7 (read only) 666923 666499 -424 -0.1
(read/write) 176900 177324 424 0.2
.bss 72836 72836 0 0.0
.data 3304 3304 0 0.0
.rodata 86819 86787 -32 -0.0
.text 579620 579228 -392 -0.1
pump-controller-app LP_CC2652R7 (read only) 658075 657667 -408 -0.1
(read/write) 185860 186268 408 0.2
.bss 72948 72948 0 0.0
.data 3268 3268 0 0.0
.rodata 84867 84843 -24 -0.0
.text 572724 572340 -384 -0.1
shell LP_CC2652R7 (read only) 684542 684150 -392 -0.1
(read/write) 162808 163200 392 0.2
.bss 77044 77044 0 0.0
.data 3412 3412 0 0.0
.rodata 109318 109294 -24 -0.0
.text 574912 574544 -368 -0.1
cyw30739 light cyw930739m2evb_01 (read/write) 604202 604202 0 0.0
.app_xip_area 463132 463132 0 0.0
.bss 84008 84008 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 601254 601262 8 0.0
.app_xip_area 460048 460056 8 0.0
.bss 84176 84176 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599462 599470 8 0.0
.app_xip_area 459380 459388 8 0.0
.bss 83140 83140 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919272 919032 -240 -0.0
(read/write) 133280 133280 0 0.0
.bss 131176 131176 0 0.0
.data 2104 2104 0 0.0
.text 919264 919024 -240 -0.0
BRD4161A+rpc (read only) 953500 953260 -240 -0.0
(read/write) 149972 149972 0 0.0
.bss 147664 147664 0 0.0
.data 2308 2308 0 0.0
.text 953492 953252 -240 -0.0
BRD4161A+rs911x (read only) 794548 794196 -352 -0.0
(read/write) 129556 129556 0 0.0
.bss 127444 127444 0 0.0
.data 2112 2112 0 0.0
.text 794540 794188 -352 -0.0
lock-app BRD4161A+wf200 (read only) 960964 960676 -288 -0.0
(read/write) 128348 128348 0 0.0
.bss 126268 126268 0 0.0
.data 2080 2080 0 0.0
.text 960956 960668 -288 -0.0
window-app BRD4161A (read only) 904320 904080 -240 -0.0
(read/write) 133368 133368 0 0.0
.bss 131264 131264 0 0.0
.data 2100 2100 0 0.0
.text 904312 904072 -240 -0.0
k32w light k32w061+release (read/write) 655736 655544 -192 -0.0
.bss 70052 70052 0 0.0
.data 2020 2020 0 0.0
.text 577864 577672 -192 -0.0
lock k32w061+release (read/write) 717284 717060 -224 -0.0
.bss 70492 70492 0 0.0
.data 1992 1992 0 0.0
.text 639000 638776 -224 -0.0
linux all-clusters-app debug (read only) 2894321 2893297 -1024 -0.0
(read/write) 180312 180312 0 0.0
.bss 87872 87872 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 84184 84184 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 255485 255357 -128 -0.1
.text 2463794 2462898 -896 -0.0
all-clusters-minimal-app debug (read only) 2770025 2769017 -1008 -0.0
(read/write) 172152 172152 0 0.0
.bss 87040 87040 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76984 76984 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 257277 257149 -128 -0.0
.text 2338882 2338002 -880 -0.0
bridge-app debug+rpc (read only) 2212353 2211345 -1008 -0.0
(read/write) 150008 150008 0 0.0
.bss 74528 74528 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65800 65800 0 0.0
.dynamic 608 608 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 188192 188064 -128 -0.1
.text 1864178 1863298 -880 -0.0
chip-tool debug (read only) 9739045 9738757 -288 -0.0
(read/write) 608128 608128 0 0.0
.bss 25440 25440 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 575240 575240 0 0.0
.dynamic 624 624 0 0.0
.got 5016 5016 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 505565 505533 -32 -0.0
.text 7831269 7831013 -256 -0.0
lighting-app debug+rpc (read only) 2498513 2497505 -1008 -0.0
(read/write) 155648 155648 0 0.0
.bss 76352 76352 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 71304 71304 0 0.0
.dynamic 608 608 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 205928 205800 -128 -0.1
.text 2123650 2122770 -880 -0.0
lock-app debug (read only) 2444409 2443385 -1024 -0.0
(read/write) 150784 150784 0 0.0
.bss 75072 75072 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 68248 68248 0 0.0
.dynamic 608 608 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 219944 219816 -128 -0.1
.text 2060514 2059618 -896 -0.0
ota-provider-app debug (read only) 2208465 2207441 -1024 -0.0
(read/write) 143360 143360 0 0.0
.bss 74528 74528 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61208 61208 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 192408 192280 -128 -0.1
.text 1855890 1854994 -896 -0.0
ota-requestor-app debug (read only) 2269273 2268265 -1008 -0.0
(read/write) 146408 146408 0 0.0
.bss 75296 75296 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63320 63320 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 195744 195616 -128 -0.1
.text 1909506 1908626 -880 -0.0
shell debug (read only) 2598777 2597769 -1008 -0.0
(read/write) 203680 203680 0 0.0
.bss 118760 118760 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77776 77776 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 228178 228050 -128 -0.1
.text 2210914 2210034 -880 -0.0
tv-app debug (read only) 3044489 3043481 -1008 -0.0
(read/write) 282384 282384 0 0.0
.bss 192648 192648 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 78568 78568 0 0.0
.dynamic 608 608 0 0.0
.got 4864 4864 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 240992 240864 -128 -0.1
.text 2617362 2616482 -880 -0.0
tv-casting-app debug (read only) 5348353 5347345 -1008 -0.0
(read/write) 224448 224448 0 0.0
.bss 80168 80168 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 135584 135584 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 340832 340704 -128 -0.0
.text 4655970 4655090 -880 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2432080 2431776 -304 -0.0
.bss 202716 202716 0 0.0
.data 5888 5888 0 0.0
.text 1394724 1394420 -304 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1194419 1194211 -208 -0.0
bss 141385 141385 0 0.0
rodata 155260 155228 -32 -0.0
text 818856 818692 -164 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1142131 1141923 -208 -0.0
bss 140602 140602 0 0.0
rodata 131756 131724 -32 -0.0
text 790908 790740 -168 -0.0
p6 all-clusters-app default (read/write) 2548904 2548520 -384 -0.0
.bss 137208 137208 0 0.0
.data 2816 2816 0 0.0
.text 1507168 1506784 -384 -0.0
all-clusters-minimal-app default (read/write) 2493760 2493392 -368 -0.0
.bss 136424 136424 0 0.0
.data 2760 2760 0 0.0
.text 1452024 1451656 -368 -0.0
light-app default (read/write) 2425664 2425296 -368 -0.0
.bss 129520 129520 0 0.0
.data 2608 2608 0 0.0
.text 1383928 1383560 -368 -0.0
lock-app default (read/write) 2445968 2445616 -352 -0.0
.bss 129344 129344 0 0.0
.data 2584 2584 0 0.0
.text 1404232 1403880 -352 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 784172 783900 -272 -0.0
bss 70652 70652 0 0.0
noinit 40416 40416 0 0.0
text 554392 554152 -240 -0.0
lighting-app tlsr9518adk80d (read/write) 804216 803952 -264 -0.0
bss 70912 70912 0 0.0
noinit 40416 40416 0 0.0
text 571134 570898 -236 -0.0

@yunhanw-google yunhanw-google force-pushed the feature/remove_event_management_lock branch from 88229ba to 8e22a4c Compare June 7, 2022 20:37
@github-actions
Copy link

github-actions bot commented Jun 7, 2022 •
edited
Loading

PR #19285: Size comparison from c868f81 to 8e22a4c

Increases (6 builds for cc13x2_26x2, cyw30739)
platform target config section c868f81 8e22a4c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161520 161872 352 0.2
lock-ftd LP_CC2652R7 (read/write) 159072 159424 352 0.2
pump-app LP_CC2652R7 (read/write) 178532 178892 360 0.2
pump-controller-app LP_CC2652R7 (read/write) 188060 188412 352 0.2
shell LP_CC2652R7 (read/write) 164736 165088 352 0.2
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599398 599406 8 0.0
.app_xip_area 459324 459332 8 0.0
Decreases (33 builds for cc13x2_26x2, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c868f81 8e22a4c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690335 689895 -440 -0.1
.bss 74748 74660 -88 -0.1
.rodata 112311 112279 -32 -0.0
.text 577712 577304 -408 -0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 640951 640511 -440 -0.1
(read/write) 158220 158132 -88 -0.1
.bss 73972 73884 -88 -0.1
.rodata 89351 89319 -32 -0.0
.text 551280 550872 -408 -0.1
lock-ftd LP_CC2652R7 (read only) 683847 683407 -440 -0.1
.bss 72700 72612 -88 -0.1
.rodata 98167 98143 -24 -0.0
.text 585196 584780 -416 -0.1
lock-mtd LP_CC2652R7 (read only) 633263 632823 -440 -0.1
(read/write) 145808 145720 -88 -0.1
.bss 68436 68348 -88 -0.1
.rodata 98055 98031 -24 -0.0
.text 534716 534300 -416 -0.1
pump-app LP_CC2652R7 (read only) 665299 664851 -448 -0.1
.bss 72844 72756 -88 -0.1
.rodata 86347 86315 -32 -0.0
.text 578468 578052 -416 -0.1
pump-controller-app LP_CC2652R7 (read only) 655875 655435 -440 -0.1
.bss 72948 72860 -88 -0.1
.rodata 84235 84211 -24 -0.0
.text 571156 570740 -416 -0.1
shell LP_CC2652R7 (read only) 682614 682174 -440 -0.1
.bss 77044 76956 -88 -0.1
.rodata 108910 108878 -32 -0.0
.text 573392 572984 -408 -0.1
esp32 all-clusters-app c3devkit (read only) 1008102 1007746 -356 -0.0
(read/write) 1481914 1481786 -128 -0.0
.dram0.bss 69256 69168 -88 -0.1
.flash.rodata 212568 212536 -32 -0.0
.flash.text 1008102 1007746 -356 -0.0
.iram0.text 62954 62902 -52 -0.1
m5stack (read only) 1062899 1062527 -372 -0.0
(read/write) 484048 483928 -120 -0.0
.dram0.bss 74776 74688 -88 -0.1
.flash.rodata 243076 243044 -32 -0.0
.flash.text 1057515 1057143 -372 -0.0
k32w light k32w061+release (read/write) 653976 653760 -216 -0.0
.bss 70052 70044 -8 -0.0
.text 576120 575912 -208 -0.0
lock k32w061+release (read/write) 715068 714820 -248 -0.0
.bss 70492 70484 -8 -0.0
.text 636800 636560 -240 -0.0
linux all-clusters-app debug (read only) 2893417 2892297 -1120 -0.0
(read/write) 180056 180024 -32 -0.0
.bss 87872 87840 -32 -0.0
.rodata 255549 255421 -128 -0.1
.text 2463346 2462354 -992 -0.0
all-clusters-minimal-app debug (read only) 2754929 2753809 -1120 -0.0
(read/write) 171672 171640 -32 -0.0
.bss 87040 87008 -32 -0.0
.rodata 256861 256733 -128 -0.0
.text 2325554 2324562 -992 -0.0
bridge-app debug+rpc (read only) 2198961 2197825 -1136 -0.1
(read/write) 149560 149528 -32 -0.0
.bss 74528 74496 -32 -0.0
.rodata 187904 187776 -128 -0.1
.text 1852146 1851138 -1008 -0.1
chip-tool debug (read only) 9737285 9736869 -416 -0.0
(read/write) 608064 608032 -32 -0.0
.bss 25440 25408 -32 -0.1
.rodata 505405 505373 -32 -0.0
.text 7829877 7829493 -384 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9474988 9474604 -384 -0.0
(read/write) 674321 674257 -64 -0.0
.bss 43729 43681 -48 -0.1
.got 14936 14928 -8 -0.1
.text 7470420 7470052 -368 -0.0
lighting-app debug+rpc (read only) 2483377 2482257 -1120 -0.0
(read/write) 155168 155136 -32 -0.0
.bss 76352 76320 -32 -0.0
.rodata 205480 205352 -128 -0.1
.text 2110306 2109314 -992 -0.0
lock-app debug (read only) 2429329 2428193 -1136 -0.0
(read/write) 150304 150272 -32 -0.0
.bss 75072 75040 -32 -0.0
.rodata 219496 219368 -128 -0.1
.text 2047234 2046226 -1008 -0.0
ota-provider-app debug (read only) 2204761 2203625 -1136 -0.1
(read/write) 143296 143264 -32 -0.0
.bss 74528 74496 -32 -0.0
.rodata 192024 191896 -128 -0.1
.text 1853058 1852050 -1008 -0.1
ota-requestor-app debug (read only) 2266409 2265289 -1120 -0.0
(read/write) 146344 146312 -32 -0.0
.bss 75296 75264 -32 -0.0
.rodata 195392 195264 -128 -0.1
.text 1907282 1906290 -992 -0.1
shell debug (read only) 2585089 2583953 -1136 -0.0
(read/write) 203232 203200 -32 -0.0
.bss 118760 118728 -32 -0.0
.rodata 228146 228018 -128 -0.1
.text 2198322 2197314 -1008 -0.0
thermostat-no-ble arm64 (read only) 2544956 2543900 -1056 -0.0
(read/write) 183153 183073 -80 -0.0
.bss 91457 91409 -48 -0.1
.data.rel.ro 82168 82144 -24 -0.0
.got 5000 4992 -8 -0.2
.rodata 160196 160084 -112 -0.1
.text 2147776 2146880 -896 -0.0
tv-app debug (read only) 3031449 3030313 -1136 -0.0
(read/write) 281936 281904 -32 -0.0
.bss 192648 192616 -32 -0.0
.rodata 240736 240608 -128 -0.1
.text 2605650 2604642 -1008 -0.0
tv-casting-app debug (read only) 5335041 5333921 -1120 -0.0
(read/write) 224000 223968 -32 -0.0
.bss 80168 80136 -32 -0.0
.rodata 340576 340448 -128 -0.0
.text 4643986 4642994 -992 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2429848 2429544 -304 -0.0
.bss 202724 202692 -32 -0.0
.text 1392492 1392188 -304 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192179 1191959 -220 -0.0
bss 141378 141362 -16 -0.0
rodata 154628 154600 -28 -0.0
text 817260 817076 -184 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139891 1139683 -208 -0.0
bss 140595 140579 -16 -0.0
rodata 131124 131092 -32 -0.0
text 789312 789128 -184 -0.0
p6 all-clusters-app default (read/write) 2544928 2544512 -416 -0.0
.bss 137208 137120 -88 -0.1
.text 1503192 1502776 -416 -0.0
all-clusters-minimal-app default (read/write) 2489792 2489376 -416 -0.0
.bss 136416 136328 -88 -0.1
.text 1448056 1447640 -416 -0.0
light-app default (read/write) 2421704 2421304 -400 -0.0
.bss 129520 129432 -88 -0.1
.text 1379968 1379568 -400 -0.0
lock-app default (read/write) 2442040 2441640 -400 -0.0
.bss 129344 129256 -88 -0.1
.text 1400304 1399904 -400 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 781940 781628 -312 -0.0
bss 70652 70636 -16 -0.0
text 552810 552550 -260 -0.0
lighting-app tlsr9518adk80d (read/write) 801952 801640 -312 -0.0
bss 70904 70888 -16 -0.0
text 569530 569270 -260 -0.0
Full report (36 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c868f81 8e22a4c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690335 689895 -440 -0.1
(read/write) 161520 161872 352 0.2
.bss 74748 74660 -88 -0.1
.data 3392 3392 0 0.0
.rodata 112311 112279 -32 -0.0
.text 577712 577304 -408 -0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 640951 640511 -440 -0.1
(read/write) 158220 158132 -88 -0.1
.bss 73972 73884 -88 -0.1
.data 3332 3332 0 0.0
.rodata 89351 89319 -32 -0.0
.text 551280 550872 -408 -0.1
lock-ftd LP_CC2652R7 (read only) 683847 683407 -440 -0.1
(read/write) 159072 159424 352 0.2
.bss 72700 72612 -88 -0.1
.data 3256 3256 0 0.0
.rodata 98167 98143 -24 -0.0
.text 585196 584780 -416 -0.1
lock-mtd LP_CC2652R7 (read only) 633263 632823 -440 -0.1
(read/write) 145808 145720 -88 -0.1
.bss 68436 68348 -88 -0.1
.data 3256 3256 0 0.0
.rodata 98055 98031 -24 -0.0
.text 534716 534300 -416 -0.1
pump-app LP_CC2652R7 (read only) 665299 664851 -448 -0.1
(read/write) 178532 178892 360 0.2
.bss 72844 72756 -88 -0.1
.data 3292 3292 0 0.0
.rodata 86347 86315 -32 -0.0
.text 578468 578052 -416 -0.1
pump-controller-app LP_CC2652R7 (read only) 655875 655435 -440 -0.1
(read/write) 188060 188412 352 0.2
.bss 72948 72860 -88 -0.1
.data 3252 3252 0 0.0
.rodata 84235 84211 -24 -0.0
.text 571156 570740 -416 -0.1
shell LP_CC2652R7 (read only) 682614 682174 -440 -0.1
(read/write) 164736 165088 352 0.2
.bss 77044 76956 -88 -0.1
.data 3396 3396 0 0.0
.rodata 108910 108878 -32 -0.0
.text 573392 572984 -408 -0.1
cyw30739 light cyw930739m2evb_01 (read/write) 602578 602578 0 0.0
.app_xip_area 461524 461524 0 0.0
.bss 84008 84008 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599662 599662 0 0.0
.app_xip_area 458472 458472 0 0.0
.bss 84176 84176 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599398 599406 8 0.0
.app_xip_area 459324 459332 8 0.0
.bss 83140 83140 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1008102 1007746 -356 -0.0
(read/write) 1481914 1481786 -128 -0.0
.dram0.bss 69256 69168 -88 -0.1
.dram0.data 14656 14656 0 0.0
.flash.rodata 212568 212536 -32 -0.0
.flash.text 1008102 1007746 -356 -0.0
.iram0.text 62954 62902 -52 -0.1
m5stack (read only) 1062899 1062527 -372 -0.0
(read/write) 484048 483928 -120 -0.0
.dram0.bss 74776 74688 -88 -0.1
.dram0.data 34200 34200 0 0.0
.flash.rodata 243076 243044 -32 -0.0
.flash.text 1057515 1057143 -372 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 653976 653760 -216 -0.0
.bss 70052 70044 -8 -0.0
.data 2004 2004 0 0.0
.text 576120 575912 -208 -0.0
lock k32w061+release (read/write) 715068 714820 -248 -0.0
.bss 70492 70484 -8 -0.0
.data 1976 1976 0 0.0
.text 636800 636560 -240 -0.0
linux all-clusters-app debug (read only) 2893417 2892297 -1120 -0.0
(read/write) 180056 180024 -32 -0.0
.bss 87872 87840 -32 -0.0
.data 2016 2016 0 0.0
.data.rel.ro 83960 83960 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 255549 255421 -128 -0.1
.text 2463346 2462354 -992 -0.0
all-clusters-minimal-app debug (read only) 2754929 2753809 -1120 -0.0
(read/write) 171672 171640 -32 -0.0
.bss 87040 87008 -32 -0.0
.data 1888 1888 0 0.0
.data.rel.ro 76584 76584 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 256861 256733 -128 -0.0
.text 2325554 2324562 -992 -0.0
bridge-app debug+rpc (read only) 2198961 2197825 -1136 -0.1
(read/write) 149560 149528 -32 -0.0
.bss 74528 74496 -32 -0.0
.data 3888 3888 0 0.0
.data.rel.ro 65400 65400 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 187904 187776 -128 -0.1
.text 1852146 1851138 -1008 -0.1
chip-tool debug (read only) 9737285 9736869 -416 -0.0
(read/write) 608064 608032 -32 -0.0
.bss 25440 25408 -32 -0.1
.data 1088 1088 0 0.0
.data.rel.ro 575240 575240 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 505405 505373 -32 -0.0
.text 7829877 7829493 -384 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9474988 9474604 -384 -0.0
(read/write) 674321 674257 -64 -0.0
.bss 43729 43681 -48 -0.1
.data 1152 1152 0 0.0
.data.rel.ro 610696 610696 0 0.0
.dynamic 528 528 0 0.0
.got 14936 14928 -8 -0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467548 467548 0 0.0
.text 7470420 7470052 -368 -0.0
lighting-app debug+rpc (read only) 2483377 2482257 -1120 -0.0
(read/write) 155168 155136 -32 -0.0
.bss 76352 76320 -32 -0.0
.data 2032 2032 0 0.0
.data.rel.ro 70888 70888 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 205480 205352 -128 -0.1
.text 2110306 2109314 -992 -0.0
lock-app debug (read only) 2429329 2428193 -1136 -0.0
(read/write) 150304 150272 -32 -0.0
.bss 75072 75040 -32 -0.0
.data 1520 1520 0 0.0
.data.rel.ro 67848 67848 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 219496 219368 -128 -0.1
.text 2047234 2046226 -1008 -0.0
ota-provider-app debug (read only) 2204761 2203625 -1136 -0.1
(read/write) 143296 143264 -32 -0.0
.bss 74528 74496 -32 -0.0
.data 1752 1752 0 0.0
.data.rel.ro 61208 61208 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 192024 191896 -128 -0.1
.text 1853058 1852050 -1008 -0.1
ota-requestor-app debug (read only) 2266409 2265289 -1120 -0.0
(read/write) 146344 146312 -32 -0.0
.bss 75296 75264 -32 -0.0
.data 1944 1944 0 0.0
.data.rel.ro 63320 63320 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 195392 195264 -128 -0.1
.text 1907282 1906290 -992 -0.1
shell debug (read only) 2585089 2583953 -1136 -0.0
(read/write) 203232 203200 -32 -0.0
.bss 118760 118728 -32 -0.0
.data 1328 1328 0 0.0
.data.rel.ro 77392 77392 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 228146 228018 -128 -0.1
.text 2198322 2197314 -1008 -0.0
thermostat-no-ble arm64 (read only) 2544956 2543900 -1056 -0.0
(read/write) 183153 183073 -80 -0.0
.bss 91457 91409 -48 -0.1
.data 1512 1512 0 0.0
.data.rel.ro 82168 82144 -24 -0.0
.dynamic 528 528 0 0.0
.got 5000 4992 -8 -0.2
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 160196 160084 -112 -0.1
.text 2147776 2146880 -896 -0.0
tv-app debug (read only) 3031449 3030313 -1136 -0.0
(read/write) 281936 281904 -32 -0.0
.bss 192648 192616 -32 -0.0
.data 4656 4656 0 0.0
.data.rel.ro 78184 78184 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 240736 240608 -128 -0.1
.text 2605650 2604642 -1008 -0.0
tv-casting-app debug (read only) 5335041 5333921 -1120 -0.0
(read/write) 224000 223968 -32 -0.0
.bss 80168 80136 -32 -0.0
.data 2416 2416 0 0.0
.data.rel.ro 135168 135168 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 340576 340448 -128 -0.0
.text 4643986 4642994 -992 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2429848 2429544 -304 -0.0
.bss 202724 202692 -32 -0.0
.data 5872 5872 0 0.0
.text 1392492 1392188 -304 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192179 1191959 -220 -0.0
bss 141378 141362 -16 -0.0
rodata 154628 154600 -28 -0.0
text 817260 817076 -184 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139891 1139683 -208 -0.0
bss 140595 140579 -16 -0.0
rodata 131124 131092 -32 -0.0
text 789312 789128 -184 -0.0
p6 all-clusters-app default (read/write) 2544928 2544512 -416 -0.0
.bss 137208 137120 -88 -0.1
.data 2808 2808 0 0.0
.text 1503192 1502776 -416 -0.0
all-clusters-minimal-app default (read/write) 2489792 2489376 -416 -0.0
.bss 136416 136328 -88 -0.1
.data 2752 2752 0 0.0
.text 1448056 1447640 -416 -0.0
light-app default (read/write) 2421704 2421304 -400 -0.0
.bss 129520 129432 -88 -0.1
.data 2600 2600 0 0.0
.text 1379968 1379568 -400 -0.0
lock-app default (read/write) 2442040 2441640 -400 -0.0
.bss 129344 129256 -88 -0.1
.data 2576 2576 0 0.0
.text 1400304 1399904 -400 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 781940 781628 -312 -0.0
bss 70652 70636 -16 -0.0
noinit 40416 40416 0 0.0
text 552810 552550 -260 -0.0
lighting-app tlsr9518adk80d (read/write) 801952 801640 -312 -0.0
bss 70904 70888 -16 -0.0
noinit 40416 40416 0 0.0
text 569530 569270 -260 -0.0

mrjerryjohns
mrjerryjohns reviewed Jun 7, 2022
View reviewed changes
Copy link
Contributor

@mrjerryjohns mrjerryjohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think cc13x2x7_26x2x7's main.cpp contains a call to LogEvent that seems to emanate from a thread other than the CHIP task.

Might want to file an issue on that.

@yunhanw-google yunhanw-google mentioned this pull request Jun 8, 2022
Closed
@yunhanw-google yunhanw-google merged commit b8e9ab1 into project-chip:master Jun 8, 2022
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jun 10, 2022
@yunhanw-google @mkardous-silabs
remove lock in event management (project-chip#19285)
04f9fd0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yunhanw-google @msandstedt @mrjerryjohns @bzbarsky-apple