Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chip-tool] Stop the command on pairing failure #19267

Merged

Conversation

vivien-apple
Copy link
Contributor

Problem

Looking at #19138 I found that chip-tool does not ends the command on pairing failure. That's not the cause of the issue in #19138 but that is still a problem.

Change overview

  • Call SetCommandExitStatus

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

PR #19267: Size comparison from 55ab764 to de68ca2

Increases (1 build for linux)
platform target config section 55ab764 de68ca2 change % change
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9409764 9409812 48 0.0
.text 7412116 7412164 48 0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 55ab764 de68ca2 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689547 689547 0 0.0
(read/write) 162220 162220 0 0.0
.bss 74660 74660 0 0.0
.data 3404 3404 0 0.0
.rodata 111787 111787 0 0.0
.text 577444 577444 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640171 640171 0 0.0
(read/write) 158136 158136 0 0.0
.bss 73876 73876 0 0.0
.data 3344 3344 0 0.0
.rodata 88827 88827 0 0.0
.text 551020 551020 0 0.0
lock-ftd LP_CC2652R7 (read only) 683027 683027 0 0.0
(read/write) 159804 159804 0 0.0
.bss 72612 72612 0 0.0
.data 3268 3268 0 0.0
.rodata 97651 97651 0 0.0
.text 584896 584896 0 0.0
lock-mtd LP_CC2652R7 (read only) 632435 632435 0 0.0
(read/write) 145732 145732 0 0.0
.bss 68348 68348 0 0.0
.data 3268 3268 0 0.0
.rodata 97531 97531 0 0.0
.text 534416 534416 0 0.0
pump-app LP_CC2652R7 (read only) 664099 664099 0 0.0
(read/write) 179636 179636 0 0.0
.bss 72748 72748 0 0.0
.data 3300 3300 0 0.0
.rodata 85851 85851 0 0.0
.text 577768 577768 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655259 655259 0 0.0
(read/write) 188588 188588 0 0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83899 83899 0 0.0
.text 570880 570880 0 0.0
shell LP_CC2652R7 (read only) 681842 681842 0 0.0
(read/write) 165420 165420 0 0.0
.bss 76956 76956 0 0.0
.data 3408 3408 0 0.0
.rodata 108394 108394 0 0.0
.text 573132 573132 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602242 602242 0 0.0
.app_xip_area 461268 461268 0 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599294 599294 0 0.0
.app_xip_area 458184 458184 0 0.0
.bss 84080 84080 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596910 596910 0 0.0
.app_xip_area 456932 456932 0 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916152 916152 0 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 916144 916144 0 0.0
BRD4161A+rpc (read only) 950380 950380 0 0.0
(read/write) 149876 149876 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 950372 950372 0 0.0
BRD4161A+rs911x (read only) 791364 791364 0 0.0
(read/write) 129460 129460 0 0.0
.bss 127356 127356 0 0.0
.data 2104 2104 0 0.0
.text 791356 791356 0 0.0
lock-app BRD4161A+wf200 (read only) 958152 958152 0 0.0
(read/write) 128252 128252 0 0.0
.bss 126180 126180 0 0.0
.data 2072 2072 0 0.0
.text 958144 958144 0 0.0
window-app BRD4161A (read only) 901208 901208 0 0.0
(read/write) 133272 133272 0 0.0
.bss 131176 131176 0 0.0
.data 2092 2092 0 0.0
.text 901200 901200 0 0.0
esp32 all-clusters-app c3devkit (read only) 1007798 1007798 0 0.0
(read/write) 1481490 1481490 0 0.0
.dram0.bss 69168 69168 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212240 212240 0 0.0
.flash.text 1007798 1007798 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1062743 1062743 0 0.0
(read/write) 483660 483660 0 0.0
.dram0.bss 74680 74680 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 242776 242776 0 0.0
.flash.text 1057359 1057359 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 653400 653400 0 0.0
.bss 69964 69964 0 0.0
.data 2012 2012 0 0.0
.text 575624 575624 0 0.0
lock k32w061+release (read/write) 714380 714380 0 0.0
.bss 70404 70404 0 0.0
.data 1984 1984 0 0.0
.text 636192 636192 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9409764 9409812 48 0.0
(read/write) 672401 672401 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 610256 610256 0 0.0
.dynamic 528 528 0 0.0
.got 14896 14896 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 461172 461172 0 0.0
.text 7412116 7412164 48 0.0
thermostat-no-ble arm64 (read only) 2368932 2368932 0 0.0
(read/write) 177521 177521 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80272 80272 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148804 148804 0 0.0
.text 1990432 1990432 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2427240 2427240 0 0.0
.bss 202628 202628 0 0.0
.data 5880 5880 0 0.0
.text 1389884 1389884 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1191507 1191507 0 0.0
bss 141297 141297 0 0.0
rodata 154236 154236 0 0.0
text 817100 817100 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139227 1139227 0 0.0
bss 140514 140514 0 0.0
rodata 130748 130748 0 0.0
text 789152 789152 0 0.0
p6 all-clusters-app default (read/write) 2545728 2545728 0 0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1503992 1503992 0 0.0
all-clusters-minimal-app default (read/write) 2490592 2490592 0 0.0
.bss 136336 136336 0 0.0
.data 2752 2752 0 0.0
.text 1448856 1448856 0 0.0
light-app default (read/write) 2422488 2422488 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1380752 1380752 0 0.0
lock-app default (read/write) 2442808 2442808 0 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1401072 1401072 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781016 781016 0 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 552406 552406 0 0.0
lighting-app tlsr9518adk80d (read/write) 801052 801052 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 569148 569148 0 0.0

@andy31415 andy31415 merged commit baf4ae1 into project-chip:master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants