Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address cert test case issues #19254

Merged
merged 6 commits into from
Jun 7, 2022
Merged

Address cert test case issues #19254

merged 6 commits into from
Jun 7, 2022

Conversation

chrisdecenzo
Copy link
Contributor

Problem

Change overview

Add playback state, speed and position tracking to media playback cluster

Testing

  • Tested tv-app linux and android using chip-tool

@restyled-io restyled-io bot mentioned this pull request Jun 6, 2022
Merged
@github-actions
Copy link

github-actions bot commented Jun 7, 2022 •
edited
Loading

PR #19254: Size comparison from dd636ad to ac5daa4

Full report (8 builds for cyw30739, linux, mbed, nrfconnect)
platform target config section dd636ad ac5daa4 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602242 602242 0 0.0
.app_xip_area 461268 461268 0 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599294 599294 0 0.0
.app_xip_area 458184 458184 0 0.0
.bss 84080 84080 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596910 596910 0 0.0
.app_xip_area 456932 456932 0 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9409764 9409764 0 0.0
(read/write) 672401 672401 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 610256 610256 0 0.0
.dynamic 528 528 0 0.0
.got 14896 14896 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 461172 461172 0 0.0
.text 7412116 7412116 0 0.0
thermostat-no-ble arm64 (read only) 2368932 2368932 0 0.0
(read/write) 177521 177521 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80272 80272 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148804 148804 0 0.0
.text 1990432 1990432 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2427240 2427240 0 0.0
.bss 202628 202628 0 0.0
.data 5880 5880 0 0.0
.text 1389884 1389884 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1191507 1191507 0 0.0
bss 141297 141297 0 0.0
rodata 154236 154236 0 0.0
text 817100 817100 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139227 1139227 0 0.0
bss 140514 140514 0 0.0
rodata 130748 130748 0 0.0
text 789152 789152 0 0.0

chrisdecenzo and others added 2 commits June 6, 2022 17:30
@chrisdecenzo
fix CI
2907ffd
@restyled-io @restyled-commits
Restyle Address cert test case issues (#19255)
714293c 
* Restyled by whitespace

* Restyled by google-java-format

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
@github-actions
Copy link

github-actions bot commented Jun 7, 2022 •
edited
Loading

PR #19254: Size comparison from dd636ad to 714293c

Full report (12 builds for cyw30739, esp32, mbed, nrfconnect, p6)
platform target config section dd636ad 714293c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602242 602242 0 0.0
.app_xip_area 461268 461268 0 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599294 599294 0 0.0
.app_xip_area 458184 458184 0 0.0
.bss 84080 84080 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596910 596910 0 0.0
.app_xip_area 456932 456932 0 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1007798 1007798 0 0.0
(read/write) 1481490 1481490 0 0.0
.dram0.bss 69168 69168 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212240 212240 0 0.0
.flash.text 1007798 1007798 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1062743 1062743 0 0.0
(read/write) 483660 483660 0 0.0
.dram0.bss 74680 74680 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 242776 242776 0 0.0
.flash.text 1057359 1057359 0 0.0
.iram0.text 123267 123267 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2427240 2427240 0 0.0
.bss 202628 202628 0 0.0
.data 5880 5880 0 0.0
.text 1389884 1389884 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1191507 1191507 0 0.0
bss 141297 141297 0 0.0
rodata 154236 154236 0 0.0
text 817100 817100 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139227 1139227 0 0.0
bss 140514 140514 0 0.0
rodata 130748 130748 0 0.0
text 789152 789152 0 0.0
p6 all-clusters-app default (read/write) 2545728 2545728 0 0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1503992 1503992 0 0.0
all-clusters-minimal-app default (read/write) 2490592 2490592 0 0.0
.bss 136336 136336 0 0.0
.data 2752 2752 0 0.0
.text 1448856 1448856 0 0.0
light-app default (read/write) 2422488 2422488 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1380752 1380752 0 0.0
lock-app default (read/write) 2442808 2442808 0 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1401072 1401072 0 0.0

@chrisdecenzo chrisdecenzo merged commit a005156 into master Jun 7, 2022
@chrisdecenzo chrisdecenzo deleted the tv-apps-android10 branch June 7, 2022 19:42
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jun 10, 2022
@chrisdecenzo @restyled-io
@restyled-commits @mkardous-silabs
Address cert test case issues (project-chip#19254)
5363a55 
* Address cert test case issues

* fix CI

* Restyle Address cert test case issues (project-chip#19255)

* Restyled by whitespace

* Restyled by google-java-format

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>

* fix CI test cases

* fix CI test cases

Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com>
Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@hawk248 hawk248 Awaiting requested review from hawk248

@lazarkov lazarkov Awaiting requested review from lazarkov

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisdecenzo @lazarkov @hawk248