Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EFR32] Fix QR code define #19067

Merged
merged 1 commit into from
Jun 2, 2022
Merged

[EFR32] Fix QR code define #19067

merged 1 commit into from
Jun 2, 2022

Conversation

mkardous-silabs
Copy link
Contributor

Problem

Change overview

  • Changes display enabled define to Qr code enable define

Testing

  • Manual tests with efr32 mg24 building with QR code and without

@github-actions
Copy link

github-actions bot commented Jun 1, 2022 •
edited
Loading

PR #19067: Size comparison from 76089ee to 8b09e29

Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 76089ee 8b09e29 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648547 648547 0 0.0
(read/write) 158900 158900 0 0.0
.bss 74580 74580 0 0.0
.data 3404 3404 0 0.0
.rodata 84531 84531 0 0.0
.text 563780 563780 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615379 615379 0 0.0
(read/write) 158072 158072 0 0.0
.bss 73812 73812 0 0.0
.data 3344 3344 0 0.0
.rodata 73915 73915 0 0.0
.text 541228 541228 0 0.0
lock-ftd LP_CC2652R7 (read only) 680211 680211 0 0.0
(read/write) 162612 162612 0 0.0
.bss 72604 72604 0 0.0
.data 3268 3268 0 0.0
.rodata 96603 96603 0 0.0
.text 583124 583124 0 0.0
lock-mtd LP_CC2652R7 (read only) 629619 629619 0 0.0
(read/write) 145724 145724 0 0.0
.bss 68340 68340 0 0.0
.data 3268 3268 0 0.0
.rodata 96483 96483 0 0.0
.text 532644 532644 0 0.0
pump-app LP_CC2652R7 (read only) 676635 676635 0 0.0
(read/write) 167356 167356 0 0.0
.bss 73004 73004 0 0.0
.data 3304 3304 0 0.0
.rodata 89083 89083 0 0.0
.text 587068 587068 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654563 654563 0 0.0
(read/write) 189284 189284 0 0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83811 83811 0 0.0
.text 570272 570272 0 0.0
shell LP_CC2652R7 (read only) 641578 641578 0 0.0
(read/write) 154456 154456 0 0.0
.bss 76932 76932 0 0.0
.data 3408 3408 0 0.0
.rodata 81522 81522 0 0.0
.text 559824 559824 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 622330 622330 0 0.0
.app_xip_area 525908 525908 0 0.0
.bss 79064 79064 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 631034 631034 0 0.0
.app_xip_area 536084 536084 0 0.0
.bss 77624 77624 0 0.0
.data 676 676 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571146 571146 0 0.0
.app_xip_area 466268 466268 0 0.0
.bss 87224 87224 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915072 915072 0 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 915064 915064 0 0.0
BRD4161A+rpc (read only) 949300 949300 0 0.0
(read/write) 149876 149876 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 949292 949292 0 0.0
BRD4161A+rs911x (read only) 787204 787204 0 0.0
(read/write) 129404 129404 0 0.0
.bss 127308 127308 0 0.0
.data 2096 2096 0 0.0
.text 787196 787196 0 0.0
lock-app BRD4161A+wf200 (read only) 954896 954896 0 0.0
(read/write) 128244 128244 0 0.0
.bss 126172 126172 0 0.0
.data 2068 2068 0 0.0
.text 954888 954888 0 0.0
window-app BRD4161A (read only) 899992 899992 0 0.0
(read/write) 133256 133256 0 0.0
.bss 131160 131160 0 0.0
.data 2092 2092 0 0.0
.text 899984 899984 0 0.0
k32w light k32w061+release (read/write) 680892 680892 0 0.0
.bss 80168 80168 0 0.0
.data 2012 2012 0 0.0
.text 597008 597008 0 0.0
lock k32w061+release (read/write) 732908 732908 0 0.0
.bss 80600 80600 0 0.0
.data 1980 1980 0 0.0
.text 648624 648624 0 0.0
linux all-clusters-app debug (read only) 2770337 2770337 0 0.0
(read/write) 178272 178272 0 0.0
.bss 86240 86240 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83848 83848 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 244413 244413 0 0.0
.text 2351970 2351970 0 0.0
all-clusters-minimal-app debug (read only) 2647457 2647457 0 0.0
(read/write) 170304 170304 0 0.0
.bss 85504 85504 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76728 76728 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 246333 246333 0 0.0
.text 2228562 2228562 0 0.0
bridge-app debug+rpc (read only) 2030649 2030649 0 0.0
(read/write) 147896 147896 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65496 65496 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169504 169504 0 0.0
.text 1704626 1704626 0 0.0
chip-tool debug (read only) 9683197 9683197 0 0.0
(read/write) 600688 600688 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 569296 569296 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 497885 497885 0 0.0
.text 7796725 7796725 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9424012 9424012 0 0.0
(read/write) 666929 666929 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 604696 604696 0 0.0
.dynamic 528 528 0 0.0
.got 14984 14984 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 461364 461364 0 0.0
.text 7438788 7438788 0 0.0
lighting-app debug+rpc (read only) 2320577 2320577 0 0.0
(read/write) 153536 153536 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70984 70984 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188552 188552 0 0.0
.text 1966274 1966274 0 0.0
lock-app debug (read only) 2259225 2259225 0 0.0
(read/write) 148632 148632 0 0.0
.bss 73440 73440 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67912 67912 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 201608 201608 0 0.0
.text 1897298 1897298 0 0.0
ota-provider-app debug (read only) 2069089 2069089 0 0.0
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 180984 180984 0 0.0
.text 1729010 1729010 0 0.0
ota-requestor-app debug (read only) 2097121 2097121 0 0.0
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 176992 176992 0 0.0
.text 1759570 1759570 0 0.0
shell debug (read only) 2574441 2574441 0 0.0
(read/write) 201680 201680 0 0.0
.bss 117096 117096 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77464 77464 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 224530 224530 0 0.0
.text 2190466 2190466 0 0.0
thermostat-no-ble arm64 (read only) 2367572 2367572 0 0.0
(read/write) 177457 177457 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80216 80216 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148740 148740 0 0.0
.text 1989184 1989184 0 0.0
tv-app debug (read only) 2878417 2878417 0 0.0
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222880 222880 0 0.0
.text 2472930 2472930 0 0.0
tv-casting-app debug (read only) 5430681 5430681 0 0.0
(read/write) 226000 226000 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138760 138760 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 340384 340384 0 0.0
.text 4731042 4731042 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2425280 2425280 0 0.0
.bss 202620 202620 0 0.0
.data 5872 5872 0 0.0
.text 1387924 1387924 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1188051 1188051 0 0.0
bss 141277 141277 0 0.0
rodata 152780 152780 0 0.0
text 815116 815116 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136783 1136783 0 0.0
bss 140506 140506 0 0.0
rodata 129344 129344 0 0.0
text 788124 788124 0 0.0
p6 all-clusters-app default (read/write) 2541584 2541584 0 0.0
.bss 137104 137104 0 0.0
.data 2808 2808 0 0.0
.text 1499848 1499848 0 0.0
all-clusters-minimal-app default (read/write) 2487520 2487520 0 0.0
.bss 136328 136328 0 0.0
.data 2744 2744 0 0.0
.text 1445784 1445784 0 0.0
light-app default (read/write) 2421472 2421472 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1379736 1379736 0 0.0
lock-app default (read/write) 2439520 2439520 0 0.0
.bss 129248 129248 0 0.0
.data 2568 2568 0 0.0
.text 1397784 1397784 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 780252 780252 0 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 551616 551616 0 0.0
lighting-app tlsr9518adk80d (read/write) 800296 800296 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568358 568358 0 0.0

@andy31415 andy31415 merged commit 5479a1e into project-chip:master Jun 2, 2022
@mkardous-silabs mkardous-silabs deleted the fix/show_qr branch June 2, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EFR32 examples : build failed with show_qr_code=false
6 participants
@mkardous-silabs @andy31415 @LuDuda @bzbarsky-apple @jepenven-silabs @jmeg-sfy