-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chip tool Darwin description to classes. #18909
Merged
woody-apple
merged 2 commits into
project-chip:master
from
krypton36:AddChipToolDarwinDescription
Jun 2, 2022
Merged
Add chip tool Darwin description to classes. #18909
woody-apple
merged 2 commits into
project-chip:master
from
krypton36:AddChipToolDarwinDescription
Jun 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt and
mspang
May 27, 2022 19:48
pullapprove
bot
requested review from
rgoliver,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
May 27, 2022 19:48
PR #18909: Size comparison from d2a6470 to 798cf4c Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
src/darwin/Framework/CHIP/templates/CHIPCommandPayloadsObjc-src.zapt
Outdated
Show resolved
Hide resolved
src/darwin/Framework/CHIP/templates/CHIPCommandPayloadsObjc-src.zapt
Outdated
Show resolved
Hide resolved
krypton36
force-pushed
the
AddChipToolDarwinDescription
branch
from
June 2, 2022 16:36
798cf4c
to
ac4332a
Compare
PR #18909: Size comparison from 0bf3ba4 to ac4332a Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Fast tracking platform changes |
woody-apple
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When logging a structure class, it does not log any of the attributes. This makes it difficult to validate responses using darwin-framework-tool.
Change overview
Testing