Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SessionRecoveryDelegate, deliver its event via SessionHolder #18878

Merged
merged 2 commits into from
May 30, 2022
Merged

Remove SessionRecoveryDelegate, deliver its event via SessionHolder #18878

merged 2 commits into from
May 30, 2022

Conversation

kghost
Copy link
Contributor

@kghost kghost commented May 27, 2022 •
edited
Loading

Problem

It is easier to deliver SessionRecoveryDelegate::OnFirstMessageDeliveryFailed event via SessionHolder, remove it to save code space and heap space.

Change overview

  • Remove SessionRecoveryDelegate
  • Deliver SessionRecoveryDelegate::OnFirstMessageDeliveryFailed via SessionHolder
  • Remove SessionManager::mSessionRecoveryDelegates

Testing

Passed unit-tests

@restyled-io restyled-io bot mentioned this pull request May 27, 2022
Closed
@github-actions
Copy link

github-actions bot commented May 27, 2022 •
edited
Loading

PR #18878: Size comparison from e7bb258 to 31c0bae

Increases above 0.2%:

platform target config section e7bb258 31c0bae change % change
linux all-clusters-app debug .data.rel.ro 83560 83736 176 0.2
bridge-app debug+rpc .data.rel.ro 65272 65432 160 0.2
lighting-app debug+rpc .data.rel.ro 70776 70936 160 0.2
lock-app debug .data.rel.ro 67704 67864 160 0.2
ota-provider-app debug .data.rel.ro 60776 60936 160 0.3
ota-requestor-app debug .data.rel.ro 62872 63032 160 0.3
shell debug .data.rel.ro 77208 77368 160 0.2
Increases (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section e7bb258 31c0bae change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 644979 645123 144 0.0
.rodata 83747 83827 80 0.1
.text 560996 561060 64 0.0
lock-ftd LP_CC2652R7 (read only) 679295 679415 120 0.0
.rodata 96055 96127 72 0.1
.text 582756 582804 48 0.0
lock-mtd LP_CC2652R7 (read only) 628695 628823 128 0.0
.rodata 95935 96015 80 0.1
.text 532268 532316 48 0.0
pump-app LP_CC2652R7 (read only) 675715 675843 128 0.0
.rodata 88531 88603 72 0.1
.text 586700 586756 56 0.0
pump-controller-app LP_CC2652R7 (read only) 653643 653787 144 0.0
.rodata 83275 83347 72 0.1
.text 569888 569960 72 0.0
shell LP_CC2652R7 (read only) 637986 638130 144 0.0
.rodata 80722 80802 80 0.1
.text 557032 557096 64 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621510 621702 192 0.0
.app_xip_area 524788 525060 272 0.1
lock cyw930739m2evb_01 (read/write) 630210 630418 208 0.0
.app_xip_area 534960 535248 288 0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570614 570654 40 0.0
.app_xip_area 465684 465804 120 0.0
efr32 lighting-app BRD4161A (read only) 913936 914304 368 0.0
.text 913928 914296 368 0.0
BRD4161A+rpc (read only) 948108 948492 384 0.0
.text 948100 948484 384 0.0
BRD4161A+rs911x (read only) 788508 788756 248 0.0
.text 788500 788748 248 0.0
lock-app BRD4161A+wf200 (read only) 953864 954008 144 0.0
.text 953856 954000 144 0.0
window-app BRD4161A (read only) 898880 899248 368 0.0
.text 898872 899240 368 0.0
esp32 all-clusters-app c3devkit (read only) 1002224 1002276 52 0.0
(read/write) 1479314 1479338 24 0.0
.flash.rodata 209840 209912 72 0.0
.flash.text 1002224 1002276 52 0.0
m5stack (read only) 1057135 1057231 96 0.0
(read/write) 481288 481320 32 0.0
.flash.rodata 240172 240244 72 0.0
.flash.text 1051751 1051847 96 0.0
k32w light k32w061+release (read/write) 680744 680928 184 0.0
.text 596608 596832 224 0.0
lock k32w061+release (read/write) 732084 732324 240 0.0
.text 647548 647828 280 0.0
linux all-clusters-app debug (read only) 2751177 2751433 256 0.0
(read/write) 178240 178400 160 0.1
.data.rel.ro 83560 83736 176 0.2
bridge-app debug+rpc (read only) 2023745 2024577 832 0.0
(read/write) 147896 148024 128 0.1
.data.rel.ro 65272 65432 160 0.2
.text 1699490 1699906 416 0.0
chip-tool debug (read/write) 602608 602640 32 0.0
.data.rel.ro 571264 571288 24 0.0
chip-tool-no-interactive-ipv6only arm64 (read/write) 668801 668817 16 0.0
.data.rel.ro 606568 606600 32 0.0
lighting-app debug+rpc (read only) 2314097 2314641 544 0.0
(read/write) 153536 153632 96 0.1
.data.rel.ro 70776 70936 160 0.2
.text 1961970 1962098 128 0.0
lock-app debug (read only) 2253241 2253785 544 0.0
(read/write) 148600 148728 128 0.1
.data.rel.ro 67704 67864 160 0.2
.text 1893138 1893266 128 0.0
ota-provider-app debug (read only) 2066369 2066929 560 0.0
(read/write) 141360 141488 128 0.1
.data.rel.ro 60776 60936 160 0.3
.text 1728034 1728178 144 0.0
ota-requestor-app debug (read only) 2095585 2095841 256 0.0
(read/write) 144200 144328 128 0.1
.data.rel.ro 62872 63032 160 0.3
shell debug (read only) 2555537 2555777 240 0.0
(read/write) 201744 201808 64 0.0
.data.rel.ro 77208 77368 160 0.2
thermostat-no-ble arm64 (read only) 2359708 2359884 176 0.0
(read/write) 177377 177473 96 0.1
.data.rel.ro 79872 80032 160 0.2
tv-app debug .data.rel.ro 78120 78168 48 0.1
tv-casting-app debug (read only) 5432729 5433257 528 0.0
(read/write) 226256 226320 64 0.0
.data.rel.ro 138736 138880 144 0.1
.text 4734114 4734226 112 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2423816 2424152 336 0.0
.text 1386460 1386796 336 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181375 1181463 88 0.0
rodata 152656 152728 72 0.0
text 810288 810436 148 0.0
p6 all-clusters-app default (read/write) 2536592 2536840 248 0.0
.text 1494856 1495104 248 0.0
light-app default (read/write) 2419880 2420296 416 0.0
.text 1378144 1378560 416 0.0
lock-app default (read/write) 2437912 2438320 408 0.0
.text 1396176 1396584 408 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779400 779480 80 0.0
text 551116 551164 48 0.0
lighting-app tlsr9518adk80d (read/write) 799424 799504 80 0.0
text 567850 567898 48 0.0
Decreases (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section e7bb258 31c0bae change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 159144 159104 -40 -0.0
.bss 74828 74788 -40 -0.1
lock-ftd LP_CC2652R7 (read/write) 163776 163616 -160 -0.1
.bss 72852 72812 -40 -0.1
lock-mtd LP_CC2652R7 (read/write) 145968 145928 -40 -0.0
.bss 68588 68548 -40 -0.1
pump-app LP_CC2652R7 (read/write) 168524 168356 -168 -0.1
.bss 73252 73212 -40 -0.1
pump-controller-app LP_CC2652R7 (read/write) 190452 190268 -184 -0.1
.bss 73108 73068 -40 -0.1
shell LP_CC2652R7 (read/write) 154708 154668 -40 -0.0
.bss 77188 77148 -40 -0.1
cyw30739 light cyw930739m2evb_01 .bss 79364 79284 -80 -0.1
lock cyw930739m2evb_01 .bss 77924 77844 -80 -0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 .bss 87284 87204 -80 -0.1
efr32 lighting-app BRD4161A (read/write) 133448 133408 -40 -0.0
.bss 131352 131312 -40 -0.0
BRD4161A+rpc (read/write) 150136 150096 -40 -0.0
.bss 147840 147800 -40 -0.0
BRD4161A+rs911x (read/write) 129712 129672 -40 -0.0
.bss 127612 127572 -40 -0.0
lock-app BRD4161A+wf200 (read/write) 128484 128444 -40 -0.0
.bss 126420 126380 -40 -0.0
window-app BRD4161A (read/write) 133504 133464 -40 -0.0
.bss 131416 131376 -40 -0.0
esp32 all-clusters-app c3devkit .dram0.bss 69400 69360 -40 -0.1
m5stack .dram0.bss 74912 74872 -40 -0.1
k32w light k32w061+release .bss 80424 80384 -40 -0.0
lock k32w061+release .bss 80856 80816 -40 -0.0
linux all-clusters-app debug .bss 86496 86464 -32 -0.0
.rodata 242013 241949 -64 -0.0
.text 2335570 2335410 -160 -0.0
bridge-app debug+rpc .bss 73120 73088 -32 -0.0
.rodata 168096 168032 -64 -0.0
chip-tool debug (read only) 9660005 9657733 -2272 -0.0
.rodata 492669 492445 -224 -0.0
.text 7774261 7771925 -2336 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9402692 9400436 -2256 -0.0
.got 14992 14976 -16 -0.1
.rodata 456604 456476 -128 -0.0
.text 7417892 7415572 -2320 -0.0
lighting-app debug+rpc .bss 74944 74880 -64 -0.1
.rodata 186760 186696 -64 -0.0
lock-app debug .bss 73632 73600 -32 -0.0
.rodata 200168 200104 -64 -0.0
ota-provider-app debug .bss 73024 72992 -32 -0.0
.rodata 179768 179704 -64 -0.0
ota-requestor-app debug .bss 73728 73696 -32 -0.0
.rodata 175776 175712 -64 -0.0
.text 1759778 1759618 -160 -0.0
shell debug .bss 117416 117320 -96 -0.1
.rodata 222194 222130 -64 -0.0
.text 2174258 2174082 -176 -0.0
thermostat-no-ble arm64 .bss 88177 88129 -48 -0.1
.got 4768 4760 -8 -0.2
.text 1983344 1983072 -272 -0.0
tv-app debug (read only) 2875017 2872569 -2448 -0.1
(read/write) 280368 280336 -32 -0.0
.bss 191304 191240 -64 -0.0
.rodata 221728 221472 -256 -0.1
.text 2470802 2468322 -2480 -0.1
tv-casting-app debug .bss 78888 78824 -64 -0.1
.rodata 339264 339200 -64 -0.0
mbed lock-app CY8CPROTO_062_4343W+release .bss 202868 202828 -40 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 bss 139532 139492 -40 -0.0
p6 all-clusters-app default .bss 137352 137312 -40 -0.0
light-app default .bss 129688 129648 -40 -0.0
lock-app default .bss 129496 129456 -40 -0.0
telink light-switch-app tlsr9518adk80d bss 70824 70784 -40 -0.1
lighting-app tlsr9518adk80d bss 71076 71036 -40 -0.1
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section e7bb258 31c0bae change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 644979 645123 144 0.0
(read/write) 159144 159104 -40 -0.0
.bss 74828 74788 -40 -0.1
.data 3400 3400 0 0.0
.rodata 83747 83827 80 0.1
.text 560996 561060 64 0.0
lock-ftd LP_CC2652R7 (read only) 679295 679415 120 0.0
(read/write) 163776 163616 -160 -0.1
.bss 72852 72812 -40 -0.1
.data 3264 3264 0 0.0
.rodata 96055 96127 72 0.1
.text 582756 582804 48 0.0
lock-mtd LP_CC2652R7 (read only) 628695 628823 128 0.0
(read/write) 145968 145928 -40 -0.0
.bss 68588 68548 -40 -0.1
.data 3264 3264 0 0.0
.rodata 95935 96015 80 0.1
.text 532268 532316 48 0.0
pump-app LP_CC2652R7 (read only) 675715 675843 128 0.0
(read/write) 168524 168356 -168 -0.1
.bss 73252 73212 -40 -0.1
.data 3300 3300 0 0.0
.rodata 88531 88603 72 0.1
.text 586700 586756 56 0.0
pump-controller-app LP_CC2652R7 (read only) 653643 653787 144 0.0
(read/write) 190452 190268 -184 -0.1
.bss 73108 73068 -40 -0.1
.data 3260 3260 0 0.0
.rodata 83275 83347 72 0.1
.text 569888 569960 72 0.0
shell LP_CC2652R7 (read only) 637986 638130 144 0.0
(read/write) 154708 154668 -40 -0.0
.bss 77188 77148 -40 -0.1
.data 3404 3404 0 0.0
.rodata 80722 80802 80 0.1
.text 557032 557096 64 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621510 621702 192 0.0
.app_xip_area 524788 525060 272 0.1
.bss 79364 79284 -80 -0.1
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630210 630418 208 0.0
.app_xip_area 534960 535248 288 0.1
.bss 77924 77844 -80 -0.1
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570614 570654 40 0.0
.app_xip_area 465684 465804 120 0.0
.bss 87284 87204 -80 -0.1
.data 612 612 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 913936 914304 368 0.0
(read/write) 133448 133408 -40 -0.0
.bss 131352 131312 -40 -0.0
.data 2092 2092 0 0.0
.text 913928 914296 368 0.0
BRD4161A+rpc (read only) 948108 948492 384 0.0
(read/write) 150136 150096 -40 -0.0
.bss 147840 147800 -40 -0.0
.data 2296 2296 0 0.0
.text 948100 948484 384 0.0
BRD4161A+rs911x (read only) 788508 788756 248 0.0
(read/write) 129712 129672 -40 -0.0
.bss 127612 127572 -40 -0.0
.data 2100 2100 0 0.0
.text 788500 788748 248 0.0
lock-app BRD4161A+wf200 (read only) 953864 954008 144 0.0
(read/write) 128484 128444 -40 -0.0
.bss 126420 126380 -40 -0.0
.data 2064 2064 0 0.0
.text 953856 954000 144 0.0
window-app BRD4161A (read only) 898880 899248 368 0.0
(read/write) 133504 133464 -40 -0.0
.bss 131416 131376 -40 -0.0
.data 2088 2088 0 0.0
.text 898872 899240 368 0.0
esp32 all-clusters-app c3devkit (read only) 1002224 1002276 52 0.0
(read/write) 1479314 1479338 24 0.0
.dram0.bss 69400 69360 -40 -0.1
.dram0.data 14640 14640 0 0.0
.flash.rodata 209840 209912 72 0.0
.flash.text 1002224 1002276 52 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1057135 1057231 96 0.0
(read/write) 481288 481320 32 0.0
.dram0.bss 74912 74872 -40 -0.1
.dram0.data 34208 34208 0 0.0
.flash.rodata 240172 240244 72 0.0
.flash.text 1051751 1051847 96 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 680744 680928 184 0.0
.bss 80424 80384 -40 -0.0
.data 2008 2008 0 0.0
.text 596608 596832 224 0.0
lock k32w061+release (read/write) 732084 732324 240 0.0
.bss 80856 80816 -40 -0.0
.data 1976 1976 0 0.0
.text 647548 647828 280 0.0
linux all-clusters-app debug (read only) 2751177 2751433 256 0.0
(read/write) 178240 178400 160 0.1
.bss 86496 86464 -32 -0.0
.data 2032 2032 0 0.0
.data.rel.ro 83560 83736 176 0.2
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 242013 241949 -64 -0.0
.text 2335570 2335410 -160 -0.0
bridge-app debug+rpc (read only) 2023745 2024577 832 0.0
(read/write) 147896 148024 128 0.1
.bss 73120 73088 -32 -0.0
.data 3936 3936 0 0.0
.data.rel.ro 65272 65432 160 0.2
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 168096 168032 -64 -0.0
.text 1699490 1699906 416 0.0
chip-tool debug (read only) 9660005 9657733 -2272 -0.0
(read/write) 602608 602640 32 0.0
.bss 23936 23936 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 571264 571288 24 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 492669 492445 -224 -0.0
.text 7774261 7771925 -2336 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9402692 9400436 -2256 -0.0
(read/write) 668801 668817 16 0.0
.bss 42225 42225 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 606568 606600 32 0.0
.dynamic 560 560 0 0.0
.got 14992 14976 -16 -0.1
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 456604 456476 -128 -0.0
.text 7417892 7415572 -2320 -0.0
lighting-app debug+rpc (read only) 2314097 2314641 544 0.0
(read/write) 153536 153632 96 0.1
.bss 74944 74880 -64 -0.1
.data 2048 2048 0 0.0
.data.rel.ro 70776 70936 160 0.2
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 186760 186696 -64 -0.0
.text 1961970 1962098 128 0.0
lock-app debug (read only) 2253241 2253785 544 0.0
(read/write) 148600 148728 128 0.1
.bss 73632 73600 -32 -0.0
.data 1568 1568 0 0.0
.data.rel.ro 67704 67864 160 0.2
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 200168 200104 -64 -0.0
.text 1893138 1893266 128 0.0
ota-provider-app debug (read only) 2066369 2066929 560 0.0
(read/write) 141360 141488 128 0.1
.bss 73024 72992 -32 -0.0
.data 1768 1768 0 0.0
.data.rel.ro 60776 60936 160 0.3
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 179768 179704 -64 -0.0
.text 1728034 1728178 144 0.0
ota-requestor-app debug (read only) 2095585 2095841 256 0.0
(read/write) 144200 144328 128 0.1
.bss 73728 73696 -32 -0.0
.data 1960 1960 0 0.0
.data.rel.ro 62872 63032 160 0.3
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 175776 175712 -64 -0.0
.text 1759778 1759618 -160 -0.0
shell debug (read only) 2555537 2555777 240 0.0
(read/write) 201744 201808 64 0.0
.bss 117416 117320 -96 -0.1
.data 1376 1376 0 0.0
.data.rel.ro 77208 77368 160 0.2
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222194 222130 -64 -0.0
.text 2174258 2174082 -176 -0.0
thermostat-no-ble arm64 (read only) 2359708 2359884 176 0.0
(read/write) 177377 177473 96 0.1
.bss 88177 88129 -48 -0.1
.data 1520 1520 0 0.0
.data.rel.ro 79872 80032 160 0.2
.dynamic 560 560 0 0.0
.got 4768 4760 -8 -0.2
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147404 147404 0 0.0
.text 1983344 1983072 -272 -0.0
tv-app debug (read only) 2875017 2872569 -2448 -0.1
(read/write) 280368 280336 -32 -0.0
.bss 191304 191240 -64 -0.0
.data 4672 4672 0 0.0
.data.rel.ro 78120 78168 48 0.1
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221728 221472 -256 -0.1
.text 2470802 2468322 -2480 -0.1
tv-casting-app debug (read only) 5432729 5433257 528 0.0
(read/write) 226256 226320 64 0.0
.bss 78888 78824 -64 -0.1
.data 2400 2400 0 0.0
.data.rel.ro 138736 138880 144 0.1
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339264 339200 -64 -0.0
.text 4734114 4734226 112 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2423816 2424152 336 0.0
.bss 202868 202828 -40 -0.0
.data 5872 5872 0 0.0
.text 1386460 1386796 336 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181375 1181463 88 0.0
bss 139532 139492 -40 -0.0
rodata 152656 152728 72 0.0
text 810288 810436 148 0.0
p6 all-clusters-app default (read/write) 2536592 2536840 248 0.0
.bss 137352 137312 -40 -0.0
.data 2800 2800 0 0.0
.text 1494856 1495104 248 0.0
light-app default (read/write) 2419880 2420296 416 0.0
.bss 129688 129648 -40 -0.0
.data 2600 2600 0 0.0
.text 1378144 1378560 416 0.0
lock-app default (read/write) 2437912 2438320 408 0.0
.bss 129496 129456 -40 -0.0
.data 2568 2568 0 0.0
.text 1396176 1396584 408 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779400 779480 80 0.0
bss 70824 70784 -40 -0.1
noinit 40416 40416 0 0.0
text 551116 551164 48 0.0
lighting-app tlsr9518adk80d (read/write) 799424 799504 80 0.0
bss 71076 71036 -40 -0.1
noinit 40416 40416 0 0.0
text 567850 567898 48 0.0

@yunhanw-google yunhanw-google mentioned this pull request May 27, 2022
Open
@kghost kghost mentioned this pull request May 27, 2022
Closed
3 tasks
bzbarsky-apple
bzbarsky-apple approved these changes May 28, 2022
View reviewed changes
src/transport/SessionDelegate.h Outdated Show resolved Hide resolved
src/transport/Session.h Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented May 30, 2022 •
edited
Loading

PR #18878: Size comparison from 4d84a4a to ef6a5ad

Increases (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 4d84a4a ef6a5ad change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 647575 647719 144 0.0
.rodata 84159 84239 80 0.1
.text 563180 563244 64 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 613591 613735 144 0.0
.rodata 73471 73551 80 0.1
.text 539884 539948 64 0.0
lock-ftd LP_CC2652R7 (read only) 679559 679671 112 0.0
.rodata 96135 96199 64 0.1
.text 582940 582988 48 0.0
lock-mtd LP_CC2652R7 (read only) 628967 629087 120 0.0
.rodata 96015 96087 72 0.1
.text 532460 532508 48 0.0
pump-app LP_CC2652R7 (read only) 675971 676083 112 0.0
.rodata 88611 88675 64 0.1
.text 586876 586924 48 0.0
pump-controller-app LP_CC2652R7 (read only) 653907 654027 120 0.0
.rodata 83347 83419 72 0.1
.text 570080 570128 48 0.0
shell LP_CC2652R7 (read only) 640606 640742 136 0.0
.rodata 81142 81214 72 0.1
.text 559232 559296 64 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621506 621706 200 0.0
.app_xip_area 525012 525292 280 0.1
lock cyw930739m2evb_01 (read/write) 630214 630406 192 0.0
.app_xip_area 535192 535464 272 0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570838 570878 40 0.0
.app_xip_area 465896 466016 120 0.0
efr32 lighting-app BRD4161A (read only) 914272 914640 368 0.0
.text 914264 914632 368 0.0
BRD4161A+rpc (read only) 948508 948876 368 0.0
.text 948500 948868 368 0.0
BRD4161A+rs911x (read only) 788836 789084 248 0.0
.text 788828 789076 248 0.0
lock-app BRD4161A+wf200 (read only) 954064 954224 160 0.0
.text 954056 954216 160 0.0
window-app BRD4161A (read only) 899216 899568 352 0.0
.text 899208 899560 352 0.0
esp32 all-clusters-app c3devkit (read only) 1004814 1004866 52 0.0
(read/write) 1479522 1479554 32 0.0
.flash.rodata 210256 210336 80 0.0
.flash.text 1004814 1004866 52 0.0
m5stack (read only) 1059995 1060067 72 0.0
(read/write) 481744 481776 32 0.0
.flash.rodata 240844 240916 72 0.0
.flash.text 1054611 1054683 72 0.0
k32w light k32w061+release (read/write) 680676 680860 184 0.0
.text 596764 596988 224 0.0
lock k32w061+release (read/write) 732092 732348 256 0.0
.text 647780 648076 296 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read/write) 668785 668801 16 0.0
.data.rel.ro 606528 606560 32 0.0
thermostat-no-ble arm64 (read only) 2365900 2366076 176 0.0
(read/write) 177313 177409 96 0.1
.data.rel.ro 80016 80176 160 0.2
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2424480 2424816 336 0.0
.text 1387124 1387460 336 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1185703 1185919 216 0.0
rodata 153488 153560 72 0.0
text 814036 814184 148 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1133579 1133795 216 0.0
rodata 129972 130044 72 0.1
text 786264 786412 148 0.0
p6 all-clusters-app default (read/write) 2539952 2540200 248 0.0
.text 1498216 1498464 248 0.0
all-clusters-minimal-app default (read/write) 2484712 2484976 264 0.0
.text 1442976 1443240 264 0.0
light-app default (read/write) 2420192 2420600 408 0.0
.text 1378456 1378864 408 0.0
lock-app default (read/write) 2438216 2438632 416 0.0
.text 1396480 1396896 416 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779464 779544 80 0.0
text 551326 551374 48 0.0
lighting-app tlsr9518adk80d (read/write) 799492 799572 80 0.0
text 568060 568108 48 0.0
Decreases (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 4d84a4a ef6a5ad change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 158928 158888 -40 -0.0
.bss 74612 74572 -40 -0.1
all-clusters-minimal-app LP_CC2652R7 (read/write) 158156 158116 -40 -0.0
.bss 73900 73860 -40 -0.1
lock-ftd LP_CC2652R7 (read/write) 163296 163144 -152 -0.1
.bss 72636 72596 -40 -0.1
lock-mtd LP_CC2652R7 (read/write) 145752 145712 -40 -0.0
.bss 68372 68332 -40 -0.1
pump-app LP_CC2652R7 (read/write) 168052 167900 -152 -0.1
.bss 73036 72996 -40 -0.1
pump-controller-app LP_CC2652R7 (read/write) 189972 189812 -160 -0.1
.bss 72892 72852 -40 -0.1
shell LP_CC2652R7 (read/write) 154484 154444 -40 -0.0
.bss 76964 76924 -40 -0.1
cyw30739 light cyw930739m2evb_01 .bss 79136 79056 -80 -0.1
lock cyw930739m2evb_01 .bss 77696 77616 -80 -0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 .bss 87296 87216 -80 -0.1
efr32 lighting-app BRD4161A (read/write) 133216 133176 -40 -0.0
.bss 131120 131080 -40 -0.0
BRD4161A+rpc (read/write) 149904 149864 -40 -0.0
.bss 147608 147568 -40 -0.0
BRD4161A+rs911x (read/write) 129488 129448 -40 -0.0
.bss 127388 127348 -40 -0.0
lock-app BRD4161A+wf200 (read/write) 128268 128228 -40 -0.0
.bss 126204 126164 -40 -0.0
window-app BRD4161A (read/write) 133280 133240 -40 -0.0
.bss 131192 131152 -40 -0.0
esp32 all-clusters-app c3devkit .dram0.bss 69176 69136 -40 -0.1
m5stack .dram0.bss 74696 74656 -40 -0.1
k32w light k32w061+release .bss 80200 80160 -40 -0.0
lock k32w061+release .bss 80632 80592 -40 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9422028 9419740 -2288 -0.0
.got 15016 15000 -16 -0.1
.rodata 459956 459812 -144 -0.0
.text 7434004 7431668 -2336 -0.0
thermostat-no-ble arm64 .bss 87969 87921 -48 -0.1
.got 4800 4792 -8 -0.2
.text 1988624 1988336 -288 -0.0
mbed lock-app CY8CPROTO_062_4343W+release .bss 202652 202612 -40 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 bss 139308 139268 -40 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 bss 138600 138560 -40 -0.0
p6 all-clusters-app default .bss 137136 137096 -40 -0.0
all-clusters-minimal-app default .bss 136424 136384 -40 -0.0
light-app default .bss 129464 129424 -40 -0.0
lock-app default .bss 129280 129240 -40 -0.0
telink light-switch-app tlsr9518adk80d bss 70596 70556 -40 -0.1
lighting-app tlsr9518adk80d bss 70856 70816 -40 -0.1
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 4d84a4a ef6a5ad change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 647575 647719 144 0.0
(read/write) 158928 158888 -40 -0.0
.bss 74612 74572 -40 -0.1
.data 3400 3400 0 0.0
.rodata 84159 84239 80 0.1
.text 563180 563244 64 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 613591 613735 144 0.0
(read/write) 158156 158116 -40 -0.0
.bss 73900 73860 -40 -0.1
.data 3340 3340 0 0.0
.rodata 73471 73551 80 0.1
.text 539884 539948 64 0.0
lock-ftd LP_CC2652R7 (read only) 679559 679671 112 0.0
(read/write) 163296 163144 -152 -0.1
.bss 72636 72596 -40 -0.1
.data 3264 3264 0 0.0
.rodata 96135 96199 64 0.1
.text 582940 582988 48 0.0
lock-mtd LP_CC2652R7 (read only) 628967 629087 120 0.0
(read/write) 145752 145712 -40 -0.0
.bss 68372 68332 -40 -0.1
.data 3264 3264 0 0.0
.rodata 96015 96087 72 0.1
.text 532460 532508 48 0.0
pump-app LP_CC2652R7 (read only) 675971 676083 112 0.0
(read/write) 168052 167900 -152 -0.1
.bss 73036 72996 -40 -0.1
.data 3300 3300 0 0.0
.rodata 88611 88675 64 0.1
.text 586876 586924 48 0.0
pump-controller-app LP_CC2652R7 (read only) 653907 654027 120 0.0
(read/write) 189972 189812 -160 -0.1
.bss 72892 72852 -40 -0.1
.data 3260 3260 0 0.0
.rodata 83347 83419 72 0.1
.text 570080 570128 48 0.0
shell LP_CC2652R7 (read only) 640606 640742 136 0.0
(read/write) 154484 154444 -40 -0.0
.bss 76964 76924 -40 -0.1
.data 3404 3404 0 0.0
.rodata 81142 81214 72 0.1
.text 559232 559296 64 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621506 621706 200 0.0
.app_xip_area 525012 525292 280 0.1
.bss 79136 79056 -80 -0.1
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630214 630406 192 0.0
.app_xip_area 535192 535464 272 0.1
.bss 77696 77616 -80 -0.1
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570838 570878 40 0.0
.app_xip_area 465896 466016 120 0.0
.bss 87296 87216 -80 -0.1
.data 612 612 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914272 914640 368 0.0
(read/write) 133216 133176 -40 -0.0
.bss 131120 131080 -40 -0.0
.data 2092 2092 0 0.0
.text 914264 914632 368 0.0
BRD4161A+rpc (read only) 948508 948876 368 0.0
(read/write) 149904 149864 -40 -0.0
.bss 147608 147568 -40 -0.0
.data 2296 2296 0 0.0
.text 948500 948868 368 0.0
BRD4161A+rs911x (read only) 788836 789084 248 0.0
(read/write) 129488 129448 -40 -0.0
.bss 127388 127348 -40 -0.0
.data 2100 2100 0 0.0
.text 788828 789076 248 0.0
lock-app BRD4161A+wf200 (read only) 954064 954224 160 0.0
(read/write) 128268 128228 -40 -0.0
.bss 126204 126164 -40 -0.0
.data 2064 2064 0 0.0
.text 954056 954216 160 0.0
window-app BRD4161A (read only) 899216 899568 352 0.0
(read/write) 133280 133240 -40 -0.0
.bss 131192 131152 -40 -0.0
.data 2088 2088 0 0.0
.text 899208 899560 352 0.0
esp32 all-clusters-app c3devkit (read only) 1004814 1004866 52 0.0
(read/write) 1479522 1479554 32 0.0
.dram0.bss 69176 69136 -40 -0.1
.dram0.data 14648 14648 0 0.0
.flash.rodata 210256 210336 80 0.0
.flash.text 1004814 1004866 52 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1059995 1060067 72 0.0
(read/write) 481744 481776 32 0.0
.dram0.bss 74696 74656 -40 -0.1
.dram0.data 34208 34208 0 0.0
.flash.rodata 240844 240916 72 0.0
.flash.text 1054611 1054683 72 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 680676 680860 184 0.0
.bss 80200 80160 -40 -0.0
.data 2008 2008 0 0.0
.text 596764 596988 224 0.0
lock k32w061+release (read/write) 732092 732348 256 0.0
.bss 80632 80592 -40 -0.0
.data 1976 1976 0 0.0
.text 647780 648076 296 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9422028 9419740 -2288 -0.0
(read/write) 668785 668801 16 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 606528 606560 32 0.0
.dynamic 528 528 0 0.0
.got 15016 15000 -16 -0.1
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 459956 459812 -144 -0.0
.text 7434004 7431668 -2336 -0.0
thermostat-no-ble arm64 (read only) 2365900 2366076 176 0.0
(read/write) 177313 177409 96 0.1
.bss 87969 87921 -48 -0.1
.data 1520 1520 0 0.0
.data.rel.ro 80016 80176 160 0.2
.dynamic 528 528 0 0.0
.got 4800 4792 -8 -0.2
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148156 148156 0 0.0
.text 1988624 1988336 -288 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2424480 2424816 336 0.0
.bss 202652 202612 -40 -0.0
.data 5872 5872 0 0.0
.text 1387124 1387460 336 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1185703 1185919 216 0.0
bss 139308 139268 -40 -0.0
rodata 153488 153560 72 0.0
text 814036 814184 148 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1133579 1133795 216 0.0
bss 138600 138560 -40 -0.0
rodata 129972 130044 72 0.1
text 786264 786412 148 0.0
p6 all-clusters-app default (read/write) 2539952 2540200 248 0.0
.bss 137136 137096 -40 -0.0
.data 2800 2800 0 0.0
.text 1498216 1498464 248 0.0
all-clusters-minimal-app default (read/write) 2484712 2484976 264 0.0
.bss 136424 136384 -40 -0.0
.data 2744 2744 0 0.0
.text 1442976 1443240 264 0.0
light-app default (read/write) 2420192 2420600 408 0.0
.bss 129464 129424 -40 -0.0
.data 2600 2600 0 0.0
.text 1378456 1378864 408 0.0
lock-app default (read/write) 2438216 2438632 416 0.0
.bss 129280 129240 -40 -0.0
.data 2568 2568 0 0.0
.text 1396480 1396896 416 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779464 779544 80 0.0
bss 70596 70556 -40 -0.1
noinit 40416 40416 0 0.0
text 551326 551374 48 0.0
lighting-app tlsr9518adk80d (read/write) 799492 799572 80 0.0
bss 70856 70816 -40 -0.1
noinit 40416 40416 0 0.0
text 568060 568108 48 0.0

@kghost kghost merged commit 7699761 into project-chip:master May 30, 2022
@kghost kghost deleted the session-3 branch May 30, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@msandstedt msandstedt Awaiting requested review from msandstedt

Assignees
No one assigned
Labels
app controller lib review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kghost @msandstedt @bzbarsky-apple