Fix retrieval of attestation challenge in Java #18867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #18867: Size comparison from 3956a9d to cdca933 Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda and
mlepage-google
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
rgoliver,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
bzbarsky-apple
requested changes
May 27, 2022
When not using the auto-commissioning flow, the mDeviceBeingCommissioned proxy is no longer assigned, so the default behavior of retrieving the attestation challenge fails. Since at the time of use we already have a reference to the correct DeviceProxy, added an overload to pass the proxy along to retrieve the challenge.
g-coppock
force-pushed
the
pr/coppock/fix_attestation_challenge_target
branch
from
cdca933 to
5705d4d
Compare
|
PR #18867: Size comparison from d2a6470 to 5705d4d Increases (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (4 builds for cc13x2_26x2, efr32)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
May 28, 2022
| */ | ||
| virtual CHIP_ERROR GetAttestationChallenge(ByteSpan & attestationChallenge) | ||
| { | ||
| Optional<SessionHandle> secureSessionHandle; |
There was a problem hiding this comment.
Might be better to put the implementation in the .cpp...
There was a problem hiding this comment.
Seems no updates in a while on this PR. Assuming this can be done as a followup.
There was a problem hiding this comment.
@andy31415 Is there an issue tracking tahg followup assigned to this PR's author?
I am fine with followups, but I want them to actually happen, and except for a few people our track record at them is very poor.
There was a problem hiding this comment.
Followup is here: #19058
andy31415
approved these changes
May 30, 2022
g-coppock
added a commit
to g-coppock/connectedhomeip
that referenced
this pull request
Jun 1, 2022
bzbarsky-apple
pushed a commit
that referenced
this pull request
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not using the auto-commissioning flow, the mDeviceBeingCommissioned
proxy is no longer assigned, so the default behavior of retrieving the
attestation challenge fails.
Since at the time of use we already have a reference to the correct
DeviceProxy, added an overload to pass the proxy along to retrieve the
challenge.