Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AddNOC/UpdateNOC to follow final error handling spec text #18861

Merged
merged 20 commits into from
May 28, 2022
Merged

Update AddNOC/UpdateNOC to follow final error handling spec text #18861

merged 20 commits into from
May 28, 2022

Conversation

HodgertA
Copy link
Contributor

@HodgertA HodgertA commented May 26, 2022 •
edited by tcarmelveilleux
Loading

Problem

What is being fixed?:
In https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/5231, error handling got normalized. The updates in this PR are to match the naming and error handling changes in AddNoc and UpdateNoc

Change overview

  • Renamed CaseAdminNode command field to CaseAdminSubject
  • Renamed MissingAdminNode enum value to InvalidAdminSubject
  • Added error handling for NOCValue and ICACValue and IPKValue for invalid values on update and add

Testing

The changes in this PR are already covered by the commissioning tests and operational credential cluster tests.
Currently looking at adding more YAML tests for invalid commands.

@CLAassistant
Copy link

CLAassistant commented May 26, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@restyled-io restyled-io bot mentioned this pull request May 26, 2022
Closed
@tcarmelveilleux tcarmelveilleux changed the title Update noc to follow final error handling spec text Update AddNOC/UpdateNOC to follow final error handling spec text May 26, 2022
bzbarsky-apple
bzbarsky-apple reviewed May 27, 2022
View reviewed changes
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp Show resolved Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp Show resolved Hide resolved
src/app/zap-templates/zcl/data-model/chip/operational-credentials-cluster.xml Outdated Show resolved Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp Show resolved Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp Show resolved Hide resolved
src/app/zap-templates/zcl/data-model/chip/operational-credentials-cluster.xml Show resolved Hide resolved
src/controller/CHIPDeviceController.cpp Outdated Show resolved Hide resolved
@tcarmelveilleux tcarmelveilleux mentioned this pull request May 27, 2022
Closed
@github-actions
Copy link

github-actions bot commented May 27, 2022 •
edited
Loading

PR #18861: Size comparison from 32866c0 to b1dbc35

Increases (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 32866c0 b1dbc35 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 645135 645295 160 0.0
.rodata 83783 83863 80 0.1
.text 561116 561196 80 0.0
lock-ftd LP_CC2652R7 (read only) 679435 679619 184 0.0
.rodata 96075 96163 88 0.1
.text 582876 582972 96 0.0
lock-mtd LP_CC2652R7 (read only) 628843 629027 184 0.0
.rodata 95955 96043 88 0.1
.text 532396 532492 96 0.0
pump-app LP_CC2652R7 (read only) 675863 676031 168 0.0
.rodata 88551 88639 88 0.1
.text 586828 586908 80 0.0
pump-controller-app LP_CC2652R7 (read only) 653791 653967 176 0.0
.rodata 83295 83375 80 0.1
.text 570016 570112 96 0.0
shell LP_CC2652R7 (read only) 638142 638326 184 0.0
.rodata 80758 80846 88 0.1
.text 557152 557248 96 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621662 621838 176 0.0
.app_xip_area 524928 525104 176 0.0
lock cyw930739m2evb_01 (read/write) 630370 630546 176 0.0
.app_xip_area 535108 535284 176 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570758 570910 152 0.0
.app_xip_area 465816 465968 152 0.0
efr32 lighting-app BRD4161A (read only) 914152 914344 192 0.0
.text 914144 914336 192 0.0
BRD4161A+rpc (read only) 948324 948564 240 0.0
.text 948316 948556 240 0.0
BRD4161A+rs911x (read only) 788724 788908 184 0.0
.text 788716 788900 184 0.0
lock-app BRD4161A+wf200 (read only) 954012 954188 176 0.0
.text 954004 954180 176 0.0
window-app BRD4161A (read only) 899096 899272 176 0.0
.text 899088 899264 176 0.0
esp32 all-clusters-app c3devkit (read only) 1002366 1002480 114 0.0
(read/write) 1479362 1479450 88 0.0
.flash.rodata 209872 209960 88 0.0
.flash.text 1002366 1002480 114 0.0
m5stack (read only) 1057635 1057771 136 0.0
(read/write) 481616 481696 80 0.0
.flash.rodata 240468 240548 80 0.0
.flash.text 1052251 1052387 136 0.0
k32w light k32w061+release (read/write) 680892 681004 112 0.0
.text 596740 596852 112 0.0
lock k32w061+release (read/write) 732232 732392 160 0.0
.text 647680 647840 160 0.0
linux all-clusters-app debug (read only) 2751465 2751577 112 0.0
.rodata 242205 242397 192 0.1
bridge-app debug+rpc (read only) 2024001 2024113 112 0.0
.rodata 168256 168448 192 0.1
chip-tool debug (read only) 9680229 9680437 208 0.0
.rodata 497213 497309 96 0.0
.text 7790373 7790485 112 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9423772 9423948 176 0.0
.rodata 460916 460996 80 0.0
.text 7434724 7434820 96 0.0
lighting-app debug+rpc (read only) 2314385 2314481 96 0.0
.rodata 186952 187144 192 0.1
lock-app debug (read only) 2253497 2253593 96 0.0
.rodata 200328 200520 192 0.1
ota-provider-app debug (read only) 2066657 2066881 224 0.0
.rodata 179960 180120 160 0.1
.text 1728130 1728194 64 0.0
ota-requestor-app debug (read only) 2095873 2095985 112 0.0
.rodata 175968 176160 192 0.1
shell debug (read only) 2555825 2555921 96 0.0
.rodata 222386 222578 192 0.1
thermostat-no-ble arm64 (read only) 2359836 2360028 192 0.0
.rodata 147532 147692 160 0.1
.text 1982960 1982992 32 0.0
tv-app debug (read only) 2875169 2875329 160 0.0
.rodata 221888 222080 192 0.1
tv-casting-app debug (read only) 5426113 5426257 144 0.0
.rodata 339136 339360 224 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2423968 2424632 664 0.0
.text 1386612 1387276 664 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183439 1183619 180 0.0
rodata 153112 153196 84 0.1
text 811892 811988 96 0.0
p6 all-clusters-app default (read/write) 2536808 2536992 184 0.0
.text 1495072 1495256 184 0.0
light-app default (read/write) 2420080 2420264 184 0.0
.text 1378344 1378528 184 0.0
lock-app default (read/write) 2438112 2438288 176 0.0
.text 1396376 1396552 176 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779588 779776 188 0.0
text 551262 551368 106 0.0
lighting-app tlsr9518adk80d (read/write) 799612 799808 196 0.0
text 567996 568102 106 0.0
Decreases (11 builds for cc13x2_26x2, linux)
platform target config section 32866c0 b1dbc35 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 163660 163476 -184 -0.1
pump-app LP_CC2652R7 (read/write) 168400 168232 -168 -0.1
pump-controller-app LP_CC2652R7 (read/write) 190328 190152 -176 -0.1
linux all-clusters-app debug .text 2335666 2335586 -80 -0.0
bridge-app debug+rpc .text 1699586 1699506 -80 -0.0
lighting-app debug+rpc .text 1962066 1961970 -96 -0.0
lock-app debug .text 1893234 1893138 -96 -0.0
ota-requestor-app debug .text 1759874 1759794 -80 -0.0
shell debug .text 2174354 2174258 -96 -0.0
tv-app debug .text 2470866 2470834 -32 -0.0
tv-casting-app debug .text 4728082 4728002 -80 -0.0
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 32866c0 b1dbc35 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 645135 645295 160 0.0
(read/write) 159168 159168 0 0.0
.bss 74852 74852 0 0.0
.data 3400 3400 0 0.0
.rodata 83783 83863 80 0.1
.text 561116 561196 80 0.0
lock-ftd LP_CC2652R7 (read only) 679435 679619 184 0.0
(read/write) 163660 163476 -184 -0.1
.bss 72876 72876 0 0.0
.data 3264 3264 0 0.0
.rodata 96075 96163 88 0.1
.text 582876 582972 96 0.0
lock-mtd LP_CC2652R7 (read only) 628843 629027 184 0.0
(read/write) 145992 145992 0 0.0
.bss 68612 68612 0 0.0
.data 3264 3264 0 0.0
.rodata 95955 96043 88 0.1
.text 532396 532492 96 0.0
pump-app LP_CC2652R7 (read only) 675863 676031 168 0.0
(read/write) 168400 168232 -168 -0.1
.bss 73276 73276 0 0.0
.data 3300 3300 0 0.0
.rodata 88551 88639 88 0.1
.text 586828 586908 80 0.0
pump-controller-app LP_CC2652R7 (read only) 653791 653967 176 0.0
(read/write) 190328 190152 -176 -0.1
.bss 73132 73132 0 0.0
.data 3260 3260 0 0.0
.rodata 83295 83375 80 0.1
.text 570016 570112 96 0.0
shell LP_CC2652R7 (read only) 638142 638326 184 0.0
(read/write) 154724 154724 0 0.0
.bss 77204 77204 0 0.0
.data 3404 3404 0 0.0
.rodata 80758 80846 88 0.1
.text 557152 557248 96 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621662 621838 176 0.0
.app_xip_area 524928 525104 176 0.0
.bss 79376 79376 0 0.0
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630370 630546 176 0.0
.app_xip_area 535108 535284 176 0.0
.bss 77936 77936 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570758 570910 152 0.0
.app_xip_area 465816 465968 152 0.0
.bss 87296 87296 0 0.0
.data 612 612 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914152 914344 192 0.0
(read/write) 133464 133464 0 0.0
.bss 131368 131368 0 0.0
.data 2092 2092 0 0.0
.text 914144 914336 192 0.0
BRD4161A+rpc (read only) 948324 948564 240 0.0
(read/write) 150152 150152 0 0.0
.bss 147856 147856 0 0.0
.data 2296 2296 0 0.0
.text 948316 948556 240 0.0
BRD4161A+rs911x (read only) 788724 788908 184 0.0
(read/write) 129736 129736 0 0.0
.bss 127636 127636 0 0.0
.data 2100 2100 0 0.0
.text 788716 788900 184 0.0
lock-app BRD4161A+wf200 (read only) 954012 954188 176 0.0
(read/write) 128508 128508 0 0.0
.bss 126444 126444 0 0.0
.data 2064 2064 0 0.0
.text 954004 954180 176 0.0
window-app BRD4161A (read only) 899096 899272 176 0.0
(read/write) 133520 133520 0 0.0
.bss 131432 131432 0 0.0
.data 2088 2088 0 0.0
.text 899088 899264 176 0.0
esp32 all-clusters-app c3devkit (read only) 1002366 1002480 114 0.0
(read/write) 1479362 1479450 88 0.0
.dram0.bss 69416 69416 0 0.0
.dram0.data 14640 14640 0 0.0
.flash.rodata 209872 209960 88 0.0
.flash.text 1002366 1002480 114 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1057635 1057771 136 0.0
(read/write) 481616 481696 80 0.0
.dram0.bss 74944 74944 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 240468 240548 80 0.0
.flash.text 1052251 1052387 136 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 680892 681004 112 0.0
.bss 80440 80440 0 0.0
.data 2008 2008 0 0.0
.text 596740 596852 112 0.0
lock k32w061+release (read/write) 732232 732392 160 0.0
.bss 80872 80872 0 0.0
.data 1976 1976 0 0.0
.text 647680 647840 160 0.0
linux all-clusters-app debug (read only) 2751465 2751577 112 0.0
(read/write) 178336 178336 0 0.0
.bss 86528 86528 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83608 83608 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 242205 242397 192 0.1
.text 2335666 2335586 -80 -0.0
bridge-app debug+rpc (read only) 2024001 2024113 112 0.0
(read/write) 148024 148024 0 0.0
.bss 73184 73184 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65320 65320 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 168256 168448 192 0.1
.text 1699586 1699506 -80 -0.0
chip-tool debug (read only) 9680229 9680437 208 0.0
(read/write) 602512 602512 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 571136 571136 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 497213 497309 96 0.0
.text 7790373 7790485 112 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9423772 9423948 176 0.0
(read/write) 668833 668833 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 606528 606528 0 0.0
.dynamic 560 560 0 0.0
.got 15024 15024 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 460916 460996 80 0.0
.text 7434724 7434820 96 0.0
lighting-app debug+rpc (read only) 2314385 2314481 96 0.0
(read/write) 153632 153632 0 0.0
.bss 75008 75008 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70824 70824 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 186952 187144 192 0.1
.text 1962066 1961970 -96 -0.0
lock-app debug (read only) 2253497 2253593 96 0.0
(read/write) 148728 148728 0 0.0
.bss 73696 73696 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67752 67752 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 200328 200520 192 0.1
.text 1893234 1893138 -96 -0.0
ota-provider-app debug (read only) 2066657 2066881 224 0.0
(read/write) 141456 141456 0 0.0
.bss 73056 73056 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60824 60824 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 179960 180120 160 0.1
.text 1728130 1728194 64 0.0
ota-requestor-app debug (read only) 2095873 2095985 112 0.0
(read/write) 144296 144296 0 0.0
.bss 73760 73760 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 62920 62920 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 175968 176160 192 0.1
.text 1759874 1759794 -80 -0.0
shell debug (read only) 2555825 2555921 96 0.0
(read/write) 201840 201840 0 0.0
.bss 117448 117448 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222386 222578 192 0.1
.text 2174354 2174258 -96 -0.0
thermostat-no-ble arm64 (read only) 2359836 2360028 192 0.0
(read/write) 177585 177585 0 0.0
.bss 88209 88209 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 80008 80008 0 0.0
.dynamic 560 560 0 0.0
.got 4808 4808 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147532 147692 160 0.1
.text 1982960 1982992 32 0.0
tv-app debug (read only) 2875169 2875329 160 0.0
(read/write) 280464 280464 0 0.0
.bss 191368 191368 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78152 78152 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221888 222080 192 0.1
.text 2470866 2470834 -32 -0.0
tv-casting-app debug (read only) 5426113 5426257 144 0.0
(read/write) 226160 226160 0 0.0
.bss 78952 78952 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138576 138576 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339136 339360 224 0.1
.text 4728082 4728002 -80 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2423968 2424632 664 0.0
.bss 202892 202892 0 0.0
.data 5872 5872 0 0.0
.text 1386612 1387276 664 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183439 1183619 180 0.0
bss 139552 139552 0 0.0
rodata 153112 153196 84 0.1
text 811892 811988 96 0.0
p6 all-clusters-app default (read/write) 2536808 2536992 184 0.0
.bss 137376 137376 0 0.0
.data 2800 2800 0 0.0
.text 1495072 1495256 184 0.0
light-app default (read/write) 2420080 2420264 184 0.0
.bss 129712 129712 0 0.0
.data 2600 2600 0 0.0
.text 1378344 1378528 184 0.0
lock-app default (read/write) 2438112 2438288 176 0.0
.bss 129520 129520 0 0.0
.data 2568 2568 0 0.0
.text 1396376 1396552 176 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779588 779776 188 0.0
bss 70840 70840 0 0.0
noinit 40416 40416 0 0.0
text 551262 551368 106 0.0
lighting-app tlsr9518adk80d (read/write) 799612 799808 196 0.0
bss 71100 71100 0 0.0
noinit 40416 40416 0 0.0
text 567996 568102 106 0.0

@github-actions
Copy link

github-actions bot commented May 27, 2022 •
edited
Loading

PR #18861: Size comparison from d2a6470 to d033038

Increases (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d2a6470 d033038 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 645135 645295 160 0.0
.rodata 83783 83863 80 0.1
.text 561116 561196 80 0.0
lock-ftd LP_CC2652R7 (read only) 679435 679619 184 0.0
.rodata 96075 96163 88 0.1
.text 582876 582972 96 0.0
lock-mtd LP_CC2652R7 (read only) 628843 629027 184 0.0
.rodata 95955 96043 88 0.1
.text 532396 532492 96 0.0
pump-app LP_CC2652R7 (read only) 675863 676031 168 0.0
.rodata 88551 88639 88 0.1
.text 586828 586908 80 0.0
pump-controller-app LP_CC2652R7 (read only) 653791 653967 176 0.0
.rodata 83295 83375 80 0.1
.text 570016 570112 96 0.0
shell LP_CC2652R7 (read only) 638142 638326 184 0.0
.rodata 80758 80846 88 0.1
.text 557152 557248 96 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621662 621838 176 0.0
.app_xip_area 524928 525104 176 0.0
lock cyw930739m2evb_01 (read/write) 630370 630546 176 0.0
.app_xip_area 535108 535284 176 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570758 570910 152 0.0
.app_xip_area 465816 465968 152 0.0
efr32 lighting-app BRD4161A (read only) 914152 914344 192 0.0
.text 914144 914336 192 0.0
BRD4161A+rpc (read only) 948324 948564 240 0.0
.text 948316 948556 240 0.0
BRD4161A+rs911x (read only) 788724 788908 184 0.0
.text 788716 788900 184 0.0
lock-app BRD4161A+wf200 (read only) 954012 954188 176 0.0
.text 954004 954180 176 0.0
window-app BRD4161A (read only) 899096 899272 176 0.0
.text 899088 899264 176 0.0
esp32 all-clusters-app c3devkit (read only) 1002366 1002480 114 0.0
(read/write) 1479362 1479450 88 0.0
.flash.rodata 209872 209960 88 0.0
.flash.text 1002366 1002480 114 0.0
m5stack (read only) 1057635 1057771 136 0.0
(read/write) 481616 481696 80 0.0
.flash.rodata 240468 240548 80 0.0
.flash.text 1052251 1052387 136 0.0
k32w light k32w061+release (read/write) 680892 681004 112 0.0
.text 596740 596852 112 0.0
lock k32w061+release (read/write) 732232 732392 160 0.0
.text 647680 647840 160 0.0
linux all-clusters-app debug (read only) 2751465 2751577 112 0.0
.rodata 242205 242397 192 0.1
bridge-app debug+rpc (read only) 2024001 2024113 112 0.0
.rodata 168256 168448 192 0.1
chip-tool debug (read only) 9680229 9680437 208 0.0
.rodata 497213 497309 96 0.0
.text 7790373 7790485 112 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9423772 9423948 176 0.0
.rodata 460916 460996 80 0.0
.text 7434724 7434820 96 0.0
lighting-app debug+rpc (read only) 2314385 2314481 96 0.0
.rodata 186952 187144 192 0.1
lock-app debug (read only) 2253497 2253593 96 0.0
.rodata 200328 200520 192 0.1
ota-provider-app debug (read only) 2066657 2066881 224 0.0
.rodata 179960 180120 160 0.1
.text 1728130 1728194 64 0.0
ota-requestor-app debug (read only) 2095873 2095985 112 0.0
.rodata 175968 176160 192 0.1
shell debug (read only) 2555825 2555921 96 0.0
.rodata 222386 222578 192 0.1
thermostat-no-ble arm64 (read only) 2359836 2360028 192 0.0
.rodata 147532 147692 160 0.1
.text 1982960 1982992 32 0.0
tv-app debug (read only) 2875169 2875329 160 0.0
.rodata 221888 222080 192 0.1
tv-casting-app debug (read only) 5426113 5426257 144 0.0
.rodata 339136 339360 224 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2423968 2424632 664 0.0
.text 1386612 1387276 664 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183439 1183619 180 0.0
rodata 153112 153196 84 0.1
text 811892 811988 96 0.0
p6 all-clusters-app default (read/write) 2536808 2536992 184 0.0
.text 1495072 1495256 184 0.0
light-app default (read/write) 2420080 2420264 184 0.0
.text 1378344 1378528 184 0.0
lock-app default (read/write) 2438112 2438288 176 0.0
.text 1396376 1396552 176 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779588 779776 188 0.0
text 551262 551368 106 0.0
lighting-app tlsr9518adk80d (read/write) 799612 799808 196 0.0
text 567996 568102 106 0.0
Decreases (11 builds for cc13x2_26x2, linux)
platform target config section d2a6470 d033038 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 163660 163476 -184 -0.1
pump-app LP_CC2652R7 (read/write) 168400 168232 -168 -0.1
pump-controller-app LP_CC2652R7 (read/write) 190328 190152 -176 -0.1
linux all-clusters-app debug .text 2335666 2335586 -80 -0.0
bridge-app debug+rpc .text 1699586 1699506 -80 -0.0
lighting-app debug+rpc .text 1962066 1961970 -96 -0.0
lock-app debug .text 1893234 1893138 -96 -0.0
ota-requestor-app debug .text 1759874 1759794 -80 -0.0
shell debug .text 2174354 2174258 -96 -0.0
tv-app debug .text 2470866 2470834 -32 -0.0
tv-casting-app debug .text 4728082 4728002 -80 -0.0
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d2a6470 d033038 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 645135 645295 160 0.0
(read/write) 159168 159168 0 0.0
.bss 74852 74852 0 0.0
.data 3400 3400 0 0.0
.rodata 83783 83863 80 0.1
.text 561116 561196 80 0.0
lock-ftd LP_CC2652R7 (read only) 679435 679619 184 0.0
(read/write) 163660 163476 -184 -0.1
.bss 72876 72876 0 0.0
.data 3264 3264 0 0.0
.rodata 96075 96163 88 0.1
.text 582876 582972 96 0.0
lock-mtd LP_CC2652R7 (read only) 628843 629027 184 0.0
(read/write) 145992 145992 0 0.0
.bss 68612 68612 0 0.0
.data 3264 3264 0 0.0
.rodata 95955 96043 88 0.1
.text 532396 532492 96 0.0
pump-app LP_CC2652R7 (read only) 675863 676031 168 0.0
(read/write) 168400 168232 -168 -0.1
.bss 73276 73276 0 0.0
.data 3300 3300 0 0.0
.rodata 88551 88639 88 0.1
.text 586828 586908 80 0.0
pump-controller-app LP_CC2652R7 (read only) 653791 653967 176 0.0
(read/write) 190328 190152 -176 -0.1
.bss 73132 73132 0 0.0
.data 3260 3260 0 0.0
.rodata 83295 83375 80 0.1
.text 570016 570112 96 0.0
shell LP_CC2652R7 (read only) 638142 638326 184 0.0
(read/write) 154724 154724 0 0.0
.bss 77204 77204 0 0.0
.data 3404 3404 0 0.0
.rodata 80758 80846 88 0.1
.text 557152 557248 96 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621662 621838 176 0.0
.app_xip_area 524928 525104 176 0.0
.bss 79376 79376 0 0.0
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630370 630546 176 0.0
.app_xip_area 535108 535284 176 0.0
.bss 77936 77936 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570758 570910 152 0.0
.app_xip_area 465816 465968 152 0.0
.bss 87296 87296 0 0.0
.data 612 612 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914152 914344 192 0.0
(read/write) 133464 133464 0 0.0
.bss 131368 131368 0 0.0
.data 2092 2092 0 0.0
.text 914144 914336 192 0.0
BRD4161A+rpc (read only) 948324 948564 240 0.0
(read/write) 150152 150152 0 0.0
.bss 147856 147856 0 0.0
.data 2296 2296 0 0.0
.text 948316 948556 240 0.0
BRD4161A+rs911x (read only) 788724 788908 184 0.0
(read/write) 129736 129736 0 0.0
.bss 127636 127636 0 0.0
.data 2100 2100 0 0.0
.text 788716 788900 184 0.0
lock-app BRD4161A+wf200 (read only) 954012 954188 176 0.0
(read/write) 128508 128508 0 0.0
.bss 126444 126444 0 0.0
.data 2064 2064 0 0.0
.text 954004 954180 176 0.0
window-app BRD4161A (read only) 899096 899272 176 0.0
(read/write) 133520 133520 0 0.0
.bss 131432 131432 0 0.0
.data 2088 2088 0 0.0
.text 899088 899264 176 0.0
esp32 all-clusters-app c3devkit (read only) 1002366 1002480 114 0.0
(read/write) 1479362 1479450 88 0.0
.dram0.bss 69416 69416 0 0.0
.dram0.data 14640 14640 0 0.0
.flash.rodata 209872 209960 88 0.0
.flash.text 1002366 1002480 114 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1057635 1057771 136 0.0
(read/write) 481616 481696 80 0.0
.dram0.bss 74944 74944 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 240468 240548 80 0.0
.flash.text 1052251 1052387 136 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 680892 681004 112 0.0
.bss 80440 80440 0 0.0
.data 2008 2008 0 0.0
.text 596740 596852 112 0.0
lock k32w061+release (read/write) 732232 732392 160 0.0
.bss 80872 80872 0 0.0
.data 1976 1976 0 0.0
.text 647680 647840 160 0.0
linux all-clusters-app debug (read only) 2751465 2751577 112 0.0
(read/write) 178336 178336 0 0.0
.bss 86528 86528 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83608 83608 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 242205 242397 192 0.1
.text 2335666 2335586 -80 -0.0
bridge-app debug+rpc (read only) 2024001 2024113 112 0.0
(read/write) 148024 148024 0 0.0
.bss 73184 73184 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65320 65320 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 168256 168448 192 0.1
.text 1699586 1699506 -80 -0.0
chip-tool debug (read only) 9680229 9680437 208 0.0
(read/write) 602512 602512 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 571136 571136 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 497213 497309 96 0.0
.text 7790373 7790485 112 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9423772 9423948 176 0.0
(read/write) 668833 668833 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 606528 606528 0 0.0
.dynamic 560 560 0 0.0
.got 15024 15024 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 460916 460996 80 0.0
.text 7434724 7434820 96 0.0
lighting-app debug+rpc (read only) 2314385 2314481 96 0.0
(read/write) 153632 153632 0 0.0
.bss 75008 75008 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70824 70824 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 186952 187144 192 0.1
.text 1962066 1961970 -96 -0.0
lock-app debug (read only) 2253497 2253593 96 0.0
(read/write) 148728 148728 0 0.0
.bss 73696 73696 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67752 67752 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 200328 200520 192 0.1
.text 1893234 1893138 -96 -0.0
ota-provider-app debug (read only) 2066657 2066881 224 0.0
(read/write) 141456 141456 0 0.0
.bss 73056 73056 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60824 60824 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 179960 180120 160 0.1
.text 1728130 1728194 64 0.0
ota-requestor-app debug (read only) 2095873 2095985 112 0.0
(read/write) 144296 144296 0 0.0
.bss 73760 73760 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 62920 62920 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 175968 176160 192 0.1
.text 1759874 1759794 -80 -0.0
shell debug (read only) 2555825 2555921 96 0.0
(read/write) 201840 201840 0 0.0
.bss 117448 117448 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222386 222578 192 0.1
.text 2174354 2174258 -96 -0.0
thermostat-no-ble arm64 (read only) 2359836 2360028 192 0.0
(read/write) 177585 177585 0 0.0
.bss 88209 88209 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 80008 80008 0 0.0
.dynamic 560 560 0 0.0
.got 4808 4808 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147532 147692 160 0.1
.text 1982960 1982992 32 0.0
tv-app debug (read only) 2875169 2875329 160 0.0
(read/write) 280464 280464 0 0.0
.bss 191368 191368 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78152 78152 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221888 222080 192 0.1
.text 2470866 2470834 -32 -0.0
tv-casting-app debug (read only) 5426113 5426257 144 0.0
(read/write) 226160 226160 0 0.0
.bss 78952 78952 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138576 138576 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339136 339360 224 0.1
.text 4728082 4728002 -80 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2423968 2424632 664 0.0
.bss 202892 202892 0 0.0
.data 5872 5872 0 0.0
.text 1386612 1387276 664 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183439 1183619 180 0.0
bss 139552 139552 0 0.0
rodata 153112 153196 84 0.1
text 811892 811988 96 0.0
p6 all-clusters-app default (read/write) 2536808 2536992 184 0.0
.bss 137376 137376 0 0.0
.data 2800 2800 0 0.0
.text 1495072 1495256 184 0.0
light-app default (read/write) 2420080 2420264 184 0.0
.bss 129712 129712 0 0.0
.data 2600 2600 0 0.0
.text 1378344 1378528 184 0.0
lock-app default (read/write) 2438112 2438288 176 0.0
.bss 129520 129520 0 0.0
.data 2568 2568 0 0.0
.text 1396376 1396552 176 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779588 779776 188 0.0
bss 70840 70840 0 0.0
noinit 40416 40416 0 0.0
text 551262 551368 106 0.0
lighting-app tlsr9518adk80d (read/write) 799612 799808 196 0.0
bss 71100 71100 0 0.0
noinit 40416 40416 0 0.0
text 567996 568102 106 0.0

@tcarmelveilleux tcarmelveilleux merged commit 7b2f01f into project-chip:master May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cecille cecille cecille left review comments

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller darwin examples github review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@HodgertA @CLAassistant @tcarmelveilleux @cecille @bzbarsky-apple @restyled-commits