-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better documentation for chip-tool "any" reporting commands. #18717
Merged
Damian-Nordic
merged 1 commit into
project-chip:master
from
bzbarsky-apple:better-docs-report-commands
May 23, 2022
Merged
Better documentation for chip-tool "any" reporting commands. #18717
Damian-Nordic
merged 1 commit into
project-chip:master
from
bzbarsky-apple:better-docs-report-commands
May 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not widely known that these commands support multi-path read/subscribe or how wildcards work.
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
rgoliver
May 22, 2022 18:10
pullapprove
bot
requested review from
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
May 22, 2022 18:10
PR #18717: Size comparison from b36b8eb to 07b4b13 Increases above 0.2%:
Increases (2 builds for linux)
Decreases (2 builds for linux)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
arkq
approved these changes
May 23, 2022
yunhanw-google
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not widely known that these commands support multi-path
read/subscribe or how wildcards work.
Problem
People being confused about how to do multi-path reads and the like.
Change overview
Add documentation.
Testing
Ran some read/subscribe commands with invalid args to see the help text.