Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QRCode tests to tasks.json and launch.json to run them in VSCode #187

Merged
merged 3 commits into from
Apr 1, 2020
Merged

Add QRCode tests to tasks.json and launch.json to run them in VSCode #187

merged 3 commits into from
Apr 1, 2020

Conversation

bhaskar-apple
Copy link
Contributor

Problem

Add QRCode tests to tasks.json and launch.json

Summary of Changes

Updates tasks.json and launch.json to enable running them in VSCode.

@bhaskar-apple
Copy link
Contributor Author

Please refer to this same branch in my fork to check for build status
https://github.com/bhaskar-apple/connectedhomeip/pull/4

bhaskar-apple
bhaskar-apple commented Apr 1, 2020
View reviewed changes
src/setup_payload/QRCodeSetupPayloadParser.cpp
@@ -63,7 +63,6 @@ CHIP_ERROR QRCodeSetupPayloadParser::populatePayload(SetupPayload & outPayload)

if (CHIP_NO_ERROR != result)
{
fprintf(stderr, "Decoding of base45 string failed");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these just add noise to the test output at this point

bhaskar-apple
bhaskar-apple commented Apr 1, 2020
View reviewed changes
src/setup_payload/Base45.cpp
@@ -160,7 +160,6 @@ CHIP_ERROR base45Decode(string base45, vector<uint8_t> & result)
// base45 characters
if (base45.length() % kBase45ChunkLen == 1)
{
fprintf(stderr, "\nFailed decoding base45. Input was too short. %lu", base45.length());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these just add noise to the test output at this point

@woody-apple
Copy link
Contributor

Thanks for an example work flow!

hawk248
hawk248 approved these changes Apr 1, 2020
View reviewed changes
Copy link

@hawk248 hawk248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@woody-apple woody-apple merged commit 6ff9d22 into project-chip:master Apr 1, 2020
@bhaskar-apple bhaskar-apple deleted the BS-QRCodeInDocker branch April 7, 2020 20:32
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request Oct 13, 2022
@rerasool
Pull request project-chip#187: Cherry-Pick "Code savings doc update" …
542a097 
…from silabs to silabs_1.0

Merge in WMN_TOOLS/matter from cherry-pick/update-code-savings-doc to silabs_1.0

Squashed commit of the following:

commit 608b298c73ca252894d824d32287eaa67ca87635
Author: Michael Rupp <[email protected]>
Date:   Tue Oct 11 17:40:18 2022 +0000

    Pull request project-chip#163: Code savings doc PR

    Merge in WMN_TOOLS/matter from code_savings to silabs

    Squashed commit of the following:

    commit 19be88b7ba5d132041170da3735260020b58100f
    Author: Michael Rupp <[email protected]>
    Date:   Tue Oct 11 11:17:17 2022 -0400

        fix relative pathing to lighting lite app

    commit afe599283d0a97a3375cac33905f3527520dbb18
    Author: Michael Rupp <[email protected]>
    Date:   Fri Oct 7 11:29:29 2022 -0400

        Code savings doc PR
nipatel-silabs pushed a commit to nipatel-silabs/connectedhomeip that referenced this pull request Oct 19, 2022
@rerasool
Pull request project-chip#187: Cherry-Pick "Code savings doc update" …
ea9c8ab 
…from silabs to silabs_1.0

Merge in WMN_TOOLS/matter from cherry-pick/update-code-savings-doc to silabs_1.0

Squashed commit of the following:

commit 608b298c73ca252894d824d32287eaa67ca87635
Author: Michael Rupp <[email protected]>
Date:   Tue Oct 11 17:40:18 2022 +0000

    Pull request project-chip#163: Code savings doc PR

    Merge in WMN_TOOLS/matter from code_savings to silabs

    Squashed commit of the following:

    commit 19be88b7ba5d132041170da3735260020b58100f
    Author: Michael Rupp <[email protected]>
    Date:   Tue Oct 11 11:17:17 2022 -0400

        fix relative pathing to lighting lite app

    commit afe599283d0a97a3375cac33905f3527520dbb18
    Author: Michael Rupp <[email protected]>
    Date:   Fri Oct 7 11:29:29 2022 -0400

        Code savings doc PR
mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip Nov 2, 2022
@rerasool @jmartinez-silabs
Pull request #187: Cherry-Pick "Code savings doc update" from silabs …
98152ef 
…to silabs_1.0

Merge in WMN_TOOLS/matter from cherry-pick/update-code-savings-doc to silabs_1.0

Squashed commit of the following:

commit 608b298c73ca252894d824d32287eaa67ca87635
Author: Michael Rupp <[email protected]>
Date:   Tue Oct 11 17:40:18 2022 +0000

    Pull request #163: Code savings doc PR

    Merge in WMN_TOOLS/matter from code_savings to silabs

    Squashed commit of the following:

    commit 19be88b7ba5d132041170da3735260020b58100f
    Author: Michael Rupp <[email protected]>
    Date:   Tue Oct 11 11:17:17 2022 -0400

        fix relative pathing to lighting lite app

    commit afe599283d0a97a3375cac33905f3527520dbb18
    Author: Michael Rupp <[email protected]>
    Date:   Fri Oct 7 11:29:29 2022 -0400

        Code savings doc PR
rerasool added a commit to SiliconLabs/matter that referenced this pull request Nov 2, 2022
@rerasool @jmartinez-silabs
Pull request project-chip#187: Cherry-Pick "Code savings doc update" …
490f05c 
…from silabs to silabs_1.0

Merge in WMN_TOOLS/matter from cherry-pick/update-code-savings-doc to silabs_1.0

Squashed commit of the following:

commit 608b298c73ca252894d824d32287eaa67ca87635
Author: Michael Rupp <[email protected]>
Date:   Tue Oct 11 17:40:18 2022 +0000

    Pull request project-chip#163: Code savings doc PR

    Merge in WMN_TOOLS/matter from code_savings to silabs

    Squashed commit of the following:

    commit 19be88b7ba5d132041170da3735260020b58100f
    Author: Michael Rupp <[email protected]>
    Date:   Tue Oct 11 11:17:17 2022 -0400

        fix relative pathing to lighting lite app

    commit afe599283d0a97a3375cac33905f3527520dbb18
    Author: Michael Rupp <[email protected]>
    Date:   Fri Oct 7 11:29:29 2022 -0400

        Code savings doc PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwalker-apple rwalker-apple rwalker-apple left review comments

@woody-apple woody-apple woody-apple approved these changes

@BroderickCarlin BroderickCarlin BroderickCarlin left review comments

@gerickson gerickson gerickson approved these changes

@hawk248 hawk248 hawk248 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@tpmanley tpmanley Awaiting requested review from tpmanley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bhaskar-apple @woody-apple @gerickson @hawk248 @BroderickCarlin @rwalker-apple @Bhaskar-Sarma