Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chip-tool-darwin] Fix ignored return values for simulated clusters #18428

Conversation

vivien-apple
Copy link
Contributor

Problem

The error return code of simulated clusters in chip-tool-darwin is ignored...

Change overview

  • Use the returned error code

Note: This is on top of #18383

@vivien-apple vivien-apple self-assigned this May 13, 2022
@bzbarsky-apple
Copy link
Contributor

Fast tracking test-only Darwin-only change.

@github-actions
Copy link

github-actions bot commented May 13, 2022

PR #18428: Size comparison from 5cb6777 to 5f01089

Full report (25 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 5cb6777 5f01089 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 691059 691059 0 0.0
(read/write) 161292 161292 0 0.0
.bss 75332 75332 0 0.0
.data 3412 3412 0 0.0
.rodata 103083 103083 0 0.0
.text 587492 587492 0 0.0
lock-ftd LP_CC2652R7 (read only) 678499 678499 0 0.0
(read/write) 164956 164956 0 0.0
.bss 73492 73492 0 0.0
.data 3236 3236 0 0.0
.rodata 94803 94803 0 0.0
.text 583216 583216 0 0.0
lock-mtd LP_CC2652R7 (read only) 627251 627251 0 0.0
(read/write) 146308 146308 0 0.0
.bss 69212 69212 0 0.0
.data 3236 3236 0 0.0
.rodata 94691 94691 0 0.0
.text 532072 532072 0 0.0
pump-app LP_CC2652R7 (read only) 663071 663071 0 0.0
(read/write) 181672 181672 0 0.0
.bss 73756 73756 0 0.0
.data 3268 3268 0 0.0
.rodata 80991 80991 0 0.0
.text 581596 581596 0 0.0
pump-controller-app LP_CC2652R7 (read only) 656263 656263 0 0.0
(read/write) 188280 188280 0 0.0
.bss 73812 73812 0 0.0
.data 3232 3232 0 0.0
.rodata 84087 84087 0 0.0
.text 571692 571692 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 627598 627598 0 0.0
.app_xip_area 530188 530188 0 0.0
.bss 80052 80052 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 626534 626534 0 0.0
.app_xip_area 530580 530580 0 0.0
.bss 78628 78628 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575302 575302 0 0.0
.app_xip_area 469632 469632 0 0.0
.bss 88048 88048 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 909984 909984 0 0.0
(read/write) 134520 134520 0 0.0
.bss 132456 132456 0 0.0
.data 2064 2064 0 0.0
.text 909976 909976 0 0.0
BRD4161A+rpc (read only) 944328 944328 0 0.0
(read/write) 151208 151208 0 0.0
.bss 148936 148936 0 0.0
.data 2268 2268 0 0.0
.text 944320 944320 0 0.0
BRD4161A+rs911x (read only) 787724 787724 0 0.0
(read/write) 129776 129776 0 0.0
.bss 127708 127708 0 0.0
.data 2068 2068 0 0.0
.text 787716 787716 0 0.0
lock-app BRD4161A+wf200 (read only) 946816 946816 0 0.0
(read/write) 124268 124268 0 0.0
.bss 122244 122244 0 0.0
.data 2024 2024 0 0.0
.text 946808 946808 0 0.0
window-app BRD4161A (read only) 890288 890288 0 0.0
(read/write) 134472 134472 0 0.0
.bss 132416 132416 0 0.0
.data 2052 2052 0 0.0
.text 890280 890280 0 0.0
esp32 all-clusters-app c3devkit (read only) 999828 999828 0 0.0
(read/write) 1477138 1477138 0 0.0
.dram0.bss 68472 68472 0 0.0
.dram0.data 14568 14568 0 0.0
.flash.rodata 208616 208616 0 0.0
.flash.text 999828 999828 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1053755 1053755 0 0.0
(read/write) 479040 479040 0 0.0
.dram0.bss 73992 73992 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 238868 238868 0 0.0
.flash.text 1048371 1048371 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 685148 685148 0 0.0
.bss 81248 81248 0 0.0
.data 2020 2020 0 0.0
.text 600176 600176 0 0.0
lock k32w061+release (read/write) 730492 730492 0 0.0
.bss 81680 81680 0 0.0
.data 1980 1980 0 0.0
.text 645128 645128 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9020596 9020596 0 0.0
(read/write) 643121 643121 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582008 582008 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 439236 439236 0 0.0
.text 7121828 7121828 0 0.0
thermostat-no-ble arm64 (read only) 2370244 2370244 0 0.0
(read/write) 175153 175153 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79408 79408 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146980 146980 0 0.0
.text 1993376 1993376 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420356 2420356 0 0.0
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1382956 1382956 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180271 1180271 0 0.0
bss 139680 139680 0 0.0
rodata 151792 151792 0 0.0
text 809956 809956 0 0.0
p6 all-clusters-app default (read/write) 2531960 2531960 0 0.0
.bss 139328 139328 0 0.0
.data 2808 2808 0 0.0
.text 1490224 1490224 0 0.0
light-app default (read/write) 2422016 2422016 0 0.0
.bss 132656 132656 0 0.0
.data 2608 2608 0 0.0
.text 1380280 1380280 0 0.0
lock-app default (read/write) 2431544 2431544 0 0.0
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1389808 1389808 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 806528 806528 0 0.0
bss 72176 72176 0 0.0
noinit 40416 40416 0 0.0
text 572768 572768 0 0.0

@vivien-apple vivien-apple merged commit 46f5178 into project-chip:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants