-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Content Launcher to android tv-casting-app #18356
Merged
chrisdecenzo
merged 1 commit into
project-chip:master
from
sharadb-amazon:droid-20220511
May 13, 2022
Merged
Added Content Launcher to android tv-casting-app #18356
chrisdecenzo
merged 1 commit into
project-chip:master
from
sharadb-amazon:droid-20220511
May 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel and
LuDuda
May 12, 2022 02:36
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
rgoliver,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
May 12, 2022 02:36
PR #18356: Size comparison from f59dbe1 to 8a47a1b Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
chrisdecenzo
approved these changes
May 12, 2022
hawk248
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Android tv-casting-app did not have an implementation for sending the ContentLauncher:LaunchURL matter command. See #14558
Change overview
1.Added ContentLauncherFragment and Content Launch page
2. Added JNI layer method for ContentLauncherLaunchURL.
3. Added Callback mechanism in the CastingServer to call linux/android/iOS tv-casting-apps when commissioning completes (similar mechanism will be used for other callbacks in the future).
4. Implemented handlers for the above callback in the Linux and Android tv-casting-apps.
5. In Linux, the handler simply calls CastingServer.ContentLauncherLaunchURL(). On Android, the app transitions to the next screen i.e. the Content Launch page which lets the user enter a Video URL/display title before calling CastingServer.ContentLauncherLaunchURL().
Testing
Built and deployed the Android tv-casting-app on an Android phone.