-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop having Darwin CHIPTool depend on in-framework key generation. #18221
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:CHIPTool-keys
May 9, 2022
Merged
Stop having Darwin CHIPTool depend on in-framework key generation. #18221
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:CHIPTool-keys
May 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel and
lazarkov
May 9, 2022 18:36
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
May 9, 2022 18:36
bzbarsky-apple
force-pushed
the
CHIPTool-keys
branch
from
May 9, 2022 18:40
8461569
to
099afa9
Compare
PR #18221: Size comparison from c880e28 to 099afa9 Full report (13 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
|
Allows us to remove the in-framework key generation bits.
bzbarsky-apple
force-pushed
the
CHIPTool-keys
branch
from
May 9, 2022 19:24
099afa9
to
52fa0aa
Compare
PR #18221: Size comparison from b1a0c94 to 52fa0aa Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
sagar-apple
approved these changes
May 9, 2022
Fast-tracking Darwin-only changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to remove the in-framework key generation bits.
Problem
Darwin CHIPTool is relying on key generation happening inside the Darwin framework. This is the last consumer to do so.
Change overview
Move the key generation outside the framework.
Testing
Unit tests pass, tree compiles. I tested that I can use Darwin CHIPTool to commission a device, then can control it, then can restart Darwin CHIPTool and it can still control the device.