Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support of Authorized PAA List to the Certification Declaration Structure #18062

Merged
merged 1 commit into from
May 6, 2022
Merged

Add Support of Authorized PAA List to the Certification Declaration Structure #18062

merged 1 commit into from
May 6, 2022

Conversation

emargolis
Copy link
Contributor

Problem

Current SDK implementation doesn't support AuthorizedPAAList elements to the Certification Declaration APIs.

Change overview

Added Support

Testing

Existing tests and added new tests

@github-actions
Copy link

github-actions bot commented May 4, 2022 •
edited
Loading

PR #18062: Size comparison from a932e78 to a15c8d6

Increases above 0.2%:

platform target config section a932e78 a15c8d6 change % change
linux all-clusters-app debug .bss 83488 83712 224 0.3
Increases (5 builds for linux)
platform target config section a932e78 a15c8d6 change % change
linux all-clusters-app debug (read/write) 173432 173656 224 0.1
.bss 83488 83712 224 0.3
chip-tool debug (read only) 8980533 8980693 160 0.0
.text 7193477 7193637 160 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8820404 8820532 128 0.0
.text 6930292 6930452 160 0.0
lock-app debug (read only) 2228513 2228529 16 0.0
.text 1874306 1874322 16 0.0
tv-app debug (read only) 2844753 2844929 176 0.0
.text 2445378 2445554 176 0.0
Decreases (1 build for linux)
platform target config section a932e78 a15c8d6 change % change
linux chip-tool-no-interactive-ipv6only arm64 (read/write) 642833 642817 -16 -0.0
.data.rel.ro 581760 581736 -24 -0.0
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a932e78 a15c8d6 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689319 689319 0 0.0
(read/write) 162880 162880 0 0.0
.bss 75180 75180 0 0.0
.data 3412 3412 0 0.0
.rodata 102127 102127 0 0.0
.text 586708 586708 0 0.0
lock-ftd LP_CC2652R7 (read only) 677203 677203 0 0.0
(read/write) 166244 166244 0 0.0
.bss 73484 73484 0 0.0
.data 3236 3236 0 0.0
.rodata 94195 94195 0 0.0
.text 582528 582528 0 0.0
lock-mtd LP_CC2652R7 (read only) 625947 625947 0 0.0
(read/write) 146300 146300 0 0.0
.bss 69204 69204 0 0.0
.data 3236 3236 0 0.0
.rodata 94083 94083 0 0.0
.text 531376 531376 0 0.0
pump-app LP_CC2652R7 (read only) 661891 661891 0 0.0
(read/write) 182852 182852 0 0.0
.bss 73756 73756 0 0.0
.data 3268 3268 0 0.0
.rodata 80387 80387 0 0.0
.text 581020 581020 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654823 654823 0 0.0
(read/write) 189720 189720 0 0.0
.bss 73812 73812 0 0.0
.data 3232 3232 0 0.0
.rodata 83343 83343 0 0.0
.text 570996 570996 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626502 626502 0 0.0
.app_xip_area 529092 529092 0 0.0
.bss 80052 80052 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 625214 625214 0 0.0
.app_xip_area 529268 529268 0 0.0
.bss 78620 78620 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574738 574738 0 0.0
.app_xip_area 469076 469076 0 0.0
.bss 88040 88040 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 909032 909032 0 0.0
(read/write) 134520 134520 0 0.0
.bss 132456 132456 0 0.0
.data 2064 2064 0 0.0
.text 909024 909024 0 0.0
BRD4161A+rpc (read only) 943392 943392 0 0.0
(read/write) 151208 151208 0 0.0
.bss 148936 148936 0 0.0
.data 2268 2268 0 0.0
.text 943384 943384 0 0.0
BRD4161A+rs911x (read only) 747252 747252 0 0.0
(read/write) 128700 128700 0 0.0
.bss 126708 126708 0 0.0
.data 1992 1992 0 0.0
.text 747244 747244 0 0.0
lock-app BRD4161A+wf200 (read only) 916908 916908 0 0.0
(read/write) 127480 127480 0 0.0
.bss 125532 125532 0 0.0
.data 1948 1948 0 0.0
.text 916900 916900 0 0.0
window-app BRD4161A (read only) 846296 846296 0 0.0
(read/write) 132608 132608 0 0.0
.bss 130632 130632 0 0.0
.data 1976 1976 0 0.0
.text 846288 846288 0 0.0
esp32 all-clusters-app c3devkit (read only) 1000234 1000234 0 0.0
(read/write) 1474338 1474338 0 0.0
.dram0.bss 68320 68320 0 0.0
.dram0.data 14444 14444 0 0.0
.flash.rodata 207128 207128 0 0.0
.flash.text 1000234 1000234 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1055375 1055375 0 0.0
(read/write) 476760 476760 0 0.0
.dram0.bss 73832 73832 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 236908 236908 0 0.0
.flash.text 1049991 1049991 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684496 684496 0 0.0
.bss 81248 81248 0 0.0
.data 2020 2020 0 0.0
.text 599524 599524 0 0.0
lock k32w061+release (read/write) 729176 729176 0 0.0
.bss 81680 81680 0 0.0
.data 1980 1980 0 0.0
.text 643812 643812 0 0.0
linux all-clusters-app debug (read only) 2732841 2732841 0 0.0
(read/write) 173432 173656 224 0.1
.bss 83488 83712 224 0.3
.data 2064 2064 0 0.0
.data.rel.ro 81752 81752 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 235269 235269 0 0.0
.text 2323090 2323090 0 0.0
bridge-app debug+rpc (read only) 1888177 1888177 0 0.0
(read/write) 120728 120728 0 0.0
.bss 71488 71488 0 0.0
.data 3488 3488 0 0.0
.data.rel.ro 40408 40408 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 160513 160513 0 0.0
.text 1605410 1605410 0 0.0
chip-tool debug (read only) 8980533 8980693 160 0.0
(read/write) 576720 576720 0 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546496 546496 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 463861 463861 0 0.0
.text 7193477 7193637 160 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8820404 8820532 128 0.0
(read/write) 642833 642817 -16 -0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 581760 581736 -24 -0.0
.dynamic 560 560 0 0.0
.got 14960 14960 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 431572 431572 0 0.0
.text 6930292 6930452 160 0.0
lighting-app debug+rpc (read only) 2322313 2322313 0 0.0
(read/write) 151648 151648 0 0.0
.bss 73536 73536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70328 70328 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 184713 184713 0 0.0
.text 1971490 1971490 0 0.0
lock-app debug (read only) 2228513 2228529 16 0.0
(read/write) 146264 146264 0 0.0
.bss 72160 72160 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 66856 66856 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 194449 194449 0 0.0
.text 1874306 1874322 16 0.0
ota-provider-app debug (read only) 2058009 2058009 0 0.0
(read/write) 139376 139376 0 0.0
.bss 71648 71648 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 60200 60200 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 175451 175451 0 0.0
.text 1725266 1725266 0 0.0
ota-requestor-app debug (read only) 2089065 2089065 0 0.0
(read/write) 142184 142184 0 0.0
.bss 72288 72288 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62280 62280 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171724 171724 0 0.0
.text 1758562 1758562 0 0.0
shell debug (read only) 2557849 2557849 0 0.0
(read/write) 197328 197328 0 0.0
.bss 114216 114216 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76016 76016 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 216754 216754 0 0.0
.text 2179714 2179714 0 0.0
thermostat-no-ble arm64 (read only) 2363852 2363852 0 0.0
(read/write) 174801 174801 0 0.0
.bss 86401 86401 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79096 79096 0 0.0
.dynamic 560 560 0 0.0
.got 4752 4752 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 145980 145980 0 0.0
.text 1988864 1988864 0 0.0
tv-app debug (read only) 2844753 2844929 176 0.0
(read/write) 276960 276960 0 0.0
.bss 189432 189432 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 76632 76632 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 217323 217323 0 0.0
.text 2445378 2445554 176 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418460 2418460 0 0.0
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1381060 1381060 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1178019 1178019 0 0.0
bss 139532 139532 0 0.0
rodata 150692 150692 0 0.0
text 809064 809064 0 0.0
p6 all-clusters-app default (read/write) 2529280 2529280 0 0.0
.bss 139184 139184 0 0.0
.data 2808 2808 0 0.0
.text 1487544 1487544 0 0.0
light-app default (read/write) 2419856 2419856 0 0.0
.bss 132648 132648 0 0.0
.data 2608 2608 0 0.0
.text 1378120 1378120 0 0.0
lock-app default (read/write) 2429136 2429136 0 0.0
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1387400 1387400 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 804820 804820 0 0.0
bss 72172 72172 0 0.0
noinit 40416 40416 0 0.0
text 571796 571796 0 0.0

@github-actions
Copy link

github-actions bot commented May 4, 2022 •
edited
Loading

PR #18062: Size comparison from a932e78 to bb31c14

Increases above 0.2%:

platform target config section a932e78 bb31c14 change % change
linux all-clusters-app debug .bss 83488 83712 224 0.3
Increases (7 builds for cc13x2_26x2, linux)
platform target config section a932e78 bb31c14 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 162880 162920 40 0.0
lock-ftd LP_CC2652R7 (read/write) 166244 166284 40 0.0
pump-app LP_CC2652R7 (read/write) 182852 182892 40 0.0
pump-controller-app LP_CC2652R7 (read/write) 189720 189760 40 0.0
linux all-clusters-app debug (read/write) 173432 173656 224 0.1
.bss 83488 83712 224 0.3
chip-tool debug (read only) 8980533 8980565 32 0.0
.text 7193477 7193509 32 0.0
tv-app debug (read only) 2844753 2844801 48 0.0
.text 2445378 2445426 48 0.0
Decreases (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a932e78 bb31c14 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689319 689279 -40 -0.0
.text 586708 586668 -40 -0.0
lock-ftd LP_CC2652R7 (read only) 677203 677163 -40 -0.0
.text 582528 582488 -40 -0.0
lock-mtd LP_CC2652R7 (read only) 625947 625907 -40 -0.0
.text 531376 531336 -40 -0.0
pump-app LP_CC2652R7 (read only) 661891 661851 -40 -0.0
.text 581020 580980 -40 -0.0
pump-controller-app LP_CC2652R7 (read only) 654823 654783 -40 -0.0
.text 570996 570956 -40 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626502 626462 -40 -0.0
.app_xip_area 529092 529052 -40 -0.0
lock cyw930739m2evb_01 (read/write) 625214 625174 -40 -0.0
.app_xip_area 529268 529228 -40 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574738 574698 -40 -0.0
.app_xip_area 469076 469036 -40 -0.0
efr32 lighting-app BRD4161A (read only) 909032 909000 -32 -0.0
.text 909024 908992 -32 -0.0
BRD4161A+rpc (read only) 943392 943360 -32 -0.0
.text 943384 943352 -32 -0.0
BRD4161A+rs911x (read only) 747252 747220 -32 -0.0
.text 747244 747212 -32 -0.0
lock-app BRD4161A+wf200 (read only) 916908 916876 -32 -0.0
.text 916900 916868 -32 -0.0
window-app BRD4161A (read only) 846296 846264 -32 -0.0
.text 846288 846256 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 1000234 1000196 -38 -0.0
.flash.text 1000234 1000196 -38 -0.0
m5stack (read only) 1055375 1055319 -56 -0.0
.flash.text 1049991 1049935 -56 -0.0
k32w light k32w061+release (read/write) 684496 684448 -48 -0.0
.text 599524 599476 -48 -0.0
lock k32w061+release (read/write) 729176 729128 -48 -0.0
.text 643812 643764 -48 -0.0
linux all-clusters-app debug (read only) 2732841 2732713 -128 -0.0
.text 2323090 2322962 -128 -0.0
bridge-app debug+rpc (read only) 1888177 1888049 -128 -0.0
.text 1605410 1605282 -128 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8820404 8820356 -48 -0.0
(read/write) 642833 642817 -16 -0.0
.data.rel.ro 581760 581736 -24 -0.0
.text 6930292 6930276 -16 -0.0
lighting-app debug+rpc (read only) 2322313 2322185 -128 -0.0
.text 1971490 1971362 -128 -0.0
lock-app debug (read only) 2228513 2228401 -112 -0.0
.text 1874306 1874194 -112 -0.0
ota-provider-app debug (read only) 2058009 2057881 -128 -0.0
.text 1725266 1725138 -128 -0.0
ota-requestor-app debug (read only) 2089065 2088937 -128 -0.0
.text 1758562 1758434 -128 -0.0
shell debug (read only) 2557849 2557721 -128 -0.0
.text 2179714 2179586 -128 -0.0
thermostat-no-ble arm64 (read only) 2363852 2363676 -176 -0.0
.text 1988864 1988688 -176 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2418460 2418284 -176 -0.0
.text 1381060 1380884 -176 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1178019 1177987 -32 -0.0
text 809064 809024 -40 -0.0
p6 all-clusters-app default (read/write) 2529280 2529232 -48 -0.0
.text 1487544 1487496 -48 -0.0
light-app default (read/write) 2419856 2419824 -32 -0.0
.text 1378120 1378088 -32 -0.0
lock-app default (read/write) 2429136 2429104 -32 -0.0
.text 1387400 1387368 -32 -0.0
telink lighting-app tlsr9518adk80d (read/write) 804820 804780 -40 -0.0
text 571796 571758 -38 -0.0
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a932e78 bb31c14 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689319 689279 -40 -0.0
(read/write) 162880 162920 40 0.0
.bss 75180 75180 0 0.0
.data 3412 3412 0 0.0
.rodata 102127 102127 0 0.0
.text 586708 586668 -40 -0.0
lock-ftd LP_CC2652R7 (read only) 677203 677163 -40 -0.0
(read/write) 166244 166284 40 0.0
.bss 73484 73484 0 0.0
.data 3236 3236 0 0.0
.rodata 94195 94195 0 0.0
.text 582528 582488 -40 -0.0
lock-mtd LP_CC2652R7 (read only) 625947 625907 -40 -0.0
(read/write) 146300 146300 0 0.0
.bss 69204 69204 0 0.0
.data 3236 3236 0 0.0
.rodata 94083 94083 0 0.0
.text 531376 531336 -40 -0.0
pump-app LP_CC2652R7 (read only) 661891 661851 -40 -0.0
(read/write) 182852 182892 40 0.0
.bss 73756 73756 0 0.0
.data 3268 3268 0 0.0
.rodata 80387 80387 0 0.0
.text 581020 580980 -40 -0.0
pump-controller-app LP_CC2652R7 (read only) 654823 654783 -40 -0.0
(read/write) 189720 189760 40 0.0
.bss 73812 73812 0 0.0
.data 3232 3232 0 0.0
.rodata 83343 83343 0 0.0
.text 570996 570956 -40 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626502 626462 -40 -0.0
.app_xip_area 529092 529052 -40 -0.0
.bss 80052 80052 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 625214 625174 -40 -0.0
.app_xip_area 529268 529228 -40 -0.0
.bss 78620 78620 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574738 574698 -40 -0.0
.app_xip_area 469076 469036 -40 -0.0
.bss 88040 88040 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 909032 909000 -32 -0.0
(read/write) 134520 134520 0 0.0
.bss 132456 132456 0 0.0
.data 2064 2064 0 0.0
.text 909024 908992 -32 -0.0
BRD4161A+rpc (read only) 943392 943360 -32 -0.0
(read/write) 151208 151208 0 0.0
.bss 148936 148936 0 0.0
.data 2268 2268 0 0.0
.text 943384 943352 -32 -0.0
BRD4161A+rs911x (read only) 747252 747220 -32 -0.0
(read/write) 128700 128700 0 0.0
.bss 126708 126708 0 0.0
.data 1992 1992 0 0.0
.text 747244 747212 -32 -0.0
lock-app BRD4161A+wf200 (read only) 916908 916876 -32 -0.0
(read/write) 127480 127480 0 0.0
.bss 125532 125532 0 0.0
.data 1948 1948 0 0.0
.text 916900 916868 -32 -0.0
window-app BRD4161A (read only) 846296 846264 -32 -0.0
(read/write) 132608 132608 0 0.0
.bss 130632 130632 0 0.0
.data 1976 1976 0 0.0
.text 846288 846256 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 1000234 1000196 -38 -0.0
(read/write) 1474338 1474338 0 0.0
.dram0.bss 68320 68320 0 0.0
.dram0.data 14444 14444 0 0.0
.flash.rodata 207128 207128 0 0.0
.flash.text 1000234 1000196 -38 -0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1055375 1055319 -56 -0.0
(read/write) 476760 476760 0 0.0
.dram0.bss 73832 73832 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 236908 236908 0 0.0
.flash.text 1049991 1049935 -56 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684496 684448 -48 -0.0
.bss 81248 81248 0 0.0
.data 2020 2020 0 0.0
.text 599524 599476 -48 -0.0
lock k32w061+release (read/write) 729176 729128 -48 -0.0
.bss 81680 81680 0 0.0
.data 1980 1980 0 0.0
.text 643812 643764 -48 -0.0
linux all-clusters-app debug (read only) 2732841 2732713 -128 -0.0
(read/write) 173432 173656 224 0.1
.bss 83488 83712 224 0.3
.data 2064 2064 0 0.0
.data.rel.ro 81752 81752 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 235269 235269 0 0.0
.text 2323090 2322962 -128 -0.0
bridge-app debug+rpc (read only) 1888177 1888049 -128 -0.0
(read/write) 120728 120728 0 0.0
.bss 71488 71488 0 0.0
.data 3488 3488 0 0.0
.data.rel.ro 40408 40408 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 160513 160513 0 0.0
.text 1605410 1605282 -128 -0.0
chip-tool debug (read only) 8980533 8980565 32 0.0
(read/write) 576720 576720 0 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546496 546496 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 463861 463861 0 0.0
.text 7193477 7193509 32 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8820404 8820356 -48 -0.0
(read/write) 642833 642817 -16 -0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 581760 581736 -24 -0.0
.dynamic 560 560 0 0.0
.got 14960 14960 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 431572 431572 0 0.0
.text 6930292 6930276 -16 -0.0
lighting-app debug+rpc (read only) 2322313 2322185 -128 -0.0
(read/write) 151648 151648 0 0.0
.bss 73536 73536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70328 70328 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 184713 184713 0 0.0
.text 1971490 1971362 -128 -0.0
lock-app debug (read only) 2228513 2228401 -112 -0.0
(read/write) 146264 146264 0 0.0
.bss 72160 72160 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 66856 66856 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 194449 194449 0 0.0
.text 1874306 1874194 -112 -0.0
ota-provider-app debug (read only) 2058009 2057881 -128 -0.0
(read/write) 139376 139376 0 0.0
.bss 71648 71648 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 60200 60200 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 175451 175451 0 0.0
.text 1725266 1725138 -128 -0.0
ota-requestor-app debug (read only) 2089065 2088937 -128 -0.0
(read/write) 142184 142184 0 0.0
.bss 72288 72288 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62280 62280 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171724 171724 0 0.0
.text 1758562 1758434 -128 -0.0
shell debug (read only) 2557849 2557721 -128 -0.0
(read/write) 197328 197328 0 0.0
.bss 114216 114216 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76016 76016 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 216754 216754 0 0.0
.text 2179714 2179586 -128 -0.0
thermostat-no-ble arm64 (read only) 2363852 2363676 -176 -0.0
(read/write) 174801 174801 0 0.0
.bss 86401 86401 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79096 79096 0 0.0
.dynamic 560 560 0 0.0
.got 4752 4752 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 145980 145980 0 0.0
.text 1988864 1988688 -176 -0.0
tv-app debug (read only) 2844753 2844801 48 0.0
(read/write) 276960 276960 0 0.0
.bss 189432 189432 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 76632 76632 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 217323 217323 0 0.0
.text 2445378 2445426 48 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418460 2418284 -176 -0.0
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1381060 1380884 -176 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1178019 1177987 -32 -0.0
bss 139532 139532 0 0.0
rodata 150692 150692 0 0.0
text 809064 809024 -40 -0.0
p6 all-clusters-app default (read/write) 2529280 2529232 -48 -0.0
.bss 139184 139184 0 0.0
.data 2808 2808 0 0.0
.text 1487544 1487496 -48 -0.0
light-app default (read/write) 2419856 2419824 -32 -0.0
.bss 132648 132648 0 0.0
.data 2608 2608 0 0.0
.text 1378120 1378088 -32 -0.0
lock-app default (read/write) 2429136 2429104 -32 -0.0
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1387400 1387368 -32 -0.0
telink lighting-app tlsr9518adk80d (read/write) 804820 804780 -40 -0.0
bss 72172 72172 0 0.0
noinit 40416 40416 0 0.0
text 571796 571758 -38 -0.0

bzbarsky-apple
bzbarsky-apple requested changes May 5, 2022
View reviewed changes
src/credentials/CertificationDeclaration.cpp Outdated Show resolved Hide resolved
src/credentials/CertificationDeclaration.cpp Outdated Show resolved Hide resolved
src/credentials/CertificationDeclaration.cpp Outdated Show resolved Hide resolved
src/credentials/CertificationDeclaration.cpp Outdated Show resolved Hide resolved
src/credentials/CertificationDeclaration.cpp Outdated Show resolved Hide resolved
src/credentials/CertificationDeclaration.cpp Outdated Show resolved Hide resolved
src/credentials/CertificationDeclaration.cpp Outdated Show resolved Hide resolved
src/credentials/CertificationDeclaration.h Show resolved Hide resolved
src/credentials/CertificationDeclaration.cpp Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented May 5, 2022 •
edited
Loading

PR #18062: Size comparison from a932e78 to 4a744e6

Increases (2 builds for mbed, telink)
platform target config section a932e78 4a744e6 change % change
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2418460 2419108 648 0.0
.text 1381060 1381708 648 0.0
telink lighting-app tlsr9518adk80d (read/write) 804820 805704 884 0.1
text 571796 572178 382 0.1
Full report (2 builds for mbed, telink)
platform target config section a932e78 4a744e6 change % change
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418460 2419108 648 0.0
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1381060 1381708 648 0.0
telink lighting-app tlsr9518adk80d (read/write) 804820 805704 884 0.1
bss 72172 72172 0 0.0
noinit 40416 40416 0 0.0
text 571796 572178 382 0.1

@github-actions
Copy link

github-actions bot commented May 5, 2022 •
edited
Loading

PR #18062: Size comparison from a932e78 to 2f91b0e

Increases above 0.2%:

platform target config section a932e78 2f91b0e change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 .rodata 102127 102627 500 0.5
lock-ftd LP_CC2652R7 .rodata 94195 94695 500 0.5
lock-mtd LP_CC2652R7 .rodata 94083 94583 500 0.5
pump-app LP_CC2652R7 .rodata 80387 80887 500 0.6
pump-controller-app LP_CC2652R7 .rodata 83343 83843 500 0.6
linux all-clusters-app debug (read/write) 173432 173784 352 0.2
.bss 83488 83712 224 0.3
.rodata 235269 235781 512 0.2
bridge-app debug+rpc .data.rel.ro 40408 40536 128 0.3
.rodata 160513 161017 504 0.3
lighting-app debug+rpc .rodata 184713 185193 480 0.3
lock-app debug .rodata 194449 194961 512 0.3
ota-provider-app debug .data.rel.ro 60200 60328 128 0.2
.rodata 175451 175931 480 0.3
ota-requestor-app debug .data.rel.ro 62280 62408 128 0.2
.rodata 171724 172236 512 0.3
shell debug .rodata 216754 217234 480 0.2
thermostat-no-ble arm64 .rodata 145980 146476 496 0.3
tv-app debug .rodata 217323 217835 512 0.2
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 150692 151188 496 0.3
Increases (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a932e78 2f91b0e change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689319 690099 780 0.1
.rodata 102127 102627 500 0.5
.text 586708 586988 280 0.0
lock-ftd LP_CC2652R7 (read only) 677203 677975 772 0.1
.rodata 94195 94695 500 0.5
.text 582528 582800 272 0.0
lock-mtd LP_CC2652R7 (read only) 625947 626719 772 0.1
.rodata 94083 94583 500 0.5
.text 531376 531648 272 0.1
pump-app LP_CC2652R7 (read only) 661891 662671 780 0.1
.rodata 80387 80887 500 0.6
.text 581020 581300 280 0.0
pump-controller-app LP_CC2652R7 (read only) 654823 655595 772 0.1
.rodata 83343 83843 500 0.6
.text 570996 571268 272 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626502 627274 772 0.1
.app_xip_area 529092 529864 772 0.1
lock cyw930739m2evb_01 (read/write) 625214 625986 772 0.1
.app_xip_area 529268 530040 772 0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574738 574962 224 0.0
.app_xip_area 469076 469300 224 0.0
efr32 lighting-app BRD4161A (read only) 909032 910016 984 0.1
.text 909024 910008 984 0.1
BRD4161A+rpc (read only) 943392 944360 968 0.1
.text 943384 944352 968 0.1
BRD4161A+rs911x (read only) 747252 748204 952 0.1
.text 747244 748196 952 0.1
lock-app BRD4161A+wf200 (read only) 916908 917680 772 0.1
(read/write) 127480 127484 4 0.0
.text 916900 917672 772 0.1
window-app BRD4161A (read only) 846296 847256 960 0.1
.text 846288 847248 960 0.1
esp32 all-clusters-app c3devkit (read only) 1000234 1000606 372 0.0
(read/write) 1474338 1474842 504 0.0
.flash.rodata 207128 207632 504 0.2
.flash.text 1000234 1000606 372 0.0
m5stack (read only) 1055375 1055667 292 0.0
(read/write) 476760 477256 496 0.1
.flash.rodata 236908 237404 496 0.2
.flash.text 1049991 1050283 292 0.0
k32w light k32w061+release (read/write) 684496 684800 304 0.0
.text 599524 599828 304 0.1
lock k32w061+release (read/write) 729176 729964 788 0.1
.text 643812 644600 788 0.1
linux all-clusters-app debug (read only) 2732841 2735833 2992 0.1
(read/write) 173432 173784 352 0.2
.bss 83488 83712 224 0.3
.data.rel.ro 81752 81880 128 0.2
.rodata 235269 235781 512 0.2
.text 2323090 2325282 2192 0.1
bridge-app debug+rpc (read only) 1888177 1891161 2984 0.2
(read/write) 120728 120856 128 0.1
.data.rel.ro 40408 40536 128 0.3
.rodata 160513 161017 504 0.3
.text 1605410 1607602 2192 0.1
chip-tool debug (read only) 8980533 8984661 4128 0.0
(read/write) 576720 576848 128 0.0
.data.rel.ro 546496 546624 128 0.0
.rodata 463861 464357 496 0.1
.text 7193477 7196821 3344 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8820404 8823668 3264 0.0
(read/write) 642833 642993 160 0.0
.data.rel.ro 581760 581912 152 0.0
.got 14960 14968 8 0.1
.rodata 431572 432052 480 0.1
.text 6930292 6932692 2400 0.0
lighting-app debug+rpc (read only) 2322313 2325273 2960 0.1
(read/write) 151648 151776 128 0.1
.data.rel.ro 70328 70456 128 0.2
.rodata 184713 185193 480 0.3
.text 1971490 1973682 2192 0.1
lock-app debug (read only) 2228513 2231505 2992 0.1
(read/write) 146264 146392 128 0.1
.data.rel.ro 66856 66984 128 0.2
.rodata 194449 194961 512 0.3
.text 1874306 1876498 2192 0.1
ota-provider-app debug (read only) 2058009 2060969 2960 0.1
(read/write) 139376 139504 128 0.1
.data.rel.ro 60200 60328 128 0.2
.rodata 175451 175931 480 0.3
.text 1725266 1727458 2192 0.1
ota-requestor-app debug (read only) 2089065 2092057 2992 0.1
(read/write) 142184 142312 128 0.1
.data.rel.ro 62280 62408 128 0.2
.rodata 171724 172236 512 0.3
.text 1758562 1760754 2192 0.1
shell debug (read only) 2557849 2560809 2960 0.1
(read/write) 197328 197456 128 0.1
.data.rel.ro 76016 76144 128 0.2
.rodata 216754 217234 480 0.2
.text 2179714 2181906 2192 0.1
thermostat-no-ble arm64 (read only) 2363852 2366220 2368 0.1
(read/write) 174801 174993 192 0.1
.data.rel.ro 79096 79272 176 0.2
.got 4752 4760 8 0.2
.rodata 145980 146476 496 0.3
.text 1988864 1990336 1472 0.1
tv-app debug (read only) 2844753 2848897 4144 0.1
(read/write) 276960 277088 128 0.0
.data.rel.ro 76632 76760 128 0.2
.rodata 217323 217835 512 0.2
.text 2445378 2448722 3344 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2418460 2419108 648 0.0
.text 1381060 1381708 648 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1178019 1178787 768 0.1
rodata 150692 151188 496 0.3
text 809064 809340 276 0.0
p6 all-clusters-app default (read/write) 2529280 2530240 960 0.0
.text 1487544 1488504 960 0.1
light-app default (read/write) 2419856 2420816 960 0.0
.text 1378120 1379080 960 0.1
lock-app default (read/write) 2429136 2430096 960 0.0
.text 1387400 1388360 960 0.1
telink lighting-app tlsr9518adk80d (read/write) 804820 805704 884 0.1
text 571796 572178 382 0.1
Decreases (4 builds for cc13x2_26x2)
platform target config section a932e78 2f91b0e change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 162880 162100 -780 -0.5
lock-ftd LP_CC2652R7 (read/write) 166244 165472 -772 -0.5
pump-app LP_CC2652R7 (read/write) 182852 182072 -780 -0.4
pump-controller-app LP_CC2652R7 (read/write) 189720 188948 -772 -0.4
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a932e78 2f91b0e change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689319 690099 780 0.1
(read/write) 162880 162100 -780 -0.5
.bss 75180 75180 0 0.0
.data 3412 3412 0 0.0
.rodata 102127 102627 500 0.5
.text 586708 586988 280 0.0
lock-ftd LP_CC2652R7 (read only) 677203 677975 772 0.1
(read/write) 166244 165472 -772 -0.5
.bss 73484 73484 0 0.0
.data 3236 3236 0 0.0
.rodata 94195 94695 500 0.5
.text 582528 582800 272 0.0
lock-mtd LP_CC2652R7 (read only) 625947 626719 772 0.1
(read/write) 146300 146300 0 0.0
.bss 69204 69204 0 0.0
.data 3236 3236 0 0.0
.rodata 94083 94583 500 0.5
.text 531376 531648 272 0.1
pump-app LP_CC2652R7 (read only) 661891 662671 780 0.1
(read/write) 182852 182072 -780 -0.4
.bss 73756 73756 0 0.0
.data 3268 3268 0 0.0
.rodata 80387 80887 500 0.6
.text 581020 581300 280 0.0
pump-controller-app LP_CC2652R7 (read only) 654823 655595 772 0.1
(read/write) 189720 188948 -772 -0.4
.bss 73812 73812 0 0.0
.data 3232 3232 0 0.0
.rodata 83343 83843 500 0.6
.text 570996 571268 272 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626502 627274 772 0.1
.app_xip_area 529092 529864 772 0.1
.bss 80052 80052 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 625214 625986 772 0.1
.app_xip_area 529268 530040 772 0.1
.bss 78620 78620 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574738 574962 224 0.0
.app_xip_area 469076 469300 224 0.0
.bss 88040 88040 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 909032 910016 984 0.1
(read/write) 134520 134520 0 0.0
.bss 132456 132456 0 0.0
.data 2064 2064 0 0.0
.text 909024 910008 984 0.1
BRD4161A+rpc (read only) 943392 944360 968 0.1
(read/write) 151208 151208 0 0.0
.bss 148936 148936 0 0.0
.data 2268 2268 0 0.0
.text 943384 944352 968 0.1
BRD4161A+rs911x (read only) 747252 748204 952 0.1
(read/write) 128700 128700 0 0.0
.bss 126708 126708 0 0.0
.data 1992 1992 0 0.0
.text 747244 748196 952 0.1
lock-app BRD4161A+wf200 (read only) 916908 917680 772 0.1
(read/write) 127480 127484 4 0.0
.bss 125532 125532 0 0.0
.data 1948 1948 0 0.0
.text 916900 917672 772 0.1
window-app BRD4161A (read only) 846296 847256 960 0.1
(read/write) 132608 132608 0 0.0
.bss 130632 130632 0 0.0
.data 1976 1976 0 0.0
.text 846288 847248 960 0.1
esp32 all-clusters-app c3devkit (read only) 1000234 1000606 372 0.0
(read/write) 1474338 1474842 504 0.0
.dram0.bss 68320 68320 0 0.0
.dram0.data 14444 14444 0 0.0
.flash.rodata 207128 207632 504 0.2
.flash.text 1000234 1000606 372 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1055375 1055667 292 0.0
(read/write) 476760 477256 496 0.1
.dram0.bss 73832 73832 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 236908 237404 496 0.2
.flash.text 1049991 1050283 292 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684496 684800 304 0.0
.bss 81248 81248 0 0.0
.data 2020 2020 0 0.0
.text 599524 599828 304 0.1
lock k32w061+release (read/write) 729176 729964 788 0.1
.bss 81680 81680 0 0.0
.data 1980 1980 0 0.0
.text 643812 644600 788 0.1
linux all-clusters-app debug (read only) 2732841 2735833 2992 0.1
(read/write) 173432 173784 352 0.2
.bss 83488 83712 224 0.3
.data 2064 2064 0 0.0
.data.rel.ro 81752 81880 128 0.2
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 235269 235781 512 0.2
.text 2323090 2325282 2192 0.1
bridge-app debug+rpc (read only) 1888177 1891161 2984 0.2
(read/write) 120728 120856 128 0.1
.bss 71488 71488 0 0.0
.data 3488 3488 0 0.0
.data.rel.ro 40408 40536 128 0.3
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 160513 161017 504 0.3
.text 1605410 1607602 2192 0.1
chip-tool debug (read only) 8980533 8984661 4128 0.0
(read/write) 576720 576848 128 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546496 546624 128 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 463861 464357 496 0.1
.text 7193477 7196821 3344 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8820404 8823668 3264 0.0
(read/write) 642833 642993 160 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 581760 581912 152 0.0
.dynamic 560 560 0 0.0
.got 14960 14968 8 0.1
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 431572 432052 480 0.1
.text 6930292 6932692 2400 0.0
lighting-app debug+rpc (read only) 2322313 2325273 2960 0.1
(read/write) 151648 151776 128 0.1
.bss 73536 73536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70328 70456 128 0.2
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 184713 185193 480 0.3
.text 1971490 1973682 2192 0.1
lock-app debug (read only) 2228513 2231505 2992 0.1
(read/write) 146264 146392 128 0.1
.bss 72160 72160 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 66856 66984 128 0.2
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 194449 194961 512 0.3
.text 1874306 1876498 2192 0.1
ota-provider-app debug (read only) 2058009 2060969 2960 0.1
(read/write) 139376 139504 128 0.1
.bss 71648 71648 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 60200 60328 128 0.2
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 175451 175931 480 0.3
.text 1725266 1727458 2192 0.1
ota-requestor-app debug (read only) 2089065 2092057 2992 0.1
(read/write) 142184 142312 128 0.1
.bss 72288 72288 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62280 62408 128 0.2
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171724 172236 512 0.3
.text 1758562 1760754 2192 0.1
shell debug (read only) 2557849 2560809 2960 0.1
(read/write) 197328 197456 128 0.1
.bss 114216 114216 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76016 76144 128 0.2
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 216754 217234 480 0.2
.text 2179714 2181906 2192 0.1
thermostat-no-ble arm64 (read only) 2363852 2366220 2368 0.1
(read/write) 174801 174993 192 0.1
.bss 86401 86401 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79096 79272 176 0.2
.dynamic 560 560 0 0.0
.got 4752 4760 8 0.2
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 145980 146476 496 0.3
.text 1988864 1990336 1472 0.1
tv-app debug (read only) 2844753 2848897 4144 0.1
(read/write) 276960 277088 128 0.0
.bss 189432 189432 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 76632 76760 128 0.2
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 217323 217835 512 0.2
.text 2445378 2448722 3344 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418460 2419108 648 0.0
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1381060 1381708 648 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1178019 1178787 768 0.1
bss 139532 139532 0 0.0
rodata 150692 151188 496 0.3
text 809064 809340 276 0.0
p6 all-clusters-app default (read/write) 2529280 2530240 960 0.0
.bss 139184 139184 0 0.0
.data 2808 2808 0 0.0
.text 1487544 1488504 960 0.1
light-app default (read/write) 2419856 2420816 960 0.0
.bss 132648 132648 0 0.0
.data 2608 2608 0 0.0
.text 1378120 1379080 960 0.1
lock-app default (read/write) 2429136 2430096 960 0.0
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1387400 1388360 960 0.1
telink lighting-app tlsr9518adk80d (read/write) 804820 805704 884 0.1
bss 72172 72172 0 0.0
noinit 40416 40416 0 0.0
text 571796 572178 382 0.1

@emargolis emargolis requested a review from bzbarsky-apple May 5, 2022 18:10
@emargolis emargolis force-pushed the emargolis/feature/cd-add-authorized-paa-list-support branch from 2f91b0e to c43800e Compare May 5, 2022 23:19
@github-actions
Copy link

github-actions bot commented May 5, 2022 •
edited
Loading

PR #18062: Size comparison from 8faa780 to c43800e

Increases (2 builds for linux, mbed)
platform target config section 8faa780 c43800e change % change
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8820788 8821652 864 0.0
.text 6929732 6930612 880 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2419700 2419764 64 0.0
.text 1382300 1382364 64 0.0
Decreases (1 build for linux)
platform target config section 8faa780 c43800e change % change
linux chip-tool-no-interactive-ipv6only arm64 (read/write) 643137 643105 -32 -0.0
.data.rel.ro 582048 582024 -24 -0.0
Full report (13 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 8faa780 c43800e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 627602 627602 0 0.0
.app_xip_area 530184 530184 0 0.0
.bss 80060 80060 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 626482 626482 0 0.0
.app_xip_area 530528 530528 0 0.0
.bss 78628 78628 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575242 575242 0 0.0
.app_xip_area 469572 469572 0 0.0
.bss 88048 88048 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 685144 685144 0 0.0
.bss 81256 81256 0 0.0
.data 2020 2020 0 0.0
.text 600164 600164 0 0.0
lock k32w061+release (read/write) 730492 730492 0 0.0
.bss 81688 81688 0 0.0
.data 1980 1980 0 0.0
.text 645120 645120 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8820788 8821652 864 0.0
(read/write) 643137 643105 -32 -0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582048 582024 -24 -0.0
.dynamic 560 560 0 0.0
.got 14968 14968 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 431780 431780 0 0.0
.text 6929732 6930612 880 0.0
thermostat-no-ble arm64 (read only) 2368188 2368188 0 0.0
(read/write) 175121 175121 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79376 79376 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146524 146524 0 0.0
.text 1991920 1991920 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2419700 2419764 64 0.0
.bss 205828 205828 0 0.0
.data 5872 5872 0 0.0
.text 1382300 1382364 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179787 1179787 0 0.0
bss 139684 139684 0 0.0
rodata 151532 151532 0 0.0
text 809860 809860 0 0.0
p6 all-clusters-app default (read/write) 2531160 2531160 0 0.0
.bss 139336 139336 0 0.0
.data 2808 2808 0 0.0
.text 1489424 1489424 0 0.0
light-app default (read/write) 2421224 2421224 0 0.0
.bss 132656 132656 0 0.0
.data 2608 2608 0 0.0
.text 1379488 1379488 0 0.0
lock-app default (read/write) 2430728 2430728 0 0.0
.bss 132480 132480 0 0.0
.data 2568 2568 0 0.0
.text 1388992 1388992 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 806032 806032 0 0.0
bss 72180 72180 0 0.0
noinit 40416 40416 0 0.0
text 572432 572432 0 0.0

@github-actions
Copy link

github-actions bot commented May 6, 2022 •
edited
Loading

PR #18062: Size comparison from 8faa780 to c816ae9

Increases above 0.2%:

platform target config section 8faa780 c816ae9 change % change
linux all-clusters-app debug .bss 83680 83904 224 0.3
Increases (4 builds for linux)
platform target config section 8faa780 c816ae9 change % change
linux all-clusters-app debug (read only) 2739609 2739625 16 0.0
(read/write) 174264 174488 224 0.1
.bss 83680 83904 224 0.3
.text 2328402 2328418 16 0.0
chip-tool debug (read only) 8981461 8982533 1072 0.0
.text 7193429 7194501 1072 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8820788 8821652 864 0.0
.text 6929732 6930612 880 0.0
tv-app debug (read only) 2850417 2851505 1088 0.0
.text 2449650 2450738 1088 0.0
Decreases (1 build for linux)
platform target config section 8faa780 c816ae9 change % change
linux chip-tool-no-interactive-ipv6only arm64 (read/write) 643137 643105 -32 -0.0
.data.rel.ro 582048 582024 -24 -0.0
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 8faa780 c816ae9 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690947 690947 0 0.0
(read/write) 161404 161404 0 0.0
.bss 75332 75332 0 0.0
.data 3412 3412 0 0.0
.rodata 102979 102979 0 0.0
.text 587484 587484 0 0.0
lock-ftd LP_CC2652R7 (read only) 678503 678503 0 0.0
(read/write) 164952 164952 0 0.0
.bss 73492 73492 0 0.0
.data 3236 3236 0 0.0
.rodata 94767 94767 0 0.0
.text 583256 583256 0 0.0
lock-mtd LP_CC2652R7 (read only) 627255 627255 0 0.0
(read/write) 146308 146308 0 0.0
.bss 69212 69212 0 0.0
.data 3236 3236 0 0.0
.rodata 94647 94647 0 0.0
.text 532120 532120 0 0.0
pump-app LP_CC2652R7 (read only) 663051 663051 0 0.0
(read/write) 181700 181700 0 0.0
.bss 73764 73764 0 0.0
.data 3268 3268 0 0.0
.rodata 80971 80971 0 0.0
.text 581596 581596 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655943 655943 0 0.0
(read/write) 188608 188608 0 0.0
.bss 73820 73820 0 0.0
.data 3232 3232 0 0.0
.rodata 83911 83911 0 0.0
.text 571548 571548 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 627602 627602 0 0.0
.app_xip_area 530184 530184 0 0.0
.bss 80060 80060 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 626482 626482 0 0.0
.app_xip_area 530528 530528 0 0.0
.bss 78628 78628 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575242 575242 0 0.0
.app_xip_area 469572 469572 0 0.0
.bss 88048 88048 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 910096 910096 0 0.0
(read/write) 134520 134520 0 0.0
.bss 132456 132456 0 0.0
.data 2064 2064 0 0.0
.text 910088 910088 0 0.0
BRD4161A+rpc (read only) 944440 944440 0 0.0
(read/write) 151208 151208 0 0.0
.bss 148936 148936 0 0.0
.data 2268 2268 0 0.0
.text 944432 944432 0 0.0
BRD4161A+rs911x (read only) 787304 787304 0 0.0
(read/write) 129780 129780 0 0.0
.bss 127708 127708 0 0.0
.data 2068 2068 0 0.0
.text 787296 787296 0 0.0
lock-app BRD4161A+wf200 (read only) 946436 946436 0 0.0
(read/write) 124268 124268 0 0.0
.bss 122244 122244 0 0.0
.data 2024 2024 0 0.0
.text 946428 946428 0 0.0
window-app BRD4161A (read only) 886516 886516 0 0.0
(read/write) 134468 134468 0 0.0
.bss 132416 132416 0 0.0
.data 2052 2052 0 0.0
.text 886508 886508 0 0.0
esp32 all-clusters-app c3devkit (read only) 1001030 1001030 0 0.0
(read/write) 1475354 1475354 0 0.0
.dram0.bss 68472 68472 0 0.0
.dram0.data 14444 14444 0 0.0
.flash.rodata 207984 207984 0 0.0
.flash.text 1001030 1001030 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1056027 1056027 0 0.0
(read/write) 477768 477768 0 0.0
.dram0.bss 73984 73984 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 237764 237764 0 0.0
.flash.text 1050643 1050643 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 685144 685144 0 0.0
.bss 81256 81256 0 0.0
.data 2020 2020 0 0.0
.text 600164 600164 0 0.0
lock k32w061+release (read/write) 730492 730492 0 0.0
.bss 81688 81688 0 0.0
.data 1980 1980 0 0.0
.text 645120 645120 0 0.0
linux all-clusters-app debug (read only) 2739609 2739625 16 0.0
(read/write) 174264 174488 224 0.1
.bss 83680 83904 224 0.3
.data 2064 2064 0 0.0
.data.rel.ro 82392 82392 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 236005 236005 0 0.0
.text 2328402 2328418 16 0.0
bridge-app debug+rpc (read only) 1893745 1893745 0 0.0
(read/write) 120984 120984 0 0.0
.bss 71520 71520 0 0.0
.data 3488 3488 0 0.0
.data.rel.ro 40648 40648 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 161273 161273 0 0.0
.text 1609618 1609618 0 0.0
chip-tool debug (read only) 8981461 8982533 1072 0.0
(read/write) 576944 576944 0 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546728 546728 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 464213 464213 0 0.0
.text 7193429 7194501 1072 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8820788 8821652 864 0.0
(read/write) 643137 643105 -32 -0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582048 582024 -24 -0.0
.dynamic 560 560 0 0.0
.got 14968 14968 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 431780 431780 0 0.0
.text 6929732 6930612 880 0.0
lighting-app debug+rpc (read only) 2327825 2327825 0 0.0
(read/write) 151936 151936 0 0.0
.bss 73568 73568 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70568 70568 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 185401 185401 0 0.0
.text 1975714 1975714 0 0.0
lock-app debug (read only) 2235121 2235121 0 0.0
(read/write) 146520 146520 0 0.0
.bss 72192 72192 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67080 67080 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 195145 195145 0 0.0
.text 1879618 1879618 0 0.0
ota-provider-app debug (read only) 2063449 2063449 0 0.0
(read/write) 139632 139632 0 0.0
.bss 71680 71680 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 60440 60440 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 176147 176147 0 0.0
.text 1729410 1729410 0 0.0
ota-requestor-app debug (read only) 2094593 2094593 0 0.0
(read/write) 142440 142440 0 0.0
.bss 72320 72320 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62504 62504 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172444 172444 0 0.0
.text 1762770 1762770 0 0.0
shell debug (read only) 2564585 2564585 0 0.0
(read/write) 198160 198160 0 0.0
.bss 114408 114408 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76656 76656 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 217458 217458 0 0.0
.text 2185026 2185026 0 0.0
thermostat-no-ble arm64 (read only) 2368188 2368188 0 0.0
(read/write) 175121 175121 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79376 79376 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146524 146524 0 0.0
.text 1991920 1991920 0 0.0
tv-app debug (read only) 2850417 2851505 1088 0.0
(read/write) 277248 277248 0 0.0
.bss 189464 189464 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 76872 76872 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 218091 218091 0 0.0
.text 2449650 2450738 1088 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2419700 2419700 0 0.0
.bss 205828 205828 0 0.0
.data 5872 5872 0 0.0
.text 1382300 1382300 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179787 1179787 0 0.0
bss 139684 139684 0 0.0
rodata 151532 151532 0 0.0
text 809860 809860 0 0.0
p6 all-clusters-app default (read/write) 2531160 2531160 0 0.0
.bss 139336 139336 0 0.0
.data 2808 2808 0 0.0
.text 1489424 1489424 0 0.0
light-app default (read/write) 2421224 2421224 0 0.0
.bss 132656 132656 0 0.0
.data 2608 2608 0 0.0
.text 1379488 1379488 0 0.0
lock-app default (read/write) 2430728 2430728 0 0.0
.bss 132480 132480 0 0.0
.data 2568 2568 0 0.0
.text 1388992 1388992 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 806032 806032 0 0.0
bss 72180 72180 0 0.0
noinit 40416 40416 0 0.0
text 572432 572432 0 0.0

@github-actions
Copy link

github-actions bot commented May 6, 2022 •
edited
Loading

PR #18062: Size comparison from 8faa780 to 76e27bf

Increases above 0.2%:

platform target config section 8faa780 76e27bf change % change
linux all-clusters-app debug .bss 83680 83904 224 0.3
chip-tool debug (read only) 8981461 9014101 32640 0.4
.text 7193429 7225429 32000 0.4
chip-tool-no-interactive-ipv6only arm64 (read only) 8820788 8845316 24528 0.3
.text 6929732 6953636 23904 0.3
ota-requestor-app debug .rodata 172444 172796 352 0.2
Increases (19 builds for efr32, esp32, linux, mbed, p6)
platform target config section 8faa780 76e27bf change % change
efr32 lighting-app BRD4161A+rs911x (read only) 787304 787692 388 0.0
.text 787296 787684 388 0.0
lock-app BRD4161A+wf200 (read only) 946436 946768 332 0.0
.text 946428 946760 332 0.0
esp32 all-clusters-app c3devkit (read only) 1001030 1001096 66 0.0
(read/write) 1475354 1475658 304 0.0
.flash.rodata 207984 208304 320 0.2
.flash.text 1001030 1001096 66 0.0
m5stack (read only) 1056027 1056047 20 0.0
(read/write) 477768 478080 312 0.1
.flash.rodata 237764 238076 312 0.1
.flash.text 1050643 1050663 20 0.0
linux all-clusters-app debug (read only) 2739609 2740089 480 0.0
(read/write) 174264 174488 224 0.1
.bss 83680 83904 224 0.3
.rodata 236005 236357 352 0.1
.text 2328402 2328530 128 0.0
bridge-app debug+rpc (read only) 1893745 1894177 432 0.0
.rodata 161273 161593 320 0.2
.text 1609618 1609730 112 0.0
chip-tool debug (read only) 8981461 9014101 32640 0.4
.rodata 464213 464853 640 0.1
.text 7193429 7225429 32000 0.4
chip-tool-no-interactive-ipv6only arm64 (read only) 8820788 8845316 24528 0.3
.got 14968 14976 8 0.1
.rodata 431780 432404 624 0.1
.text 6929732 6953636 23904 0.3
lighting-app debug+rpc (read only) 2327825 2328273 448 0.0
.rodata 185401 185721 320 0.2
.text 1975714 1975842 128 0.0
lock-app debug (read only) 2235121 2235553 432 0.0
.rodata 195145 195465 320 0.2
.text 1879618 1879730 112 0.0
ota-provider-app debug (read only) 2063449 2063881 432 0.0
.rodata 176147 176467 320 0.2
.text 1729410 1729522 112 0.0
ota-requestor-app debug (read only) 2094593 2095057 464 0.0
.rodata 172444 172796 352 0.2
.text 1762770 1762882 112 0.0
shell debug (read only) 2564585 2565065 480 0.0
.rodata 217458 217810 352 0.2
.text 2185026 2185154 128 0.0
thermostat-no-ble arm64 (read only) 2368188 2368620 432 0.0
.rodata 146524 146844 320 0.2
.text 1991920 1992032 112 0.0
tv-app debug (read only) 2850417 2851937 1520 0.1
.rodata 218091 218411 320 0.1
.text 2449650 2450850 1200 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2419700 2420076 376 0.0
.text 1382300 1382676 376 0.0
p6 all-clusters-app default (read/write) 2531160 2531536 376 0.0
.text 1489424 1489800 376 0.0
light-app default (read/write) 2421224 2421592 368 0.0
.text 1379488 1379856 368 0.0
lock-app default (read/write) 2430728 2431096 368 0.0
.text 1388992 1389360 368 0.0
Decreases (14 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 8faa780 76e27bf change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read/write) 181700 181692 -8 -0.0
.bss 73764 73756 -8 -0.0
pump-controller-app LP_CC2652R7 (read/write) 188608 188600 -8 -0.0
.bss 73820 73812 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 627602 627594 -8 -0.0
.bss 80060 80052 -8 -0.0
efr32 lighting-app BRD4161A+rs911x (read/write) 129780 129776 -4 -0.0
window-app BRD4161A (read/write) 134468 134460 -8 -0.0
.bss 132416 132408 -8 -0.0
esp32 all-clusters-app c3devkit .dram0.bss 68472 68464 -8 -0.0
k32w light k32w061+release (read/write) 685144 685136 -8 -0.0
.bss 81256 81248 -8 -0.0
lock k32w061+release (read/write) 730492 730484 -8 -0.0
.bss 81688 81680 -8 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read/write) 643137 643121 -16 -0.0
.data.rel.ro 582048 582024 -24 -0.0
mbed lock-app CY8CPROTO_062_4343W+release .bss 205828 205820 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 bss 139684 139680 -4 -0.0
p6 all-clusters-app default .bss 139336 139328 -8 -0.0
lock-app default .bss 132480 132472 -8 -0.0
telink lighting-app tlsr9518adk80d (read/write) 806032 806024 -8 -0.0
bss 72180 72176 -4 -0.0
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 8faa780 76e27bf change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690947 690947 0 0.0
(read/write) 161404 161404 0 0.0
.bss 75332 75332 0 0.0
.data 3412 3412 0 0.0
.rodata 102979 102979 0 0.0
.text 587484 587484 0 0.0
lock-ftd LP_CC2652R7 (read only) 678503 678503 0 0.0
(read/write) 164952 164952 0 0.0
.bss 73492 73492 0 0.0
.data 3236 3236 0 0.0
.rodata 94767 94767 0 0.0
.text 583256 583256 0 0.0
lock-mtd LP_CC2652R7 (read only) 627255 627255 0 0.0
(read/write) 146308 146308 0 0.0
.bss 69212 69212 0 0.0
.data 3236 3236 0 0.0
.rodata 94647 94647 0 0.0
.text 532120 532120 0 0.0
pump-app LP_CC2652R7 (read only) 663051 663051 0 0.0
(read/write) 181700 181692 -8 -0.0
.bss 73764 73756 -8 -0.0
.data 3268 3268 0 0.0
.rodata 80971 80971 0 0.0
.text 581596 581596 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655943 655943 0 0.0
(read/write) 188608 188600 -8 -0.0
.bss 73820 73812 -8 -0.0
.data 3232 3232 0 0.0
.rodata 83911 83911 0 0.0
.text 571548 571548 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 627602 627594 -8 -0.0
.app_xip_area 530184 530184 0 0.0
.bss 80060 80052 -8 -0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 626482 626482 0 0.0
.app_xip_area 530528 530528 0 0.0
.bss 78628 78628 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575242 575242 0 0.0
.app_xip_area 469572 469572 0 0.0
.bss 88048 88048 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 910096 910096 0 0.0
(read/write) 134520 134520 0 0.0
.bss 132456 132456 0 0.0
.data 2064 2064 0 0.0
.text 910088 910088 0 0.0
BRD4161A+rpc (read only) 944440 944440 0 0.0
(read/write) 151208 151208 0 0.0
.bss 148936 148936 0 0.0
.data 2268 2268 0 0.0
.text 944432 944432 0 0.0
BRD4161A+rs911x (read only) 787304 787692 388 0.0
(read/write) 129780 129776 -4 -0.0
.bss 127708 127708 0 0.0
.data 2068 2068 0 0.0
.text 787296 787684 388 0.0
lock-app BRD4161A+wf200 (read only) 946436 946768 332 0.0
(read/write) 124268 124268 0 0.0
.bss 122244 122244 0 0.0
.data 2024 2024 0 0.0
.text 946428 946760 332 0.0
window-app BRD4161A (read only) 886516 886516 0 0.0
(read/write) 134468 134460 -8 -0.0
.bss 132416 132408 -8 -0.0
.data 2052 2052 0 0.0
.text 886508 886508 0 0.0
esp32 all-clusters-app c3devkit (read only) 1001030 1001096 66 0.0
(read/write) 1475354 1475658 304 0.0
.dram0.bss 68472 68464 -8 -0.0
.dram0.data 14444 14444 0 0.0
.flash.rodata 207984 208304 320 0.2
.flash.text 1001030 1001096 66 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1056027 1056047 20 0.0
(read/write) 477768 478080 312 0.1
.dram0.bss 73984 73984 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 237764 238076 312 0.1
.flash.text 1050643 1050663 20 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 685144 685136 -8 -0.0
.bss 81256 81248 -8 -0.0
.data 2020 2020 0 0.0
.text 600164 600164 0 0.0
lock k32w061+release (read/write) 730492 730484 -8 -0.0
.bss 81688 81680 -8 -0.0
.data 1980 1980 0 0.0
.text 645120 645120 0 0.0
linux all-clusters-app debug (read only) 2739609 2740089 480 0.0
(read/write) 174264 174488 224 0.1
.bss 83680 83904 224 0.3
.data 2064 2064 0 0.0
.data.rel.ro 82392 82392 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 236005 236357 352 0.1
.text 2328402 2328530 128 0.0
bridge-app debug+rpc (read only) 1893745 1894177 432 0.0
(read/write) 120984 120984 0 0.0
.bss 71520 71520 0 0.0
.data 3488 3488 0 0.0
.data.rel.ro 40648 40648 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 161273 161593 320 0.2
.text 1609618 1609730 112 0.0
chip-tool debug (read only) 8981461 9014101 32640 0.4
(read/write) 576944 576944 0 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546728 546728 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 464213 464853 640 0.1
.text 7193429 7225429 32000 0.4
chip-tool-no-interactive-ipv6only arm64 (read only) 8820788 8845316 24528 0.3
(read/write) 643137 643121 -16 -0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582048 582024 -24 -0.0
.dynamic 560 560 0 0.0
.got 14968 14976 8 0.1
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 431780 432404 624 0.1
.text 6929732 6953636 23904 0.3
lighting-app debug+rpc (read only) 2327825 2328273 448 0.0
(read/write) 151936 151936 0 0.0
.bss 73568 73568 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70568 70568 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 185401 185721 320 0.2
.text 1975714 1975842 128 0.0
lock-app debug (read only) 2235121 2235553 432 0.0
(read/write) 146520 146520 0 0.0
.bss 72192 72192 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67080 67080 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 195145 195465 320 0.2
.text 1879618 1879730 112 0.0
ota-provider-app debug (read only) 2063449 2063881 432 0.0
(read/write) 139632 139632 0 0.0
.bss 71680 71680 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 60440 60440 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 176147 176467 320 0.2
.text 1729410 1729522 112 0.0
ota-requestor-app debug (read only) 2094593 2095057 464 0.0
(read/write) 142440 142440 0 0.0
.bss 72320 72320 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62504 62504 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172444 172796 352 0.2
.text 1762770 1762882 112 0.0
shell debug (read only) 2564585 2565065 480 0.0
(read/write) 198160 198160 0 0.0
.bss 114408 114408 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76656 76656 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 217458 217810 352 0.2
.text 2185026 2185154 128 0.0
thermostat-no-ble arm64 (read only) 2368188 2368620 432 0.0
(read/write) 175121 175121 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79376 79376 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146524 146844 320 0.2
.text 1991920 1992032 112 0.0
tv-app debug (read only) 2850417 2851937 1520 0.1
(read/write) 277248 277248 0 0.0
.bss 189464 189464 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 76872 76872 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 218091 218411 320 0.1
.text 2449650 2450850 1200 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2419700 2420076 376 0.0
.bss 205828 205820 -8 -0.0
.data 5872 5872 0 0.0
.text 1382300 1382676 376 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179787 1179787 0 0.0
bss 139684 139680 -4 -0.0
rodata 151532 151532 0 0.0
text 809860 809860 0 0.0
p6 all-clusters-app default (read/write) 2531160 2531536 376 0.0
.bss 139336 139328 -8 -0.0
.data 2808 2808 0 0.0
.text 1489424 1489800 376 0.0
light-app default (read/write) 2421224 2421592 368 0.0
.bss 132656 132656 0 0.0
.data 2608 2608 0 0.0
.text 1379488 1379856 368 0.0
lock-app default (read/write) 2430728 2431096 368 0.0
.bss 132480 132472 -8 -0.0
.data 2568 2568 0 0.0
.text 1388992 1389360 368 0.0
telink lighting-app tlsr9518adk80d (read/write) 806032 806024 -8 -0.0
bss 72180 72176 -4 -0.0
noinit 40416 40416 0 0.0
text 572432 572432 0 0.0

@emargolis emargolis force-pushed the emargolis/feature/cd-add-authorized-paa-list-support branch from 76e27bf to 97f9e30 Compare May 6, 2022 16:56
@github-actions
Copy link

github-actions bot commented May 6, 2022 •
edited
Loading

PR #18062: Size comparison from 70dc49f to 97f9e30

Increases above 0.2%:

platform target config section 70dc49f 97f9e30 change % change
linux all-clusters-app debug .bss 83680 83904 224 0.3
Increases (5 builds for linux)
platform target config section 70dc49f 97f9e30 change % change
linux all-clusters-app debug (read/write) 174264 174488 224 0.1
.bss 83680 83904 224 0.3
bridge-app debug+rpc (read only) 1894161 1894177 16 0.0
.text 1609714 1609730 16 0.0
chip-tool debug (read only) 9026661 9027733 1072 0.0
.text 7236709 7237781 1072 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8856532 8857396 864 0.0
.text 6963588 6964484 896 0.0
tv-app debug (read only) 2850849 2851921 1072 0.0
.text 2449762 2450834 1072 0.0
Decreases (1 build for linux)
platform target config section 70dc49f 97f9e30 change % change
linux chip-tool-no-interactive-ipv6only arm64 (read/write) 643137 643121 -16 -0.0
.data.rel.ro 582048 582024 -24 -0.0
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 70dc49f 97f9e30 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690935 690935 0 0.0
(read/write) 161416 161416 0 0.0
.bss 75332 75332 0 0.0
.data 3412 3412 0 0.0
.rodata 102983 102983 0 0.0
.text 587468 587468 0 0.0
lock-ftd LP_CC2652R7 (read only) 678507 678507 0 0.0
(read/write) 164948 164948 0 0.0
.bss 73492 73492 0 0.0
.data 3236 3236 0 0.0
.rodata 94771 94771 0 0.0
.text 583256 583256 0 0.0
lock-mtd LP_CC2652R7 (read only) 627259 627259 0 0.0
(read/write) 146308 146308 0 0.0
.bss 69212 69212 0 0.0
.data 3236 3236 0 0.0
.rodata 94651 94651 0 0.0
.text 532120 532120 0 0.0
pump-app LP_CC2652R7 (read only) 663035 663035 0 0.0
(read/write) 181708 181708 0 0.0
.bss 73756 73756 0 0.0
.data 3268 3268 0 0.0
.rodata 80971 80971 0 0.0
.text 581580 581580 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655943 655943 0 0.0
(read/write) 188600 188600 0 0.0
.bss 73812 73812 0 0.0
.data 3232 3232 0 0.0
.rodata 83911 83911 0 0.0
.text 571548 571548 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 627586 627586 0 0.0
.app_xip_area 530176 530176 0 0.0
.bss 80052 80052 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 626474 626474 0 0.0
.app_xip_area 530520 530520 0 0.0
.bss 78628 78628 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575234 575234 0 0.0
.app_xip_area 469564 469564 0 0.0
.bss 88048 88048 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 910096 910096 0 0.0
(read/write) 134520 134520 0 0.0
.bss 132456 132456 0 0.0
.data 2064 2064 0 0.0
.text 910088 910088 0 0.0
BRD4161A+rpc (read only) 944440 944440 0 0.0
(read/write) 151208 151208 0 0.0
.bss 148936 148936 0 0.0
.data 2268 2268 0 0.0
.text 944432 944432 0 0.0
BRD4161A+rs911x (read only) 787676 787676 0 0.0
(read/write) 129776 129776 0 0.0
.bss 127708 127708 0 0.0
.data 2068 2068 0 0.0
.text 787668 787668 0 0.0
lock-app BRD4161A+wf200 (read only) 946768 946768 0 0.0
(read/write) 124268 124268 0 0.0
.bss 122244 122244 0 0.0
.data 2024 2024 0 0.0
.text 946760 946760 0 0.0
window-app BRD4161A (read only) 886516 886516 0 0.0
(read/write) 134460 134460 0 0.0
.bss 132408 132408 0 0.0
.data 2052 2052 0 0.0
.text 886508 886508 0 0.0
esp32 all-clusters-app c3devkit (read only) 1001090 1001090 0 0.0
(read/write) 1475658 1475658 0 0.0
.dram0.bss 68464 68464 0 0.0
.dram0.data 14444 14444 0 0.0
.flash.rodata 208304 208304 0 0.0
.flash.text 1001090 1001090 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1056031 1056031 0 0.0
(read/write) 478088 478088 0 0.0
.dram0.bss 73984 73984 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 238084 238084 0 0.0
.flash.text 1050647 1050647 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 685136 685136 0 0.0
.bss 81248 81248 0 0.0
.data 2020 2020 0 0.0
.text 600164 600164 0 0.0
lock k32w061+release (read/write) 730468 730468 0 0.0
.bss 81680 81680 0 0.0
.data 1980 1980 0 0.0
.text 645104 645104 0 0.0
linux all-clusters-app debug (read only) 2740073 2740073 0 0.0
(read/write) 174264 174488 224 0.1
.bss 83680 83904 224 0.3
.data 2064 2064 0 0.0
.data.rel.ro 82392 82392 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 236357 236357 0 0.0
.text 2328514 2328514 0 0.0
bridge-app debug+rpc (read only) 1894161 1894177 16 0.0
(read/write) 120984 120984 0 0.0
.bss 71520 71520 0 0.0
.data 3488 3488 0 0.0
.data.rel.ro 40648 40648 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 161593 161593 0 0.0
.text 1609714 1609730 16 0.0
chip-tool debug (read only) 9026661 9027733 1072 0.0
(read/write) 576944 576944 0 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546728 546728 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 466133 466133 0 0.0
.text 7236709 7237781 1072 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8856532 8857396 864 0.0
(read/write) 643137 643121 -16 -0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582048 582024 -24 -0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 433636 433636 0 0.0
.text 6963588 6964484 896 0.0
lighting-app debug+rpc (read only) 2328241 2328241 0 0.0
(read/write) 151936 151936 0 0.0
.bss 73568 73568 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70568 70568 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 185721 185721 0 0.0
.text 1975810 1975810 0 0.0
lock-app debug (read only) 2235537 2235537 0 0.0
(read/write) 146520 146520 0 0.0
.bss 72192 72192 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67080 67080 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 195465 195465 0 0.0
.text 1879714 1879714 0 0.0
ota-provider-app debug (read only) 2063865 2063865 0 0.0
(read/write) 139632 139632 0 0.0
.bss 71680 71680 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 60440 60440 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 176467 176467 0 0.0
.text 1729506 1729506 0 0.0
ota-requestor-app debug (read only) 2095041 2095041 0 0.0
(read/write) 142440 142440 0 0.0
.bss 72320 72320 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62504 62504 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172796 172796 0 0.0
.text 1762866 1762866 0 0.0
shell debug (read only) 2565049 2565049 0 0.0
(read/write) 198160 198160 0 0.0
.bss 114408 114408 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76656 76656 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 217810 217810 0 0.0
.text 2185138 2185138 0 0.0
thermostat-no-ble arm64 (read only) 2368620 2368620 0 0.0
(read/write) 175121 175121 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79376 79376 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146844 146844 0 0.0
.text 1992032 1992032 0 0.0
tv-app debug (read only) 2850849 2851921 1072 0.0
(read/write) 277248 277248 0 0.0
.bss 189464 189464 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 76872 76872 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 218411 218411 0 0.0
.text 2449762 2450834 1072 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420084 2420084 0 0.0
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1382684 1382684 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179787 1179787 0 0.0
bss 139680 139680 0 0.0
rodata 151532 151532 0 0.0
text 809856 809856 0 0.0
p6 all-clusters-app default (read/write) 2531536 2531536 0 0.0
.bss 139328 139328 0 0.0
.data 2808 2808 0 0.0
.text 1489800 1489800 0 0.0
light-app default (read/write) 2421592 2421592 0 0.0
.bss 132656 132656 0 0.0
.data 2608 2608 0 0.0
.text 1379856 1379856 0 0.0
lock-app default (read/write) 2431096 2431096 0 0.0
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1389360 1389360 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 806024 806024 0 0.0
bss 72176 72176 0 0.0
noinit 40416 40416 0 0.0
text 572426 572426 0 0.0

@emargolis emargolis merged commit d6a7226 into project-chip:master May 6, 2022
@emargolis emargolis mentioned this pull request May 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emargolis @tcarmelveilleux @bzbarsky-apple