Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[IM] Merge paths when global dirty set is exhausted" #17931

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

woody-apple
Copy link
Contributor

Reverts #17417

Testing this

@github-actions
Copy link

github-actions bot commented Apr 29, 2022

PR #17931: Size comparison from 4a145d6 to abe53f4

Decreases (11 builds for efr32, k32w, linux, mbed, telink)
platform target config section 4a145d6 abe53f4 change % change
efr32 lighting-app BRD4161A (read only) 908936 908248 -688 -0.1
.text 908928 908240 -688 -0.1
BRD4161A+rpc (read only) 943280 942592 -688 -0.1
.text 943272 942584 -688 -0.1
BRD4161A+rs911x (read only) 747260 746564 -696 -0.1
.text 747252 746556 -696 -0.1
lock-app BRD4161A+wf200 (read only) 917184 916576 -608 -0.1
.text 917176 916568 -608 -0.1
window-app BRD4161A (read only) 846168 845480 -688 -0.1
.text 846160 845472 -688 -0.1
k32w light k32w061+release (read/write) 684860 684396 -464 -0.1
.text 599828 599364 -464 -0.1
lock k32w061+release (read/write) 729676 729212 -464 -0.1
.text 644260 643796 -464 -0.1
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8694996 8692404 -2592 -0.0
(read/write) 616497 616305 -192 -0.0
.bss 41105 40913 -192 -0.5
.rodata 429860 429748 -112 -0.0
.text 6867892 6865412 -2480 -0.0
thermostat-no-ble arm64 (read only) 2367732 2365124 -2608 -0.1
(read/write) 174801 174593 -208 -0.1
.bss 86481 86273 -208 -0.2
.rodata 146100 145988 -112 -0.1
.text 1992480 1989984 -2496 -0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2418892 2418268 -624 -0.0
.text 1381492 1380868 -624 -0.0
telink lighting-app tlsr9518adk80d (read/write) 808144 807436 -708 -0.1
text 571822 571226 -596 -0.1
Full report (11 builds for efr32, k32w, linux, mbed, telink)
platform target config section 4a145d6 abe53f4 change % change
efr32 lighting-app BRD4161A (read only) 908936 908248 -688 -0.1
(read/write) 135128 135128 0 0.0
.bss 133072 133072 0 0.0
.data 2052 2052 0 0.0
.text 908928 908240 -688 -0.1
BRD4161A+rpc (read only) 943280 942592 -688 -0.1
(read/write) 151808 151808 0 0.0
.bss 149552 149552 0 0.0
.data 2256 2256 0 0.0
.text 943272 942584 -688 -0.1
BRD4161A+rs911x (read only) 747260 746564 -696 -0.1
(read/write) 129352 129352 0 0.0
.bss 127372 127372 0 0.0
.data 1980 1980 0 0.0
.text 747252 746556 -696 -0.1
lock-app BRD4161A+wf200 (read only) 917184 916576 -608 -0.1
(read/write) 127540 127540 0 0.0
.bss 125604 125604 0 0.0
.data 1936 1936 0 0.0
.text 917176 916568 -608 -0.1
window-app BRD4161A (read only) 846168 845480 -688 -0.1
(read/write) 133216 133216 0 0.0
.bss 131248 131248 0 0.0
.data 1964 1964 0 0.0
.text 846160 845472 -688 -0.1
k32w light k32w061+release (read/write) 684860 684396 -464 -0.1
.bss 81320 81320 0 0.0
.data 2008 2008 0 0.0
.text 599828 599364 -464 -0.1
lock k32w061+release (read/write) 729676 729212 -464 -0.1
.bss 81744 81744 0 0.0
.data 1968 1968 0 0.0
.text 644260 643796 -464 -0.1
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8694996 8692404 -2592 -0.0
(read/write) 616497 616305 -192 -0.0
.bss 41105 40913 -192 -0.5
.data 1192 1192 0 0.0
.data.rel.ro 555648 555648 0 0.0
.dynamic 560 560 0 0.0
.got 14736 14736 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 429860 429748 -112 -0.0
.text 6867892 6865412 -2480 -0.0
thermostat-no-ble arm64 (read only) 2367732 2365124 -2608 -0.1
(read/write) 174801 174593 -208 -0.1
.bss 86481 86273 -208 -0.2
.data 1496 1496 0 0.0
.data.rel.ro 79048 79048 0 0.0
.dynamic 560 560 0 0.0
.got 4736 4736 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146100 145988 -112 -0.1
.text 1992480 1989984 -2496 -0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418892 2418268 -624 -0.0
.bss 205884 205884 0 0.0
.data 5856 5856 0 0.0
.text 1381492 1380868 -624 -0.0
telink lighting-app tlsr9518adk80d (read/write) 808144 807436 -708 -0.1
bss 75432 75432 0 0.0
noinit 40416 40416 0 0.0
text 571822 571226 -596 -0.1

@woody-apple woody-apple added the hotfix urgent fix needed, can bypass review label Apr 29, 2022
@mlepage-google mlepage-google merged commit 9dc2682 into master Apr 29, 2022
@mlepage-google mlepage-google deleted the revert-17417-im/issue16273 branch April 29, 2022 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app hotfix urgent fix needed, can bypass review lib review - pending
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants