Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure #176 #179

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Build failure #176 #179

merged 1 commit into from
Mar 31, 2020

Conversation

bhaskar-apple
Copy link
Contributor

Problem

Build failure #176

Build was failing as two new files weren't in the Makefile.am
However it was passing locally for me at my desk as I was using the following -
makefile -f Makefile-Standalone to build
and
makefile -f <pathToFolder>tests/ to test

The former was passing as it wasn't simply building those files. And the latter was fine as the tests import the .cpp

The GitHub build bot runs ./bootstrap && make -f Makefile-Standalone distcheck and this was failing.
This change fixes the broken build.
Output from my local run

./bootstrap && make -f Makefile-Standalone distcheck
...
=======================================
chip- archives ready for distribution: 
chip-.tar.gz
=======================================

Summary of Changes

Fix MakeFile.am

Fixes issue ##176

gerickson
gerickson suggested changes Mar 31, 2020
View reviewed changes
src/setup_payload/Makefile.am Outdated Show resolved Hide resolved
@bhaskar-apple
Copy link
Contributor Author

Link to PR in fork.
Build is passing in that.
https://github.com/bhaskar-apple/connectedhomeip/pull/3

@bhaskar-apple bhaskar-apple requested a review from gerickson March 31, 2020 21:38
hawk248
hawk248 approved these changes Mar 31, 2020
View reviewed changes
Copy link

@hawk248 hawk248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@woody-apple woody-apple merged commit d08ffea into project-chip:master Mar 31, 2020
@rwalker-apple
Copy link
Contributor

this looks to have to do with the "dist" part of the "distcheck" target

"distcheck" runs all the unit tests against an imputed source distribution?

@gerickson @turon

@gerickson
Copy link
Contributor

this looks to have to do with the "dist" part of the "distcheck" target

"distcheck" runs all the unit tests against an imputed source distribution?

@gerickson @turon

The 'distcheck' target effectively runs the following:

  • make dist
    • Create an archive distribution.
  • Unarchive that distribution.
  • make
    • Build the distribution.
  • make dvi
    • Build device independent file format documentation (no-op)
  • make check
    • Run any integration, functional, and unit tests in-tree (if defined).
  • make install
    • Install package executables, headers, data, libraries, etc. to package-default location.
  • make installcheck
    • Run any integration, functional, and unit tests against what was installed (if defined).
  • make uninstall
    • Uninstall package executables, headers, data, libraries, etc. from package-default location.
  • make distuninstallcheck
    • Ensure your package didn't leave any orphan files behind from package-default location.
  • make DESTDIR=<temporary destination directory> install
    • Install package executables, headers, data, libraries, etc. to user-specified location.
  • make DESTDIR=<temporary destination directory> uninstall
    • Uninstall package executables, headers, data, libraries, etc. from user-specified location.
  • make DESTDIR=<temporary destination directory> distuninstallcheck
    • Ensure your package didn't leave any orphan files behind from user-specified location.
  • make dist
    • Create an archive distribution from the distribution that was created earlier.
  • make distcleancheck
    • Execute make distclean and ensure that the distribution contains no temporary files that were not in the distribution when it was unarchived.

@bhaskar-apple bhaskar-apple deleted the BS-fixbuild branch April 10, 2020 05:33
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request Oct 13, 2022
@rerasool @mkardous-silabs
Pull request project-chip#179: Bump third_party/silabs/matter_support…
b2c5d8b 
… in silabs_1.0 for BRD4316, BRD4317 and BRD4319 bootloaders

Merge in WMN_TOOLS/matter from sdk_support_update_for_bootloaders to silabs_1.0

Squashed commit of the following:

commit f6e15b585ab93911866f1bf7f1eb1d4671d85484
Author: Rehan Rasool <[email protected]>
Date:   Mon Oct 10 15:45:41 2022 -0400

    Bump third_party/silabs/matter_support for BRD4316, BRD4317 and BRD4319 bootloaders
nipatel-silabs pushed a commit to nipatel-silabs/connectedhomeip that referenced this pull request Oct 19, 2022
@rerasool @mkardous-silabs
Pull request project-chip#179: Bump third_party/silabs/matter_support…
597e042 
… in silabs_1.0 for BRD4316, BRD4317 and BRD4319 bootloaders

Merge in WMN_TOOLS/matter from sdk_support_update_for_bootloaders to silabs_1.0

Squashed commit of the following:

commit f6e15b585ab93911866f1bf7f1eb1d4671d85484
Author: Rehan Rasool <[email protected]>
Date:   Mon Oct 10 15:45:41 2022 -0400

    Bump third_party/silabs/matter_support for BRD4316, BRD4317 and BRD4319 bootloaders
mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip Nov 2, 2022
@rerasool @jmartinez-silabs
Pull request #179: Bump third_party/silabs/matter_support in silabs_1…
73c7cfe 
….0 for BRD4316, BRD4317 and BRD4319 bootloaders

Merge in WMN_TOOLS/matter from sdk_support_update_for_bootloaders to silabs_1.0

Squashed commit of the following:

commit f6e15b585ab93911866f1bf7f1eb1d4671d85484
Author: Rehan Rasool <[email protected]>
Date:   Mon Oct 10 15:45:41 2022 -0400

    Bump third_party/silabs/matter_support for BRD4316, BRD4317 and BRD4319 bootloaders
rerasool added a commit to SiliconLabs/matter that referenced this pull request Nov 2, 2022
@rerasool @jmartinez-silabs
Pull request project-chip#179: Bump third_party/silabs/matter_support…
1cc09fa 
… in silabs_1.0 for BRD4316, BRD4317 and BRD4319 bootloaders

Merge in WMN_TOOLS/matter from sdk_support_update_for_bootloaders to silabs_1.0

Squashed commit of the following:

commit f6e15b585ab93911866f1bf7f1eb1d4671d85484
Author: Rehan Rasool <[email protected]>
Date:   Mon Oct 10 15:45:41 2022 -0400

    Bump third_party/silabs/matter_support for BRD4316, BRD4317 and BRD4319 bootloaders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@hawk248 hawk248 hawk248 approved these changes

@gerickson gerickson gerickson approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@tpmanley tpmanley Awaiting requested review from tpmanley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bhaskar-apple @rwalker-apple @gerickson @hawk248 @woody-apple @Bhaskar-Sarma