-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce length constraints in access control #17817
Merged
mlepage-google
merged 36 commits into
project-chip:master
from
mlepage-google:enforce-length-constraints
May 10, 2022
Merged
Enforce length constraints in access control #17817
mlepage-google
merged 36 commits into
project-chip:master
from
mlepage-google:enforce-length-constraints
May 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor ACL persistent storage so it's in the server layer between the system layer (below it) and the cluster layer (above it). Refactor events using a new listener. Slightly reorder server layer initialization (e.g. access control system layer should initialize before cluster layer). Issue project-chip#14451 (and more)
Needed for event attribution.
These are detected by the test harness. :-(
Add some APIs for length constraints. Use them in system module and in cluster to enforce length constraints. Partially fixes project-chip#14455 Partially fixes project-chip#14460 Partially fixes project-chip#16034
pullapprove
bot
requested review from
andy31415,
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro and
Damian-Nordic
April 27, 2022 17:09
|
PR #17817: Size comparison from 11c49af to 1ed9545 Increases above 0.2%:
Increases (29 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (23 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, nrfconnect, telink)
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
approved these changes
Apr 27, 2022
src/app/clusters/access-control-server/access-control-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/access-control-server/access-control-server.cpp
Outdated
Show resolved
Hide resolved
PersistentStorageDelegate and FabricTable are injected now.
Mostly clarifying docs, removing a few unused functions that were missed, etc.
PR #17817: Size comparison from cfc3595 to a84ebcf Increases above 0.2%:
Increases (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, linux, mbed, nrfconnect, p6, telink)
Decreases (14 builds for cc13x2_26x2, cyw30739, efr32, esp32, linux, nrfconnect, telink)
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, linux, mbed, nrfconnect, p6, telink)
|
PR #17817: Size comparison from ad2520a to a4d0cd3 Increases (24 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, telink)
Decreases (11 builds for cc13x2_26x2, efr32, p6)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, p6, telink)
|
PR #17817: Size comparison from 9dc2682 to c988931 Increases (27 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, telink)
Decreases (12 builds for cc13x2_26x2, efr32, esp32, p6)
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Use RESOURCE_EXHAUSTED in some cases.
PR #17817: Size comparison from d85700e to 099bbf1 Increases (27 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, telink)
Decreases (20 builds for cc13x2_26x2, efr32, esp32, linux, p6)
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
May 9, 2022
PR #17817: Size comparison from d85700e to 24b37dd Increases (27 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, telink)
Decreases (20 builds for cc13x2_26x2, efr32, esp32, linux, p6)
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #17817: Size comparison from afb7ccb to a0e064b Increases (27 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, telink)
Decreases (20 builds for cc13x2_26x2, efr32, esp32, linux, p6)
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do Not Merge, Let mlepage merge it, needs dependent PR
Problem
Partially fixes #14455
Partially fixes #14460
Partially fixes #16034
Change overview
Add some APIs for length constraints. Use them in system module and in
cluster to enforce length constraints.
Partially fixes #14455
Partially fixes #14460
Partially fixes #16034
Testing