-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update zap data type schema #17645
Merged
woody-apple
merged 61 commits into
project-chip:master
from
brdandu:task/updateZapDataTypeSchema
May 11, 2022
Merged
Update zap data type schema #17645
woody-apple
merged 61 commits into
project-chip:master
from
brdandu:task/updateZapDataTypeSchema
May 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
lazarkov and
LuDuda
April 22, 2022 15:18
JIRa: ZAPP-757
…t know JIRa: ZAPP-757
JIRa: ZAPP-757
JIRA: ZAPP-757
JIRA: ZAPP-757
…ibility Cleaning up regex updating the zap repo JIRA: ZAPP-757
JIRa: ZAPP-757
JIRA: ZAPP-757
JIRa: ZAPP-757
…unnecessary diff JIRA: ZAPP-757
…hat we do not get unnecessary diff JIRA: ZAPP-757
…ary diff JIRA: ZAPP-757
…ary diff JIRA: ZAPP-757
JIRa: ZAPP-757
JIRA: ZAPP-757
brdandu
force-pushed
the
task/updateZapDataTypeSchema
branch
from
May 11, 2022 13:55
b9dec36
to
bb15a4e
Compare
PR #17645: Size comparison from e457c5c to bb15a4e Full report (18 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
|
JIRA: ZAPP-757
PR #17645: Size comparison from e457c5c to 9ae9759 Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
…as well as semicolons JIRa: ZAPP-757
PR #17645: Size comparison from e457c5c to 4e60c8a Increases (31 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (6 builds for cc13x2_26x2, k32w)
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
May 11, 2022
JIRa: ZAPP-757
PR #17645: Size comparison from e457c5c to 6e4d6cc Increases (33 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (6 builds for cc13x2_26x2, k32w)
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
May 11, 2022
jmartinez-silabs
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This involves the ZCL Data Type Schema rework along with the zap repo PR
Change overview
There is a DATA type schema change, data type loading changes into the db, sql query changes for helpers and other data type rework related changes
Testing
Was made sure existing unit tests continue passing with the schema changes
More zap unit tests were added for the new tables that were added for the data type re-work