Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tidy file readable #17613

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Make tidy file readable #17613

merged 2 commits into from
Apr 22, 2022

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Apr 21, 2022 •
edited
Loading

Problem

Clang-tidy checks list is one line that is not human readable.

Change overview

Change checks to multiline
Add a look-ahead assert for valid headers to not include third_party repos since that fails (specifically nlio fails when locally running against chip-tool)

Testing

CI validates that clang-tidy can still run.

@github-actions
Copy link

github-actions bot commented Apr 21, 2022 •
edited
Loading

PR #17613: Size comparison from 40842bf to e020255

Full report (2 builds for nrfconnect, telink)
platform target config section 40842bf e020255 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1170603 1170603 0 0.0
bss 136264 136264 0 0.0
rodata 150076 150076 0 0.0
text 805608 805608 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 801048 801048 0 0.0
bss 69696 69696 0 0.0
noinit 40416 40416 0 0.0
text 570370 570370 0 0.0

@andy31415
Ignore third_party in examples - examples often copy third_party and …
ad20bfa 
…we do not want to validate those (e.g. nlio errors out in else after return)
@github-actions
Copy link

github-actions bot commented Apr 21, 2022 •
edited
Loading

PR #17613: Size comparison from 40842bf to ad20bfa

Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 40842bf ad20bfa change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690947 690947 0 0.0
(read/write) 161980 161980 0 0.0
.bss 75912 75912 0 0.0
.data 3396 3396 0 0.0
.rodata 106043 106043 0 0.0
.text 584424 584424 0 0.0
lock-ftd LP_CC2652R7 (read only) 677311 677311 0 0.0
(read/write) 166584 166584 0 0.0
.bss 73936 73936 0 0.0
.data 3220 3220 0 0.0
.rodata 98807 98807 0 0.0
.text 578020 578020 0 0.0
lock-mtd LP_CC2652R7 (read only) 626063 626063 0 0.0
(read/write) 146732 146732 0 0.0
.bss 69656 69656 0 0.0
.data 3220 3220 0 0.0
.rodata 98687 98687 0 0.0
.text 526884 526884 0 0.0
pump-app LP_CC2652R7 (read only) 649139 649139 0 0.0
(read/write) 152500 152500 0 0.0
.bss 74368 74368 0 0.0
.data 3252 3252 0 0.0
.rodata 75379 75379 0 0.0
.text 573272 573272 0 0.0
pump-controller-app LP_CC2652R7 (read only) 642119 642119 0 0.0
(read/write) 151912 151912 0 0.0
.bss 74072 74072 0 0.0
.data 3216 3216 0 0.0
.rodata 78511 78511 0 0.0
.text 563120 563120 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618106 618106 0 0.0
.app_xip_area 525112 525112 0 0.0
.bss 75652 75652 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 613054 613054 0 0.0
.app_xip_area 521540 521540 0 0.0
.bss 74204 74204 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 565698 565698 0 0.0
.app_xip_area 464596 464596 0 0.0
.bss 83496 83496 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 905912 905912 0 0.0
(read/write) 129384 129384 0 0.0
.bss 127336 127336 0 0.0
.data 2044 2044 0 0.0
.text 905904 905904 0 0.0
BRD4161A+rpc (read only) 940312 940312 0 0.0
(read/write) 146064 146064 0 0.0
.bss 143816 143816 0 0.0
.data 2248 2248 0 0.0
.text 940304 940304 0 0.0
window-app BRD4161A (read only) 843400 843400 0 0.0
(read/write) 127472 127472 0 0.0
.bss 125512 125512 0 0.0
.data 1956 1956 0 0.0
.text 843392 843392 0 0.0
esp32 all-clusters-app c3devkit (read only) 985164 985164 0 0.0
(read/write) 1465954 1465954 0 0.0
.dram0.bss 62376 62376 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 204696 204696 0 0.0
.flash.text 985164 985164 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1040415 1040415 0 0.0
(read/write) 468112 468112 0 0.0
.dram0.bss 67896 67896 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 234212 234212 0 0.0
.flash.text 1035031 1035031 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684108 684108 0 0.0
.bss 77656 77656 0 0.0
.data 2000 2000 0 0.0
.text 598652 598652 0 0.0
lock k32w061+release (read/write) 725192 725192 0 0.0
.bss 78288 78288 0 0.0
.data 1960 1960 0 0.0
.text 639144 639144 0 0.0
linux all-clusters-app debug (read only) 2728521 2728521 0 0.0
(read/write) 149664 149664 0 0.0
.bss 59936 59936 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 81672 81672 0 0.0
.dynamic 608 608 0 0.0
.got 4448 4448 0 0.0
.init 27 27 0 0.0
.init_array 984 984 0 0.0
.rodata 233221 233221 0 0.0
.text 2320434 2320434 0 0.0
bridge-app debug+rpc (read only) 1842397 1842397 0 0.0
(read/write) 92016 92016 0 0.0
.bss 44136 44136 0 0.0
.data 3072 3072 0 0.0
.data.rel.ro 39744 39744 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 148961 148961 0 0.0
.text 1574293 1574293 0 0.0
chip-tool debug (read only) 10935181 10935181 0 0.0
(read/write) 375824 375824 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 345840 345840 0 0.0
.dynamic 624 624 0 0.0
.got 4936 4936 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 546421 546421 0 0.0
.text 9548821 9548821 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10547324 10547324 0 0.0
(read/write) 497697 497697 0 0.0
.bss 40865 40865 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 393160 393160 0 0.0
.dynamic 560 560 0 0.0
.got 58680 58680 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 520316 520316 0 0.0
.text 8909140 8909140 0 0.0
lighting-app debug+rpc (read only) 2319849 2319849 0 0.0
(read/write) 128080 128080 0 0.0
.bss 50016 50016 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70360 70360 0 0.0
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 183121 183121 0 0.0
.text 1970066 1970066 0 0.0
lock-app debug (read only) 2146377 2146377 0 0.0
(read/write) 120312 120312 0 0.0
.bss 47808 47808 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 65416 65416 0 0.0
.dynamic 592 592 0 0.0
.got 4264 4264 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 189441 189441 0 0.0
.text 1799794 1799794 0 0.0
ota-provider-app debug (read only) 2052953 2052953 0 0.0
(read/write) 115680 115680 0 0.0
.bss 48000 48000 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 173595 173595 0 0.0
.text 1721970 1721970 0 0.0
ota-requestor-app debug (read only) 2084169 2084169 0 0.0
(read/write) 118488 118488 0 0.0
.bss 48672 48672 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62296 62296 0 0.0
.dynamic 592 592 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 169916 169916 0 0.0
.text 1755378 1755378 0 0.0
shell debug (read only) 2555065 2555065 0 0.0
(read/write) 150408 150408 0 0.0
.bss 67336 67336 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 76000 76000 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 215410 215410 0 0.0
.text 2177698 2177698 0 0.0
thermostat-no-ble arm64 (read only) 2361868 2361868 0 0.0
(read/write) 151185 151185 0 0.0
.bss 62897 62897 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 79040 79040 0 0.0
.dynamic 560 560 0 0.0
.got 4744 4744 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145164 145164 0 0.0
.text 1987520 1987520 0 0.0
tv-app debug (read only) 2838841 2838841 0 0.0
(read/write) 253424 253424 0 0.0
.bss 165944 165944 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76632 76632 0 0.0
.dynamic 592 592 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 215371 215371 0 0.0
.text 2440914 2440914 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2410068 2410068 0 0.0
.bss 184996 184996 0 0.0
.data 5848 5848 0 0.0
.text 1372668 1372668 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1170603 1170603 0 0.0
bss 136264 136264 0 0.0
rodata 150076 150076 0 0.0
text 805608 805608 0 0.0
p6 all-clusters-app default (read/write) 2524632 2524632 0 0.0
.bss 118368 118368 0 0.0
.data 2784 2784 0 0.0
.text 1482896 1482896 0 0.0
light-app default (read/write) 2416368 2416368 0 0.0
.bss 111848 111848 0 0.0
.data 2584 2584 0 0.0
.text 1374632 1374632 0 0.0
lock-app default (read/write) 2420568 2420568 0 0.0
.bss 111648 111648 0 0.0
.data 2544 2544 0 0.0
.text 1378832 1378832 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 801048 801048 0 0.0
bss 69696 69696 0 0.0
noinit 40416 40416 0 0.0
text 570370 570370 0 0.0

@andy31415 andy31415 merged commit 253ff55 into project-chip:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy31415 @bzbarsky-apple