Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EFR32] Fix idle task overflow #17560

Merged
merged 2 commits into from
Apr 20, 2022
Merged

[EFR32] Fix idle task overflow #17560

merged 2 commits into from
Apr 20, 2022

Conversation

mkardous-silabs
Copy link
Contributor

Problem

Idle task was overflowing

Change overview

Increase idle task stack

Testing

Manual tests on Mg12 and Mg24 to validate fix

@github-actions
Copy link

github-actions bot commented Apr 20, 2022 •
edited
Loading

PR #17560: Size comparison from afd1801 to ed4239c

Increases above 0.2%:

platform target config section afd1801 ed4239c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 684907 691035 6128 0.9
.rodata 103307 106163 2856 2.8
.text 581120 584392 3272 0.6
efr32 lighting-app BRD4161A (read/write) 128636 129356 720 0.6
.bss 126592 127312 720 0.6
BRD4161A+rpc (read/write) 145320 146040 720 0.5
.bss 143072 143792 720 0.5
window-app BRD4161A (read/write) 126724 127444 720 0.6
.bss 124768 125488 720 0.6
esp32 all-clusters-app c3devkit (read only) 981316 985068 3752 0.4
(read/write) 1397706 1466138 68432 4.9
.flash.rodata 202016 204912 2896 1.4
.flash.text 981316 985068 3752 0.4
m5stack (read only) 1036835 1040355 3520 0.3
(read/write) 465456 468312 2856 0.6
.flash.rodata 231580 234436 2856 1.2
.flash.text 1031451 1034971 3520 0.3
linux all-clusters-app debug (read only) 2710057 2728025 17968 0.7
.text 2301906 2319938 18032 0.8
shell debug (read only) 2537321 2554601 17280 0.7
.text 2159954 2177202 17248 0.8
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1164667 1170799 6132 0.5
rodata 147468 150320 2852 1.9
text 802280 805560 3280 0.4
p6 all-clusters-app default (read/write) 2517920 2524856 6936 0.3
.text 1476184 1483120 6936 0.5
Increases (17 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6)
platform target config section afd1801 ed4239c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 684907 691035 6128 0.9
.rodata 103307 106163 2856 2.8
.text 581120 584392 3272 0.6
lock-ftd LP_CC2652R7 (read only) 677219 677483 264 0.0
.rodata 98971 99011 40 0.0
.text 577764 577988 224 0.0
lock-mtd LP_CC2652R7 (read only) 625971 626235 264 0.0
.rodata 98851 98891 40 0.0
.text 526628 526852 224 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 612830 613086 256 0.0
.app_xip_area 521340 521596 256 0.0
efr32 lighting-app BRD4161A (read/write) 128636 129356 720 0.6
.bss 126592 127312 720 0.6
BRD4161A+rpc (read/write) 145320 146040 720 0.5
.bss 143072 143792 720 0.5
window-app BRD4161A (read/write) 126724 127444 720 0.6
.bss 124768 125488 720 0.6
esp32 all-clusters-app c3devkit (read only) 981316 985068 3752 0.4
(read/write) 1397706 1466138 68432 4.9
.flash.rodata 202016 204912 2896 1.4
.flash.text 981316 985068 3752 0.4
m5stack (read only) 1036835 1040355 3520 0.3
(read/write) 465456 468312 2856 0.6
.flash.rodata 231580 234436 2856 1.2
.flash.text 1031451 1034971 3520 0.3
k32w lock k32w061+release (read/write) 724976 725240 264 0.0
.text 638952 639216 264 0.0
linux all-clusters-app debug (read only) 2710057 2728025 17968 0.7
.text 2301906 2319938 18032 0.8
lock-app debug (read only) 2145177 2146313 1136 0.1
.text 1798466 1799698 1232 0.1
shell debug (read only) 2537321 2554601 17280 0.7
.rodata 215410 215442 32 0.0
.text 2159954 2177202 17248 0.8
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2410012 2410244 232 0.0
.text 1372612 1372844 232 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1164667 1170799 6132 0.5
rodata 147468 150320 2852 1.9
text 802280 805560 3280 0.4
p6 all-clusters-app default (read/write) 2517920 2524856 6936 0.3
.text 1476184 1483120 6936 0.5
lock-app default (read/write) 2420464 2420760 296 0.0
.text 1378728 1379024 296 0.0
Decreases (4 builds for cc13x2_26x2, linux)
platform target config section afd1801 ed4239c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 167996 161868 -6128 -3.6
lock-ftd LP_CC2652R7 (read/write) 166652 166388 -264 -0.2
linux all-clusters-app debug .rodata 233285 233221 -64 -0.0
lock-app debug .rodata 189569 189473 -96 -0.1
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section afd1801 ed4239c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 684907 691035 6128 0.9
(read/write) 167996 161868 -6128 -3.6
.bss 75888 75888 0 0.0
.data 3396 3396 0 0.0
.rodata 103307 106163 2856 2.8
.text 581120 584392 3272 0.6
lock-ftd LP_CC2652R7 (read only) 677219 677483 264 0.0
(read/write) 166652 166388 -264 -0.2
.bss 73912 73912 0 0.0
.data 3220 3220 0 0.0
.rodata 98971 99011 40 0.0
.text 577764 577988 224 0.0
lock-mtd LP_CC2652R7 (read only) 625971 626235 264 0.0
(read/write) 146708 146708 0 0.0
.bss 69632 69632 0 0.0
.data 3220 3220 0 0.0
.rodata 98851 98891 40 0.0
.text 526628 526852 224 0.0
pump-app LP_CC2652R7 (read only) 649251 649251 0 0.0
(read/write) 152476 152476 0 0.0
.bss 74344 74344 0 0.0
.data 3252 3252 0 0.0
.rodata 75531 75531 0 0.0
.text 573232 573232 0 0.0
pump-controller-app LP_CC2652R7 (read only) 642291 642291 0 0.0
(read/write) 151888 151888 0 0.0
.bss 74048 74048 0 0.0
.data 3216 3216 0 0.0
.rodata 78715 78715 0 0.0
.text 563088 563088 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618122 618122 0 0.0
.app_xip_area 525152 525152 0 0.0
.bss 75628 75628 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 612830 613086 256 0.0
.app_xip_area 521340 521596 256 0.0
.bss 74180 74180 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 565602 565602 0 0.0
.app_xip_area 464524 464524 0 0.0
.bss 83472 83472 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 905964 905964 0 0.0
(read/write) 128636 129356 720 0.6
.bss 126592 127312 720 0.6
.data 2044 2044 0 0.0
.text 905956 905956 0 0.0
BRD4161A+rpc (read only) 940356 940356 0 0.0
(read/write) 145320 146040 720 0.5
.bss 143072 143792 720 0.5
.data 2248 2248 0 0.0
.text 940348 940348 0 0.0
window-app BRD4161A (read only) 843452 843452 0 0.0
(read/write) 126724 127444 720 0.6
.bss 124768 125488 720 0.6
.data 1956 1956 0 0.0
.text 843444 843444 0 0.0
esp32 all-clusters-app c3devkit (read only) 981316 985068 3752 0.4
(read/write) 1397706 1466138 68432 4.9
.dram0.bss 62352 62352 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 202016 204912 2896 1.4
.flash.text 981316 985068 3752 0.4
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1036835 1040355 3520 0.3
(read/write) 465456 468312 2856 0.6
.dram0.bss 67872 67872 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 231580 234436 2856 1.2
.flash.text 1031451 1034971 3520 0.3
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684048 684048 0 0.0
.bss 77632 77632 0 0.0
.data 2000 2000 0 0.0
.text 598616 598616 0 0.0
lock k32w061+release (read/write) 724976 725240 264 0.0
.bss 78264 78264 0 0.0
.data 1960 1960 0 0.0
.text 638952 639216 264 0.0
linux all-clusters-app debug (read only) 2710057 2728025 17968 0.7
(read/write) 149664 149664 0 0.0
.bss 59936 59936 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 81672 81672 0 0.0
.dynamic 608 608 0 0.0
.got 4448 4448 0 0.0
.init 27 27 0 0.0
.init_array 984 984 0 0.0
.rodata 233285 233221 -64 -0.0
.text 2301906 2319938 18032 0.8
bridge-app debug+rpc (read only) 1842365 1842365 0 0.0
(read/write) 92016 92016 0 0.0
.bss 44136 44136 0 0.0
.data 3072 3072 0 0.0
.data.rel.ro 39744 39744 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 148961 148961 0 0.0
.text 1574261 1574261 0 0.0
chip-tool debug (read only) 10915517 10915517 0 0.0
(read/write) 375120 375120 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 345152 345152 0 0.0
.dynamic 624 624 0 0.0
.got 4936 4936 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 546005 546005 0 0.0
.text 9531109 9531109 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10530108 10530108 0 0.0
(read/write) 496897 496897 0 0.0
.bss 40865 40865 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 392424 392424 0 0.0
.dynamic 560 560 0 0.0
.got 58608 58608 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 519948 519948 0 0.0
.text 8894084 8894084 0 0.0
lighting-app debug+rpc (read only) 2319817 2319817 0 0.0
(read/write) 128048 128048 0 0.0
.bss 49984 49984 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70360 70360 0 0.0
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 183121 183121 0 0.0
.text 1970034 1970034 0 0.0
lock-app debug (read only) 2145177 2146313 1136 0.1
(read/write) 120312 120312 0 0.0
.bss 47808 47808 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 65416 65416 0 0.0
.dynamic 592 592 0 0.0
.got 4264 4264 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 189569 189473 -96 -0.1
.text 1798466 1799698 1232 0.1
ota-provider-app debug (read only) 2052953 2052953 0 0.0
(read/write) 115680 115680 0 0.0
.bss 48000 48000 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 173627 173627 0 0.0
.text 1721938 1721938 0 0.0
ota-requestor-app debug (read only) 2083737 2083737 0 0.0
(read/write) 118488 118488 0 0.0
.bss 48672 48672 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62296 62296 0 0.0
.dynamic 592 592 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 169916 169916 0 0.0
.text 1754946 1754946 0 0.0
shell debug (read only) 2537321 2554601 17280 0.7
(read/write) 150408 150408 0 0.0
.bss 67336 67336 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 76000 76000 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 215410 215442 32 0.0
.text 2159954 2177202 17248 0.8
thermostat-no-ble arm64 (read only) 2361388 2361388 0 0.0
(read/write) 151169 151169 0 0.0
.bss 62881 62881 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 79040 79040 0 0.0
.dynamic 560 560 0 0.0
.got 4744 4744 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145180 145180 0 0.0
.text 1987024 1987024 0 0.0
tv-app debug (read only) 2838385 2838385 0 0.0
(read/write) 253392 253392 0 0.0
.bss 165944 165944 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76600 76600 0 0.0
.dynamic 592 592 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 215371 215371 0 0.0
.text 2440482 2440482 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2410012 2410244 232 0.0
.bss 184972 184972 0 0.0
.data 5848 5848 0 0.0
.text 1372612 1372844 232 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1164667 1170799 6132 0.5
bss 136240 136240 0 0.0
rodata 147468 150320 2852 1.9
text 802280 805560 3280 0.4
p6 all-clusters-app default (read/write) 2517920 2524856 6936 0.3
.bss 118344 118344 0 0.0
.data 2784 2784 0 0.0
.text 1476184 1483120 6936 0.5
light-app default (read/write) 2416576 2416576 0 0.0
.bss 111824 111824 0 0.0
.data 2584 2584 0 0.0
.text 1374840 1374840 0 0.0
lock-app default (read/write) 2420464 2420760 296 0.0
.bss 111624 111624 0 0.0
.data 2544 2544 0 0.0
.text 1378728 1379024 296 0.0
telink lighting-app tlsr9518adk80d (read/write) 801104 801104 0 0.0
bss 69672 69672 0 0.0
noinit 40416 40416 0 0.0
text 570272 570272 0 0.0

@andy31415 andy31415 merged commit df02224 into project-chip:master Apr 20, 2022
@mkardous-silabs mkardous-silabs deleted the fix/idle_task branch April 21, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkardous-silabs @andy31415 @jmartinez-silabs