Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BUILDING.md #175

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Update BUILDING.md #175

merged 1 commit into from
Mar 31, 2020

Conversation

rwalker-apple
Copy link
Contributor

@rwalker-apple rwalker-apple commented Mar 31, 2020 •
edited
Loading

Problem

nit (missing ')' )

Summary of Changes

a ')'

helps with #143

BroderickCarlin
BroderickCarlin approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@BroderickCarlin BroderickCarlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😉

@woody-apple woody-apple merged commit 6723255 into project-chip:master Mar 31, 2020
@rwalker-apple rwalker-apple deleted the update-BUILDING branch March 31, 2020 20:32
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request Oct 13, 2022
@rerasool
Pull request project-chip#175: Cherry-Pick lite-light example from si…
fd6828d 
…labs to silabs_1.0

Merge in WMN_TOOLS/matter from cherry-pick/lite-light to silabs_1.0

Squashed commit of the following:

commit 563d97e2849488266acb2d9414ed79d2a2fe415c
Author: Rehan Rasool <[email protected]>
Date:   Mon Oct 10 13:34:14 2022 -0400

    Add old bluetooth header to fix lighting-lite-app compilation -- same header is used in other examples on 1.0 branch

commit 04204a07beef3dde113aa8b8e012898ad5c6c17a
Author: Rehan Rasool <[email protected]>
Date:   Mon Oct 10 13:18:17 2022 -0400

    Apply changes from c84abce to lighting-lite-app: update build.gn of silabs_examples to keep up with upstream changes

commit 7abb556e4d5ccf471b13c49974a399bf632a8062
Author: Mathieu Kardous <[email protected]>
Date:   Fri Oct 7 19:36:19 2022 +0000

    Pull request project-chip#166: Add lite light to Jenkinsfile

    Merge in WMN_TOOLS/matter from feature/add_lite_light to silabs

    Squashed commit of the following:

    commit 5f440ac92c3df57dbbb115ad8f49e1f4b0bd3b58
    Author: Mathieu Kardous <[email protected]>
    Date:   Fri Oct 7 14:04:53 2022 -0400

        Remove old ble header

    commit af7adb6fcc9962973d44e9382229b52206a19f31
    Author: Mathieu Kardous <[email protected]>
    Date:   Fri Oct 7 13:10:55 2022 -0400

        Fix lite light

    commit 966e3ce925c1993869c8b3f69e6c0ff205040759
    Author: Mathieu Kardous <[email protected]>
    Date:   Fri Oct 7 12:26:32 2022 -0400

        Add lite light to Jenkinsfile

... and 1 more commit
nipatel-silabs pushed a commit to nipatel-silabs/connectedhomeip that referenced this pull request Oct 19, 2022
@rerasool
Pull request project-chip#175: Cherry-Pick lite-light example from si…
4f3e3b8 
…labs to silabs_1.0

Merge in WMN_TOOLS/matter from cherry-pick/lite-light to silabs_1.0

Squashed commit of the following:

commit 563d97e2849488266acb2d9414ed79d2a2fe415c
Author: Rehan Rasool <[email protected]>
Date:   Mon Oct 10 13:34:14 2022 -0400

    Add old bluetooth header to fix lighting-lite-app compilation -- same header is used in other examples on 1.0 branch

commit 04204a07beef3dde113aa8b8e012898ad5c6c17a
Author: Rehan Rasool <[email protected]>
Date:   Mon Oct 10 13:18:17 2022 -0400

    Apply changes from c84abce to lighting-lite-app: update build.gn of silabs_examples to keep up with upstream changes

commit 7abb556e4d5ccf471b13c49974a399bf632a8062
Author: Mathieu Kardous <[email protected]>
Date:   Fri Oct 7 19:36:19 2022 +0000

    Pull request project-chip#166: Add lite light to Jenkinsfile

    Merge in WMN_TOOLS/matter from feature/add_lite_light to silabs

    Squashed commit of the following:

    commit 5f440ac92c3df57dbbb115ad8f49e1f4b0bd3b58
    Author: Mathieu Kardous <[email protected]>
    Date:   Fri Oct 7 14:04:53 2022 -0400

        Remove old ble header

    commit af7adb6fcc9962973d44e9382229b52206a19f31
    Author: Mathieu Kardous <[email protected]>
    Date:   Fri Oct 7 13:10:55 2022 -0400

        Fix lite light

    commit 966e3ce925c1993869c8b3f69e6c0ff205040759
    Author: Mathieu Kardous <[email protected]>
    Date:   Fri Oct 7 12:26:32 2022 -0400

        Add lite light to Jenkinsfile

... and 1 more commit
mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip Nov 2, 2022
@rerasool @jmartinez-silabs
Pull request #175: Cherry-Pick lite-light example from silabs to sila…
3aa33d6 
…bs_1.0

Merge in WMN_TOOLS/matter from cherry-pick/lite-light to silabs_1.0

Squashed commit of the following:

commit 563d97e2849488266acb2d9414ed79d2a2fe415c
Author: Rehan Rasool <[email protected]>
Date:   Mon Oct 10 13:34:14 2022 -0400

    Add old bluetooth header to fix lighting-lite-app compilation -- same header is used in other examples on 1.0 branch

commit 04204a07beef3dde113aa8b8e012898ad5c6c17a
Author: Rehan Rasool <[email protected]>
Date:   Mon Oct 10 13:18:17 2022 -0400

    Apply changes from c84abce to lighting-lite-app: update build.gn of silabs_examples to keep up with upstream changes

commit 7abb556e4d5ccf471b13c49974a399bf632a8062
Author: Mathieu Kardous <[email protected]>
Date:   Fri Oct 7 19:36:19 2022 +0000

    Pull request #166: Add lite light to Jenkinsfile

    Merge in WMN_TOOLS/matter from feature/add_lite_light to silabs

    Squashed commit of the following:

    commit 5f440ac92c3df57dbbb115ad8f49e1f4b0bd3b58
    Author: Mathieu Kardous <[email protected]>
    Date:   Fri Oct 7 14:04:53 2022 -0400

        Remove old ble header

    commit af7adb6fcc9962973d44e9382229b52206a19f31
    Author: Mathieu Kardous <[email protected]>
    Date:   Fri Oct 7 13:10:55 2022 -0400

        Fix lite light

    commit 966e3ce925c1993869c8b3f69e6c0ff205040759
    Author: Mathieu Kardous <[email protected]>
    Date:   Fri Oct 7 12:26:32 2022 -0400

        Add lite light to Jenkinsfile

... and 1 more commit
rerasool added a commit to SiliconLabs/matter that referenced this pull request Nov 2, 2022
@rerasool @jmartinez-silabs
Pull request project-chip#175: Cherry-Pick lite-light example from si…
af03d0c 
…labs to silabs_1.0

Merge in WMN_TOOLS/matter from cherry-pick/lite-light to silabs_1.0

Squashed commit of the following:

commit 563d97e2849488266acb2d9414ed79d2a2fe415c
Author: Rehan Rasool <[email protected]>
Date:   Mon Oct 10 13:34:14 2022 -0400

    Add old bluetooth header to fix lighting-lite-app compilation -- same header is used in other examples on 1.0 branch

commit 04204a07beef3dde113aa8b8e012898ad5c6c17a
Author: Rehan Rasool <[email protected]>
Date:   Mon Oct 10 13:18:17 2022 -0400

    Apply changes from c84abce to lighting-lite-app: update build.gn of silabs_examples to keep up with upstream changes

commit 7abb556e4d5ccf471b13c49974a399bf632a8062
Author: Mathieu Kardous <[email protected]>
Date:   Fri Oct 7 19:36:19 2022 +0000

    Pull request project-chip#166: Add lite light to Jenkinsfile

    Merge in WMN_TOOLS/matter from feature/add_lite_light to silabs

    Squashed commit of the following:

    commit 5f440ac92c3df57dbbb115ad8f49e1f4b0bd3b58
    Author: Mathieu Kardous <[email protected]>
    Date:   Fri Oct 7 14:04:53 2022 -0400

        Remove old ble header

    commit af7adb6fcc9962973d44e9382229b52206a19f31
    Author: Mathieu Kardous <[email protected]>
    Date:   Fri Oct 7 13:10:55 2022 -0400

        Fix lite light

    commit 966e3ce925c1993869c8b3f69e6c0ff205040759
    Author: Mathieu Kardous <[email protected]>
    Date:   Fri Oct 7 12:26:32 2022 -0400

        Add lite light to Jenkinsfile

... and 1 more commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@BroderickCarlin BroderickCarlin BroderickCarlin approved these changes

@gerickson gerickson gerickson approved these changes

@turon turon turon approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@tpmanley tpmanley Awaiting requested review from tpmanley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rwalker-apple @turon @gerickson @BroderickCarlin @woody-apple