Attempt to skip code in misspell #17335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02 and
mlepage-google
…uper obvious ones and have some code improvements
tcarmelveilleux
approved these changes
Apr 13, 2022
|
PR #17335: Size comparison from 184bda1 to d7aa3b0 Increases (19 builds for efr32, esp32, mbed, nrfconnect, telink)
Decreases (13 builds for cc13x2_26x2, cyw30739, linux)
Full report (43 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
* Attempt to skip code in misspell * Changed a readme.md containing odd words to see if filtering works * Escape a md file and try to ignore hyperlink content in spellcheck * More escaping for code in mbedos_commissioning.md * Add instructions for local spelling run * More updates to make spell checker happy * Cleanup some image logic in mbed unit test files * More updates for spelling - move code blocks into code blocks * More paths updates for lwip patch readme * Restyle * update for allow language in 3 backticks, replaced a lot of mbedos logo pictures * Code and image block updates on guides * Updating several nrf files for code blocks * update k32w android doc for code blocks * Code blocks for several readmes * Code blocks for some silabs and esp32 * Code blocks * More code blocks * More code blocks * More code blocks * More code blocks * More code blocks * Roll back some of the wordlist - this takes too long. Just fix some super obvious ones and have some code improvements * Restyle * Fix misplaced backtick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are spellchecking code in misspell, which results in strange 'words' being added to wordlist and generally creating developer overhead without a practical use (no use to say things like
fHtcwcAAAAAAAAAwQAAAAAAXPMlAAAAAAAis a word)Change overview
Uses https://facelessuser.github.io/pyspelling/configuration/#pipeline configuration to attempt to filter out code blocks (single or tripple backtics).
Removed some seemingly invalid words from the word list.
changed
examples/all-clusters-app/linux/README.mdsince that contained code that was spellchecked, to validate if we indeed now ignore those sections. Had to manually add code sections.Testing
Spell check may test itself.