Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 17211: TV Casting does not work on Mac #17214

Merged
merged 13 commits into from
Apr 12, 2022
Merged

Fix 17211: TV Casting does not work on Mac #17214

merged 13 commits into from
Apr 12, 2022

Conversation

chrisdecenzo
Copy link
Contributor

@chrisdecenzo chrisdecenzo commented Apr 8, 2022 •
edited
Loading

Problem

Change overview

  • Fix MDns instance filter
  • Update tv-casting-app to not use same files for storage (fixes "[SC] Failed to obtain IPK for initiating" error message)
  • Fix commissioning when BLE disabled
  • Add proper shell to casting app, with commands to discover and to request commissioning
  • Fix re-use of discovery controller

Testing

  • run tv-app and tv-casting-app from the same Mac

@boring-cyborg boring-cyborg bot added the app label Apr 8, 2022
@github-actions
Copy link

github-actions bot commented Apr 8, 2022 •
edited
Loading

PR #17214: Size comparison from ecf91b2 to 614ca11

Increases (2 builds for nrfconnect, p6)
platform target config section ecf91b2 614ca11 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154847 1154967 120 0.0
rodata 146408 146544 136 0.1
p6 all-clusters-app default (read/write) 2514008 2514152 144 0.0
.text 1472272 1472416 144 0.0
Decreases (3 builds for linux, nrfconnect)
platform target config section ecf91b2 614ca11 change % change
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10278380 10278364 -16 -0.0
.text 8662772 8662756 -16 -0.0
thermostat-no-ble arm64 (read only) 2351852 2351276 -576 -0.0
.rodata 144652 144524 -128 -0.1
.text 1978720 1978272 -448 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 794412 794408 -4 -0.0
Full report (7 builds for linux, mbed, nrfconnect, p6)
platform target config section ecf91b2 614ca11 change % change
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10278380 10278364 -16 -0.0
(read/write) 492193 492193 0 0.0
.bss 41009 41009 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 388824 388824 0 0.0
.dynamic 560 560 0 0.0
.got 57392 57392 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 512428 512428 0 0.0
.text 8662772 8662756 -16 -0.0
thermostat-no-ble arm64 (read only) 2351852 2351276 -576 -0.0
(read/write) 150833 150833 0 0.0
.bss 63025 63025 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 78600 78600 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144652 144524 -128 -0.1
.text 1978720 1978272 -448 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2367996 2367996 0 0.0
.bss 185076 185076 0 0.0
.data 5840 5840 0 0.0
.text 1330596 1330596 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154847 1154967 120 0.0
bss 135304 135304 0 0.0
rodata 146408 146544 136 0.1
text 794412 794408 -4 -0.0
p6 all-clusters-app default (read/write) 2514008 2514152 144 0.0
.bss 118480 118480 0 0.0
.data 2768 2768 0 0.0
.text 1472272 1472416 144 0.0
light-app default (read/write) 2414840 2414840 0 0.0
.bss 111976 111976 0 0.0
.data 2576 2576 0 0.0
.text 1373104 1373104 0 0.0
lock-app default (read/write) 2378408 2378408 0 0.0
.bss 111720 111720 0 0.0
.data 2536 2536 0 0.0
.text 1336672 1336672 0 0.0

andy31415
andy31415 reviewed Apr 8, 2022
View reviewed changes
examples/tv-casting-app/linux/main.cpp Outdated Show resolved Hide resolved
examples/tv-casting-app/linux/main.cpp Outdated Show resolved Hide resolved
examples/tv-casting-app/linux/main.cpp Outdated Show resolved Hide resolved
bzbarsky-apple
bzbarsky-apple reviewed Apr 8, 2022
View reviewed changes
examples/tv-casting-app/linux/CastingShellCommands.cpp Outdated Show resolved Hide resolved
examples/tv-casting-app/linux/main.cpp Outdated Show resolved Hide resolved
src/platform/Darwin/DnssdImpl.cpp Outdated Show resolved Hide resolved
@boring-cyborg boring-cyborg bot added the lib label Apr 12, 2022
@chrisdecenzo chrisdecenzo mentioned this pull request Apr 12, 2022
Open
@github-actions
Copy link

github-actions bot commented Apr 12, 2022 •
edited
Loading

PR #17214: Size comparison from 2e33dec to 945c867

Increases (8 builds for cyw30739, k32w, linux, nrfconnect, telink)
platform target config section 2e33dec 945c867 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 618514 618786 272 0.0
.app_xip_area 525224 525496 272 0.1
lock cyw930739m2evb_01 (read/write) 576126 576390 264 0.0
.app_xip_area 484372 484636 264 0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 564642 564906 264 0.0
.app_xip_area 463260 463524 264 0.1
k32w light k32w061+release (read/write) 686728 687004 276 0.0
.text 600764 601040 276 0.0
lock k32w061+release (read/write) 691360 691636 276 0.0
.text 604860 605136 276 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 1027722 10277236 16 0.0
.text 8661732 8661748 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155895 1156119 224 0.0
text 794976 795208 232 0.0
telink lighting-app tlsr9518adk80d (read/write) 800992 801232 240 0.0
text 569690 569926 236 0.0
Decreases (1 build for linux)
platform target config section 2e33dec 945c867 change % change
linux thermostat-no-ble arm64 (read only) 2352700 2352268 -432 -0.0
.rodata 144668 144540 -128 -0.1
.text 1979456 1979152 -304 -0.0
Full report (15 builds for cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 2e33dec 945c867 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 618514 618786 272 0.0
.app_xip_area 525224 525496 272 0.1
.bss 75956 75956 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 576126 576390 264 0.0
.app_xip_area 484372 484636 264 0.1
.bss 74452 74452 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 564642 564906 264 0.0
.app_xip_area 463260 463524 264 0.1
.bss 83784 83784 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 979666 979666 0 0.0
(read/write) 1397514 1397514 0 0.0
.dram0.bss 62624 62624 0 0.0
.dram0.data 14420 14420 0 0.0
.flash.rodata 201552 201552 0 0.0
.flash.text 979666 979666 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1035255 1035255 0 0.0
(read/write) 465252 465252 0 0.0
.dram0.bss 68144 68144 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 231120 231120 0 0.0
.flash.text 1029871 1029871 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 686728 687004 276 0.0
.bss 78128 78128 0 0.0
.data 2036 2036 0 0.0
.text 600764 601040 276 0.0
lock k32w061+release (read/write) 691360 691636 276 0.0
.bss 78704 78704 0 0.0
.data 1996 1996 0 0.0
.text 604860 605136 276 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 1027722 10277236 16 0.0
(read/write) 492193 492193 0 0.0
.bss 41009 41009 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 388816 388816 0 0.0
.dynamic 560 560 0 0.0
.got 57392 57392 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 512228 512228 0 0.0
.text 8661732 8661748 16 0.0
thermostat-no-ble arm64 (read only) 2352700 2352268 -432 -0.0
(read/write) 150993 150993 0 0.0
.bss 63153 63153 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 78632 78632 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144668 144540 -128 -0.1
.text 1979456 1979152 -304 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2368260 2368260 0 0.0
.bss 185236 185236 0 0.0
.data 5840 5840 0 0.0
.text 1330860 1330860 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155895 1156119 224 0.0
bss 135464 135464 0 0.0
rodata 146768 146768 0 0.0
text 794976 795208 232 0.0
p6 all-clusters-app default (read/write) 2514688 2514688 0 0.0
.bss 118640 118640 0 0.0
.data 2768 2768 0 0.0
.text 1472952 1472952 0 0.0
light-app default (read/write) 2415160 2415160 0 0.0
.bss 112136 112136 0 0.0
.data 2576 2576 0 0.0
.text 1373424 1373424 0 0.0
lock-app default (read/write) 2378712 2378712 0 0.0
.bss 111880 111880 0 0.0
.data 2536 2536 0 0.0
.text 1336976 1336976 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 800992 801232 240 0.0
bss 69988 69988 0 0.0
noinit 40416 40416 0 0.0
text 569690 569926 236 0.0

@github-actions
Copy link

github-actions bot commented Apr 12, 2022 •
edited
Loading

PR #17214: Size comparison from 2e33dec to 8588d2d

Increases (15 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, nrfconnect, telink)
platform target config section 2e33dec 8588d2d change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 639911 640179 268 0.0
.rodata 80143 80163 20 0.0
.text 559276 559524 248 0.0
lock-mtd LP_CC2652R7 (read only) 588655 588923 268 0.0
.rodata 80023 80043 20 0.0
.text 508140 508388 248 0.0
pump-app LP_CC2652R7 (read only) 647995 648263 268 0.0
.rodata 75331 75351 20 0.0
.text 572176 572424 248 0.0
pump-controller-app LP_CC2652R7 (read only) 641967 642235 268 0.0
.rodata 78967 78987 20 0.0
.text 562512 562760 248 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618514 618786 272 0.0
.app_xip_area 525224 525496 272 0.1
lock cyw930739m2evb_01 (read/write) 576126 576390 264 0.0
.app_xip_area 484372 484636 264 0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 564642 564906 264 0.0
.app_xip_area 463260 463524 264 0.1
efr32 lighting-app BRD4161A (read only) 907004 907268 264 0.0
.text 906996 907260 264 0.0
BRD4161A+rpc (read only) 941372 941636 264 0.0
.text 941364 941628 264 0.0
window-app BRD4161A (read only) 843996 844276 280 0.0
.text 843988 844268 280 0.0
k32w light k32w061+release (read/write) 686728 687004 276 0.0
.text 600764 601040 276 0.0
lock k32w061+release (read/write) 691360 691636 276 0.0
.text 604860 605136 276 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 1027722 10277236 16 0.0
.text 8661732 8661748 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155895 1156119 224 0.0
text 794976 795208 232 0.0
telink lighting-app tlsr9518adk80d (read/write) 800992 801232 240 0.0
text 569690 569926 236 0.0
Decreases (1 build for linux)
platform target config section 2e33dec 8588d2d change % change
linux thermostat-no-ble arm64 (read only) 2352700 2352268 -432 -0.0
.rodata 144668 144540 -128 -0.1
.text 1979456 1979152 -304 -0.0
Full report (20 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 2e33dec 8588d2d change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 639911 640179 268 0.0
(read/write) 151212 151212 0 0.0
.bss 74144 74144 0 0.0
.data 3212 3212 0 0.0
.rodata 80143 80163 20 0.0
.text 559276 559524 248 0.0
lock-mtd LP_CC2652R7 (read only) 588655 588923 268 0.0
(read/write) 146932 146932 0 0.0
.bss 69864 69864 0 0.0
.data 3212 3212 0 0.0
.rodata 80023 80043 20 0.0
.text 508140 508388 248 0.0
pump-app LP_CC2652R7 (read only) 647995 648263 268 0.0
(read/write) 152508 152508 0 0.0
.bss 74640 74640 0 0.0
.data 3244 3244 0 0.0
.rodata 75331 75351 20 0.0
.text 572176 572424 248 0.0
pump-controller-app LP_CC2652R7 (read only) 641967 642235 268 0.0
(read/write) 152176 152176 0 0.0
.bss 74344 74344 0 0.0
.data 3208 3208 0 0.0
.rodata 78967 78987 20 0.0
.text 562512 562760 248 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618514 618786 272 0.0
.app_xip_area 525224 525496 272 0.1
.bss 75956 75956 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 576126 576390 264 0.0
.app_xip_area 484372 484636 264 0.1
.bss 74452 74452 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 564642 564906 264 0.0
.app_xip_area 463260 463524 264 0.1
.bss 83784 83784 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907004 907268 264 0.0
(read/write) 133080 133080 0 0.0
.bss 131040 131040 0 0.0
.data 2040 2040 0 0.0
.text 906996 907260 264 0.0
BRD4161A+rpc (read only) 941372 941636 264 0.0
(read/write) 149764 149764 0 0.0
.bss 147520 147520 0 0.0
.data 2244 2244 0 0.0
.text 941364 941628 264 0.0
window-app BRD4161A (read only) 843996 844276 280 0.0
(read/write) 131148 131148 0 0.0
.bss 129200 129200 0 0.0
.data 1948 1948 0 0.0
.text 843988 844268 280 0.0
k32w light k32w061+release (read/write) 686728 687004 276 0.0
.bss 78128 78128 0 0.0
.data 2036 2036 0 0.0
.text 600764 601040 276 0.0
lock k32w061+release (read/write) 691360 691636 276 0.0
.bss 78704 78704 0 0.0
.data 1996 1996 0 0.0
.text 604860 605136 276 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 1027722 10277236 16 0.0
(read/write) 492193 492193 0 0.0
.bss 41009 41009 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 388816 388816 0 0.0
.dynamic 560 560 0 0.0
.got 57392 57392 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 512228 512228 0 0.0
.text 8661732 8661748 16 0.0
thermostat-no-ble arm64 (read only) 2352700 2352268 -432 -0.0
(read/write) 150993 150993 0 0.0
.bss 63153 63153 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 78632 78632 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144668 144540 -128 -0.1
.text 1979456 1979152 -304 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2368260 2368260 0 0.0
.bss 185236 185236 0 0.0
.data 5840 5840 0 0.0
.text 1330860 1330860 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155895 1156119 224 0.0
bss 135464 135464 0 0.0
rodata 146768 146768 0 0.0
text 794976 795208 232 0.0
p6 all-clusters-app default (read/write) 2514688 2514688 0 0.0
.bss 118640 118640 0 0.0
.data 2768 2768 0 0.0
.text 1472952 1472952 0 0.0
light-app default (read/write) 2415160 2415160 0 0.0
.bss 112136 112136 0 0.0
.data 2576 2576 0 0.0
.text 1373424 1373424 0 0.0
lock-app default (read/write) 2378712 2378712 0 0.0
.bss 111880 111880 0 0.0
.data 2536 2536 0 0.0
.text 1336976 1336976 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 800992 801232 240 0.0
bss 69988 69988 0 0.0
noinit 40416 40416 0 0.0
text 569690 569926 236 0.0

@chrisdecenzo chrisdecenzo mentioned this pull request Apr 12, 2022
Open
@chrisdecenzo chrisdecenzo merged commit 3af5410 into master Apr 12, 2022
@chrisdecenzo chrisdecenzo deleted the tv-apps-mac branch April 12, 2022 22:57
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@chrisdecenzo @restyled-io
@restyled-commits @andrei-menzopol
Fix 17211: TV Casting does not work on Mac (project-chip#17214)
c27eec2 
* Fix MDns instance filter and iPK storage

* Fix commissioning when BLE disabled

* Add proper shell to tv-casting-app

* Fix re-use of discovery controller

* Add shell commands for launching content and printing bindings

* Address comments

* Address comments

* Address comments

* Address comments, formatting

* fix resolve by service name

* Restyled by clang-format (project-chip#17218)

Co-authored-by: Restyled.io <[email protected]>

* fix TIDY

Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com>
Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@sharadb-amazon sharadb-amazon sharadb-amazon approved these changes

@lazarkov lazarkov lazarkov approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

Assignees
No one assigned
Labels
app controller darwin examples lib platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TV Casting does not work on Mac
5 participants
@chrisdecenzo @andy31415 @lazarkov @sharadb-amazon @bzbarsky-apple