Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nrf-nrf52840dongle-light build #17212

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Fix nrf-nrf52840dongle-light build #17212

merged 1 commit into from
Apr 8, 2022

Conversation

andy31415
Copy link
Contributor

Problem

build-examples fails to compile nrf dongle light:

2022-04-07 20:13:53 INFO    FAILED: zephyr/drivers/flash/CMakeFiles/drivers__flash.dir/nrf_qspi_nor.c.obj 
2022-04-07 20:13:53 INFO    /pwenv/cipd/packages/arm/bin/arm-none-eabi-gcc -DBUILD_VERSION=b05b8ad63acf -DKERNEL -DNRF52840_XXAA -DUSE_PARTITION_MANAGER=1 -D_FORTIFY_SOURCE=2 -D__PROGRAM_START -D__ZEPHYR_SUPERVISOR__ -D__ZEPHYR__=1 -I/opt/NordicSemiconductor/nrfconnect/zephyr/include -Izephyr/include/generated -I/opt/NordicSemiconductor/nrfconnect/zephyr/soc/arm/nordic_nrf/nrf52 -I/opt/Nord…pt/NordicSemiconductor/nrfconnect/zephyr/lib/libc/minimal/include/errno.h:32,
2022-04-07 20:13:53 INFO                     from /opt/NordicSemiconductor/nrfconnect/zephyr/drivers/flash/nrf_qspi_nor.c:9:
2022-04-07 20:13:53 INFO    /opt/NordicSemiconductor/nrfconnect/zephyr/include/devicetree.h:305:40: error: 'DT_N_INST_0_nordic_qspi_nor_P_sck_frequency' undeclared here (not in a function)
2022-04-07 20:13:53 INFO      305 | #define DT_INST(inst, compat) UTIL_CAT(DT_N_INST, DT_DASH(inst, compat))

Change overview

It seems after #17174 we need a -DCONF_FILE=prj_no_dfu.conf configuration based on how CI is set up.

Testing

Compiled successfully locally after the change.

@boring-cyborg boring-cyborg bot added the scripts label Apr 8, 2022
@pullapprove pullapprove bot requested a review from anush-apple April 8, 2022 14:22
@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label Apr 8, 2022
@pullapprove pullapprove bot added review - pending and removed hotfix urgent fix needed, can bypass review labels Apr 8, 2022
@github-actions
Copy link

github-actions bot commented Apr 8, 2022 •
edited
Loading

PR #17212: Size comparison from ecf91b2 to b6b2097

Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ecf91b2 b6b2097 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 639379 639379 0 0.0
(read/write) 151052 151052 0 0.0
.bss 73984 73984 0 0.0
.data 3212 3212 0 0.0
.rodata 79955 79955 0 0.0
.text 558932 558932 0 0.0
lock-mtd LP_CC2652R7 (read only) 588115 588115 0 0.0
(read/write) 146772 146772 0 0.0
.bss 69704 69704 0 0.0
.data 3212 3212 0 0.0
.rodata 79835 79835 0 0.0
.text 507788 507788 0 0.0
pump-app LP_CC2652R7 (read only) 646759 646759 0 0.0
(read/write) 152260 152260 0 0.0
.bss 74392 74392 0 0.0
.data 3244 3244 0 0.0
.rodata 74663 74663 0 0.0
.text 571608 571608 0 0.0
pump-controller-app LP_CC2652R7 (read only) 641099 641099 0 0.0
(read/write) 151952 151952 0 0.0
.bss 74120 74120 0 0.0
.data 3208 3208 0 0.0
.rodata 78443 78443 0 0.0
.text 562168 562168 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 617822 617822 0 0.0
.app_xip_area 524948 524948 0 0.0
.bss 75540 75540 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 575426 575426 0 0.0
.app_xip_area 484088 484088 0 0.0
.bss 74036 74036 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 563918 563918 0 0.0
.app_xip_area 462952 462952 0 0.0
.bss 83368 83368 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 906400 906400 0 0.0
(read/write) 132920 132920 0 0.0
.bss 130880 130880 0 0.0
.data 2040 2040 0 0.0
.text 906392 906392 0 0.0
BRD4161A+rpc (read only) 934272 934272 0 0.0
(read/write) 148872 148872 0 0.0
.bss 146648 146648 0 0.0
.data 2220 2220 0 0.0
.text 934264 934264 0 0.0
window-app BRD4161A (read only) 843688 843688 0 0.0
(read/write) 130992 130992 0 0.0
.bss 129040 129040 0 0.0
.data 1948 1948 0 0.0
.text 843680 843680 0 0.0
esp32 all-clusters-app c3devkit (read only) 992918 992918 0 0.0
(read/write) 1462378 1462378 0 0.0
.dram0.bss 62960 62960 0 0.0
.dram0.data 14364 14364 0 0.0
.flash.rodata 199584 199584 0 0.0
.flash.text 992918 992918 0 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1045579 1045579 0 0.0
(read/write) 463440 463440 0 0.0
.dram0.bss 68480 68480 0 0.0
.dram0.data 34160 34160 0 0.0
.flash.rodata 228656 228656 0 0.0
.flash.text 1040195 1040195 0 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 686348 686348 0 0.0
.bss 77968 77968 0 0.0
.data 2036 2036 0 0.0
.text 600544 600544 0 0.0
lock k32w061+release (read/write) 690948 690948 0 0.0
.bss 78544 78544 0 0.0
.data 1996 1996 0 0.0
.text 604608 604608 0 0.0
linux all-clusters-app debug (read only) 2627009 2627009 0 0.0
(read/write) 146248 146248 0 0.0
.bss 57664 57664 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 80856 80856 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 222661 222661 0 0.0
.text 2233746 2233746 0 0.0
bridge-app debug+rpc (read only) 1834861 1834861 0 0.0
(read/write) 91592 91592 0 0.0
.bss 44344 44344 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 39240 39240 0 0.0
.dynamic 592 592 0 0.0
.got 3936 3936 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 148473 148473 0 0.0
.text 1568053 1568053 0 0.0
chip-tool debug (read only) 10677589 10677589 0 0.0
(read/write) 371768 371768 0 0.0
.bss 22752 22752 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 341680 341680 0 0.0
.dynamic 624 624 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 538165 538165 0 0.0
.text 9310341 9310341 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10278380 10278380 0 0.0
(read/write) 492193 492193 0 0.0
.bss 41009 41009 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 388824 388824 0 0.0
.dynamic 560 560 0 0.0
.got 57392 57392 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 512428 512428 0 0.0
.text 8662772 8662772 0 0.0
door-lock-app debug (read only) 2106049 2106049 0 0.0
(read/write) 119344 119344 0 0.0
.bss 47936 47936 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 64392 64392 0 0.0
.dynamic 592 592 0 0.0
.got 4264 4264 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 186505 186505 0 0.0
.text 1763938 1763938 0 0.0
lighting-app debug+rpc (read only) 2308649 2308649 0 0.0
(read/write) 127664 127664 0 0.0
.bss 50144 50144 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 69864 69864 0 0.0
.dynamic 608 608 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 181673 181673 0 0.0
.text 1961234 1961234 0 0.0
ota-provider-app debug (read only) 2043393 2043393 0 0.0
(read/write) 114784 114784 0 0.0
.bss 47840 47840 0 0.0
.data 1608 1608 0 0.0
.data.rel.ro 59576 59576 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 172451 172451 0 0.0
.text 1714850 1714850 0 0.0
ota-requestor-app debug (read only) 2073145 2073145 0 0.0
(read/write) 118104 118104 0 0.0
.bss 48800 48800 0 0.0
.data 1864 1864 0 0.0
.data.rel.ro 61832 61832 0 0.0
.dynamic 592 592 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 169132 169132 0 0.0
.text 1746050 1746050 0 0.0
shell debug (read only) 2521825 2521825 0 0.0
(read/write) 149680 149680 0 0.0
.bss 67368 67368 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 75336 75336 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 214290 214290 0 0.0
.text 2146466 2146466 0 0.0
thermostat-no-ble arm64 (read only) 2351852 2351852 0 0.0
(read/write) 150833 150833 0 0.0
.bss 63025 63025 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 78600 78600 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144652 144652 0 0.0
.text 1978720 1978720 0 0.0
tv-app debug (read only) 2797297 2797297 0 0.0
(read/write) 251576 251576 0 0.0
.bss 165032 165032 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 75888 75888 0 0.0
.dynamic 592 592 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 213451 213451 0 0.0
.text 2402738 2402738 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2367996 2367996 0 0.0
.bss 185076 185076 0 0.0
.data 5840 5840 0 0.0
.text 1330596 1330596 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154847 1154847 0 0.0
bss 135304 135304 0 0.0
rodata 146408 146408 0 0.0
text 794412 794412 0 0.0
p6 all-clusters-app default (read/write) 2514008 2514008 0 0.0
.bss 118480 118480 0 0.0
.data 2768 2768 0 0.0
.text 1472272 1472272 0 0.0
light-app default (read/write) 2414840 2414840 0 0.0
.bss 111976 111976 0 0.0
.data 2576 2576 0 0.0
.text 1373104 1373104 0 0.0
lock-app default (read/write) 2378408 2378408 0 0.0
.bss 111720 111720 0 0.0
.data 2536 2536 0 0.0
.text 1336672 1336672 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 800600 800600 0 0.0
bss 69828 69828 0 0.0
noinit 40416 40416 0 0.0
text 569474 569474 0 0.0

@andy31415 andy31415 merged commit bb9b3c4 into project-chip:master Apr 8, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@andy31415 @andrei-menzopol
Fix nrf-nrf52840dongle-light build (project-chip#17212)
85afc8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@saurabhst saurabhst saurabhst approved these changes

@mspang mspang mspang approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andy31415 @mspang @saurabhst @Damian-Nordic