add const for DeviceControllerSystemState getter methods

[holbrookt]

Problem

Accessor methods in DeviceControllerSystemState are not marked const and therefore cannot be called by a const DeviceControllerSystemState *. This is an issue since #16650 provides access to const DeviceControllerSystemState * via DeviceControllerFactory.

Change overview

Change DeviceControllerSystemState methods to be const.

Testing

N/A

[github-actions]

PR #16960: Size comparison from a673eb7 to 083ae18

Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)

platform	target	config	section	a673eb7	083ae18	change	% change
cc13x2_26x2	lock-ftd	LP_CC2652R7	(read only)	667427	667427	0	0.0
			(read/write)	184300	184300	0	0.0
			.bss	81768	81768	0	0.0
			.data	3132	3132	0	0.0
			.rodata	79707	79707	0	0.0
			.text	587240	587240	0	0.0
	lock-mtd	LP_CC2652R7	(read only)	616555	616555	0	0.0
			(read/write)	154484	154484	0	0.0
			.bss	77496	77496	0	0.0
			.data	3132	3132	0	0.0
			.rodata	79587	79587	0	0.0
			.text	536480	536480	0	0.0
	pump-app	LP_CC2652R7	(read only)	686887	686887	0	0.0
			(read/write)	166000	166000	0	0.0
			.bss	82160	82160	0	0.0
			.data	3164	3164	0	0.0
			.rodata	81783	81783	0	0.0
			.text	604620	604620	0	0.0
	pump-controller-app	LP_CC2652R7	(read only)	669111	669111	0	0.0
			(read/write)	183520	183520	0	0.0
			.bss	81904	81904	0	0.0
			.data	3128	3128	0	0.0
			.rodata	78119	78119	0	0.0
			.text	590508	590508	0	0.0
cyw30739	light	cyw930739m2evb_01	(read/write)	609810	609810	0	0.0
			.app_xip_area	516552	516552	0	0.0
			.bss	76004	76004	0	0.0
			.data	600	600	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	lock	cyw930739m2evb_01	(read/write)	567322	567322	0	0.0
			.app_xip_area	475600	475600	0	0.0
			.bss	74508	74508	0	0.0
			.data	564	564	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	578942	578942	0	0.0
			.app_xip_area	477580	477580	0	0.0
			.bss	83820	83820	0	0.0
			.data	504	504	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
efr32	lighting-app	BRD4161A	(read only)	914672	914672	0	0.0
			(read/write)	129760	129760	0	0.0
			.bss	127800	127800	0	0.0
			.data	1960	1960	0	0.0
			.text	914664	914664	0	0.0
		BRD4161A+rpc	(read only)	942552	942552	0	0.0
			(read/write)	145720	145720	0	0.0
			.bss	143576	143576	0	0.0
			.data	2140	2140	0	0.0
			.text	942544	942544	0	0.0
	window-app	BRD4161A	(read only)	850032	850032	0	0.0
			(read/write)	127784	127784	0	0.0
			.bss	125944	125944	0	0.0
			.data	1840	1840	0	0.0
			.text	850024	850024	0	0.0
esp32	all-clusters-app	c3devkit	(read only)	985074	985074	0	0.0
			(read/write)	1460586	1460586	0	0.0
			.dram0.bss	62952	62952	0	0.0
			.dram0.data	14172	14172	0	0.0
			.flash.rodata	197984	197984	0	0.0
			.flash.text	985074	985074	0	0.0
			.iram0.text	62572	62572	0	0.0
		m5stack	(read only)	1037635	1037635	0	0.0
			(read/write)	461608	461608	0	0.0
			.dram0.bss	68480	68480	0	0.0
			.dram0.data	34024	34024	0	0.0
			.flash.rodata	226960	226960	0	0.0
			.flash.text	1032251	1032251	0	0.0
			.iram0.text	123415	123415	0	0.0
k32w	light	k32w061+release	(read/write)	707256	707256	0	0.0
			.bss	77976	77976	0	0.0
			.data	1872	1872	0	0.0
			.text	621608	621608	0	0.0
	lock	k32w061+release	(read/write)	706664	706664	0	0.0
			.bss	77960	77960	0	0.0
			.data	1912	1912	0	0.0
			.text	620992	620992	0	0.0
linux	all-clusters-app	debug	(read only)	2574001	2574001	0	0.0
			(read/write)	144456	144456	0	0.0
			.bss	57600	57600	0	0.0
			.data	1328	1328	0	0.0
			.data.rel.ro	79640	79640	0	0.0
			.dynamic	592	592	0	0.0
			.got	4312	4312	0	0.0
			.init	27	27	0	0.0
			.init_array	960	960	0	0.0
			.rodata	220581	220581	0	0.0
			.text	2185954	2185954	0	0.0
	bridge-app	debug+rpc	(read only)	1785045	1785045	0	0.0
			(read/write)	90040	90040	0	0.0
			.bss	44584	44584	0	0.0
			.data	2000	2000	0	0.0
			.data.rel.ro	38352	38352	0	0.0
			.dynamic	592	592	0	0.0
			.got	3928	3928	0	0.0
			.init	27	27	0	0.0
			.init_array	552	552	0	0.0
			.rodata	147217	147217	0	0.0
			.text	1521653	1521653	0	0.0
	chip-tool	debug	(read only)	10423837	10423837	0	0.0
			(read/write)	358040	358040	0	0.0
			.bss	22016	22016	0	0.0
			.data	1072	1072	0	0.0
			.data.rel.ro	328728	328728	0	0.0
			.dynamic	624	624	0	0.0
			.got	4896	4896	0	0.0
			.init	27	27	0	0.0
			.init_array	656	656	0	0.0
			.rodata	531597	531597	0	0.0
			.text	9100965	9100965	0	0.0
	chip-tool-no-interactive-ipv6only	arm64	(read only)	10025340	10025340	0	0.0
			(read/write)	477521	477521	0	0.0
			.bss	40337	40337	0	0.0
			.data	1136	1136	0	0.0
			.data.rel.ro	375576	375576	0	0.0
			.dynamic	560	560	0	0.0
			.got	56680	56680	0	0.0
			.init	24	24	0	0.0
			.init_array	184	184	0	0.0
			.rodata	506044	506044	0	0.0
			.text	8456260	8456260	0	0.0
	door-lock-app	debug	(read only)	2055745	2055745	0	0.0
			(read/write)	117936	117936	0	0.0
			.bss	47840	47840	0	0.0
			.data	1072	1072	0	0.0
			.data.rel.ro	63448	63448	0	0.0
			.dynamic	592	592	0	0.0
			.got	4256	4256	0	0.0
			.init	27	27	0	0.0
			.init_array	680	680	0	0.0
			.rodata	185057	185057	0	0.0
			.text	1717330	1717330	0	0.0
	lighting-app	debug+rpc	(read only)	2233609	2233609	0	0.0
			(read/write)	124896	124896	0	0.0
			.bss	49152	49152	0	0.0
			.data	1520	1520	0	0.0
			.data.rel.ro	68520	68520	0	0.0
			.dynamic	608	608	0	0.0
			.got	4304	4304	0	0.0
			.init	27	27	0	0.0
			.init_array	760	760	0	0.0
			.rodata	179073	179073	0	0.0
			.text	1891810	1891810	0	0.0
	ota-provider-app	debug	(read only)	1993713	1993713	0	0.0
			(read/write)	113504	113504	0	0.0
			.bss	47680	47680	0	0.0
			.data	1320	1320	0	0.0
			.data.rel.ro	58760	58760	0	0.0
			.dynamic	608	608	0	0.0
			.got	4456	4456	0	0.0
			.init	27	27	0	0.0
			.init_array	632	632	0	0.0
			.rodata	170851	170851	0	0.0
			.text	1668594	1668594	0	0.0
	ota-requestor-app	debug	(read only)	2022545	2022545	0	0.0
			(read/write)	116728	116728	0	0.0
			.bss	48672	48672	0	0.0
			.data	1512	1512	0	0.0
			.data.rel.ro	60968	60968	0	0.0
			.dynamic	592	592	0	0.0
			.got	4296	4296	0	0.0
			.init	27	27	0	0.0
			.init_array	656	656	0	0.0
			.rodata	167084	167084	0	0.0
			.text	1699538	1699538	0	0.0
	shell	debug	(read only)	2471185	2471185	0	0.0
			(read/write)	147952	147952	0	0.0
			.bss	67304	67304	0	0.0
			.data	784	784	0	0.0
			.data.rel.ro	74136	74136	0	0.0
			.dynamic	592	592	0	0.0
			.got	4160	4160	0	0.0
			.init	27	27	0	0.0
			.init_array	928	928	0	0.0
			.rodata	212498	212498	0	0.0
			.text	2100754	2100754	0	0.0
	thermostat-no-ble	arm64	(read only)	2308604	2308604	0	0.0
			(read/write)	149137	149137	0	0.0
			.bss	62961	62961	0	0.0
			.data	1080	1080	0	0.0
			.data.rel.ro	77496	77496	0	0.0
			.dynamic	560	560	0	0.0
			.got	4576	4576	0	0.0
			.init	24	24	0	0.0
			.init_array	368	368	0	0.0
			.rodata	143036	143036	0	0.0
			.text	1940384	1940384	0	0.0
	tv-app	debug	(read only)	2738217	2738217	0	0.0
			(read/write)	249440	249440	0	0.0
			.bss	165264	165264	0	0.0
			.data	3328	3328	0	0.0
			.data.rel.ro	74680	74680	0	0.0
			.dynamic	592	592	0	0.0
			.got	4656	4656	0	0.0
			.init	27	27	0	0.0
			.init_array	904	904	0	0.0
			.rodata	210699	210699	0	0.0
			.text	2349554	2349554	0	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2358716	2358716	0	0.0
			.bss	185052	185052	0	0.0
			.data	5760	5760	0	0.0
			.text	1321316	1321316	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1148055	1148055	0	0.0
			bss	143076	143076	0	0.0
			rodata	143320	143320	0	0.0
			text	786840	786840	0	0.0
p6	all-clusters-app	default	(read/write)	2503216	2503216	0	0.0
			.bss	118488	118488	0	0.0
			.data	2640	2640	0	0.0
			.text	1461480	1461480	0	0.0
	light-app	default	(read/write)	2404400	2404400	0	0.0
			.bss	111944	111944	0	0.0
			.data	2496	2496	0	0.0
			.text	1362664	1362664	0	0.0
	lock-app	default	(read/write)	2368008	2368008	0	0.0
			.bss	111688	111688	0	0.0
			.data	2456	2456	0	0.0
			.text	1326272	1326272	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	791456	791456	0	0.0
			bss	70296	70296	0	0.0
			noinit	40416	40416	0	0.0
			text	561310	561310	0	0.0