Allow Storage, Groups and Access Delegate injection on Server::Init() #16956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Clean-up Server::Init() arguments to have a single extendable struct of arguments. - Extract `Server::DeviceStorageDelegate` to a new reusable `KvsPersistentStorageDelegate` class - Allow injection of group data provider - Allow injection if - Fix names of the operational/UDC ports that were misleading - Show usage of new injection via a couple line delta on all examples. Fixes project-chip#12276
pullapprove
bot
requested review from
andy31415,
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
mspang
jmartinez-silabs
approved these changes
Apr 1, 2022
|
PR #16956: Size comparison from a673eb7 to eb102bc Increases above 0.2%:
Increases (26 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, nrfconnect, p6, telink)
Decreases (14 builds for cc13x2_26x2, linux, nrfconnect)
Full report (27 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, nrfconnect, p6, telink)
|
|
PR #16956: Size comparison from a673eb7 to c9f0756 Increases above 0.2%:
Increases (40 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (16 builds for cc13x2_26x2, esp32, linux, nrfconnect)
Full report (42 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #16956: Size comparison from a673eb7 to ca229ce Increases above 0.2%:
Increases (42 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (14 builds for cc13x2_26x2, esp32, nrfconnect)
Full report (42 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
reviewed
Apr 4, 2022
Damian-Nordic
approved these changes
Apr 4, 2022
msandstedt
reviewed
Apr 4, 2022
|
PR #16956: Size comparison from 3666138 to d668313 Increases above 0.2%:
Increases (40 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (16 builds for cc13x2_26x2, esp32, linux, nrfconnect)
Full report (42 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Apr 4, 2022
msandstedt
approved these changes
Apr 4, 2022
tcarmelveilleux
added a commit
to tcarmelveilleux/connectedhomeip
that referenced
this pull request
Apr 4, 2022
- During review of 16956, some editorial comments were added about Server.h comments when the PR was near passing CI. This PR follows-up the promised editorial changes.
tcarmelveilleux
added a commit
that referenced
this pull request
Apr 4, 2022
* Follow-up comment fixes in Server.h after #16956 - During review of 16956, some editorial comments were added about Server.h comments when the PR was near passing CI. This PR follows-up the promised editorial changes. * Update src/app/server/Server.h Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
…project-chip#16956) * Allow Storage, Groups and Access Delegate injection on Server::Init() - Clean-up Server::Init() arguments to have a single extendable struct of arguments. - Extract `Server::DeviceStorageDelegate` to a new reusable `KvsPersistentStorageDelegate` class - Allow injection of group data provider - Allow injection if - Fix names of the operational/UDC ports that were misleading - Show usage of new injection via a couple line delta on all examples. Fixes project-chip#12276 * Restyled by clang-format * Add missing refactors * Fix CI * Fix CI * Apply review comments Co-authored-by: Restyled.io <[email protected]>
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
…-chip#17009) * Follow-up comment fixes in Server.h after project-chip#16956 - During review of 16956, some editorial comments were added about Server.h comments when the PR was near passing CI. This PR follows-up the promised editorial changes. * Update src/app/server/Server.h Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
…project-chip#16956) * Allow Storage, Groups and Access Delegate injection on Server::Init() - Clean-up Server::Init() arguments to have a single extendable struct of arguments. - Extract `Server::DeviceStorageDelegate` to a new reusable `KvsPersistentStorageDelegate` class - Allow injection of group data provider - Allow injection if - Fix names of the operational/UDC ports that were misleading - Show usage of new injection via a couple line delta on all examples. Fixes project-chip#12276 * Restyled by clang-format * Add missing refactors * Fix CI * Fix CI * Apply review comments Co-authored-by: Restyled.io <[email protected]>
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
…-chip#17009) * Follow-up comment fixes in Server.h after project-chip#16956 - During review of 16956, some editorial comments were added about Server.h comments when the PR was near passing CI. This PR follows-up the promised editorial changes. * Update src/app/server/Server.h Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…project-chip#16956) * Allow Storage, Groups and Access Delegate injection on Server::Init() - Clean-up Server::Init() arguments to have a single extendable struct of arguments. - Extract `Server::DeviceStorageDelegate` to a new reusable `KvsPersistentStorageDelegate` class - Allow injection of group data provider - Allow injection if - Fix names of the operational/UDC ports that were misleading - Show usage of new injection via a couple line delta on all examples. Fixes project-chip#12276 * Restyled by clang-format * Add missing refactors * Fix CI * Fix CI * Apply review comments Co-authored-by: Restyled.io <[email protected]>
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…-chip#17009) * Follow-up comment fixes in Server.h after project-chip#16956 - During review of 16956, some editorial comments were added about Server.h comments when the PR was near passing CI. This PR follows-up the promised editorial changes. * Update src/app/server/Server.h Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Serverclass used by 100% of all examples, and most customer, does not allow override of the criticalPersistentStorageDelegate,GroupDataProviderandAccessControlDelegate, which all use storage a lot and can be optimized for different memory/performance trade-offs.It has been identified that injection of these would solve the problem without a significant burden.
Fixes #12276
Change overview
struct of arguments.
Server::DeviceStorageDelegateto a newreusable
KvsPersistentStorageDelegateclassTesting