Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chip-tool: use correct interface when specified #16833

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

bluebin14
Copy link
Contributor

Problem

chip-tool fails on Darwin when using commands that require an ipv6 address. The interface is required to make it work. chip-tool parses the interface passed on command line but ignores it.

Change overview

Use correct interface when specified. When unspecified, the behavior is unchanged.

Testing

Tested manually using pairing ethernet command.

@github-actions
Copy link

github-actions bot commented Mar 30, 2022

PR #16833: Size comparison from 0f8d2c9 to 0b4d0eb

Increases (2 builds for linux)
platform target config section 0f8d2c9 0b4d0eb change % change
linux chip-tool debug (read only) 10311229 10311293 64 0.0
.text 8999013 8999077 64 0.0
chip-tool-ipv6only arm64 (read only) 9923868 9923996 128 0.0
.text 8365268 8365396 128 0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0f8d2c9 0b4d0eb change % change
cyw30739 light cyw930739m2evb_01 (read/write) 607198 607198 0 0.0
.app_xip_area 513968 513968 0 0.0
.bss 75976 75976 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 564738 564738 0 0.0
.app_xip_area 473036 473036 0 0.0
.bss 74480 74480 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 576874 576874 0 0.0
.app_xip_area 475524 475524 0 0.0
.bss 83808 83808 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 928152 928152 0 0.0
(read/write) 129112 129112 0 0.0
.bss 127112 127112 0 0.0
.data 1996 1996 0 0.0
.text 928144 928144 0 0.0
BRD4161A+rpc (read only) 957160 957160 0 0.0
(read/write) 145064 145064 0 0.0
.bss 142888 142888 0 0.0
.data 2176 2176 0 0.0
.text 957152 957152 0 0.0
window-app BRD4161A (read only) 857636 857636 0 0.0
(read/write) 127072 127072 0 0.0
.bss 125200 125200 0 0.0
.data 1872 1872 0 0.0
.text 857628 857628 0 0.0
esp32 all-clusters-app c3devkit (read only) 968374 968374 0 0.0
(read/write) 1394770 1394770 0 0.0
.dram0.bss 62416 62416 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 199240 199240 0 0.0
.flash.text 968374 968374 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1024075 1024075 0 0.0
(read/write) 462532 462532 0 0.0
.dram0.bss 67944 67944 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228728 228728 0 0.0
.flash.text 1018691 1018691 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 705780 705780 0 0.0
.bss 77968 77968 0 0.0
.data 1876 1876 0 0.0
.text 620136 620136 0 0.0
lock k32w061+release (read/write) 704900 704900 0 0.0
.bss 77944 77944 0 0.0
.data 1916 1916 0 0.0
.text 619240 619240 0 0.0
linux all-clusters-app debug (read only) 2537441 2537441 0 0.0
(read/write) 143384 143384 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78952 78952 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 216613 216613 0 0.0
.text 2156930 2156930 0 0.0
bridge-app debug+rpc (read only) 1771221 1771221 0 0.0
(read/write) 89552 89552 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37968 37968 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 145004 145004 0 0.0
.text 1510789 1510789 0 0.0
chip-tool debug (read only) 10311229 10311293 64 0.0
(read/write) 356456 356456 0 0.0
.bss 22464 22464 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 326808 326808 0 0.0
.dynamic 608 608 0 0.0
.got 4824 4824 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 525877 525877 0 0.0
.text 8999013 8999077 64 0.0
chip-tool-ipv6only arm64 (read only) 9923868 9923996 128 0.0
(read/write) 475441 475441 0 0.0
.bss 40753 40753 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 373536 373536 0 0.0
.dynamic 560 560 0 0.0
.got 56200 56200 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 501012 501012 0 0.0
.text 8365268 8365396 128 0.0
door-lock-app debug (read only) 2023865 2023865 0 0.0
(read/write) 116928 116928 0 0.0
.bss 47648 47648 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62872 62872 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181596 181596 0 0.0
.text 1692386 1692386 0 0.0
lighting-app debug+rpc (read only) 2200153 2200153 0 0.0
(read/write) 123888 123888 0 0.0
.bss 48928 48928 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67944 67944 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175452 175452 0 0.0
.text 1865458 1865458 0 0.0
ota-provider-app debug (read only) 1964257 1964257 0 0.0
(read/write) 112720 112720 0 0.0
.bss 47584 47584 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58216 58216 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 167371 167371 0 0.0
.text 1644946 1644946 0 0.0
ota-requestor-app debug (read only) 1991481 1991481 0 0.0
(read/write) 115944 115944 0 0.0
.bss 48512 48512 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60472 60472 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 163556 163556 0 0.0
.text 1674978 1674978 0 0.0
shell debug (read only) 2452209 2452209 0 0.0
(read/write) 147400 147400 0 0.0
.bss 67304 67304 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73592 73592 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 210066 210066 0 0.0
.text 2085122 2085122 0 0.0
thermostat-no-ble arm64 (read only) 2281796 2281796 0 0.0
(read/write) 148353 148353 0 0.0
.bss 62817 62817 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 76976 76976 0 0.0
.dynamic 560 560 0 0.0
.got 4512 4512 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 140116 140116 0 0.0
.text 1918272 1918272 0 0.0
tv-app debug (read only) 2699817 2699817 0 0.0
(read/write) 247552 247552 0 0.0
.bss 164288 164288 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74064 74064 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206443 206443 0 0.0
.text 2318674 2318674 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357388 2357388 0 0.0
.bss 185020 185020 0 0.0
.data 5760 5760 0 0.0
.text 1319988 1319988 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1145211 1145211 0 0.0
bss 143052 143052 0 0.0
rodata 142516 142516 0 0.0
text 784788 784788 0 0.0
p6 all-clusters-app default (read/write) 2499976 2499976 0 0.0
.bss 118440 118440 0 0.0
.data 2640 2640 0 0.0
.text 1458240 1458240 0 0.0
light-app default (read/write) 2402144 2402144 0 0.0
.bss 111912 111912 0 0.0
.data 2496 2496 0 0.0
.text 1360408 1360408 0 0.0
lock-app default (read/write) 2365760 2365760 0 0.0
.bss 111656 111656 0 0.0
.data 2456 2456 0 0.0
.text 1324024 1324024 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 789580 789580 0 0.0
bss 70268 70268 0 0.0
noinit 40416 40416 0 0.0
text 559722 559722 0 0.0

@bluebin14 bluebin14 added the ipv6 All things IPv6 label Mar 30, 2022
@bzbarsky-apple bzbarsky-apple merged commit 8928308 into project-chip:master Mar 31, 2022
@bluebin14 bluebin14 deleted the fix-interface branch March 31, 2022 07:14
rochaferraz pushed a commit to rochaferraz/connectedhomeip that referenced this pull request Mar 31, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants