-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YAML] Issue an error on pairing timeout #16774
Merged
vivien-apple
merged 5 commits into
project-chip:master
from
vivien-apple:YAML_IssueErrorOnPairingTimeout
Apr 5, 2022
Merged
[YAML] Issue an error on pairing timeout #16774
vivien-apple
merged 5 commits into
project-chip:master
from
vivien-apple:YAML_IssueErrorOnPairingTimeout
Apr 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
lazarkov,
LuDuda and
lzgrablic02
March 29, 2022 15:28
vivien-apple
force-pushed
the
YAML_IssueErrorOnPairingTimeout
branch
2 times, most recently
from
March 30, 2022 12:47
35b4e48
to
f3869e8
Compare
PR #16774: Size comparison from b80df3d to f3869e8 Increases above 0.2%:
Increases (2 builds for linux)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
vivien-apple
force-pushed
the
YAML_IssueErrorOnPairingTimeout
branch
2 times, most recently
from
March 30, 2022 13:55
f05c15f
to
e7e6752
Compare
PR #16774: Size comparison from 0f8d2c9 to e7e6752 Increases above 0.2%:
Increases (3 builds for linux)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Mar 31, 2022
vivien-apple
force-pushed
the
YAML_IssueErrorOnPairingTimeout
branch
from
March 31, 2022 07:52
e7e6752
to
18795d8
Compare
PR #16774: Size comparison from a20ba1c to 18795d8 Increases above 0.2%:
Increases (3 builds for linux)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Mar 31, 2022
Fast tracking testing updates |
vivien-apple
force-pushed
the
YAML_IssueErrorOnPairingTimeout
branch
from
April 4, 2022 15:42
18795d8
to
f2ba6bd
Compare
PR #16774: Size comparison from 3666138 to f2ba6bd Increases above 0.2%:
Increases (3 builds for linux)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
…tead of a custom struct
…f simulated clusters
…nstead of internally keeping track of the expected status
vivien-apple
force-pushed
the
YAML_IssueErrorOnPairingTimeout
branch
from
April 5, 2022 07:17
27d8314
to
109a73c
Compare
vivien-apple
force-pushed
the
YAML_IssueErrorOnPairingTimeout
branch
from
April 5, 2022 07:23
109a73c
to
6ba6a9c
Compare
PR #16774: Size comparison from e92157a to 6ba6a9c Increases above 0.2%:
Increases (3 builds for linux)
Full report (28 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a YAML test is trying to pair to a device but can not find any advertisement it just wait until the whole test times out.
This PR update the YAML format to have a common path for "simulated" clusters such as "discovery" and "commissioner" since the "commissioner" simulated cluster is what is used to pair with devices.
Then it also add a timer to
SetUpCodePairer
to cancel everything after a given timeout - where the value of the timeout is the one use for other pairing methods intoCHIPDeviceController
.Also there are a few more changes to the
zapt
templates than what is needed since this was some code I have to migrate the YAML c++ backend fromInvoke
toReadClient/WriteClient/CommandSender
fix #16017
Change overview
Update
src/app/tests/suites/commands/discovery
to use a decodable type when it returns a value instead of a custom struct.Update
src/app/tests/suites/commands/commissioner
to use the sameOnResponse
path into YAML generated code.Add a timer to
SetUpCodePairer
Add a test to check if not finding any device triggers an error as expected
Testing
A test has been added to
TestMultiAdmin.yaml