Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve default countryCodeSize when not set on commissioner #16724

Merged
merged 4 commits into from
Mar 31, 2022
Merged

Resolve default countryCodeSize when not set on commissioner #16724

merged 4 commits into from
Mar 31, 2022

Conversation

adabreuti
Copy link
Contributor

Problem

Change overview

Update commissioner to correctly set the default country code size.

Testing

Linux RPI based CHIP-tool - ble-thread pairinig using out of box configuration on CC13x2x7 device.

@github-actions
Copy link

github-actions bot commented Mar 28, 2022 •
edited
Loading

PR #16724: Size comparison from 125e73c to 1c1e29a

Increases (2 builds for linux)
platform target config section 125e73c 1c1e29a change % change
linux chip-tool debug (read only) 10183973 10183989 16 0.0
.text 8880629 8880645 16 0.0
chip-tool-ipv6only arm64 (read only) 9815548 9815564 16 0.0
.text 8268164 8268180 16 0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 125e73c 1c1e29a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 605426 605426 0 0.0
.app_xip_area 512356 512356 0 0.0
.bss 75816 75816 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563238 563238 0 0.0
.app_xip_area 471696 471696 0 0.0
.bss 74320 74320 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575498 575498 0 0.0
.app_xip_area 474308 474308 0 0.0
.bss 83648 83648 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 926600 926600 0 0.0
(read/write) 128952 128952 0 0.0
.bss 126952 126952 0 0.0
.data 1996 1996 0 0.0
.text 926592 926592 0 0.0
BRD4161A+rpc (read only) 955416 955416 0 0.0
(read/write) 144904 144904 0 0.0
.bss 142728 142728 0 0.0
.data 2176 2176 0 0.0
.text 955408 955408 0 0.0
window-app BRD4161A (read only) 856004 856004 0 0.0
(read/write) 126912 126912 0 0.0
.bss 125040 125040 0 0.0
.data 1872 1872 0 0.0
.text 855996 855996 0 0.0
esp32 all-clusters-app c3devkit (read only) 966714 966714 0 0.0
(read/write) 1394810 1394810 0 0.0
.dram0.bss 62240 62240 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 199456 199456 0 0.0
.flash.text 966714 966714 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1023131 1023131 0 0.0
(read/write) 462572 462572 0 0.0
.dram0.bss 67768 67768 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228944 228944 0 0.0
.flash.text 1017747 1017747 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 704272 704272 0 0.0
.bss 77808 77808 0 0.0
.data 1876 1876 0 0.0
.text 618788 618788 0 0.0
lock k32w061+release (read/write) 703364 703364 0 0.0
.bss 77784 77784 0 0.0
.data 1916 1916 0 0.0
.text 617864 617864 0 0.0
linux all-clusters-app debug (read only) 2525993 2525993 0 0.0
(read/write) 143352 143352 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78920 78920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 216549 216549 0 0.0
.text 2145618 2145618 0 0.0
bridge-app debug+rpc (read only) 1765325 1765325 0 0.0
(read/write) 89520 89520 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144684 144684 0 0.0
.text 1505285 1505285 0 0.0
chip-tool debug (read only) 10183973 10183989 16 0.0
(read/write) 355656 355656 0 0.0
.bss 22464 22464 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 326008 326008 0 0.0
.dynamic 608 608 0 0.0
.got 4824 4824 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 518805 518805 0 0.0
.text 8880629 8880645 16 0.0
chip-tool-ipv6only arm64 (read only) 9815548 9815564 16 0.0
(read/write) 473697 473697 0 0.0
.bss 40737 40737 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372656 372656 0 0.0
.dynamic 560 560 0 0.0
.got 55352 55352 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 494212 494212 0 0.0
.text 8268164 8268180 16 0.0
door-lock-app debug (read only) 2017153 2017153 0 0.0
(read/write) 116896 116896 0 0.0
.bss 47648 47648 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181276 181276 0 0.0
.text 1686066 1686066 0 0.0
lighting-app debug+rpc (read only) 2191489 2191489 0 0.0
(read/write) 123888 123888 0 0.0
.bss 48928 48928 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175356 175356 0 0.0
.text 1856962 1856962 0 0.0
ota-provider-app debug (read only) 1957977 1957977 0 0.0
(read/write) 112688 112688 0 0.0
.bss 47584 47584 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58184 58184 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 167115 167115 0 0.0
.text 1638994 1638994 0 0.0
ota-requestor-app debug (read only) 1985569 1985569 0 0.0
(read/write) 115912 115912 0 0.0
.bss 48512 48512 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60440 60440 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 163236 163236 0 0.0
.text 1669458 1669458 0 0.0
shell debug (read only) 2441625 2441625 0 0.0
(read/write) 147368 147368 0 0.0
.bss 67304 67304 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73568 73568 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 210034 210034 0 0.0
.text 2074642 2074642 0 0.0
thermostat-no-ble arm64 (read only) 2275156 2275156 0 0.0
(read/write) 148369 148369 0 0.0
.bss 62817 62817 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4504 4504 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 140036 140036 0 0.0
.text 1911760 1911760 0 0.0
tv-app debug (read only) 2688417 2688417 0 0.0
(read/write) 247520 247520 0 0.0
.bss 164288 164288 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74048 74048 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206059 206059 0 0.0
.text 2307730 2307730 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2355644 2355644 0 0.0
.bss 184860 184860 0 0.0
.data 5760 5760 0 0.0
.text 1318244 1318244 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1143379 1143379 0 0.0
bss 142892 142892 0 0.0
rodata 142364 142364 0 0.0
text 783240 783240 0 0.0
p6 all-clusters-app default (read/write) 2498384 2498384 0 0.0
.bss 118280 118280 0 0.0
.data 2640 2640 0 0.0
.text 1456648 1456648 0 0.0
light-app default (read/write) 2400816 2400816 0 0.0
.bss 111752 111752 0 0.0
.data 2496 2496 0 0.0
.text 1359080 1359080 0 0.0
lock-app default (read/write) 2364352 2364352 0 0.0
.bss 111496 111496 0 0.0
.data 2456 2456 0 0.0
.text 1322616 1322616 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 898750 898750 0 0.0
bss 87596 87596 0 0.0
noinit 37160 37160 0 0.0
text 635626 635626 0 0.0

@adabreuti adabreuti force-pushed the countryCodeResolution branch 2 times, most recently from 0c05849 to e109b99 Compare March 28, 2022 19:15
@github-actions
Copy link

github-actions bot commented Mar 28, 2022 •
edited
Loading

PR #16724: Size comparison from df7036f to e109b99

Increases (2 builds for linux)
platform target config section df7036f e109b99 change % change
linux chip-tool debug (read only) 10183973 10183989 16 0.0
.text 8880629 8880645 16 0.0
chip-tool-ipv6only arm64 (read only) 9815548 9815564 16 0.0
.text 8268164 8268180 16 0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section df7036f e109b99 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 605426 605426 0 0.0
.app_xip_area 512356 512356 0 0.0
.bss 75816 75816 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563238 563238 0 0.0
.app_xip_area 471696 471696 0 0.0
.bss 74320 74320 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575498 575498 0 0.0
.app_xip_area 474308 474308 0 0.0
.bss 83648 83648 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 926600 926600 0 0.0
(read/write) 128952 128952 0 0.0
.bss 126952 126952 0 0.0
.data 1996 1996 0 0.0
.text 926592 926592 0 0.0
BRD4161A+rpc (read only) 955416 955416 0 0.0
(read/write) 144904 144904 0 0.0
.bss 142728 142728 0 0.0
.data 2176 2176 0 0.0
.text 955408 955408 0 0.0
window-app BRD4161A (read only) 856004 856004 0 0.0
(read/write) 126912 126912 0 0.0
.bss 125040 125040 0 0.0
.data 1872 1872 0 0.0
.text 855996 855996 0 0.0
esp32 all-clusters-app c3devkit (read only) 966714 966714 0 0.0
(read/write) 1394810 1394810 0 0.0
.dram0.bss 62240 62240 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 199456 199456 0 0.0
.flash.text 966714 966714 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1023131 1023131 0 0.0
(read/write) 462572 462572 0 0.0
.dram0.bss 67768 67768 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228944 228944 0 0.0
.flash.text 1017747 1017747 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 704272 704272 0 0.0
.bss 77808 77808 0 0.0
.data 1876 1876 0 0.0
.text 618788 618788 0 0.0
lock k32w061+release (read/write) 703364 703364 0 0.0
.bss 77784 77784 0 0.0
.data 1916 1916 0 0.0
.text 617864 617864 0 0.0
linux all-clusters-app debug (read only) 2525993 2525993 0 0.0
(read/write) 143352 143352 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78920 78920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 216549 216549 0 0.0
.text 2145618 2145618 0 0.0
bridge-app debug+rpc (read only) 1765325 1765325 0 0.0
(read/write) 89520 89520 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144684 144684 0 0.0
.text 1505285 1505285 0 0.0
chip-tool debug (read only) 10183973 10183989 16 0.0
(read/write) 355656 355656 0 0.0
.bss 22464 22464 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 326008 326008 0 0.0
.dynamic 608 608 0 0.0
.got 4824 4824 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 518805 518805 0 0.0
.text 8880629 8880645 16 0.0
chip-tool-ipv6only arm64 (read only) 9815548 9815564 16 0.0
(read/write) 473697 473697 0 0.0
.bss 40737 40737 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372656 372656 0 0.0
.dynamic 560 560 0 0.0
.got 55352 55352 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 494212 494212 0 0.0
.text 8268164 8268180 16 0.0
door-lock-app debug (read only) 2017153 2017153 0 0.0
(read/write) 116896 116896 0 0.0
.bss 47648 47648 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181276 181276 0 0.0
.text 1686066 1686066 0 0.0
lighting-app debug+rpc (read only) 2191489 2191489 0 0.0
(read/write) 123888 123888 0 0.0
.bss 48928 48928 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175356 175356 0 0.0
.text 1856962 1856962 0 0.0
ota-provider-app debug (read only) 1957977 1957977 0 0.0
(read/write) 112688 112688 0 0.0
.bss 47584 47584 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58184 58184 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 167115 167115 0 0.0
.text 1638994 1638994 0 0.0
ota-requestor-app debug (read only) 1985569 1985569 0 0.0
(read/write) 115912 115912 0 0.0
.bss 48512 48512 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60440 60440 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 163236 163236 0 0.0
.text 1669458 1669458 0 0.0
shell debug (read only) 2441625 2441625 0 0.0
(read/write) 147368 147368 0 0.0
.bss 67304 67304 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73568 73568 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 210034 210034 0 0.0
.text 2074642 2074642 0 0.0
thermostat-no-ble arm64 (read only) 2275156 2275156 0 0.0
(read/write) 148369 148369 0 0.0
.bss 62817 62817 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4504 4504 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 140036 140036 0 0.0
.text 1911760 1911760 0 0.0
tv-app debug (read only) 2688417 2688417 0 0.0
(read/write) 247520 247520 0 0.0
.bss 164288 164288 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74048 74048 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206059 206059 0 0.0
.text 2307730 2307730 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2355644 2355644 0 0.0
.bss 184860 184860 0 0.0
.data 5760 5760 0 0.0
.text 1318244 1318244 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1143379 1143379 0 0.0
bss 142892 142892 0 0.0
rodata 142364 142364 0 0.0
text 783240 783240 0 0.0
p6 all-clusters-app default (read/write) 2498384 2498384 0 0.0
.bss 118280 118280 0 0.0
.data 2640 2640 0 0.0
.text 1456648 1456648 0 0.0
light-app default (read/write) 2400816 2400816 0 0.0
.bss 111752 111752 0 0.0
.data 2496 2496 0 0.0
.text 1359080 1359080 0 0.0
lock-app default (read/write) 2364352 2364352 0 0.0
.bss 111496 111496 0 0.0
.data 2456 2456 0 0.0
.text 1322616 1322616 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 787516 787516 0 0.0
bss 70092 70092 0 0.0
noinit 40416 40416 0 0.0
text 557906 557906 0 0.0

@adabreuti adabreuti force-pushed the countryCodeResolution branch from e109b99 to 68a3f35 Compare March 28, 2022 21:21
@github-actions
Copy link

github-actions bot commented Mar 28, 2022 •
edited
Loading

PR #16724: Size comparison from 7c69523 to 68a3f35

Increases (3 builds for linux)
platform target config section 7c69523 68a3f35 change % change
linux chip-tool debug (read only) 10186853 10186869 16 0.0
.text 8883509 8883525 16 0.0
chip-tool-ipv6only arm64 (read only) 9817724 9817740 16 0.0
.text 8270340 8270356 16 0.0
tv-app debug (read only) 2691297 2691313 16 0.0
.text 2310610 2310626 16 0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 7c69523 68a3f35 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 605450 605450 0 0.0
.app_xip_area 512380 512380 0 0.0
.bss 75816 75816 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563254 563254 0 0.0
.app_xip_area 471712 471712 0 0.0
.bss 74320 74320 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575522 575522 0 0.0
.app_xip_area 474332 474332 0 0.0
.bss 83648 83648 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 926600 926600 0 0.0
(read/write) 128952 128952 0 0.0
.bss 126952 126952 0 0.0
.data 1996 1996 0 0.0
.text 926592 926592 0 0.0
BRD4161A+rpc (read only) 955416 955416 0 0.0
(read/write) 144904 144904 0 0.0
.bss 142728 142728 0 0.0
.data 2176 2176 0 0.0
.text 955408 955408 0 0.0
window-app BRD4161A (read only) 856004 856004 0 0.0
(read/write) 126912 126912 0 0.0
.bss 125040 125040 0 0.0
.data 1872 1872 0 0.0
.text 855996 855996 0 0.0
esp32 all-clusters-app c3devkit (read only) 966746 966746 0 0.0
(read/write) 1394810 1394810 0 0.0
.dram0.bss 62240 62240 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 199456 199456 0 0.0
.flash.text 966746 966746 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1023171 1023171 0 0.0
(read/write) 462572 462572 0 0.0
.dram0.bss 67768 67768 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228944 228944 0 0.0
.flash.text 1017787 1017787 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 704288 704288 0 0.0
.bss 77808 77808 0 0.0
.data 1876 1876 0 0.0
.text 618804 618804 0 0.0
lock k32w061+release (read/write) 703380 703380 0 0.0
.bss 77784 77784 0 0.0
.data 1916 1916 0 0.0
.text 617880 617880 0 0.0
linux all-clusters-app debug (read only) 2525993 2525993 0 0.0
(read/write) 143352 143352 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78920 78920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 216549 216549 0 0.0
.text 2145618 2145618 0 0.0
bridge-app debug+rpc (read only) 1765325 1765325 0 0.0
(read/write) 89520 89520 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144684 144684 0 0.0
.text 1505285 1505285 0 0.0
chip-tool debug (read only) 10186853 10186869 16 0.0
(read/write) 355656 355656 0 0.0
.bss 22464 22464 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 326008 326008 0 0.0
.dynamic 608 608 0 0.0
.got 4824 4824 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 518805 518805 0 0.0
.text 8883509 8883525 16 0.0
chip-tool-ipv6only arm64 (read only) 9817724 9817740 16 0.0
(read/write) 473697 473697 0 0.0
.bss 40737 40737 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372656 372656 0 0.0
.dynamic 560 560 0 0.0
.got 55352 55352 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 494212 494212 0 0.0
.text 8270340 8270356 16 0.0
door-lock-app debug (read only) 2017153 2017153 0 0.0
(read/write) 116896 116896 0 0.0
.bss 47648 47648 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181276 181276 0 0.0
.text 1686066 1686066 0 0.0
lighting-app debug+rpc (read only) 2191489 2191489 0 0.0
(read/write) 123888 123888 0 0.0
.bss 48928 48928 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175356 175356 0 0.0
.text 1856962 1856962 0 0.0
ota-provider-app debug (read only) 1957977 1957977 0 0.0
(read/write) 112688 112688 0 0.0
.bss 47584 47584 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58184 58184 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 167115 167115 0 0.0
.text 1638994 1638994 0 0.0
ota-requestor-app debug (read only) 1985569 1985569 0 0.0
(read/write) 115912 115912 0 0.0
.bss 48512 48512 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60440 60440 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 163236 163236 0 0.0
.text 1669458 1669458 0 0.0
shell debug (read only) 2441625 2441625 0 0.0
(read/write) 147368 147368 0 0.0
.bss 67304 67304 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73568 73568 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 210034 210034 0 0.0
.text 2074642 2074642 0 0.0
thermostat-no-ble arm64 (read only) 2275156 2275156 0 0.0
(read/write) 148369 148369 0 0.0
.bss 62817 62817 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4504 4504 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 140036 140036 0 0.0
.text 1911760 1911760 0 0.0
tv-app debug (read only) 2691297 2691313 16 0.0
(read/write) 247520 247520 0 0.0
.bss 164288 164288 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74048 74048 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206059 206059 0 0.0
.text 2310610 2310626 16 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2355644 2355644 0 0.0
.bss 184860 184860 0 0.0
.data 5760 5760 0 0.0
.text 1318244 1318244 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1143395 1143395 0 0.0
bss 142892 142892 0 0.0
rodata 142364 142364 0 0.0
text 783260 783260 0 0.0
p6 all-clusters-app default (read/write) 2498384 2498384 0 0.0
.bss 118280 118280 0 0.0
.data 2640 2640 0 0.0
.text 1456648 1456648 0 0.0
light-app default (read/write) 2400816 2400816 0 0.0
.bss 111752 111752 0 0.0
.data 2496 2496 0 0.0
.text 1359080 1359080 0 0.0
lock-app default (read/write) 2364352 2364352 0 0.0
.bss 111496 111496 0 0.0
.data 2456 2456 0 0.0
.text 1322616 1322616 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 787524 787524 0 0.0
bss 70092 70092 0 0.0
noinit 40416 40416 0 0.0
text 557916 557916 0 0.0

@adabreuti adabreuti force-pushed the countryCodeResolution branch from 68a3f35 to e2b7b50 Compare March 29, 2022 14:05
@restyled-io restyled-io bot mentioned this pull request Mar 29, 2022
Closed
@adabreuti adabreuti force-pushed the countryCodeResolution branch from e2b7b50 to 4c24cff Compare March 29, 2022 14:09
@github-actions
Copy link

github-actions bot commented Mar 29, 2022 •
edited
Loading

PR #16724: Size comparison from d6fcbd9 to 7c8cc23

Increases (1 build for linux)
platform target config section d6fcbd9 7c8cc23 change % change
linux chip-tool-ipv6only arm64 (read only) 9849660 9849692 32 0.0
.text 8301972 8302004 32 0.0
Full report (13 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d6fcbd9 7c8cc23 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 605498 605498 0 0.0
.app_xip_area 512428 512428 0 0.0
.bss 75816 75816 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563286 563286 0 0.0
.app_xip_area 471744 471744 0 0.0
.bss 74320 74320 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575546 575546 0 0.0
.app_xip_area 474356 474356 0 0.0
.bss 83648 83648 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 704320 704320 0 0.0
.bss 77808 77808 0 0.0
.data 1876 1876 0 0.0
.text 618836 618836 0 0.0
lock k32w061+release (read/write) 703428 703428 0 0.0
.bss 77784 77784 0 0.0
.data 1916 1916 0 0.0
.text 617928 617928 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9849660 9849692 32 0.0
(read/write) 473713 473713 0 0.0
.bss 40737 40737 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372656 372656 0 0.0
.dynamic 560 560 0 0.0
.got 55368 55368 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 494468 494468 0 0.0
.text 8301972 8302004 32 0.0
thermostat-no-ble arm64 (read only) 2275348 2275348 0 0.0
(read/write) 148369 148369 0 0.0
.bss 62817 62817 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4504 4504 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 140036 140036 0 0.0
.text 1911952 1911952 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2355772 2355772 0 0.0
.bss 184860 184860 0 0.0
.data 5760 5760 0 0.0
.text 1318372 1318372 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1143459 1143459 0 0.0
bss 142892 142892 0 0.0
rodata 142364 142364 0 0.0
text 783316 783316 0 0.0
p6 all-clusters-app default (read/write) 2498448 2498448 0 0.0
.bss 118280 118280 0 0.0
.data 2640 2640 0 0.0
.text 1456712 1456712 0 0.0
light-app default (read/write) 2400896 2400896 0 0.0
.bss 111752 111752 0 0.0
.data 2496 2496 0 0.0
.text 1359160 1359160 0 0.0
lock-app default (read/write) 2364400 2364400 0 0.0
.bss 111496 111496 0 0.0
.data 2456 2456 0 0.0
.text 1322664 1322664 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 787556 787556 0 0.0
bss 70092 70092 0 0.0
noinit 40416 40416 0 0.0
text 557952 557952 0 0.0

@adabreuti adabreuti force-pushed the countryCodeResolution branch from 7c8cc23 to 030ad50 Compare March 29, 2022 15:00
@adabreuti adabreuti force-pushed the countryCodeResolution branch from 030ad50 to f105247 Compare March 29, 2022 15:27
@github-actions
Copy link

github-actions bot commented Mar 29, 2022 •
edited
Loading

PR #16724: Size comparison from 8da5d03 to f105247

Increases (3 builds for linux)
platform target config section 8da5d03 f105247 change % change
linux chip-tool debug (read only) 10228533 10228581 48 0.0
.text 8924837 8924885 48 0.0
chip-tool-ipv6only arm64 (read only) 9849708 9849740 32 0.0
.text 8302004 8302036 32 0.0
tv-app debug (read only) 2696209 2696257 48 0.0
.text 2315394 2315442 48 0.0
Full report (25 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 8da5d03 f105247 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606194 606194 0 0.0
.app_xip_area 512964 512964 0 0.0
.bss 75976 75976 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563734 563734 0 0.0
.app_xip_area 472032 472032 0 0.0
.bss 74480 74480 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575994 575994 0 0.0
.app_xip_area 474644 474644 0 0.0
.bss 83808 83808 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 927264 927264 0 0.0
(read/write) 129112 129112 0 0.0
.bss 127112 127112 0 0.0
.data 1996 1996 0 0.0
.text 927256 927256 0 0.0
BRD4161A+rpc (read only) 956272 956272 0 0.0
(read/write) 145064 145064 0 0.0
.bss 142888 142888 0 0.0
.data 2176 2176 0 0.0
.text 956264 956264 0 0.0
window-app BRD4161A (read only) 856748 856748 0 0.0
(read/write) 127072 127072 0 0.0
.bss 125200 125200 0 0.0
.data 1872 1872 0 0.0
.text 856740 856740 0 0.0
k32w light k32w061+release (read/write) 704784 704784 0 0.0
.bss 77968 77968 0 0.0
.data 1876 1876 0 0.0
.text 619140 619140 0 0.0
lock k32w061+release (read/write) 703900 703900 0 0.0
.bss 77944 77944 0 0.0
.data 1916 1916 0 0.0
.text 618240 618240 0 0.0
linux all-clusters-app debug (read only) 2533833 2533833 0 0.0
(read/write) 143352 143352 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78920 78920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 216357 216357 0 0.0
.text 2153650 2153650 0 0.0
bridge-app debug+rpc (read only) 1767533 1767533 0 0.0
(read/write) 89520 89520 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144716 144716 0 0.0
.text 1507461 1507461 0 0.0
chip-tool debug (read only) 10228533 10228581 48 0.0
(read/write) 355656 355656 0 0.0
.bss 22464 22464 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 326008 326008 0 0.0
.dynamic 608 608 0 0.0
.got 4824 4824 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 519157 519157 0 0.0
.text 8924837 8924885 48 0.0
chip-tool-ipv6only arm64 (read only) 9849708 9849740 32 0.0
(read/write) 473713 473713 0 0.0
.bss 40737 40737 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372656 372656 0 0.0
.dynamic 560 560 0 0.0
.got 55368 55368 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 494484 494484 0 0.0
.text 8302004 8302036 32 0.0
door-lock-app debug (read only) 2020193 2020193 0 0.0
(read/write) 116896 116896 0 0.0
.bss 47648 47648 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181340 181340 0 0.0
.text 1689042 1689042 0 0.0
lighting-app debug+rpc (read only) 2196545 2196545 0 0.0
(read/write) 123888 123888 0 0.0
.bss 48928 48928 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175196 175196 0 0.0
.text 1862178 1862178 0 0.0
ota-provider-app debug (read only) 1960825 1960825 0 0.0
(read/write) 112688 112688 0 0.0
.bss 47584 47584 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58184 58184 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 167147 167147 0 0.0
.text 1641810 1641810 0 0.0
ota-requestor-app debug (read only) 1987793 1987793 0 0.0
(read/write) 115912 115912 0 0.0
.bss 48512 48512 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60440 60440 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 163268 163268 0 0.0
.text 1671650 1671650 0 0.0
shell debug (read only) 2448601 2448601 0 0.0
(read/write) 147368 147368 0 0.0
.bss 67304 67304 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73568 73568 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209810 209810 0 0.0
.text 2081842 2081842 0 0.0
thermostat-no-ble arm64 (read only) 2278468 2278468 0 0.0
(read/write) 148305 148305 0 0.0
.bss 62817 62817 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 76928 76928 0 0.0
.dynamic 560 560 0 0.0
.got 4504 4504 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139908 139908 0 0.0
.text 1915264 1915264 0 0.0
tv-app debug (read only) 2696209 2696257 48 0.0
(read/write) 247520 247520 0 0.0
.bss 164288 164288 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74048 74048 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206187 206187 0 0.0
.text 2315394 2315442 48 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2356076 2356076 0 0.0
.bss 185020 185020 0 0.0
.data 5760 5760 0 0.0
.text 1318676 1318676 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1144215 1144215 0 0.0
bss 143052 143052 0 0.0
rodata 142304 142304 0 0.0
text 784004 784004 0 0.0
p6 all-clusters-app default (read/write) 2499312 2499312 0 0.0
.bss 118440 118440 0 0.0
.data 2640 2640 0 0.0
.text 1457576 1457576 0 0.0
light-app default (read/write) 2401496 2401496 0 0.0
.bss 111912 111912 0 0.0
.data 2496 2496 0 0.0
.text 1359760 1359760 0 0.0
lock-app default (read/write) 2365112 2365112 0 0.0
.bss 111656 111656 0 0.0
.data 2456 2456 0 0.0
.text 1323376 1323376 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 788424 788424 0 0.0
bss 70268 70268 0 0.0
noinit 40416 40416 0 0.0
text 558792 558792 0 0.0

@adabreuti
Copy link
Contributor Author

@bzbarsky-apple @msandstedt I believe the failing PR check is infrastructure related and not related to the changes made in this PR. If you agree, would you be able to merge it?

bzbarsky-apple
bzbarsky-apple approved these changes Mar 30, 2022
View reviewed changes
src/controller/CHIPDeviceController.cpp Outdated Show resolved Hide resolved
@bzbarsky-apple
Copy link
Contributor

not related to the changes made in this PR

Agreed. If it fails again, please ping me on Slack and I will retrigger as needed (and bump job timeouts as needed....)

@adabreuti
Copy link
Contributor Author

@bzbarsky-apple Should be good to go, looks like the previous build failure was resolved.

@bzbarsky-apple bzbarsky-apple merged commit 63e6ed8 into project-chip:master Mar 31, 2022
@adabreuti adabreuti deleted the countryCodeResolution branch March 31, 2022 13:32
rochaferraz pushed a commit to rochaferraz/connectedhomeip that referenced this pull request Mar 31, 2022
@adabreuti @bzbarsky-apple @rochaferraz
Resolve default countryCodeSize when not set on commissioner (project…
4054b2a 
…-chip#16724)

* Resolve default countryCodeSize when not set on commissioner

* Re-initialize countrycodestr on failure

* Generalize print

* Update src/controller/CHIPDeviceController.cpp

Co-authored-by: Boris Zbarsky <[email protected]>

Co-authored-by: Boris Zbarsky <[email protected]>
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@adabreuti @bzbarsky-apple @andrei-menzopol
Resolve default countryCodeSize when not set on commissioner (project…
ea65629 
…-chip#16724)

* Resolve default countryCodeSize when not set on commissioner

* Re-initialize countrycodestr on failure

* Generalize print

* Update src/controller/CHIPDeviceController.cpp

Co-authored-by: Boris Zbarsky <[email protected]>

Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Country Code default length is not set correctly upon GetCountryCode() Read failure
3 participants
@adabreuti @bzbarsky-apple @msandstedt