TE8 fixes #16721
Merged
TE8 fixes #16721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
lazarkov,
LuDuda and
mlepage-google
woody-apple
force-pushed
the
fix/TE8_K32W0
branch
from
8aa1728 to
41f223c
Compare
|
@woody-apple , I think that I accidentally removed your changes (while trying to remove third_party/efr32_sdk/repo) from your forced-push. Please re-add them if needed. Sorry for this. |
|
PR #16721: Size comparison from 37094b5 to 7d6c9a6 Increases above 0.2%:
Increases (11 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, nrfconnect)
Decreases (5 builds for cc13x2_26x2, k32w)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #16721: Size comparison from 3666138 to 0254a54 Increases above 0.2%:
Increases (11 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, nrfconnect)
Decreases (5 builds for cc13x2_26x2, k32w)
Full report (29 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #16721: Size comparison from 3666138 to 33c5084 Increases above 0.2%:
Increases (11 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, nrfconnect)
Decreases (5 builds for cc13x2_26x2, k32w)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
@doru91 Note, still conflicts here :( |
doru91
force-pushed
the
fix/TE8_K32W0
branch
2 times, most recently
from
ef4e1c5 to
c9ee3fb
Compare
|
PR #16721: Size comparison from 2ff1d72 to c9ee3fb Increases above 0.2%:
Increases (7 builds for cc13x2_26x2, k32w, nrfconnect)
Decreases (5 builds for cc13x2_26x2, k32w)
Full report (11 builds for cc13x2_26x2, k32w, linux, mbed, nrfconnect, telink)
|
|
PR #16721: Size comparison from e92157a to bceadc2 Increases above 0.2%:
Increases (10 builds for cc13x2_26x2, efr32, k32w, linux, nrfconnect)
Decreases (5 builds for cc13x2_26x2, k32w)
Full report (28 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #16721: Size comparison from 04f1acd to 221ce6e Increases above 0.2%:
Increases (6 builds for cc13x2_26x2, linux, nrfconnect)
Decreases (3 builds for cc13x2_26x2)
Full report (9 builds for cc13x2_26x2, linux, mbed, nrfconnect, telink)
|
doru91
force-pushed
the
fix/TE8_K32W0
branch
2 times, most recently
from
12bbd6c to
708b2ca
Compare
|
PR #16721: Size comparison from 3034129 to 708b2ca Increases above 0.2%:
Increases (7 builds for cc13x2_26x2, k32w, nrfconnect)
Decreases (5 builds for cc13x2_26x2, k32w)
Full report (14 builds for cc13x2_26x2, k32w, linux, mbed, nrfconnect, p6, telink)
|
OTA * add support for compiling without OTA support. If this happens, then the application is written at address 0 in flash (instead at 0 + 16K - required for SSBL). Also, more space is available for the app in this case; * add detailed README instructions; * increase idle task stack size - that's because writes to the eeprom are done on the idle task; * allow the application to specify the block size for each OTA fragment; * add NXP SDK fixes for fixing eeprom race conditions; * add NXP SDK fix for allowing the processing of OTA blocks of different sizes; * add support for parsing the OTA header; * fix OTA logic such that the application can pace the rate at which new OTA fragments are requested; Tokenizer * add detailed README instructions. Light app/Lock app * enable lock tracking; * schedule OTA/Matter attribute change/Server operations on the Matter task; * avoid checking if thread is provisioned in a busy loop on eeprom - use an event instead; * disable mbedtls error logging (~13K) and instead add error logs in MemConfig.cpp in case mbedtls memory allocations fail; * change task priorities such that the app task has a smaller priority than the Matter one; * enable CHIP_DEVICE_CONFIG_ENABLE_TEST_SETUP_PARAMS such that the PBKDF are hard-coded on the device side; * refactor the gn options such that K32W0 module can be easily configured to be attached to a dk different than DK6; * group initialization calls in a single function; * consider the case when WriteConfigValueStr is not called with a NULL-terminated string. * refactor board initialization code; * allow building k32w light application with ota support - disable ble for the moment, until a size-optimized SDK is released; * fix NFC compilation error is BLE is disabled. Signed-off-by: Doru Gucea <[email protected]>
|
PR #16721: Size comparison from dcca243 to 4279f6d Increases above 0.2%:
Increases (9 builds for cc13x2_26x2, efr32, k32w, nrfconnect)
Decreases (5 builds for cc13x2_26x2, k32w)
Full report (19 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
@woody-apple, solved. |
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
OTA * add support for compiling without OTA support. If this happens, then the application is written at address 0 in flash (instead at 0 + 16K - required for SSBL). Also, more space is available for the app in this case; * add detailed README instructions; * increase idle task stack size - that's because writes to the eeprom are done on the idle task; * allow the application to specify the block size for each OTA fragment; * add NXP SDK fixes for fixing eeprom race conditions; * add NXP SDK fix for allowing the processing of OTA blocks of different sizes; * add support for parsing the OTA header; * fix OTA logic such that the application can pace the rate at which new OTA fragments are requested; Tokenizer * add detailed README instructions. Light app/Lock app * enable lock tracking; * schedule OTA/Matter attribute change/Server operations on the Matter task; * avoid checking if thread is provisioned in a busy loop on eeprom - use an event instead; * disable mbedtls error logging (~13K) and instead add error logs in MemConfig.cpp in case mbedtls memory allocations fail; * change task priorities such that the app task has a smaller priority than the Matter one; * enable CHIP_DEVICE_CONFIG_ENABLE_TEST_SETUP_PARAMS such that the PBKDF are hard-coded on the device side; * refactor the gn options such that K32W0 module can be easily configured to be attached to a dk different than DK6; * group initialization calls in a single function; * consider the case when WriteConfigValueStr is not called with a NULL-terminated string. * refactor board initialization code; * allow building k32w light application with ota support - disable ble for the moment, until a size-optimized SDK is released; * fix NFC compilation error is BLE is disabled. Signed-off-by: Doru Gucea <[email protected]>
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
OTA * add support for compiling without OTA support. If this happens, then the application is written at address 0 in flash (instead at 0 + 16K - required for SSBL). Also, more space is available for the app in this case; * add detailed README instructions; * increase idle task stack size - that's because writes to the eeprom are done on the idle task; * allow the application to specify the block size for each OTA fragment; * add NXP SDK fixes for fixing eeprom race conditions; * add NXP SDK fix for allowing the processing of OTA blocks of different sizes; * add support for parsing the OTA header; * fix OTA logic such that the application can pace the rate at which new OTA fragments are requested; Tokenizer * add detailed README instructions. Light app/Lock app * enable lock tracking; * schedule OTA/Matter attribute change/Server operations on the Matter task; * avoid checking if thread is provisioned in a busy loop on eeprom - use an event instead; * disable mbedtls error logging (~13K) and instead add error logs in MemConfig.cpp in case mbedtls memory allocations fail; * change task priorities such that the app task has a smaller priority than the Matter one; * enable CHIP_DEVICE_CONFIG_ENABLE_TEST_SETUP_PARAMS such that the PBKDF are hard-coded on the device side; * refactor the gn options such that K32W0 module can be easily configured to be attached to a dk different than DK6; * group initialization calls in a single function; * consider the case when WriteConfigValueStr is not called with a NULL-terminated string. * refactor board initialization code; * allow building k32w light application with ota support - disable ble for the moment, until a size-optimized SDK is released; * fix NFC compilation error is BLE is disabled. Signed-off-by: Doru Gucea <[email protected]>
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
OTA * add support for compiling without OTA support. If this happens, then the application is written at address 0 in flash (instead at 0 + 16K - required for SSBL). Also, more space is available for the app in this case; * add detailed README instructions; * increase idle task stack size - that's because writes to the eeprom are done on the idle task; * allow the application to specify the block size for each OTA fragment; * add NXP SDK fixes for fixing eeprom race conditions; * add NXP SDK fix for allowing the processing of OTA blocks of different sizes; * add support for parsing the OTA header; * fix OTA logic such that the application can pace the rate at which new OTA fragments are requested; Tokenizer * add detailed README instructions. Light app/Lock app * enable lock tracking; * schedule OTA/Matter attribute change/Server operations on the Matter task; * avoid checking if thread is provisioned in a busy loop on eeprom - use an event instead; * disable mbedtls error logging (~13K) and instead add error logs in MemConfig.cpp in case mbedtls memory allocations fail; * change task priorities such that the app task has a smaller priority than the Matter one; * enable CHIP_DEVICE_CONFIG_ENABLE_TEST_SETUP_PARAMS such that the PBKDF are hard-coded on the device side; * refactor the gn options such that K32W0 module can be easily configured to be attached to a dk different than DK6; * group initialization calls in a single function; * consider the case when WriteConfigValueStr is not called with a NULL-terminated string. * refactor board initialization code; * allow building k32w light application with ota support - disable ble for the moment, until a size-optimized SDK is released; * fix NFC compilation error is BLE is disabled. Signed-off-by: Doru Gucea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes different issues encountered during TE8 on K32W0 plaform.
Change overview
OTA
application is written at address 0 in flash (instead at 0 + 16K - required
for SSBL). Also, more space is available for the app in this case;
done on the idle task;
sizes;
Tokenizer
Light app/Lock app
event instead;
in case mbedtls memory allocations fail;
Matter one;
hard-coded on the device side;
attached to a dk different than DK6;
string.
Testing
How was this tested? (at least one bullet point required)