Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Group] Remove AssociateWithGroup #16583

Merged
merged 2 commits into from
Mar 25, 2022
Merged

[Group] Remove AssociateWithGroup #16583

merged 2 commits into from
Mar 25, 2022

Conversation

jepenven-silabs
Copy link
Contributor

Problem

Fix #11850

Change overview

Remove the AssociateWithGroup method since it didn't make sense to tie a DeviceProxy object with a group command. The api can now support a WriteAttribute command without any DeviceProxy object involved.

However, for the yaml test part of it, the necessary data is still retrieved from the DeviceProxy for convenience reasons only since this is limited to test code.

Testing

Yaml test.

@github-actions
Copy link

github-actions bot commented Mar 23, 2022 •
edited
Loading

PR #16583: Size comparison from 395bb1f to 45bbda2

Increases (1 build for linux)
platform target config section 395bb1f 45bbda2 change % change
linux chip-tool-ipv6only arm64 (read/write) 473313 473345 32 0.0
.got 55696 55720 24 0.0
.rodata 496036 496132 96 0.0
Decreases (6 builds for cyw30739, efr32, k32w, linux, nrfconnect)
platform target config section 395bb1f 45bbda2 change % change
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 573350 573334 -16 -0.0
.app_xip_area 472320 472304 -16 -0.0
efr32 lighting-app BRD4161A (read only) 922876 922860 -16 -0.0
.text 922868 922852 -16 -0.0
BRD4161A+rpc (read only) 951692 951676 -16 -0.0
.text 951684 951668 -16 -0.0
k32w light k32w061+release (read/write) 701644 701628 -16 -0.0
.text 616320 616304 -16 -0.0
linux chip-tool-ipv6only arm64 (read only) 9807276 9788124 -19152 -0.2
.text 8258340 8239012 -19328 -0.2
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1139459 1139443 -16 -0.0
text 780508 780496 -12 -0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 395bb1f 45bbda2 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603470 603470 0 0.0
.app_xip_area 510560 510560 0 0.0
.bss 75656 75656 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561266 561266 0 0.0
.app_xip_area 469884 469884 0 0.0
.bss 74160 74160 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 573350 573334 -16 -0.0
.app_xip_area 472320 472304 -16 -0.0
.bss 83488 83488 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 922876 922860 -16 -0.0
(read/write) 128756 128756 0 0.0
.bss 126760 126760 0 0.0
.data 1996 1996 0 0.0
.text 922868 922852 -16 -0.0
BRD4161A+rpc (read only) 951692 951676 -16 -0.0
(read/write) 144712 144712 0 0.0
.bss 142536 142536 0 0.0
.data 2176 2176 0 0.0
.text 951684 951668 -16 -0.0
window-app BRD4161A (read only) 852656 852656 0 0.0
(read/write) 126728 126728 0 0.0
.bss 124856 124856 0 0.0
.data 1872 1872 0 0.0
.text 852648 852648 0 0.0
esp32 all-clusters-app c3devkit (read only) 964154 964154 0 0.0
(read/write) 1393730 1393730 0 0.0
.dram0.bss 62072 62072 0 0.0
.dram0.data 14196 14196 0 0.0
.flash.rodata 198536 198536 0 0.0
.flash.text 964154 964154 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1020691 1020691 0 0.0
(read/write) 461500 461500 0 0.0
.dram0.bss 67600 67600 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228040 228040 0 0.0
.flash.text 1015307 1015307 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 701644 701628 -16 -0.0
.bss 77648 77648 0 0.0
.data 1876 1876 0 0.0
.text 616320 616304 -16 -0.0
lock k32w061+release (read/write) 701080 701080 0 0.0
.bss 77624 77624 0 0.0
.data 1916 1916 0 0.0
.text 615740 615740 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9807276 9788124 -19152 -0.2
(read/write) 473313 473345 32 0.0
.bss 40673 40673 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372000 372000 0 0.0
.dynamic 560 560 0 0.0
.got 55696 55720 24 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 496036 496132 96 0.0
.text 8258340 8239012 -19328 -0.2
thermostat-no-ble arm64 (read only) 2262660 2262660 0 0.0
(read/write) 148289 148289 0 0.0
.bss 62753 62753 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4480 4480 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139780 139780 0 0.0
.text 1899536 1899536 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353636 2353636 0 0.0
.bss 184652 184652 0 0.0
.data 5760 5760 0 0.0
.text 1316236 1316236 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1139459 1139443 -16 -0.0
bss 142588 142588 0 0.0
rodata 141588 141588 0 0.0
text 780508 780496 -12 -0.0
p6 all-clusters-app default (read/write) 2493592 2493592 0 0.0
.bss 118072 118072 0 0.0
.data 2640 2640 0 0.0
.text 1451856 1451856 0 0.0
light-app default (read/write) 2396760 2396760 0 0.0
.bss 111544 111544 0 0.0
.data 2496 2496 0 0.0
.text 1355024 1355024 0 0.0
lock-app default (read/write) 2360296 2360296 0 0.0
.bss 111288 111288 0 0.0
.data 2456 2456 0 0.0
.text 1318560 1318560 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 896954 896954 0 0.0
bss 87444 87444 0 0.0
noinit 37160 37160 0 0.0
text 634296 634296 0 0.0

@bzbarsky-apple
Copy link
Contributor

/rebase

@woody-apple woody-apple force-pushed the remove_associate_with_group branch from e021a79 to a01e0ce Compare March 25, 2022 00:21
@github-actions
Copy link

github-actions bot commented Mar 25, 2022 •
edited
Loading

PR #16583: Size comparison from 45f5ffc to a01e0ce

Increases (1 build for linux)
platform target config section 45f5ffc a01e0ce change % change
linux chip-tool-ipv6only arm64 (read/write) 473889 473921 32 0.0
.got 55464 55488 24 0.0
.rodata 494020 494116 96 0.0
Decreases (9 builds for cyw30739, efr32, k32w, linux, nrfconnect)
platform target config section 45f5ffc a01e0ce change % change
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574634 574618 -16 -0.0
.app_xip_area 473684 473668 -16 -0.0
efr32 lighting-app BRD4161A (read only) 925504 925488 -16 -0.0
.text 925496 925480 -16 -0.0
BRD4161A+rpc (read only) 954320 954304 -16 -0.0
.text 954312 954296 -16 -0.0
k32w light k32w061+release (read/write) 703000 702984 -16 -0.0
.text 617756 617740 -16 -0.0
linux chip-tool debug (read only) 10219085 10195021 -24064 -0.2
.text 8915653 8891589 -24064 -0.3
chip-tool-ipv6only arm64 (read only) 9836652 9817484 -19168 -0.2
.text 8289012 8269668 -19344 -0.2
ota-requestor-app debug (read only) 1980961 1980929 -32 -0.0
.text 1665394 1665362 -32 -0.0
tv-app debug (read only) 2685465 2682961 -2504 -0.1
(read/write) 247712 247552 -160 -0.1
.bss 164352 164320 -32 -0.0
.data.rel.ro 74160 74048 -112 -0.2
.rodata 206027 205611 -416 -0.2
.text 2304546 2302722 -1824 -0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1141319 1141303 -16 -0.0
text 781916 781904 -12 -0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 45f5ffc a01e0ce change % change
cyw30739 light cyw930739m2evb_01 (read/write) 604482 604482 0 0.0
.app_xip_area 511652 511652 0 0.0
.bss 75576 75576 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 562270 562270 0 0.0
.app_xip_area 470968 470968 0 0.0
.bss 74080 74080 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574634 574618 -16 -0.0
.app_xip_area 473684 473668 -16 -0.0
.bss 83408 83408 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 925504 925488 -16 -0.0
(read/write) 128688 128688 0 0.0
.bss 126688 126688 0 0.0
.data 1996 1996 0 0.0
.text 925496 925480 -16 -0.0
BRD4161A+rpc (read only) 954320 954304 -16 -0.0
(read/write) 144640 144640 0 0.0
.bss 142464 142464 0 0.0
.data 2176 2176 0 0.0
.text 954312 954296 -16 -0.0
window-app BRD4161A (read only) 854900 854900 0 0.0
(read/write) 126648 126648 0 0.0
.bss 124776 124776 0 0.0
.data 1872 1872 0 0.0
.text 854892 854892 0 0.0
esp32 all-clusters-app c3devkit (read only) 965630 965630 0 0.0
(read/write) 1394162 1394162 0 0.0
.dram0.bss 61992 61992 0 0.0
.dram0.data 14212 14212 0 0.0
.flash.rodata 199032 199032 0 0.0
.flash.text 965630 965630 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1022107 1022107 0 0.0
(read/write) 461908 461908 0 0.0
.dram0.bss 67520 67520 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228528 228528 0 0.0
.flash.text 1016723 1016723 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 703000 702984 -16 -0.0
.bss 77568 77568 0 0.0
.data 1876 1876 0 0.0
.text 617756 617740 -16 -0.0
lock k32w061+release (read/write) 702068 702068 0 0.0
.bss 77544 77544 0 0.0
.data 1916 1916 0 0.0
.text 616808 616808 0 0.0
linux all-clusters-app debug (read only) 2487873 2487873 0 0.0
(read/write) 143344 143344 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78920 78920 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 212229 212229 0 0.0
.text 2111922 2111922 0 0.0
bridge-app debug+rpc (read only) 1760133 1760133 0 0.0
(read/write) 89552 89552 0 0.0
.bss 44552 44552 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144268 144268 0 0.0
.text 1500629 1500629 0 0.0
chip-tool debug (read only) 10219085 10195021 -24064 -0.2
(read/write) 355720 355720 0 0.0
.bss 22496 22496 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 326056 326056 0 0.0
.dynamic 608 608 0 0.0
.got 4816 4816 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 518901 518901 0 0.0
.text 8915653 8891589 -24064 -0.3
chip-tool-ipv6only arm64 (read only) 9836652 9817484 -19168 -0.2
(read/write) 473889 473921 32 0.0
.bss 40769 40769 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372712 372712 0 0.0
.dynamic 560 560 0 0.0
.got 55464 55488 24 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 494020 494116 96 0.0
.text 8289012 8269668 -19344 -0.2
door-lock-app debug (read only) 2012145 2012145 0 0.0
(read/write) 116896 116896 0 0.0
.bss 47680 47680 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 180956 180956 0 0.0
.text 1681506 1681506 0 0.0
lighting-app debug+rpc (read only) 2185993 2185993 0 0.0
(read/write) 123888 123888 0 0.0
.bss 48960 48960 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 174972 174972 0 0.0
.text 1851954 1851954 0 0.0
ota-provider-app debug (read only) 1953337 1953337 0 0.0
(read/write) 112688 112688 0 0.0
.bss 47616 47616 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58184 58184 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 166699 166699 0 0.0
.text 1634898 1634898 0 0.0
ota-requestor-app debug (read only) 1980961 1980929 -32 -0.0
(read/write) 115912 115912 0 0.0
.bss 48544 48544 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60440 60440 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 162820 162820 0 0.0
.text 1665394 1665362 -32 -0.0
shell debug (read only) 2436633 2436633 0 0.0
(read/write) 147400 147400 0 0.0
.bss 67336 67336 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73568 73568 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209682 209682 0 0.0
.text 2070082 2070082 0 0.0
thermostat-no-ble arm64 (read only) 2269668 2269668 0 0.0
(read/write) 148385 148385 0 0.0
.bss 62833 62833 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4504 4504 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139716 139716 0 0.0
.text 1906544 1906544 0 0.0
tv-app debug (read only) 2685465 2682961 -2504 -0.1
(read/write) 247712 247552 -160 -0.1
.bss 164352 164320 -32 -0.0
.data 3136 3136 0 0.0
.data.rel.ro 74160 74048 -112 -0.2
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206027 205611 -416 -0.2
.text 2304546 2302722 -1824 -0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2354708 2354708 0 0.0
.bss 184572 184572 0 0.0
.data 5760 5760 0 0.0
.text 1317308 1317308 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1141319 1141303 -16 -0.0
bss 142520 142520 0 0.0
rodata 142040 142040 0 0.0
text 781916 781904 -12 -0.0
p6 all-clusters-app default (read/write) 2496728 2496728 0 0.0
.bss 117992 117992 0 0.0
.data 2640 2640 0 0.0
.text 1454992 1454992 0 0.0
light-app default (read/write) 2399104 2399104 0 0.0
.bss 111464 111464 0 0.0
.data 2496 2496 0 0.0
.text 1357368 1357368 0 0.0
lock-app default (read/write) 2362632 2362632 0 0.0
.bss 111208 111208 0 0.0
.data 2456 2456 0 0.0
.text 1320896 1320896 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 897470 897470 0 0.0
bss 87356 87356 0 0.0
noinit 37160 37160 0 0.0
text 634874 634874 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 197f65f into project-chip:master Mar 25, 2022
rochaferraz pushed a commit to rochaferraz/connectedhomeip that referenced this pull request Mar 31, 2022
@jepenven-silabs @rochaferraz
[Group] Remove AssociateWithGroup (project-chip#16583)
60b4b67 
* Remove AssociateWithGroup

* Fix comments
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@jepenven-silabs @andrei-menzopol
[Group] Remove AssociateWithGroup (project-chip#16583)
04a10a2 
* Remove AssociateWithGroup

* Fix comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
controller examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ClusterBase AssociateWithGroup method
3 participants
@jepenven-silabs @bzbarsky-apple @andy31415