Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude some redundant things from Darwin build CI. #16551

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

Fixes #16464

Problem

See #16464.

Change overview

Don't build libCHIP three times as part of the darwin build.

Testing

Verified that the updated command still builds tests with ASAN and builds various "standalone" things.

@github-actions
Copy link

github-actions bot commented Mar 23, 2022

PR #16551: Size comparison from dd2f7e0 to dd88657

Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section dd2f7e0 dd88657 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 604314 604314 0 0.0
.app_xip_area 511412 511412 0 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 562094 562094 0 0.0
.app_xip_area 470720 470720 0 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571950 571950 0 0.0
.app_xip_area 470928 470928 0 0.0
.bss 83488 83488 0 0.0
.data 500 500 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 922180 922180 0 0.0
(read/write) 128756 128756 0 0.0
.bss 126768 126768 0 0.0
.data 1988 1988 0 0.0
.text 922172 922172 0 0.0
BRD4161A+rpc (read only) 951008 951008 0 0.0
(read/write) 144712 144712 0 0.0
.bss 142544 142544 0 0.0
.data 2168 2168 0 0.0
.text 951000 951000 0 0.0
window-app BRD4161A (read only) 852556 852556 0 0.0
(read/write) 126720 126720 0 0.0
.bss 124856 124856 0 0.0
.data 1864 1864 0 0.0
.text 852548 852548 0 0.0
esp32 all-clusters-app c3devkit (read only) 964012 964012 0 0.0
(read/write) 1393530 1393530 0 0.0
.dram0.bss 62072 62072 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 198352 198352 0 0.0
.flash.text 964012 964012 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1020571 1020571 0 0.0
(read/write) 461292 461292 0 0.0
.dram0.bss 67592 67592 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 227848 227848 0 0.0
.flash.text 1015187 1015187 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 701104 701104 0 0.0
.bss 77656 77656 0 0.0
.data 1868 1868 0 0.0
.text 615780 615780 0 0.0
lock k32w061+release (read/write) 700976 700976 0 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615644 615644 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9776108 9776108 0 0.0
(read/write) 472817 472817 0 0.0
.bss 40625 40625 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371880 371880 0 0.0
.dynamic 560 560 0 0.0
.got 55384 55384 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493716 493716 0 0.0
.text 8230740 8230740 0 0.0
thermostat-no-ble arm64 (read only) 2262596 2262596 0 0.0
(read/write) 148273 148273 0 0.0
.bss 62753 62753 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4480 4480 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139684 139684 0 0.0
.text 1899600 1899600 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353532 2353532 0 0.0
.bss 184652 184652 0 0.0
.data 5752 5752 0 0.0
.text 1316132 1316132 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155991 1155991 0 0.0
bss 146716 146716 0 0.0
rodata 145736 145736 0 0.0
text 788380 788380 0 0.0
p6 all-clusters-app default (read/write) 2493256 2493256 0 0.0
.bss 118072 118072 0 0.0
.data 2632 2632 0 0.0
.text 1451520 1451520 0 0.0
light-app default (read/write) 2396656 2396656 0 0.0
.bss 111544 111544 0 0.0
.data 2488 2488 0 0.0
.text 1354920 1354920 0 0.0
lock-app default (read/write) 2360208 2360208 0 0.0
.bss 111288 111288 0 0.0
.data 2448 2448 0 0.0
.text 1318472 1318472 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 896758 896758 0 0.0
bss 87424 87424 0 0.0
noinit 37160 37160 0 0.0
text 634242 634242 0 0.0

@andy31415 andy31415 merged commit 7172ac9 into project-chip:master Mar 23, 2022
@bzbarsky-apple bzbarsky-apple deleted the faster-darwin-build-job branch March 23, 2022 14:40
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAC CI compiles gcc even though it claims CLANG only
3 participants