-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing clusters and attributes to simulated app #16461
Merged
carol-apple
merged 2 commits into
project-chip:master
from
krypton36:AddMissingAttrSimulated
Mar 22, 2022
Merged
Add missing clusters and attributes to simulated app #16461
carol-apple
merged 2 commits into
project-chip:master
from
krypton36:AddMissingAttrSimulated
Mar 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt and
mspang
March 18, 2022 19:44
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
March 18, 2022 19:44
PR #16461: Size comparison from 59c6bae to 810b774 Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
krypton36
force-pushed
the
AddMissingAttrSimulated
branch
from
March 19, 2022 04:25
810b774
to
a7b6cf5
Compare
PR #16461: Size comparison from a673d2f to a7b6cf5 Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Mar 19, 2022
jmeg-sfy
approved these changes
Mar 21, 2022
Damian-Nordic
approved these changes
Mar 21, 2022
krypton36
force-pushed
the
AddMissingAttrSimulated
branch
from
March 21, 2022 16:27
a7b6cf5
to
8d422ee
Compare
PR #16461: Size comparison from 7d1256f to 8d422ee Full report (25 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
krypton36
force-pushed
the
AddMissingAttrSimulated
branch
from
March 21, 2022 17:12
8d422ee
to
a792b4f
Compare
PR #16461: Size comparison from 532ddf7 to a792b4f Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
krypton36
force-pushed
the
AddMissingAttrSimulated
branch
from
March 22, 2022 04:40
a792b4f
to
7569a8e
Compare
PR #16461: Size comparison from bca6caa to 7569a8e Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
krypton36
force-pushed
the
AddMissingAttrSimulated
branch
from
March 22, 2022 14:02
7569a8e
to
c3269b2
Compare
PR #16461: Size comparison from 2e658fb to c3269b2 Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Issue #16409 addresses missing clusters and attributes for simulated tests that are being implemented.
Change overview
Testing