Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msg] Fix #13669 - Skip over MX and SX extension blocks. #16324

Merged
merged 6 commits into from
Mar 18, 2022
Merged

[msg] Fix #13669 - Skip over MX and SX extension blocks. #16324

merged 6 commits into from
Mar 18, 2022

Conversation

turon
Copy link
Contributor

@turon turon commented Mar 16, 2022 •
edited
Loading

Problem

Fix #13669

Change overview

Skip over Message and Secured extensions in ::Decode.

Testing

CI
Unit tests added

@turon turon changed the title [msg] Fix #15799 - Skip over MX and SX extension blocks. [msg] Fix #13669 - Skip over MX and SX extension blocks. Mar 16, 2022
@github-actions
Copy link

github-actions bot commented Mar 16, 2022 •
edited
Loading

PR #16324: Size comparison from 0c43841 to 5e6f684

Increases (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0c43841 5e6f684 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603122 603210 88 0.0
.app_xip_area 510220 510308 88 0.0
lock cyw930739m2evb_01 (read/write) 560910 560998 88 0.0
.app_xip_area 469536 469624 88 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570794 570882 88 0.0
.app_xip_area 469772 469860 88 0.0
efr32 lighting-app BRD4161A (read only) 920572 920684 112 0.0
.text 920564 920676 112 0.0
BRD4161A+rpc (read only) 949392 949488 96 0.0
.text 949384 949480 96 0.0
window-app BRD4161A (read only) 851336 851432 96 0.0
.text 851328 851424 96 0.0
esp32 all-clusters-app c3devkit (read only) 961006 961104 98 0.0
.flash.text 961006 961104 98 0.0
m5stack (read only) 1017043 1017131 88 0.0
.flash.text 1011659 1011747 88 0.0
k32w light k32w061+release (read/write) 699800 699880 80 0.0
.text 614480 614560 80 0.0
lock k32w061+release (read/write) 700096 700192 96 0.0
.text 614764 614860 96 0.0
linux chip-tool-ipv6only arm64 (read only) 9753444 9754084 640 0.0
.text 8211204 8211844 640 0.0
thermostat-no-ble arm64 (read only) 2219164 2219836 672 0.0
.text 1861536 1862208 672 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2351980 2352452 472 0.0
.text 1314580 1315052 472 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154487 1154583 96 0.0
text 787180 787264 84 0.0
p6 all-clusters-app default (read/write) 2491232 2491344 112 0.0
.text 1449496 1449608 112 0.0
light-app default (read/write) 2395088 2395200 112 0.0
.text 1353352 1353464 112 0.0
lock-app default (read/write) 2358632 2358744 112 0.0
.text 1316896 1317008 112 0.0
telink lighting-app tlsr9518adk80d (read/write) 894566 894662 96 0.0
text 632492 632590 98 0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0c43841 5e6f684 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603122 603210 88 0.0
.app_xip_area 510220 510308 88 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560910 560998 88 0.0
.app_xip_area 469536 469624 88 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570794 570882 88 0.0
.app_xip_area 469772 469860 88 0.0
.bss 83464 83464 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920572 920684 112 0.0
(read/write) 128752 128752 0 0.0
.bss 126744 126744 0 0.0
.data 2008 2008 0 0.0
.text 920564 920676 112 0.0
BRD4161A+rpc (read only) 949392 949488 96 0.0
(read/write) 144712 144712 0 0.0
.bss 142520 142520 0 0.0
.data 2188 2188 0 0.0
.text 949384 949480 96 0.0
window-app BRD4161A (read only) 851336 851432 96 0.0
(read/write) 126704 126704 0 0.0
.bss 124840 124840 0 0.0
.data 1864 1864 0 0.0
.text 851328 851424 96 0.0
esp32 all-clusters-app c3devkit (read only) 961006 961104 98 0.0
(read/write) 1394690 1394690 0 0.0
.dram0.bss 64048 64048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197544 197544 0 0.0
.flash.text 961006 961104 98 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017043 1017131 88 0.0
(read/write) 462364 462364 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 226936 226936 0 0.0
.flash.text 1011659 1011747 88 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699800 699880 80 0.0
.bss 77632 77632 0 0.0
.data 1888 1888 0 0.0
.text 614480 614560 80 0.0
lock k32w061+release (read/write) 700096 700192 96 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 614764 614860 96 0.0
linux chip-tool-ipv6only arm64 (read only) 9753444 9754084 640 0.0
(read/write) 475473 475473 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371256 371256 0 0.0
.dynamic 560 560 0 0.0
.got 55264 55264 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492348 492348 0 0.0
.text 8211204 8211844 640 0.0
thermostat-no-ble arm64 (read only) 2219164 2219836 672 0.0
(read/write) 149777 149777 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75696 75696 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137660 137660 0 0.0
.text 1861536 1862208 672 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351980 2352452 472 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1314580 1315052 472 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154487 1154583 96 0.0
bss 146724 146724 0 0.0
rodata 145432 145432 0 0.0
text 787180 787264 84 0.0
p6 all-clusters-app default (read/write) 2491232 2491344 112 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1449496 1449608 112 0.0
light-app default (read/write) 2395088 2395200 112 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1353352 1353464 112 0.0
lock-app default (read/write) 2358632 2358744 112 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1316896 1317008 112 0.0
telink lighting-app tlsr9518adk80d (read/write) 894566 894662 96 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 632492 632590 98 0.0

@restyled-io restyled-io bot mentioned this pull request Mar 17, 2022
Closed
@turon turon marked this pull request as ready for review March 17, 2022 07:38
@restyled-io restyled-io bot mentioned this pull request Mar 17, 2022
Closed
@github-actions
Copy link

github-actions bot commented Mar 17, 2022 •
edited
Loading

PR #16324: Size comparison from 84c150a to 4e00544

Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 84c150a 4e00544 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603426 603498 72 0.0
.app_xip_area 510524 510596 72 0.0
lock cyw930739m2evb_01 (read/write) 561222 561294 72 0.0
.app_xip_area 469848 469920 72 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571026 571090 64 0.0
.app_xip_area 470004 470068 64 0.0
efr32 lighting-app BRD4161A (read only) 920956 921020 64 0.0
.text 920948 921012 64 0.0
BRD4161A+rpc (read only) 949760 949840 80 0.0
.text 949752 949832 80 0.0
window-app BRD4161A (read only) 851708 851772 64 0.0
.text 851700 851764 64 0.0
esp32 all-clusters-app c3devkit (read only) 961358 961398 40 0.0
.flash.text 961358 961398 40 0.0
m5stack (read only) 1017511 1017559 48 0.0
.flash.text 1012127 1012175 48 0.0
k32w light k32w061+release (read/write) 700112 700176 64 0.0
.text 614792 614856 64 0.0
lock k32w061+release (read/write) 700408 700472 64 0.0
.text 615076 615140 64 0.0
linux all-clusters-app debug (read only) 2471969 2472657 688 0.0
.text 2097570 2098258 688 0.0
bridge-app debug+rpc (read only) 1748173 1748845 672 0.0
.text 1489333 1490005 672 0.0
chip-tool debug (read only) 10139581 10140237 656 0.0
.text 8840277 8840933 656 0.0
chip-tool-ipv6only arm64 (read only) 9764284 9764668 384 0.0
.text 8219924 8220308 384 0.0
door-lock-app debug (read only) 1999337 2000009 672 0.0
.text 1669842 1670514 672 0.0
lighting-app debug+rpc (read only) 2130937 2131625 688 0.0
.text 1801842 1802530 688 0.0
ota-provider-app debug (read only) 1934369 1935025 656 0.0
.text 1616770 1617426 656 0.0
ota-requestor-app debug (read only) 1964169 1964825 656 0.0
.text 1650322 1650978 656 0.0
shell debug (read only) 2422129 2422817 688 0.0
.text 2056546 2057234 688 0.0
thermostat-no-ble arm64 (read only) 2220324 2220724 400 0.0
.text 1862528 1862928 400 0.0
tv-app debug (read only) 2670673 2671329 656 0.0
.text 2290130 2290786 656 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2352364 2352668 304 0.0
.text 1314964 1315268 304 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154847 1154895 48 0.0
text 787432 787480 48 0.0
p6 all-clusters-app default (read/write) 2491776 2491840 64 0.0
.text 1450040 1450104 64 0.0
light-app default (read/write) 2395528 2395592 64 0.0
.text 1353792 1353856 64 0.0
lock-app default (read/write) 2359072 2359136 64 0.0
.text 1317336 1317400 64 0.0
telink lighting-app tlsr9518adk80d (read/write) 894970 895010 40 0.0
text 632832 632872 40 0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 84c150a 4e00544 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603426 603498 72 0.0
.app_xip_area 510524 510596 72 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561222 561294 72 0.0
.app_xip_area 469848 469920 72 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571026 571090 64 0.0
.app_xip_area 470004 470068 64 0.0
.bss 83464 83464 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920956 921020 64 0.0
(read/write) 128752 128752 0 0.0
.bss 126744 126744 0 0.0
.data 2008 2008 0 0.0
.text 920948 921012 64 0.0
BRD4161A+rpc (read only) 949760 949840 80 0.0
(read/write) 144712 144712 0 0.0
.bss 142520 142520 0 0.0
.data 2188 2188 0 0.0
.text 949752 949832 80 0.0
window-app BRD4161A (read only) 851708 851772 64 0.0
(read/write) 126704 126704 0 0.0
.bss 124840 124840 0 0.0
.data 1864 1864 0 0.0
.text 851700 851764 64 0.0
esp32 all-clusters-app c3devkit (read only) 961358 961398 40 0.0
(read/write) 1394818 1394818 0 0.0
.dram0.bss 64048 64048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197672 197672 0 0.0
.flash.text 961358 961398 40 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017511 1017559 48 0.0
(read/write) 462660 462660 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 227232 227232 0 0.0
.flash.text 1012127 1012175 48 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 700112 700176 64 0.0
.bss 77632 77632 0 0.0
.data 1888 1888 0 0.0
.text 614792 614856 64 0.0
lock k32w061+release (read/write) 700408 700472 64 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615076 615140 64 0.0
linux all-clusters-app debug (read only) 2471969 2472657 688 0.0
(read/write) 146576 146576 0 0.0
.bss 60736 60736 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78840 78840 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 210949 210949 0 0.0
.text 2097570 2098258 688 0.0
bridge-app debug+rpc (read only) 1748173 1748845 672 0.0
(read/write) 92752 92752 0 0.0
.bss 47784 47784 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 143628 143628 0 0.0
.text 1489333 1490005 672 0.0
chip-tool debug (read only) 10139581 10140237 656 0.0
(read/write) 358264 358264 0 0.0
.bss 25728 25728 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 325408 325408 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 516725 516725 0 0.0
.text 8840277 8840933 656 0.0
chip-tool-ipv6only arm64 (read only) 9764284 9764668 384 0.0
(read/write) 476113 476113 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371824 371824 0 0.0
.dynamic 560 560 0 0.0
.got 55328 55328 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492996 492996 0 0.0
.text 8219924 8220308 384 0.0
door-lock-app debug (read only) 1999337 2000009 672 0.0
(read/write) 120224 120224 0 0.0
.bss 51008 51008 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 179836 179836 0 0.0
.text 1669842 1670514 672 0.0
lighting-app debug+rpc (read only) 2130937 2131625 688 0.0
(read/write) 125544 125544 0 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66792 66792 0 0.0
.dynamic 608 608 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 172412 172412 0 0.0
.text 1801842 1802530 688 0.0
ota-provider-app debug (read only) 1934369 1935025 656 0.0
(read/write) 116048 116048 0 0.0
.bss 50912 50912 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 58200 58200 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 165835 165835 0 0.0
.text 1616770 1617426 656 0.0
ota-requestor-app debug (read only) 1964169 1964825 656 0.0
(read/write) 119016 119016 0 0.0
.bss 51904 51904 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 161860 161860 0 0.0
.text 1650322 1650978 656 0.0
shell debug (read only) 2422129 2422817 688 0.0
(read/write) 150632 150632 0 0.0
.bss 70664 70664 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73472 73472 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 208882 208882 0 0.0
.text 2056546 2057234 688 0.0
thermostat-no-ble arm64 (read only) 2220324 2220724 400 0.0
(read/write) 149809 149809 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137732 137732 0 0.0
.text 1862528 1862928 400 0.0
tv-app debug (read only) 2670673 2671329 656 0.0
(read/write) 251224 251224 0 0.0
.bss 167904 167904 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 74184 74184 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 205717 205717 0 0.0
.text 2290130 2290786 656 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352364 2352668 304 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1314964 1315268 304 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154847 1154895 48 0.0
bss 146724 146724 0 0.0
rodata 145536 145536 0 0.0
text 787432 787480 48 0.0
p6 all-clusters-app default (read/write) 2491776 2491840 64 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1450040 1450104 64 0.0
light-app default (read/write) 2395528 2395592 64 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1353792 1353856 64 0.0
lock-app default (read/write) 2359072 2359136 64 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317336 1317400 64 0.0
telink lighting-app tlsr9518adk80d (read/write) 894970 895010 40 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 632832 632872 40 0.0

@bzbarsky-apple bzbarsky-apple merged commit f68cca0 into project-chip:master Mar 18, 2022
ArekBalysNordic pushed a commit to ArekBalysNordic/connectedhomeip that referenced this pull request Mar 18, 2022
@turon @ArekBalysNordic
[msg] Fix project-chip#13669 - Skip over MX and SX extension blocks. (p…
a43529c 
…roject-chip#16324)

* [msg] Fix project-chip#13669 - Skip over MX and SX extension blocks.

* [msg] Add MX flag parsing unit test.

* [msg] Add SX flag parsing unit tests.

* [restyle]

* Remove redundant check.

* [style] Use constexpr instead of #define.
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@turon @andrei-menzopol
[msg] Fix project-chip#13669 - Skip over MX and SX extension blocks. (p…
d5a62af 
…roject-chip#16324)

* [msg] Fix project-chip#13669 - Skip over MX and SX extension blocks.

* [msg] Add MX flag parsing unit test.

* [msg] Add SX flag parsing unit tests.

* [restyle]

* Remove redundant check.

* [style] Use constexpr instead of #define.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
message layer review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[msg] Confirm proper handling of message and secure extensions
3 participants
@turon @andy31415 @bzbarsky-apple