Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use clang-tidy to readability-make-member-function-const #16309

Merged
merged 9 commits into from
Mar 17, 2022
Merged

use clang-tidy to readability-make-member-function-const #16309

merged 9 commits into from
Mar 17, 2022

Conversation

andy31415
Copy link
Contributor

Problem

Some member functions are const but are not declared as such. Const allows compilers more optimization options.

Change overview

Ran:

./.environment/cipd/packages/pigweed/bin/run-clang-tidy -p ./out/linux-x64-chip-tool-clang/ -fix -checks readability-make-member-function-const 'connectedhomeip/src/'

Testing

This is an automated tool run. Visually the changes looked ok.

@restyled-io restyled-io bot mentioned this pull request Mar 16, 2022
Closed
bzbarsky-apple
bzbarsky-apple reviewed Mar 16, 2022
View reviewed changes
src/app/CASESessionManager.cpp Outdated Show resolved Hide resolved
src/app/CASESessionManager.cpp Outdated Show resolved Hide resolved
src/app/ReadClient.cpp Outdated Show resolved Hide resolved
src/lib/core/CHIPTLVReader.cpp Show resolved Hide resolved
src/lib/support/Pool.h Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Mar 16, 2022 •
edited
Loading

PR #16309: Size comparison from 645b03b to 8b04e2a

Full report (11 builds for linux)
platform target config section 645b03b 8b04e2a change % change
linux all-clusters-app debug (read only) 2471121 2471121 0 0.0
(read/write) 146544 146544 0 0.0
.bss 60736 60736 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78808 78808 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 210853 210853 0 0.0
.text 2096914 2096914 0 0.0
bridge-app debug+rpc (read only) 1747453 1747453 0 0.0
(read/write) 92720 92720 0 0.0
.bss 47784 47784 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 37904 37904 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 143564 143564 0 0.0
.text 1488773 1488773 0 0.0
chip-tool debug (read only) 10127373 10127373 0 0.0
(read/write) 357720 357720 0 0.0
.bss 25728 25728 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 324864 324864 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 515669 515669 0 0.0
.text 8830373 8830373 0 0.0
chip-tool-ipv6only arm64 (read only) 9754132 9754132 0 0.0
(read/write) 475473 475473 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371256 371256 0 0.0
.dynamic 560 560 0 0.0
.got 55264 55264 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492348 492348 0 0.0
.text 8211892 8211892 0 0.0
door-lock-app debug (read only) 1998585 1998585 0 0.0
(read/write) 120192 120192 0 0.0
.bss 51008 51008 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62808 62808 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 179740 179740 0 0.0
.text 1669282 1669282 0 0.0
lighting-app debug+rpc (read only) 2130201 2130201 0 0.0
(read/write) 125512 125512 0 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66760 66760 0 0.0
.dynamic 608 608 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 172316 172316 0 0.0
.text 1801298 1801298 0 0.0
ota-provider-app debug (read only) 1933633 1933633 0 0.0
(read/write) 116016 116016 0 0.0
.bss 50912 50912 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 58168 58168 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 165739 165739 0 0.0
.text 1616226 1616226 0 0.0
ota-requestor-app debug (read only) 1963417 1963417 0 0.0
(read/write) 118984 118984 0 0.0
.bss 51904 51904 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 60232 60232 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 161764 161764 0 0.0
.text 1649762 1649762 0 0.0
shell debug (read only) 2421345 2421345 0 0.0
(read/write) 150600 150600 0 0.0
.bss 70664 70664 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73440 73440 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 208850 208850 0 0.0
.text 2055890 2055890 0 0.0
thermostat-no-ble arm64 (read only) 2219868 2219868 0 0.0
(read/write) 149777 149777 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75696 75696 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137660 137660 0 0.0
.text 1862240 1862240 0 0.0
tv-app debug (read only) 2669889 2669889 0 0.0
(read/write) 251192 251192 0 0.0
.bss 167904 167904 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 74152 74152 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 205621 205621 0 0.0
.text 2289538 2289538 0 0.0

@andy31415
Copy link
Contributor Author

I will have to go through these. I believe clang-tidy cannot have a global view and this is how all the embedded platforms fail.

@github-actions
Copy link

github-actions bot commented Mar 16, 2022 •
edited
Loading

PR #16309: Size comparison from 6091a14 to 08e8a11

Full report (22 builds for cyw30739, efr32, k32w, linux, p6)
platform target config section 6091a14 08e8a118 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603122 603122 0 0.0
.app_xip_area 510220 510220 0 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560910 560910 0 0.0
.app_xip_area 469536 469536 0 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570794 570794 0 0.0
.app_xip_area 469772 469772 0 0.0
.bss 83464 83464 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920572 920572 0 0.0
(read/write) 128752 128752 0 0.0
.bss 126744 126744 0 0.0
.data 2008 2008 0 0.0
.text 920564 920564 0 0.0
BRD4161A+rpc (read only) 949392 949392 0 0.0
(read/write) 144712 144712 0 0.0
.bss 142520 142520 0 0.0
.data 2188 2188 0 0.0
.text 949384 949384 0 0.0
window-app BRD4161A (read only) 851336 851336 0 0.0
(read/write) 126704 126704 0 0.0
.bss 124840 124840 0 0.0
.data 1864 1864 0 0.0
.text 851328 851328 0 0.0
k32w light k32w061+release (read/write) 699800 699800 0 0.0
.bss 77632 77632 0 0.0
.data 1888 1888 0 0.0
.text 614480 614480 0 0.0
lock k32w061+release (read/write) 700096 700096 0 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 614764 614764 0 0.0
linux all-clusters-app debug (read only) 2470657 2470657 0 0.0
(read/write) 146544 146544 0 0.0
.bss 60736 60736 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78808 78808 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 210885 210885 0 0.0
.text 2096418 2096418 0 0.0
bridge-app debug+rpc (read only) 1746957 1746957 0 0.0
(read/write) 92720 92720 0 0.0
.bss 47784 47784 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 37904 37904 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 143564 143564 0 0.0
.text 1488277 1488277 0 0.0
chip-tool debug (read only) 10126877 10126877 0 0.0
(read/write) 357720 357720 0 0.0
.bss 25728 25728 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 324864 324864 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 515669 515669 0 0.0
.text 8829877 8829877 0 0.0
chip-tool-ipv6only arm64 (read only) 9753604 9753604 0 0.0
(read/write) 475473 475473 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371256 371256 0 0.0
.dynamic 560 560 0 0.0
.got 55264 55264 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492364 492364 0 0.0
.text 8211348 8211348 0 0.0
door-lock-app debug (read only) 1998105 1998105 0 0.0
(read/write) 120192 120192 0 0.0
.bss 51008 51008 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62808 62808 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 179740 179740 0 0.0
.text 1668802 1668802 0 0.0
lighting-app debug+rpc (read only) 2129753 2129753 0 0.0
(read/write) 125512 125512 0 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66760 66760 0 0.0
.dynamic 608 608 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 172348 172348 0 0.0
.text 1800818 1800818 0 0.0
ota-provider-app debug (read only) 1933169 1933169 0 0.0
(read/write) 116016 116016 0 0.0
.bss 50912 50912 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 58168 58168 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 165771 165771 0 0.0
.text 1615730 1615730 0 0.0
ota-requestor-app debug (read only) 1962953 1962953 0 0.0
(read/write) 118984 118984 0 0.0
.bss 51904 51904 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 60232 60232 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 161796 161796 0 0.0
.text 1649266 1649266 0 0.0
shell debug (read only) 2420849 2420849 0 0.0
(read/write) 150600 150600 0 0.0
.bss 70664 70664 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73440 73440 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 208850 208850 0 0.0
.text 2055394 2055394 0 0.0
thermostat-no-ble arm64 (read only) 2219292 2219292 0 0.0
(read/write) 149777 149777 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75696 75696 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137676 137676 0 0.0
.text 1861648 1861648 0 0.0
tv-app debug (read only) 2669425 2669425 0 0.0
(read/write) 251192 251192 0 0.0
.bss 167904 167904 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 74152 74152 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 205653 205653 0 0.0
.text 2289042 2289042 0 0.0
p6 all-clusters-app default (read/write) 2491280 2491280 0 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1449544 1449544 0 0.0
light-app default (read/write) 2395136 2395136 0 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1353400 1353400 0 0.0
lock-app default (read/write) 2358680 2358680 0 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1316944 1316944 0 0.0

@github-actions
Copy link

github-actions bot commented Mar 17, 2022 •
edited
Loading

PR #16309: Size comparison from e5c5a9e to f2e8b8b

Increases (11 builds for esp32, linux, nrfconnect, p6, telink)
platform target config section e5c5a9e f2e8b8b change % change
esp32 all-clusters-app c3devkit (read only) 961334 961358 24 0.0
.flash.text 961334 961358 24 0.0
m5stack (read only) 1017487 1017511 24 0.0
.flash.text 1012103 1012127 24 0.0
linux all-clusters-app debug (read only) 2471921 2471969 48 0.0
.text 2097522 2097570 48 0.0
chip-tool debug (read only) 10128269 10139581 11312 0.1
(read/write) 357752 358264 512 0.1
.data.rel.ro 324896 325408 512 0.2
.rodata 515733 516725 992 0.2
.text 8831109 8840277 9168 0.1
chip-tool-ipv6only arm64 (read only) 9754764 9764284 9520 0.1
(read/write) 475505 476113 608 0.1
.data.rel.ro 371288 371824 536 0.1
.got 55264 55328 64 0.1
.rodata 492308 492996 688 0.1
.text 8212468 8219924 7456 0.1
shell debug (read only) 2422081 2422129 48 0.0
.text 2056498 2056546 48 0.0
thermostat-no-ble arm64 (read only) 2220292 2220324 32 0.0
.text 1862496 1862528 32 0.0
tv-app debug (read only) 2670609 2670673 64 0.0
.text 2290066 2290130 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 787424 787432 8 0.0
p6 all-clusters-app default (read/write) 2491760 2491776 16 0.0
.text 1450024 1450040 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 894946 894970 24 0.0
text 632808 632832 24 0.0
Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section e5c5a9e f2e8b8b change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603426 603426 0 0.0
.app_xip_area 510524 510524 0 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561222 561222 0 0.0
.app_xip_area 469848 469848 0 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571026 571026 0 0.0
.app_xip_area 470004 470004 0 0.0
.bss 83464 83464 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920956 920956 0 0.0
(read/write) 128752 128752 0 0.0
.bss 126744 126744 0 0.0
.data 2008 2008 0 0.0
.text 920948 920948 0 0.0
BRD4161A+rpc (read only) 949760 949760 0 0.0
(read/write) 144712 144712 0 0.0
.bss 142520 142520 0 0.0
.data 2188 2188 0 0.0
.text 949752 949752 0 0.0
window-app BRD4161A (read only) 851708 851708 0 0.0
(read/write) 126704 126704 0 0.0
.bss 124840 124840 0 0.0
.data 1864 1864 0 0.0
.text 851700 851700 0 0.0
esp32 all-clusters-app c3devkit (read only) 961334 961358 24 0.0
(read/write) 1394818 1394818 0 0.0
.dram0.bss 64048 64048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197672 197672 0 0.0
.flash.text 961334 961358 24 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017487 1017511 24 0.0
(read/write) 462660 462660 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 227232 227232 0 0.0
.flash.text 1012103 1012127 24 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 700112 700112 0 0.0
.bss 77632 77632 0 0.0
.data 1888 1888 0 0.0
.text 614792 614792 0 0.0
lock k32w061+release (read/write) 700408 700408 0 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615076 615076 0 0.0
linux all-clusters-app debug (read only) 2471921 2471969 48 0.0
(read/write) 146576 146576 0 0.0
.bss 60736 60736 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78840 78840 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 210949 210949 0 0.0
.text 2097522 2097570 48 0.0
bridge-app debug+rpc (read only) 1748173 1748173 0 0.0
(read/write) 92752 92752 0 0.0
.bss 47784 47784 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 143628 143628 0 0.0
.text 1489333 1489333 0 0.0
chip-tool debug (read only) 10128269 10139581 11312 0.1
(read/write) 357752 358264 512 0.1
.bss 25728 25728 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 324896 325408 512 0.2
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 515733 516725 992 0.2
.text 8831109 8840277 9168 0.1
chip-tool-ipv6only arm64 (read only) 9754764 9764284 9520 0.1
(read/write) 475505 476113 608 0.1
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371288 371824 536 0.1
.dynamic 560 560 0 0.0
.got 55264 55328 64 0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492308 492996 688 0.1
.text 8212468 8219924 7456 0.1
door-lock-app debug (read only) 1999337 1999337 0 0.0
(read/write) 120224 120224 0 0.0
.bss 51008 51008 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 179836 179836 0 0.0
.text 1669842 1669842 0 0.0
lighting-app debug+rpc (read only) 2130937 2130937 0 0.0
(read/write) 125544 125544 0 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66792 66792 0 0.0
.dynamic 608 608 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 172412 172412 0 0.0
.text 1801842 1801842 0 0.0
ota-provider-app debug (read only) 1934369 1934369 0 0.0
(read/write) 116048 116048 0 0.0
.bss 50912 50912 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 58200 58200 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 165835 165835 0 0.0
.text 1616770 1616770 0 0.0
ota-requestor-app debug (read only) 1964169 1964169 0 0.0
(read/write) 119016 119016 0 0.0
.bss 51904 51904 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 161860 161860 0 0.0
.text 1650322 1650322 0 0.0
shell debug (read only) 2422081 2422129 48 0.0
(read/write) 150632 150632 0 0.0
.bss 70664 70664 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73472 73472 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 208882 208882 0 0.0
.text 2056498 2056546 48 0.0
thermostat-no-ble arm64 (read only) 2220292 2220324 32 0.0
(read/write) 149809 149809 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137732 137732 0 0.0
.text 1862496 1862528 32 0.0
tv-app debug (read only) 2670609 2670673 64 0.0
(read/write) 251224 251224 0 0.0
.bss 167904 167904 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 74184 74184 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 205717 205717 0 0.0
.text 2290066 2290130 64 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2458352 2458352 0 0.0
.bss 192568 192568 0 0.0
.data 5448 5448 0 0.0
.text 1420924 1420924 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2419688 2419688 0 0.0
.bss 187876 187876 0 0.0
.data 5776 5776 0 0.0
.text 1382260 1382260 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352364 2352364 0 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1314964 1314964 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2345920 2345920 0 0.0
.bss 186424 186424 0 0.0
.data 5560 5560 0 0.0
.text 1308492 1308492 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154847 1154847 0 0.0
bss 146724 146724 0 0.0
rodata 145536 145536 0 0.0
text 787424 787432 8 0.0
p6 all-clusters-app default (read/write) 2491760 2491776 16 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1450024 1450040 16 0.0
light-app default (read/write) 2395528 2395528 0 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1353792 1353792 0 0.0
lock-app default (read/write) 2359072 2359072 0 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317336 1317336 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 894946 894970 24 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 632808 632832 24 0.0

@andy31415 andy31415 merged commit d43e6a7 into project-chip:master Mar 17, 2022
ArekBalysNordic pushed a commit to ArekBalysNordic/connectedhomeip that referenced this pull request Mar 18, 2022
@andy31415 @ArekBalysNordic
use clang-tidy to readability-make-member-function-const (project-chi…
2d5f93a 
…p#16309)

* use clang-tidy to readability-make-member-function-const

* Code review comments - remove some of the consts that are not conceptually correct

* Undo CHIPTLV changes - method seems to use class members

* Update const compile for LWIP platforms

* Restyle

* Fix mbedos build

* Fix one more const to make telink compile
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@andy31415 @andrei-menzopol
use clang-tidy to readability-make-member-function-const (project-chi…
7b2908a 
…p#16309)

* use clang-tidy to readability-make-member-function-const

* Code review comments - remove some of the consts that are not conceptually correct

* Undo CHIPTLV changes - method seems to use class members

* Update const compile for LWIP platforms

* Restyle

* Fix mbedos build

* Fix one more const to make telink compile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app ble controller inet lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andy31415 @bzbarsky-apple @Damian-Nordic