Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ota requestor variants for efr32 builds in build_examples #16228

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Add ota requestor variants for efr32 builds in build_examples #16228

merged 2 commits into from
Mar 16, 2022

Conversation

andy31415
Copy link
Contributor

Problem

Add more support for specific variants in build_examples

Change overview

Make 'variant' logic a bit more centralized so it can be shared between targets.
Adds ota requestor variant to efr32 and expose it as a build option

Testing

Manual compile, unit tests.

@github-actions
Copy link

github-actions bot commented Mar 15, 2022 •
edited
Loading

PR #16228: Size comparison from 494cfb2 to 929dde0

Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 494cfb2 929dde0 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602578 602578 0 0.0
.app_xip_area 509756 509756 0 0.0
.bss 75576 75576 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560430 560430 0 0.0
.app_xip_area 469136 469136 0 0.0
.bss 74080 74080 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570498 570498 0 0.0
.app_xip_area 469556 469556 0 0.0
.bss 83384 83384 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919652 919652 0 0.0
(read/write) 128672 128672 0 0.0
.bss 126664 126664 0 0.0
.data 2008 2008 0 0.0
.text 919644 919644 0 0.0
BRD4161A+rpc (read only) 948440 948440 0 0.0
(read/write) 144632 144632 0 0.0
.bss 142440 142440 0 0.0
.data 2188 2188 0 0.0
.text 948432 948432 0 0.0
window-app BRD4161A (read only) 850392 850392 0 0.0
(read/write) 126632 126632 0 0.0
.bss 124768 124768 0 0.0
.data 1864 1864 0 0.0
.text 850384 850384 0 0.0
esp32 all-clusters-app c3devkit (read only) 961388 961388 0 0.0
(read/write) 1394938 1394938 0 0.0
.dram0.bss 64056 64056 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197776 197776 0 0.0
.flash.text 961388 961388 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017011 1017011 0 0.0
(read/write) 462148 462148 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 226720 226720 0 0.0
.flash.text 1011627 1011627 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699340 699340 0 0.0
.bss 77560 77560 0 0.0
.data 1888 1888 0 0.0
.text 614092 614092 0 0.0
lock k32w061+release (read/write) 699644 699644 0 0.0
.bss 77552 77552 0 0.0
.data 1908 1908 0 0.0
.text 614384 614384 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9728308 9728308 0 0.0
(read/write) 475441 475441 0 0.0
.bss 44017 44017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371232 371232 0 0.0
.dynamic 560 560 0 0.0
.got 55264 55264 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492252 492252 0 0.0
.text 8186180 8186180 0 0.0
thermostat-no-ble arm64 (read only) 2207324 2207324 0 0.0
(read/write) 149377 149377 0 0.0
.bss 65649 65649 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75368 75368 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 136828 136828 0 0.0
.text 1851184 1851184 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352756 2352756 0 0.0
.bss 186652 186652 0 0.0
.data 5752 5752 0 0.0
.text 1315356 1315356 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154011 1154011 0 0.0
bss 146644 146644 0 0.0
rodata 145276 145276 0 0.0
text 786976 786976 0 0.0
p6 all-clusters-app default (read/write) 2492152 2492152 0 0.0
.bss 120080 120080 0 0.0
.data 2632 2632 0 0.0
.text 1450416 1450416 0 0.0
light-app default (read/write) 2396000 2396000 0 0.0
.bss 113544 113544 0 0.0
.data 2488 2488 0 0.0
.text 1354264 1354264 0 0.0
lock-app default (read/write) 2359544 2359544 0 0.0
.bss 113288 113288 0 0.0
.data 2448 2448 0 0.0
.text 1317808 1317808 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 893770 893770 0 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 631868 631868 0 0.0

@github-actions
Copy link

github-actions bot commented Mar 15, 2022 •
edited
Loading

PR #16228: Size comparison from 85b4e5c to bba029d

Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 85b4e5c bba029d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602562 602562 0 0.0
.app_xip_area 509668 509668 0 0.0
.bss 75648 75648 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560422 560422 0 0.0
.app_xip_area 469056 469056 0 0.0
.bss 74152 74152 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570490 570490 0 0.0
.app_xip_area 469476 469476 0 0.0
.bss 83456 83456 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919700 919700 0 0.0
(read/write) 128752 128752 0 0.0
.bss 126744 126744 0 0.0
.data 2008 2008 0 0.0
.text 919692 919692 0 0.0
BRD4161A+rpc (read only) 948488 948488 0 0.0
(read/write) 144712 144712 0 0.0
.bss 142520 142520 0 0.0
.data 2188 2188 0 0.0
.text 948480 948480 0 0.0
window-app BRD4161A (read only) 850456 850456 0 0.0
(read/write) 126712 126712 0 0.0
.bss 124848 124848 0 0.0
.data 1864 1864 0 0.0
.text 850448 850448 0 0.0
esp32 all-clusters-app c3devkit (read only) 961466 961466 0 0.0
(read/write) 1394978 1394978 0 0.0
.dram0.bss 64056 64056 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197816 197816 0 0.0
.flash.text 961466 961466 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1016983 1016983 0 0.0
(read/write) 462188 462188 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 226760 226760 0 0.0
.flash.text 1011599 1011599 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699324 699324 0 0.0
.bss 77624 77624 0 0.0
.data 1888 1888 0 0.0
.text 614012 614012 0 0.0
lock k32w061+release (read/write) 699628 699628 0 0.0
.bss 77616 77616 0 0.0
.data 1908 1908 0 0.0
.text 614304 614304 0 0.0
linux all-clusters-app debug (read only) 2465449 2465449 0 0.0
(read/write) 146352 146352 0 0.0
.bss 60640 60640 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78728 78728 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 210757 210757 0 0.0
.text 2091458 2091458 0 0.0
bridge-app debug+rpc (read only) 1750077 1750077 0 0.0
(read/write) 92912 92912 0 0.0
.bss 47752 47752 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 38128 38128 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 143372 143372 0 0.0
.text 1491157 1491157 0 0.0
chip-tool debug (read only) 10095789 10095789 0 0.0
(read/write) 357680 357680 0 0.0
.bss 25696 25696 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 324864 324864 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 515189 515189 0 0.0
.text 8799349 8799349 0 0.0
chip-tool-ipv6only arm64 (read only) 9728724 9728724 0 0.0
(read/write) 475441 475441 0 0.0
.bss 44017 44017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371232 371232 0 0.0
.dynamic 560 560 0 0.0
.got 55264 55264 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492252 492252 0 0.0
.text 8186596 8186596 0 0.0
door-lock-app debug (read only) 1984609 1984609 0 0.0
(read/write) 119776 119776 0 0.0
.bss 50944 50944 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 178460 178460 0 0.0
.text 1657250 1657250 0 0.0
lighting-app debug+rpc (read only) 2116185 2116185 0 0.0
(read/write) 125160 125160 0 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66408 66408 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 171004 171004 0 0.0
.text 1789266 1789266 0 0.0
ota-provider-app debug (read only) 1919673 1919673 0 0.0
(read/write) 115568 115568 0 0.0
.bss 50848 50848 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 57816 57816 0 0.0
.dynamic 608 608 0 0.0
.got 4360 4360 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 164491 164491 0 0.0
.text 1604178 1604178 0 0.0
ota-requestor-app debug (read only) 1949473 1949473 0 0.0
(read/write) 118568 118568 0 0.0
.bss 51840 51840 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 59880 59880 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 160516 160516 0 0.0
.text 1637730 1637730 0 0.0
shell debug (read only) 2411593 2411593 0 0.0
(read/write) 150184 150184 0 0.0
.bss 70600 70600 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73088 73088 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 207538 207538 0 0.0
.text 2047906 2047906 0 0.0
thermostat-no-ble arm64 (read only) 2207484 2207484 0 0.0
(read/write) 149377 149377 0 0.0
.bss 65649 65649 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75368 75368 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 136828 136828 0 0.0
.text 1851344 1851344 0 0.0
tv-app debug (read only) 2656433 2656433 0 0.0
(read/write) 250776 250776 0 0.0
.bss 167840 167840 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 73800 73800 0 0.0
.dynamic 592 592 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 204277 204277 0 0.0
.text 2278098 2278098 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352692 2352692 0 0.0
.bss 186652 186652 0 0.0
.data 5752 5752 0 0.0
.text 1315292 1315292 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154071 1154071 0 0.0
bss 146724 146724 0 0.0
rodata 145272 145272 0 0.0
text 786916 786916 0 0.0
p6 all-clusters-app default (read/write) 2492136 2492136 0 0.0
.bss 120080 120080 0 0.0
.data 2632 2632 0 0.0
.text 1450400 1450400 0 0.0
light-app default (read/write) 2395984 2395984 0 0.0
.bss 113544 113544 0 0.0
.data 2488 2488 0 0.0
.text 1354248 1354248 0 0.0
lock-app default (read/write) 2359528 2359528 0 0.0
.bss 113288 113288 0 0.0
.data 2448 2448 0 0.0
.text 1317792 1317792 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 893762 893762 0 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 631860 631860 0 0.0

@andy31415
Copy link
Contributor Author

/rebase

@andy31415 andy31415 mentioned this pull request Mar 16, 2022
Merged
@andy31415
Copy link
Contributor Author

/rebase

@woody-apple woody-apple force-pushed the build_examples/ota_in_efr32 branch from e02931e to 961582c Compare March 16, 2022 20:03
@github-actions
Copy link

github-actions bot commented Mar 16, 2022 •
edited
Loading

PR #16228: Size comparison from 645efef to 961582c

Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 645efef 961582c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603122 603122 0 0.0
.app_xip_area 510220 510220 0 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560910 560910 0 0.0
.app_xip_area 469536 469536 0 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570794 570794 0 0.0
.app_xip_area 469772 469772 0 0.0
.bss 83464 83464 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920572 920572 0 0.0
(read/write) 128752 128752 0 0.0
.bss 126744 126744 0 0.0
.data 2008 2008 0 0.0
.text 920564 920564 0 0.0
BRD4161A+rpc (read only) 949392 949392 0 0.0
(read/write) 144712 144712 0 0.0
.bss 142520 142520 0 0.0
.data 2188 2188 0 0.0
.text 949384 949384 0 0.0
window-app BRD4161A (read only) 851336 851336 0 0.0
(read/write) 126704 126704 0 0.0
.bss 124840 124840 0 0.0
.data 1864 1864 0 0.0
.text 851328 851328 0 0.0
esp32 all-clusters-app c3devkit (read only) 961044 961044 0 0.0
(read/write) 1394706 1394706 0 0.0
.dram0.bss 64048 64048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197560 197560 0 0.0
.flash.text 961044 961044 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017055 1017055 0 0.0
(read/write) 462380 462380 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 226952 226952 0 0.0
.flash.text 1011671 1011671 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699800 699800 0 0.0
.bss 77632 77632 0 0.0
.data 1888 1888 0 0.0
.text 614480 614480 0 0.0
lock k32w061+release (read/write) 700096 700096 0 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 614764 614764 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9753604 9753604 0 0.0
(read/write) 475473 475473 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371256 371256 0 0.0
.dynamic 560 560 0 0.0
.got 55264 55264 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492364 492364 0 0.0
.text 8211348 8211348 0 0.0
thermostat-no-ble arm64 (read only) 2219292 2219292 0 0.0
(read/write) 149777 149777 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75696 75696 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137676 137676 0 0.0
.text 1861648 1861648 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352068 2352068 0 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1314668 1314668 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154487 1154487 0 0.0
bss 146724 146724 0 0.0
rodata 145432 145432 0 0.0
text 787180 787180 0 0.0
p6 all-clusters-app default (read/write) 2491280 2491280 0 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1449544 1449544 0 0.0
light-app default (read/write) 2395136 2395136 0 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1353400 1353400 0 0.0
lock-app default (read/write) 2358680 2358680 0 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1316944 1316944 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 894566 894566 0 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 632492 632492 0 0.0

@andy31415 andy31415 merged commit 1986d5e into project-chip:master Mar 16, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@andy31415 @andrei-menzopol
Add ota requestor variants for efr32 builds in build_examples (projec…
23eef78 
…t-chip#16228)

* Add ota requestor variant for efr32 builds

* Restyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy31415 @bzbarsky-apple