-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Filter out non-commissionable devices #16221
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
Damian-Nordic:chip-tool-cm0
Mar 16, 2022
Merged
[chip-tool] Filter out non-commissionable devices #16221
bzbarsky-apple
merged 1 commit into
project-chip:master
from
Damian-Nordic:chip-tool-cm0
Mar 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"pairing onnetwork" commands don't filter out devices with CM=0 TXT entry indicating closed commissioning window.
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda,
msandstedt and
sagar-apple
March 15, 2022 12:58
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
March 15, 2022 12:58
PR #16221: Size comparison from b18b03a to bb18975 Increases (2 builds for linux)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
saurabhst
approved these changes
Mar 15, 2022
bzbarsky-apple
approved these changes
Mar 16, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
"pairing onnetwork" commands don't filter out devices with CM=0 TXT entry indicating closed commissioning window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
"pairing onnetwork" commands don't filter out devices with CM=0 TXT entry indicating closed commissioning window.
Change overview
Don't try to pair devices with CM=0.
Testing
Ran the command against a device in non-commissionable state.