Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra namespace scope identifier #16082

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Remove extra namespace scope identifier #16082

merged 1 commit into from
Mar 11, 2022

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

  • Already in namespace {}, extra namespace with same scope identifier

Change overview

Remove extra namespace scope identifier

Testing

How was this tested? (at least one bullet point required)

  • Cleanup only, no logic change

@github-actions
Copy link

github-actions bot commented Mar 10, 2022

PR #16082: Size comparison from 665a4ae to 2260867

Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 665a4ae 2260867 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599130 599130 0 0.0
.app_xip_area 506712 506712 0 0.0
.bss 75108 75108 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557010 557010 0 0.0
.app_xip_area 466128 466128 0 0.0
.bss 73612 73612 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566894 566894 0 0.0
.app_xip_area 466324 466324 0 0.0
.bss 82980 82980 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921016 921016 0 0.0
(read/write) 128256 128256 0 0.0
.bss 126216 126216 0 0.0
.data 2040 2040 0 0.0
.text 921008 921008 0 0.0
BRD4161A+rpc (read only) 949828 949828 0 0.0
(read/write) 144212 144212 0 0.0
.bss 141992 141992 0 0.0
.data 2220 2220 0 0.0
.text 949820 949820 0 0.0
window-app BRD4161A (read only) 853556 853556 0 0.0
(read/write) 126220 126220 0 0.0
.bss 124304 124304 0 0.0
.data 1916 1916 0 0.0
.text 853548 853548 0 0.0
esp32 all-clusters-app c3devkit (read only) 958466 958466 0 0.0
(read/write) 1393914 1393914 0 0.0
.dram0.bss 63576 63576 0 0.0
.dram0.data 14228 14228 0 0.0
.flash.rodata 197184 197184 0 0.0
.flash.text 958466 958466 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1014067 1014067 0 0.0
(read/write) 461140 461140 0 0.0
.dram0.bss 69096 69096 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226144 226144 0 0.0
.flash.text 1008683 1008683 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 695512 695512 0 0.0
.bss 77152 77152 0 0.0
.data 1924 1924 0 0.0
.text 610636 610636 0 0.0
lock k32w061+release (read/write) 696356 696356 0 0.0
.bss 77072 77072 0 0.0
.data 1964 1964 0 0.0
.text 611520 611520 0 0.0
linux all-clusters-app debug (read only) 2436177 2436177 0 0.0
(read/write) 145872 145872 0 0.0
.bss 60352 60352 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78424 78424 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 206181 206181 0 0.0
.text 2067010 2067010 0 0.0
bridge-app debug+rpc (read only) 1741461 1741461 0 0.0
(read/write) 92784 92784 0 0.0
.bss 47624 47624 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 38064 38064 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 142316 142316 0 0.0
.text 1483173 1483173 0 0.0
chip-tool debug (read only) 10097253 10097253 0 0.0
(read/write) 358168 358168 0 0.0
.bss 25640 25640 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 325352 325352 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514516 514516 0 0.0
.text 8800053 8800053 0 0.0
chip-tool-ipv6only arm64 (read only) 9730828 9730828 0 0.0
(read/write) 475905 475905 0 0.0
.bss 43953 43953 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 371664 371664 0 0.0
.dynamic 560 560 0 0.0
.got 55296 55296 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492148 492148 0 0.0
.text 8187556 8187556 0 0.0
door-lock-app debug (read only) 1955841 1955841 0 0.0
(read/write) 119296 119296 0 0.0
.bss 50656 50656 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 174300 174300 0 0.0
.text 1632898 1632898 0 0.0
lighting-app debug+rpc (read only) 2087977 2087977 0 0.0
(read/write) 124616 124616 0 0.0
.bss 51456 51456 0 0.0
.data 1536 1536 0 0.0
.data.rel.ro 66104 66104 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 166460 166460 0 0.0
.text 1765858 1765858 0 0.0
ota-provider-app debug (read only) 1889225 1889225 0 0.0
(read/write) 114896 114896 0 0.0
.bss 50464 50464 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 159475 159475 0 0.0
.text 1579026 1579026 0 0.0
ota-requestor-app debug (read only) 1917097 1917097 0 0.0
(read/write) 117992 117992 0 0.0
.bss 51552 51552 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 59512 59512 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 155468 155468 0 0.0
.text 1610754 1610754 0 0.0
shell debug (read only) 2402177 2402177 0 0.0
(read/write) 150088 150088 0 0.0
.bss 70472 70472 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73064 73064 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 206130 206130 0 0.0
.text 2039474 2039474 0 0.0
thermostat-no-ble arm64 (read only) 2181908 2181908 0 0.0
(read/write) 148801 148801 0 0.0
.bss 65393 65393 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 75112 75112 0 0.0
.dynamic 560 560 0 0.0
.got 4272 4272 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133412 133412 0 0.0
.text 1829856 1829856 0 0.0
tv-app debug (read only) 2627817 2627817 0 0.0
(read/write) 250360 250360 0 0.0
.bss 167520 167520 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199741 199741 0 0.0
.text 2253986 2253986 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350964 2350964 0 0.0
.bss 186212 186212 0 0.0
.data 5792 5792 0 0.0
.text 1313564 1313564 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152707 1152707 0 0.0
bss 146208 146208 0 0.0
rodata 144556 144556 0 0.0
text 786700 786700 0 0.0
p6 all-clusters-app default (read/write) 2495504 2495504 0 0.0
.bss 119640 119640 0 0.0
.data 2680 2680 0 0.0
.text 1453768 1453768 0 0.0
light-app default (read/write) 2399520 2399520 0 0.0
.bss 113104 113104 0 0.0
.data 2536 2536 0 0.0
.text 1357784 1357784 0 0.0
lock-app default (read/write) 2363064 2363064 0 0.0
.bss 112848 112848 0 0.0
.data 2496 2496 0 0.0
.text 1321328 1321328 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 889758 889758 0 0.0
bss 86968 86968 0 0.0
noinit 37160 37160 0 0.0
text 628910 628910 0 0.0

@andy31415 andy31415 merged commit 388b463 into project-chip:master Mar 11, 2022
@yufengwangca yufengwangca deleted the pr/esp32/cleanup branch March 14, 2022 23:06
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants