Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP32: Remove example connection from menuconfig #15955

Merged
merged 1 commit into from
Mar 11, 2022
Merged

ESP32: Remove example connection from menuconfig #15955

merged 1 commit into from
Mar 11, 2022

Conversation

wqx6
Copy link
Contributor

@wqx6 wqx6 commented Mar 8, 2022 •
edited
Loading

Problem

#15952 We have provided a way to connect an AP so the example connection is not required.

Change overview

Remove it from the extra components.

Testing

Components path change, CI is enough.

@jadhavrohit924
Copy link
Contributor

If we set ssid and pass through menuconfig ( Component config --> CHIP Device Layer --> WiFi Station Options ), device is connecting to AP.

@github-actions
Copy link

github-actions bot commented Mar 8, 2022 •
edited
Loading

PR #15955: Size comparison from 1434c51 to 86d8169

Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1434c51 86d8169 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601802 601802 0 0.0
.app_xip_area 506344 506344 0 0.0
.bss 78140 78140 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559722 559722 0 0.0
.app_xip_area 465800 465800 0 0.0
.bss 76644 76644 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581910 581910 0 0.0
.app_xip_area 478308 478308 0 0.0
.bss 85972 85972 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920868 920868 0 0.0
(read/write) 128848 128848 0 0.0
.bss 126768 126768 0 0.0
.data 2080 2080 0 0.0
.text 920860 920860 0 0.0
BRD4161A+rpc (read only) 949688 949688 0 0.0
(read/write) 144808 144808 0 0.0
.bss 142544 142544 0 0.0
.data 2260 2260 0 0.0
.text 949680 949680 0 0.0
window-app BRD4161A (read only) 853888 853888 0 0.0
(read/write) 126840 126840 0 0.0
.bss 124912 124912 0 0.0
.data 1924 1924 0 0.0
.text 853880 853880 0 0.0
esp32 all-clusters-app c3devkit (read only) 957506 957506 0 0.0
(read/write) 1393618 1393618 0 0.0
.dram0.bss 63432 63432 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197032 197032 0 0.0
.flash.text 957506 957506 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012255 1012255 0 0.0
(read/write) 460724 460724 0 0.0
.dram0.bss 68960 68960 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225848 225848 0 0.0
.flash.text 1006871 1006871 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694852 694852 0 0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 609384 609384 0 0.0
lock k32w061+release (read/write) 696456 696456 0 0.0
.bss 77672 77672 0 0.0
.data 1972 1972 0 0.0
.text 611012 611012 0 0.0
linux all-clusters-app debug (read only) 2426809 2426809 0 0.0
(read/write) 145600 145600 0 0.0
.bss 60128 60128 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78360 78360 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205509 205509 0 0.0
.text 2058434 2058434 0 0.0
bridge-app debug+rpc (read only) 1731837 1731837 0 0.0
(read/write) 92560 92560 0 0.0
.bss 47432 47432 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38008 38008 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141748 141748 0 0.0
.text 1474213 1474213 0 0.0
chip-tool debug (read only) 9758533 9758533 0 0.0
(read/write) 338488 338488 0 0.0
.bss 25512 25512 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 305816 305816 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 510868 510868 0 0.0
.text 8508373 8508373 0 0.0
chip-tool-ipv6only arm64 (read only) 9430548 9430548 0 0.0
(read/write) 454177 454177 0 0.0
.bss 43825 43825 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 351000 351000 0 0.0
.dynamic 560 560 0 0.0
.got 54360 54360 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 486556 486556 0 0.0
.text 7940244 7940244 0 0.0
door-lock-app debug (read only) 1946161 1946161 0 0.0
(read/write) 119008 119008 0 0.0
.bss 50432 50432 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62136 62136 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173660 173660 0 0.0
.text 1623954 1623954 0 0.0
lighting-app debug+rpc (read only) 2078233 2078233 0 0.0
(read/write) 124376 124376 0 0.0
.bss 51264 51264 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 66040 66040 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 165852 165852 0 0.0
.text 1756866 1756866 0 0.0
ota-provider-app debug (read only) 1879017 1879017 0 0.0
(read/write) 114640 114640 0 0.0
.bss 50240 50240 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57416 57416 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158899 158899 0 0.0
.text 1569490 1569490 0 0.0
ota-requestor-app debug (read only) 1901001 1901001 0 0.0
(read/write) 117352 117352 0 0.0
.bss 51296 51296 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 59112 59112 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 154188 154188 0 0.0
.text 1596850 1596850 0 0.0
shell debug (read only) 2392921 2392921 0 0.0
(read/write) 149752 149752 0 0.0
.bss 70216 70216 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73008 73008 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205458 205458 0 0.0
.text 2031010 2031010 0 0.0
thermostat-no-ble arm64 (read only) 2174612 2174612 0 0.0
(read/write) 148465 148465 0 0.0
.bss 65201 65201 0 0.0
.data 1080 1080 0 0.0
.data.rel.ro 75000 75000 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133012 133012 0 0.0
.text 1823312 1823312 0 0.0
tv-app debug (read only) 2617049 2617049 0 0.0
(read/write) 250648 250648 0 0.0
.bss 167904 167904 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73504 73504 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199453 199453 0 0.0
.text 2243698 2243698 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350876 2350876 0 0.0
.bss 186084 186084 0 0.0
.data 5800 5800 0 0.0
.text 1313476 1313476 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151827 1151827 0 0.0
bss 146792 146792 0 0.0
rodata 144300 144300 0 0.0
text 785544 785544 0 0.0
p6 all-clusters-app default (read/write) 2494064 2494064 0 0.0
.bss 119504 119504 0 0.0
.data 2696 2696 0 0.0
.text 1452328 1452328 0 0.0
light-app default (read/write) 2397504 2397504 0 0.0
.bss 112976 112976 0 0.0
.data 2544 2544 0 0.0
.text 1355768 1355768 0 0.0
lock-app default (read/write) 2360936 2360936 0 0.0
.bss 112720 112720 0 0.0
.data 2504 2504 0 0.0
.text 1319200 1319200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888978 888978 0 0.0
bss 86928 86928 0 0.0
noinit 37160 37160 0 0.0
text 628342 628342 0 0.0

@chshu chshu mentioned this pull request Mar 9, 2022
Closed
@wqx6 wqx6 force-pushed the fix-on-network-commissioning-esp branch from 86d8169 to fa64e9e Compare March 9, 2022 02:21
@wqx6 wqx6 changed the title ESP32: Fix on-network commissioning issue on ESP32 ESP32: Reomve example connection from menuconfig Mar 9, 2022
@github-actions
Copy link

github-actions bot commented Mar 9, 2022 •
edited
Loading

PR #15955: Size comparison from 4d18b49 to fa64e9e

Full report (17 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 4d18b49 fa64e9e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602114 602114 0 0.0
.app_xip_area 506632 506632 0 0.0
.bss 78172 78172 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560014 560014 0 0.0
.app_xip_area 466068 466068 0 0.0
.bss 76676 76676 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 582214 582214 0 0.0
.app_xip_area 478588 478588 0 0.0
.bss 86004 86004 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921392 921392 0 0.0
(read/write) 128872 128872 0 0.0
.bss 126800 126800 0 0.0
.data 2072 2072 0 0.0
.text 921384 921384 0 0.0
BRD4161A+rpc (read only) 950228 950228 0 0.0
(read/write) 144828 144828 0 0.0
.bss 142576 142576 0 0.0
.data 2252 2252 0 0.0
.text 950220 950220 0 0.0
window-app BRD4161A (read only) 854428 854428 0 0.0
(read/write) 126852 126852 0 0.0
.bss 124936 124936 0 0.0
.data 1916 1916 0 0.0
.text 854420 854420 0 0.0
esp32 all-clusters-app c3devkit (read only) 958612 958612 0 0.0
(read/write) 1393770 1393770 0 0.0
.dram0.bss 63576 63576 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 197056 197056 0 0.0
.flash.text 958612 958612 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1013671 1013671 0 0.0
(read/write) 461028 461028 0 0.0
.dram0.bss 69096 69096 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226032 226032 0 0.0
.flash.text 1008287 1008287 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 695272 695272 0 0.0
.bss 77736 77736 0 0.0
.data 1956 1956 0 0.0
.text 609780 609780 0 0.0
lock k32w061+release (read/write) 696876 696876 0 0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 611408 611408 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9485596 9485596 0 0.0
(read/write) 454481 454481 0 0.0
.bss 43921 43921 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 351136 351136 0 0.0
.dynamic 560 560 0 0.0
.got 54424 54424 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 486916 486916 0 0.0
.text 7994484 7994484 0 0.0
thermostat-no-ble arm64 (read only) 2180012 2180012 0 0.0
(read/write) 148801 148801 0 0.0
.bss 65377 65377 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 75160 75160 0 0.0
.dynamic 560 560 0 0.0
.got 4240 4240 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133068 133068 0 0.0
.text 1828352 1828352 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152383 1152383 0 0.0
bss 146832 146832 0 0.0
rodata 144328 144328 0 0.0
text 785956 785956 0 0.0
p6 all-clusters-app default (read/write) 2495712 2495712 0 0.0
.bss 119640 119640 0 0.0
.data 2680 2680 0 0.0
.text 1453976 1453976 0 0.0
light-app default (read/write) 2399096 2399096 0 0.0
.bss 113104 113104 0 0.0
.data 2536 2536 0 0.0
.text 1357360 1357360 0 0.0
lock-app default (read/write) 2362528 2362528 0 0.0
.bss 112848 112848 0 0.0
.data 2496 2496 0 0.0
.text 1320792 1320792 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 889646 889646 0 0.0
bss 86968 86968 0 0.0
noinit 37160 37160 0 0.0
text 628950 628950 0 0.0

@electrocucaracha electrocucaracha changed the title ESP32: Reomve example connection from menuconfig ESP32: Remove example connection from menuconfig Mar 9, 2022
@wqx6 wqx6 force-pushed the fix-on-network-commissioning-esp branch from fa64e9e to d58162d Compare March 10, 2022 03:57
@github-actions
Copy link

github-actions bot commented Mar 10, 2022 •
edited
Loading

PR #15955: Size comparison from 2727739 to d58162d

Full report (17 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section 2727739 d58162d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598026 598026 0 0.0
.app_xip_area 505608 505608 0 0.0
.bss 75108 75108 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 555894 555894 0 0.0
.app_xip_area 465012 465012 0 0.0
.bss 73612 73612 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 565998 565998 0 0.0
.app_xip_area 465412 465412 0 0.0
.bss 82996 82996 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919824 919824 0 0.0
(read/write) 128264 128264 0 0.0
.bss 126224 126224 0 0.0
.data 2040 2040 0 0.0
.text 919816 919816 0 0.0
BRD4161A+rpc (read only) 948652 948652 0 0.0
(read/write) 144220 144220 0 0.0
.bss 142000 142000 0 0.0
.data 2220 2220 0 0.0
.text 948644 948644 0 0.0
window-app BRD4161A (read only) 852300 852300 0 0.0
(read/write) 126220 126220 0 0.0
.bss 124304 124304 0 0.0
.data 1916 1916 0 0.0
.text 852292 852292 0 0.0
esp32 all-clusters-app c3devkit (read only) 957672 957672 0 0.0
(read/write) 1393778 1393778 0 0.0
.dram0.bss 63576 63576 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 197064 197064 0 0.0
.flash.text 957672 957672 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012855 1012855 0 0.0
(read/write) 461028 461028 0 0.0
.dram0.bss 69096 69096 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226032 226032 0 0.0
.flash.text 1007471 1007471 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694460 694460 0 0.0
.bss 77160 77160 0 0.0
.data 1924 1924 0 0.0
.text 609576 609576 0 0.0
lock k32w061+release (read/write) 695260 695260 0 0.0
.bss 77072 77072 0 0.0
.data 1964 1964 0 0.0
.text 610424 610424 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9728940 9728940 0 0.0
(read/write) 475969 475969 0 0.0
.bss 43953 43953 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 371712 371712 0 0.0
.dynamic 560 560 0 0.0
.got 55304 55304 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 491892 491892 0 0.0
.text 8185860 8185860 0 0.0
thermostat-no-ble arm64 (read only) 2178588 2178588 0 0.0
(read/write) 148817 148817 0 0.0
.bss 65393 65393 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 75160 75160 0 0.0
.dynamic 560 560 0 0.0
.got 4240 4240 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133116 133116 0 0.0
.text 1826880 1826880 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351388 2351388 0 0.0
.bss 186212 186212 0 0.0
.data 5792 5792 0 0.0
.text 1313988 1313988 0 0.0
p6 all-clusters-app default (read/write) 2494184 2494184 0 0.0
.bss 119640 119640 0 0.0
.data 2680 2680 0 0.0
.text 1452448 1452448 0 0.0
light-app default (read/write) 2398248 2398248 0 0.0
.bss 113104 113104 0 0.0
.data 2536 2536 0 0.0
.text 1356512 1356512 0 0.0
lock-app default (read/write) 2361808 2361808 0 0.0
.bss 112848 112848 0 0.0
.data 2496 2496 0 0.0
.text 1320072 1320072 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888838 888838 0 0.0
bss 86968 86968 0 0.0
noinit 37160 37160 0 0.0
text 628138 628138 0 0.0

@isiu-apple isiu-apple merged commit 10b8046 into project-chip:master Mar 11, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@wqx6 @andrei-menzopol
Remove example connection option from menuconfig (project-chip#15955)
1859b7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chshu chshu chshu approved these changes

@dhrishi dhrishi dhrishi approved these changes

@electrocucaracha electrocucaracha electrocucaracha approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wqx6 @jadhavrohit924 @electrocucaracha @dhrishi @chshu @isiu-apple