-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTA] Move OTARequestorDriver to clusters directory #15949
Merged
carol-apple
merged 1 commit into
project-chip:master
from
carol-apple:ota_requestor_driver_clusters
Mar 8, 2022
Merged
[OTA] Move OTARequestorDriver to clusters directory #15949
carol-apple
merged 1 commit into
project-chip:master
from
carol-apple:ota_requestor_driver_clusters
Mar 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carol-apple
force-pushed
the
ota_requestor_driver_clusters
branch
from
March 8, 2022 06:39
6a2441b
to
bace3f3
Compare
woody-apple
approved these changes
Mar 8, 2022
pullapprove
bot
requested review from
andy31415,
Byungjoo-Lee,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
mspang
March 8, 2022 06:57
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
wbschiller,
xylophone21 and
yunhanw-google
March 8, 2022 06:57
PR #15949: Size comparison from 1f458a5 to bace3f3 Increases (4 builds for cyw30739, p6)
Decreases (1 build for p6)
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#15926 moved OTARequestorInterface into the cluster directory. OTARequestorDriver needs to reference the OTARequestorInterface so it is best that it is also moved to the clusters directory.
Change overview
Testing
Tree compiles